synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-18 14:17:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(site): only show provisioner warnings for pending workspaces (#15858)

Browse Source 
When creating, starting, stopping or otherwise mutating a workspace, we
used to erroneously and briefly display a provisioner health warning
alert. This PR updates the component to only display this warning if the
build is pending, not "starting" or any other state that means a
provisioner has already acquired the job.
This commit is contained in:
Sas Swart
2024-12-13 11:58:19 +02:00
committed by GitHub
parent d35de45d94
commit b5ba3e3da8
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
site/src/pages/WorkspacePage/Workspace.tsx
View File

@ -111,12 +111,13 @@ export const Workspace: FC<WorkspaceProps> = ({
); );
const workspaceRunning = workspace.latest_build.status === "running"; const workspaceRunning = workspace.latest_build.status === "running";
const workspacePending = workspace.latest_build.status === "pending";
const haveBuildLogs = (buildLogs ?? []).length > 0; const haveBuildLogs = (buildLogs ?? []).length > 0;
const shouldShowBuildLogs = haveBuildLogs && !workspaceRunning;
const provisionersHealthy = const provisionersHealthy =
(workspace.latest_build.matched_provisioners?.available ?? 0) > 0; (workspace.latest_build.matched_provisioners?.available ?? 1) > 0;
const shouldDisplayBuildLogs = haveBuildLogs && !workspaceRunning;
const shouldShowProvisionerAlert = const shouldShowProvisionerAlert =
!workspaceRunning && !haveBuildLogs && !provisionersHealthy; workspacePending && !haveBuildLogs && !provisionersHealthy && !isRestarting;
return ( return (
<div <div
@ -244,7 +245,7 @@ export const Workspace: FC<WorkspaceProps> = ({
/> />
)} )}
{shouldDisplayBuildLogs && ( {shouldShowBuildLogs && (
<WorkspaceBuildLogsSection logs={buildLogs} /> <WorkspaceBuildLogsSection logs={buildLogs} />
)} )}