From b7cd545d0a8d1bc879395c587b7b284f717db4a4 Mon Sep 17 00:00:00 2001 From: Spike Curtis Date: Wed, 16 Apr 2025 14:29:45 +0400 Subject: [PATCH] test: fix TestConfigSSH_FileWriteAndOptionsFlow on Windows 11 24H2 (#17410) Fixes tests on Windows 11 due to `printf` not being a recognized command name. --- cli/configssh_test.go | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/cli/configssh_test.go b/cli/configssh_test.go index 638e38a3fe..b42241b6b3 100644 --- a/cli/configssh_test.go +++ b/cli/configssh_test.go @@ -435,7 +435,7 @@ func TestConfigSSH_FileWriteAndOptionsFlow(t *testing.T) { "# :hostname-suffix=coder-suffix", "# :header=X-Test-Header=foo", "# :header=X-Test-Header2=bar", - "# :header-command=printf h1=v1 h2=\"v2\" h3='v3'", + "# :header-command=echo h1=v1 h2=\"v2\" h3='v3'", "#", }, "\n"), strings.Join([]string{ @@ -451,7 +451,7 @@ func TestConfigSSH_FileWriteAndOptionsFlow(t *testing.T) { "--hostname-suffix", "coder-suffix", "--header", "X-Test-Header=foo", "--header", "X-Test-Header2=bar", - "--header-command", "printf h1=v1 h2=\"v2\" h3='v3'", + "--header-command", "echo h1=v1 h2=\"v2\" h3='v3'", }, }, { @@ -566,36 +566,36 @@ func TestConfigSSH_FileWriteAndOptionsFlow(t *testing.T) { name: "Header command", args: []string{ "--yes", - "--header-command", "printf h1=v1", + "--header-command", "echo h1=v1", }, wantErr: false, hasAgent: true, wantConfig: wantConfig{ - regexMatch: `ProxyCommand .* --header-command "printf h1=v1" ssh .* --ssh-host-prefix coder. %h`, + regexMatch: `ProxyCommand .* --header-command "echo h1=v1" ssh .* --ssh-host-prefix coder. %h`, }, }, { name: "Header command with double quotes", args: []string{ "--yes", - "--header-command", "printf h1=v1 h2=\"v2\"", + "--header-command", "echo h1=v1 h2=\"v2\"", }, wantErr: false, hasAgent: true, wantConfig: wantConfig{ - regexMatch: `ProxyCommand .* --header-command "printf h1=v1 h2=\\\"v2\\\"" ssh .* --ssh-host-prefix coder. %h`, + regexMatch: `ProxyCommand .* --header-command "echo h1=v1 h2=\\\"v2\\\"" ssh .* --ssh-host-prefix coder. %h`, }, }, { name: "Header command with single quotes", args: []string{ "--yes", - "--header-command", "printf h1=v1 h2='v2'", + "--header-command", "echo h1=v1 h2='v2'", }, wantErr: false, hasAgent: true, wantConfig: wantConfig{ - regexMatch: `ProxyCommand .* --header-command "printf h1=v1 h2='v2'" ssh .* --ssh-host-prefix coder. %h`, + regexMatch: `ProxyCommand .* --header-command "echo h1=v1 h2='v2'" ssh .* --ssh-host-prefix coder. %h`, }, }, {