diff --git a/site/src/pages/WorkspacePage/WorkspaceActions/BuildParametersPopover.tsx b/site/src/pages/WorkspacePage/WorkspaceActions/BuildParametersPopover.tsx index 18965aafab..fcda04c5c0 100644 --- a/site/src/pages/WorkspacePage/WorkspaceActions/BuildParametersPopover.tsx +++ b/site/src/pages/WorkspacePage/WorkspaceActions/BuildParametersPopover.tsx @@ -37,6 +37,14 @@ export const BuildParametersPopover = ({ disabled?: boolean; onSubmit: (buildParameters: WorkspaceBuildParameter[]) => void; }) => { + const { data: parameters } = useQuery({ + queryKey: ["workspace", workspace.id, "parameters"], + queryFn: () => getWorkspaceParameters(workspace), + }); + const ephemeralParameters = parameters + ? parameters.templateVersionRichParameters.filter((p) => p.ephemeral) + : undefined; + return ( @@ -54,7 +62,8 @@ export const BuildParametersPopover = ({ css={{ ".MuiPaper-root": { width: 304 } }} > @@ -63,25 +72,19 @@ export const BuildParametersPopover = ({ }; const BuildParametersPopoverContent = ({ - workspace, onSubmit, + ephemeralParameters, + buildParameters, }: { - workspace: Workspace; onSubmit: (buildParameters: WorkspaceBuildParameter[]) => void; + ephemeralParameters?: TemplateVersionParameter[]; + buildParameters?: WorkspaceBuildParameter[]; }) => { const popover = usePopover(); - const { data: parameters } = useQuery({ - queryKey: ["workspace", workspace.id, "parameters"], - queryFn: () => getWorkspaceParameters(workspace), - enabled: popover.isOpen, - }); - const ephemeralParameters = parameters - ? parameters.templateVersionRichParameters.filter((p) => p.ephemeral) - : undefined; return ( <> - {parameters && parameters.buildParameters && ephemeralParameters ? ( + {buildParameters && ephemeralParameters ? ( ephemeralParameters.length > 0 ? ( <>