fix: coderd: decouple ttl and deadline (#2282)

This commit makes the following changes:

- Partially reverts the changes of feat: update workspace deadline when workspace ttl updated #2165, making the deadline of a running workspace build independant of TTL, once started.
- CLI: updating a workspace TTL no longer updates the deadline of the workspace.
- UI: updating a workspace TTL no longer updates the deadline of the workspace.
- Drive-by: API: When creating a workspace, default TTL to min(12 hours, template max_ttl) if not instructed otherwise.
- Drive-by: CLI: list: measure workspace extension correctly (+X in last column) from the time the provisioner job was completed
- Drive-by: WorkspaceSchedule: show timezone of schedule if it is set, defaulting to dayjs guess otherwise.
- Drive-by: WorkspaceScheduleForm: fixed an issue where deleting the "TTL" value in the form would show the text "Your workspace will shut down a few seconds after start".

coderd/autobuild/executor/lifecycle_executor.go

@@ -85,11 +85,9 @@ func (e *Executor) runOnce(t time.Time) Stats {
 		// is what we compare against when performing autostop operations, rounded down
 		// to the minute.
 		//
-		// NOTE: Currently, if a workspace build is created with a given TTL and then
-		//       the user either changes or unsets the TTL, the deadline for the workspace
-		//       build will not have changed. So, autostop will still happen at the
-		//       original TTL value from when the workspace build was created.
-		//       Whether this is expected behavior from a user's perspective is not yet known.
+		// NOTE: If a workspace build is created with a given TTL and then the user either
+		//       changes or unsets the TTL, the deadline for the workspace build will not
+		//       have changed. This behavior is as expected per #2229.
 		eligibleWorkspaces, err := db.GetWorkspacesAutostart(e.ctx)
 		if err != nil {
 			return xerrors.Errorf("get eligible workspaces for autostart or autostop: %w", err)

coderd/autobuild/executor/lifecycle_executor_test.go

@@ -308,8 +308,7 @@ func TestExecutorAutostopNotEnabled(t *testing.T) {
 	require.NoError(t, err)
 	require.Nil(t, workspace.TTLMillis)
 
-	// TODO(cian): need to stop and start the workspace as we do not update the deadline yet
-	//             see: https://github.com/coder/coder/issues/1783
+	// TODO(cian): need to stop and start the workspace as we do not update the deadline. See: #2229
 	coderdtest.MustTransitionWorkspace(t, client, workspace.ID, database.WorkspaceTransitionStart, database.WorkspaceTransitionStop)
 	coderdtest.MustTransitionWorkspace(t, client, workspace.ID, database.WorkspaceTransitionStop, database.WorkspaceTransitionStart)
 
@@ -440,29 +439,36 @@ func TestExecutorWorkspaceAutostopNoWaitChangedMyMind(t *testing.T) {
 	err := client.UpdateWorkspaceTTL(ctx, workspace.ID, codersdk.UpdateWorkspaceTTLRequest{TTLMillis: nil})
 	require.NoError(t, err)
 
-	// Then: the deadline should be the zero value
+	// Then: the deadline should still be the original value
 	updated := coderdtest.MustWorkspace(t, client, workspace.ID)
-	assert.Zero(t, updated.LatestBuild.Deadline)
+	assert.WithinDuration(t, workspace.LatestBuild.Deadline, updated.LatestBuild.Deadline, time.Minute)
 
 	// When: the autobuild executor ticks after the original deadline
 	go func() {
 		tickCh <- workspace.LatestBuild.Deadline.Add(time.Minute)
 	}()
 
-	// Then: the workspace should not stop
+	// Then: the workspace should stop
 	stats := <-statsCh
 	assert.NoError(t, stats.Error)
-	assert.Len(t, stats.Transitions, 0)
+	assert.Len(t, stats.Transitions, 1)
+	assert.Equal(t, stats.Transitions[workspace.ID], database.WorkspaceTransitionStop)
+
+	// Wait for stop to complete
+	updated = coderdtest.MustWorkspace(t, client, workspace.ID)
+	_ = coderdtest.AwaitWorkspaceBuildJob(t, client, updated.LatestBuild.ID)
+
+	// Start the workspace again
+	workspace = coderdtest.MustTransitionWorkspace(t, client, workspace.ID, database.WorkspaceTransitionStop, database.WorkspaceTransitionStart)
 
 	// Given: the user changes their mind again and wants to enable auto-stop
 	newTTL := 8 * time.Hour
-	expectedDeadline := workspace.LatestBuild.UpdatedAt.Add(newTTL)
 	err = client.UpdateWorkspaceTTL(ctx, workspace.ID, codersdk.UpdateWorkspaceTTLRequest{TTLMillis: ptr.Ref(newTTL.Milliseconds())})
 	require.NoError(t, err)
 
-	// Then: the deadline should be updated based on the TTL
+	// Then: the deadline should remain at the zero value
 	updated = coderdtest.MustWorkspace(t, client, workspace.ID)
-	assert.WithinDuration(t, expectedDeadline, updated.LatestBuild.Deadline, time.Minute)
+	assert.Zero(t, updated.LatestBuild.Deadline)
 
 	// When: the relentless onward march of time continues
 	go func() {
@@ -470,11 +476,10 @@ func TestExecutorWorkspaceAutostopNoWaitChangedMyMind(t *testing.T) {
 		close(tickCh)
 	}()
 
-	// Then: the workspace should stop
+	// Then: the workspace should not stop
 	stats = <-statsCh
 	assert.NoError(t, stats.Error)
-	assert.Len(t, stats.Transitions, 1)
-	assert.Equal(t, stats.Transitions[workspace.ID], database.WorkspaceTransitionStop)
+	assert.Len(t, stats.Transitions, 0)
 }
 
 func TestExecutorAutostartMultipleOK(t *testing.T) {