fix: coderd: decouple ttl and deadline (#2282)

This commit makes the following changes:

- Partially reverts the changes of feat: update workspace deadline when workspace ttl updated #2165, making the deadline of a running workspace build independant of TTL, once started.
- CLI: updating a workspace TTL no longer updates the deadline of the workspace.
- UI: updating a workspace TTL no longer updates the deadline of the workspace.
- Drive-by: API: When creating a workspace, default TTL to min(12 hours, template max_ttl) if not instructed otherwise.
- Drive-by: CLI: list: measure workspace extension correctly (+X in last column) from the time the provisioner job was completed
- Drive-by: WorkspaceSchedule: show timezone of schedule if it is set, defaulting to dayjs guess otherwise.
- Drive-by: WorkspaceScheduleForm: fixed an issue where deleting the "TTL" value in the form would show the text "Your workspace will shut down a few seconds after start".

coderd/workspaces_test.go

@@ -867,23 +867,20 @@ func TestWorkspaceUpdateTTL(t *testing.T) {
 	t.Parallel()
 
 	testCases := []struct {
-		name             string
-		ttlMillis        *int64
-		expectedError    string
-		expectedDeadline *time.Time
-		modifyTemplate   func(*codersdk.CreateTemplateRequest)
+		name           string
+		ttlMillis      *int64
+		expectedError  string
+		modifyTemplate func(*codersdk.CreateTemplateRequest)
 	}{
 		{
-			name:             "disable ttl",
-			ttlMillis:        nil,
-			expectedError:    "",
-			expectedDeadline: ptr.Ref(time.Time{}),
+			name:          "disable ttl",
+			ttlMillis:     nil,
+			expectedError: "",
 		},
 		{
-			name:             "update ttl",
-			ttlMillis:        ptr.Ref(12 * time.Hour.Milliseconds()),
-			expectedError:    "",
-			expectedDeadline: ptr.Ref(time.Now().Add(12*time.Hour + time.Minute)),
+			name:          "update ttl",
+			ttlMillis:     ptr.Ref(12 * time.Hour.Milliseconds()),
+			expectedError: "",
 		},
 		{
 			name:          "below minimum ttl",
@@ -891,16 +888,14 @@ func TestWorkspaceUpdateTTL(t *testing.T) {
 			expectedError: "ttl must be at least one minute",
 		},
 		{
-			name:             "minimum ttl",
-			ttlMillis:        ptr.Ref(time.Minute.Milliseconds()),
-			expectedError:    "",
-			expectedDeadline: ptr.Ref(time.Now().Add(2 * time.Minute)),
+			name:          "minimum ttl",
+			ttlMillis:     ptr.Ref(time.Minute.Milliseconds()),
+			expectedError: "",
 		},
 		{
-			name:             "maximum ttl",
-			ttlMillis:        ptr.Ref((24 * 7 * time.Hour).Milliseconds()),
-			expectedError:    "",
-			expectedDeadline: ptr.Ref(time.Now().Add(24*7*time.Hour + time.Minute)),
+			name:          "maximum ttl",
+			ttlMillis:     ptr.Ref((24 * 7 * time.Hour).Milliseconds()),
+			expectedError: "",
 		},
 		{
 			name:          "above maximum ttl",
@@ -953,9 +948,6 @@ func TestWorkspaceUpdateTTL(t *testing.T) {
 			require.NoError(t, err, "fetch updated workspace")
 
 			require.Equal(t, testCase.ttlMillis, updated.TTLMillis, "expected autostop ttl to equal requested")
-			if testCase.expectedDeadline != nil {
-				require.WithinDuration(t, *testCase.expectedDeadline, updated.LatestBuild.Deadline, time.Minute, "expected autostop deadline to be equal expected")
-			}
 		})
 	}