synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-06 15:41:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: add 'classic_parameter_flow' column setting to templates (#17828)

Browse Source 
We are forcing users to try the dynamic parameter experience first.
Currently this setting only comes into effect if an experiment is
enabled.
This commit is contained in:
Steven Masley
2025-05-15 17:55:17 -05:00
committed by GitHub
parent 9063b67c4d
commit c2bc801f83
21 changed files with 229 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
coderd/database/migrations/000327_version_dynamic_parameter_flow.down.sql Normal file
View File

@ -0,0 +1,28 @@
DROP VIEW template_with_names;
-- Drop the column
ALTER TABLE templates DROP COLUMN use_classic_parameter_flow;
CREATE VIEW
template_with_names
AS
SELECT
templates.*,
coalesce(visible_users.avatar_url, '') AS created_by_avatar_url,
coalesce(visible_users.username, '') AS created_by_username,
coalesce(organizations.name, '') AS organization_name,
coalesce(organizations.display_name, '') AS organization_display_name,
coalesce(organizations.icon, '') AS organization_icon
FROM
templates
LEFT JOIN
visible_users
ON
templates.created_by = visible_users.id
LEFT JOIN
organizations
ON templates.organization_id = organizations.id
;
COMMENT ON VIEW template_with_names IS 'Joins in the display name information such as username, avatar, and organization name.';

36
coderd/database/migrations/000327_version_dynamic_parameter_flow.up.sql Normal file
View File

@ -0,0 +1,36 @@
-- Default to `false`. Users will have to manually opt back into the classic parameter flow.
-- We want the new experience to be tried first.
ALTER TABLE templates ADD COLUMN use_classic_parameter_flow BOOL NOT NULL DEFAULT false;
COMMENT ON COLUMN templates.use_classic_parameter_flow IS
'Determines whether to default to the dynamic parameter creation flow for this template '
'or continue using the legacy classic parameter creation flow.'
'This is a template wide setting, the template admin can revert to the classic flow if there are any issues. '
'An escape hatch is required, as workspace creation is a core workflow and cannot break. '
'This column will be removed when the dynamic parameter creation flow is stable.';
-- Update the template_with_names view by recreating it.
DROP VIEW template_with_names;
CREATE VIEW
template_with_names
AS
SELECT
templates.*,
coalesce(visible_users.avatar_url, '') AS created_by_avatar_url,
coalesce(visible_users.username, '') AS created_by_username,
coalesce(organizations.name, '') AS organization_name,
coalesce(organizations.display_name, '') AS organization_display_name,
coalesce(organizations.icon, '') AS organization_icon
FROM
templates
LEFT JOIN
visible_users
ON
templates.created_by = visible_users.id
LEFT JOIN
organizations
ON templates.organization_id = organizations.id
;
COMMENT ON VIEW template_with_names IS 'Joins in the display name information such as username, avatar, and organization name.';