From c3fcf7c953eddcb94cd07ada0a3d130b2bc57887 Mon Sep 17 00:00:00 2001 From: Muhammad Atif Ali Date: Fri, 12 Aug 2022 18:21:42 +0300 Subject: [PATCH] chore: renamed `coder template edit` flags in coder CLI (#3471) Use `-` over `_` for cli flags --- cli/templateedit.go | 4 ++-- cli/templateedit_test.go | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/cli/templateedit.go b/cli/templateedit.go index 1f73eea8e3..083df3fb7d 100644 --- a/cli/templateedit.go +++ b/cli/templateedit.go @@ -53,8 +53,8 @@ func templateEdit() *cobra.Command { } cmd.Flags().StringVarP(&description, "description", "", "", "Edit the template description") - cmd.Flags().DurationVarP(&maxTTL, "max_ttl", "", 0, "Edit the template maximum time before shutdown") - cmd.Flags().DurationVarP(&minAutostartInterval, "min_autostart_interval", "", 0, "Edit the template minimum autostart interval") + cmd.Flags().DurationVarP(&maxTTL, "max-ttl", "", 0, "Edit the template maximum time before shutdown") + cmd.Flags().DurationVarP(&minAutostartInterval, "min-autostart-interval", "", 0, "Edit the template minimum autostart interval") cliui.AllowSkipPrompt(cmd) return cmd diff --git a/cli/templateedit_test.go b/cli/templateedit_test.go index 74431a8e24..1bc6a3b89d 100644 --- a/cli/templateedit_test.go +++ b/cli/templateedit_test.go @@ -38,8 +38,8 @@ func TestTemplateEdit(t *testing.T) { "edit", template.Name, "--description", desc, - "--max_ttl", maxTTL.String(), - "--min_autostart_interval", minAutostartInterval.String(), + "--max-ttl", maxTTL.String(), + "--min-autostart-interval", minAutostartInterval.String(), } cmd, root := clitest.New(t, cmdArgs...) clitest.SetupConfig(t, client, root) @@ -74,8 +74,8 @@ func TestTemplateEdit(t *testing.T) { "edit", template.Name, "--description", template.Description, - "--max_ttl", (time.Duration(template.MaxTTLMillis) * time.Millisecond).String(), - "--min_autostart_interval", (time.Duration(template.MinAutostartIntervalMillis) * time.Millisecond).String(), + "--max-ttl", (time.Duration(template.MaxTTLMillis) * time.Millisecond).String(), + "--min-autostart-interval", (time.Duration(template.MinAutostartIntervalMillis) * time.Millisecond).String(), } cmd, root := clitest.New(t, cmdArgs...) clitest.SetupConfig(t, client, root)