fix: Tidy up closes for nicer output (#4605)

* fix: Tidy up closes for nicer output

There was a context canceled message that would appear
because of traces, and this was using the wrong close.

I don't think it was causing any specific problems, but
it could make a replica warning appear on restart.

* Fix migration and experimental

coderd/database/dump.sql

@@ -1,9 +1,5 @@
 -- Code generated by 'make coderd/database/generate'. DO NOT EDIT.
 
-CREATE EXTENSION IF NOT EXISTS pgcrypto WITH SCHEMA public;
-
-COMMENT ON EXTENSION pgcrypto IS 'cryptographic functions';
-
 CREATE TYPE api_key_scope AS ENUM (
     'all',
     'application_connect'

coderd/database/migrations/000059_file_id.up.sql

@@ -14,9 +14,6 @@ BEGIN;
 -- Drop the primary key on hash.
 ALTER TABLE files DROP CONSTRAINT files_pkey;
 
--- This extension is required by gen_random_uuid
-CREATE EXTENSION IF NOT EXISTS pgcrypto;
-
 -- Add an 'id' column and designate it the primary key.
 ALTER TABLE files ADD COLUMN
 	id uuid NOT NULL PRIMARY KEY DEFAULT gen_random_uuid ();

coderd/tracing/exporter.go

@@ -3,6 +3,7 @@ package tracing
 import (
 	"context"
 
+	"github.com/go-logr/logr"
 	"go.opentelemetry.io/otel"
 	"go.opentelemetry.io/otel/exporters/otlp/otlptrace"
 	"go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc"
@@ -59,12 +60,15 @@ func TracerProvider(ctx context.Context, service string, opts TracerOpts) (*sdkt
 
 	tracerProvider := sdktrace.NewTracerProvider(tracerOpts...)
 	otel.SetTracerProvider(tracerProvider)
+	// Ignore otel errors!
+	otel.SetErrorHandler(otel.ErrorHandlerFunc(func(err error) {}))
 	otel.SetTextMapPropagator(
 		propagation.NewCompositeTextMapPropagator(
 			propagation.TraceContext{},
 			propagation.Baggage{},
 		),
 	)
+	otel.SetLogger(logr.Discard())
 
 	return tracerProvider, func(ctx context.Context) error {
 		for _, close := range closers {