From ca6e6213bf3886da14a88c4a4f49d70d58643e2e Mon Sep 17 00:00:00 2001 From: Kayla Washburn Date: Mon, 6 Nov 2023 11:43:06 -0500 Subject: [PATCH] chore: use px values instead of `theme.spacing` and `theme.shape.borderRadius` (#10519) --- site/src/components/Avatar/Avatar.tsx | 30 +++++----- site/src/components/AvatarData/AvatarData.tsx | 2 +- .../components/CodeExample/CodeExample.tsx | 6 +- site/src/components/CopyButton/CopyButton.tsx | 14 +---- .../components/Dashboard/DashboardLayout.tsx | 2 +- .../DeploymentBanner/DeploymentBannerView.tsx | 57 ++++++++++--------- .../LicenseBanner/LicenseBannerView.tsx | 14 ++--- .../Dashboard/Navbar/NavbarView.tsx | 23 ++++---- .../Navbar/UserDropdown/UserDropdown.tsx | 8 +-- .../UserDropdown/UserDropdownContent.tsx | 10 ++-- .../ServiceBanner/ServiceBannerView.tsx | 2 +- .../DeploySettingsLayout/Badges.tsx | 10 ++-- .../DeploySettingsLayout.tsx | 6 +- .../DeploySettingsLayout/Fieldset.tsx | 19 +++---- .../DeploySettingsLayout/Header.tsx | 6 +- .../DeploySettingsLayout/Option.tsx | 24 +++----- .../DeploySettingsLayout/OptionsTable.tsx | 8 +-- .../DeploySettingsLayout/Sidebar.tsx | 18 ++---- .../Dialogs/ConfirmDialog/ConfirmDialog.tsx | 12 ++-- .../Dialogs/DeleteDialog/DeleteDialog.tsx | 2 +- .../DropdownArrow/DropdownArrow.tsx | 2 +- site/src/components/EmptyState/EmptyState.tsx | 27 ++------- .../ErrorBoundary/RuntimeErrorState.tsx | 47 ++++++++------- site/src/components/Expander/Expander.tsx | 6 +- site/src/components/FileUpload/FileUpload.tsx | 22 +++---- site/src/components/Form/Form.tsx | 24 ++++---- site/src/components/FormFooter/FormFooter.tsx | 8 +-- .../components/FullPageForm/FullPageForm.tsx | 5 +- .../GlobalSnackbar/EnterpriseSnackbar.tsx | 4 +- .../GlobalSnackbar/GlobalSnackbar.tsx | 8 +-- .../components/HelpTooltip/HelpTooltip.tsx | 30 +++++----- site/src/components/IconField/IconField.tsx | 4 +- site/src/components/Markdown/Markdown.tsx | 18 +++--- site/src/components/MoreMenu/MoreMenu.tsx | 4 +- .../PageHeader/FullWidthPageHeader.tsx | 4 +- site/src/components/PageHeader/PageHeader.tsx | 16 +++--- .../PaginationWidget/PageButton.tsx | 2 +- .../PaginationWidget/PaginationWidgetBase.tsx | 2 +- site/src/components/Paywall/Paywall.tsx | 16 +++--- site/src/components/Pill/Pill.tsx | 19 +++---- site/src/components/Popover/Popover.tsx | 8 +-- .../src/components/Resources/AgentLatency.tsx | 6 +- .../components/Resources/AgentMetadata.tsx | 18 +++--- site/src/components/Resources/AgentRow.tsx | 30 +++++----- .../components/Resources/AgentRowPreview.tsx | 12 ++-- site/src/components/Resources/AgentStatus.tsx | 16 +++--- .../components/Resources/AppLink/AppLink.tsx | 2 +- .../Resources/AppLink/AppPreviewLink.tsx | 2 +- .../Resources/PortForwardButton.stories.tsx | 2 +- .../Resources/PortForwardButton.tsx | 49 +++++++--------- .../src/components/Resources/ResourceCard.tsx | 18 +++--- site/src/components/Resources/Resources.tsx | 6 +- .../Resources/SSHButton/SSHButton.tsx | 12 ++-- .../components/Resources/SensitiveValue.tsx | 10 ++-- .../RichParameterInput/MultiTextField.tsx | 12 ++-- .../RichParameterInput/RichParameterInput.tsx | 41 +++++++------ .../src/components/SettingsLayout/Section.tsx | 13 ++--- .../SettingsLayout/SectionAction.tsx | 10 +--- .../SettingsLayout/SettingsLayout.tsx | 15 +---- .../src/components/SettingsLayout/Sidebar.tsx | 19 ++----- site/src/components/Sidebar/Sidebar.tsx | 10 ++-- .../components/SignInLayout/SignInLayout.tsx | 2 +- site/src/components/Stack/Stack.tsx | 6 +- site/src/components/Stats/Stats.tsx | 20 +++---- .../SyntaxHighlighter/SyntaxHighlighter.tsx | 2 +- .../components/TableLoader/TableLoader.tsx | 11 +--- .../components/TableToolbar/TableToolbar.tsx | 8 ++- site/src/components/Tabs/Tabs.tsx | 10 ++-- .../TemplateExampleCard.tsx | 26 ++++----- .../TemplateFiles/TemplateFiles.tsx | 10 ++-- .../components/Timeline/TimelineDateRow.tsx | 2 +- .../UserAutocomplete/UserAutocomplete.tsx | 8 +-- site/src/components/Welcome/Welcome.tsx | 8 +-- .../components/WorkspaceBuildLogs/Logs.tsx | 28 ++++----- .../WorkspaceBuildLogs/WorkspaceBuildLogs.tsx | 2 +- .../WorkspaceStatusBadge.tsx | 2 +- site/src/hooks/useClickableTableRow.ts | 4 +- site/src/pages/404Page/404Page.tsx | 4 +- .../AuditLogRow/AuditLogDiff/AuditLogDiff.tsx | 24 ++++---- .../AuditPage/AuditLogRow/AuditLogRow.tsx | 6 +- .../src/pages/CliAuthPage/CliAuthPageView.tsx | 4 +- .../CreateTemplatePage/CreateTemplateForm.tsx | 14 ++--- .../CreateTemplatePage/VariableInput.tsx | 2 +- .../pages/CreateTokenPage/CreateTokenPage.tsx | 6 +- .../CreateWorkspacePageView.tsx | 12 ++-- .../CreateWorkspacePage/SelectedTemplate.tsx | 4 +- .../AppearanceSettingsPageView.tsx | 4 +- .../ExternalAuthSettingsPageView.tsx | 14 ++--- .../GeneralSettingsPage/ChartSection.tsx | 11 +--- .../AddNewLicensePageView.tsx | 5 +- .../LicensesSettingsPage/DividerWithText.tsx | 8 +-- .../LicensesSettingsPage/LicenseCard.tsx | 8 +-- .../LicensesSettingsPageView.tsx | 16 +++--- .../ExternalAuthPage/ExternalAuthPageView.tsx | 24 ++++---- site/src/pages/GroupsPage/GroupsPageView.tsx | 2 +- site/src/pages/HealthPage/HealthPage.tsx | 12 ++-- site/src/pages/IconsPage/IconsPage.tsx | 8 +-- site/src/pages/LoginPage/LoginPageView.tsx | 20 +++---- site/src/pages/LoginPage/OAuthSignInForm.tsx | 7 +-- site/src/pages/LoginPage/SignInForm.tsx | 32 +++++------ site/src/pages/SetupPage/SetupPageView.tsx | 17 ++---- .../StarterTemplatePageView.tsx | 8 +-- .../StarterTemplatesPageView.tsx | 12 ++-- .../TemplateDocsPage/TemplateDocsPage.tsx | 6 +- .../TemplateInsightsPage.tsx | 32 +++++------ .../src/pages/TemplatePage/TemplateLayout.tsx | 4 +- .../TemplateVersionsPage/VersionRow.tsx | 6 +- .../pages/TemplateSettingsPage/Sidebar.tsx | 18 +++--- .../TemplateSettingsForm.tsx | 4 +- .../TemplatePermissionsPageView.tsx | 18 +++--- .../TemplateSchedulePage/ScheduleDialog.tsx | 12 ++-- .../TemplateSettingsLayout.tsx | 6 +- .../TemplateVariablesPageView.tsx | 2 +- .../FileTreeView.tsx | 4 +- .../MissingTemplateVariablesDialog.tsx | 27 +++++---- .../TemplateVersionEditor.tsx | 14 ++--- .../pages/TemplatesPage/EmptyTemplates.tsx | 14 ++--- site/src/pages/TerminalPage/TerminalPage.tsx | 6 +- .../SecurityPage/SingleSignOnSection.tsx | 4 +- .../TokensPage/TokensPage.tsx | 8 +-- .../WorkspaceProxyPage/WorkspaceProxyRow.tsx | 4 +- .../pages/UsersPage/ResetPasswordDialog.tsx | 5 +- .../UsersPage/UsersTable/EditRolesButton.tsx | 28 ++++----- .../UsersPage/UsersTable/UserGroupsCell.tsx | 6 +- .../UsersPage/UsersTable/UserRoleCell.tsx | 6 +- .../WorkspaceBuildPageView.tsx | 6 +- site/src/pages/WorkspacePage/BuildRow.tsx | 6 +- .../WorkspacePage/ChangeVersionDialog.tsx | 11 +--- .../UpdateBuildParametersDialog.tsx | 27 +++++---- site/src/pages/WorkspacePage/Workspace.tsx | 6 +- .../BuildParametersPopover.tsx | 2 +- .../WorkspaceActions/WorkspaceActions.tsx | 6 +- .../WorkspaceBuildLogsSection.tsx | 2 +- .../WorkspacePage/WorkspaceBuildProgress.tsx | 14 ++--- .../pages/WorkspacePage/WorkspaceStats.tsx | 49 ++++++++-------- .../pages/WorkspaceSettingsPage/Sidebar.tsx | 19 ++----- .../WorkspaceParametersPage.tsx | 2 +- .../WorkspaceScheduleForm.tsx | 13 ++--- .../WorkspaceSettingsLayout.tsx | 8 +-- site/src/pages/WorkspacesPage/LastUsed.tsx | 6 +- .../pages/WorkspacesPage/WorkspacesButton.tsx | 15 +++-- .../pages/WorkspacesPage/WorkspacesEmpty.tsx | 12 ++-- .../pages/WorkspacesPage/WorkspacesTable.tsx | 7 +-- site/src/theme/theme.ts | 2 +- 144 files changed, 774 insertions(+), 958 deletions(-) diff --git a/site/src/components/Avatar/Avatar.tsx b/site/src/components/Avatar/Avatar.tsx index 89de1f174b..5fe92aae2d 100644 --- a/site/src/components/Avatar/Avatar.tsx +++ b/site/src/components/Avatar/Avatar.tsx @@ -11,24 +11,24 @@ export type AvatarProps = MuiAvatarProps & { }; const sizeStyles = { - xs: (theme) => ({ - width: theme.spacing(2), - height: theme.spacing(2), - fontSize: theme.spacing(1), + xs: { + width: 16, + height: 16, + fontSize: 8, fontWeight: 700, - }), - sm: (theme) => ({ - width: theme.spacing(3), - height: theme.spacing(3), - fontSize: theme.spacing(1.5), + }, + sm: { + width: 24, + height: 24, + fontSize: 12, fontWeight: 600, - }), + }, md: {}, - xl: (theme) => ({ - width: theme.spacing(6), - height: theme.spacing(6), - fontSize: theme.spacing(3), - }), + xl: { + width: 48, + height: 48, + fontSize: 24, + }, } satisfies Record>; const colorStyles = { diff --git a/site/src/components/AvatarData/AvatarData.tsx b/site/src/components/AvatarData/AvatarData.tsx index ba5d7db14d..2f8b59a30a 100644 --- a/site/src/components/AvatarData/AvatarData.tsx +++ b/site/src/components/AvatarData/AvatarData.tsx @@ -28,7 +28,7 @@ export const AvatarData: FC = ({ direction="row" alignItems="center" css={{ - minHeight: theme.spacing(5), // Make it predictable for the skeleton + minHeight: 40, // Make it predictable for the skeleton width: "100%", lineHeight: "150%", }} diff --git a/site/src/components/CodeExample/CodeExample.tsx b/site/src/components/CodeExample/CodeExample.tsx index aaf5aca643..7f6dfc62ce 100644 --- a/site/src/components/CodeExample/CodeExample.tsx +++ b/site/src/components/CodeExample/CodeExample.tsx @@ -26,8 +26,8 @@ export const CodeExample: FC = (props) => { color: theme.palette.primary.contrastText, fontFamily: MONOSPACE_FONT_FAMILY, fontSize: 14, - borderRadius: theme.shape.borderRadius, - padding: theme.spacing(1), + borderRadius: 8, + padding: 8, lineHeight: "150%", border: `1px solid ${theme.palette.divider}`, }} @@ -35,7 +35,7 @@ export const CodeExample: FC = (props) => { > > = ({ css` - border-radius: ${theme.shape.borderRadius}px; - padding: ${theme.spacing(0.85)}; + border-radius: 8px; + padding: 8px; min-width: 32px; &:hover { @@ -64,15 +64,7 @@ export const CopyButton: React.FC> = ({ ) : ( )} - {ctaCopy && ( -
({ - marginLeft: theme.spacing(1), - })} - > - {ctaCopy} -
- )} + {ctaCopy &&
{ctaCopy}
}
diff --git a/site/src/components/Dashboard/DashboardLayout.tsx b/site/src/components/Dashboard/DashboardLayout.tsx index 1947e3ef9c..e06888c6b3 100644 --- a/site/src/components/Dashboard/DashboardLayout.tsx +++ b/site/src/components/Dashboard/DashboardLayout.tsx @@ -60,7 +60,7 @@ export const DashboardLayout: FC = () => { sx: (theme) => ({ background: theme.palette.background.paper, color: theme.palette.text.primary, - maxWidth: theme.spacing(55), + maxWidth: 440, flexDirection: "row", borderColor: theme.palette.info.light, diff --git a/site/src/components/Dashboard/DeploymentBanner/DeploymentBannerView.tsx b/site/src/components/Dashboard/DeploymentBanner/DeploymentBannerView.tsx index fe742c9b9c..847761dced 100644 --- a/site/src/components/Dashboard/DeploymentBanner/DeploymentBannerView.tsx +++ b/site/src/components/Dashboard/DeploymentBanner/DeploymentBannerView.tsx @@ -46,18 +46,18 @@ const styles = { align-items: center; `, category: (theme) => ({ - marginRight: theme.spacing(2), + marginRight: 16, color: theme.palette.text.primary, }), values: (theme) => ({ display: "flex", - gap: theme.spacing(1), + gap: 8, color: theme.palette.text.secondary, }), - value: (theme) => css` + value: css` display: flex; align-items: center; - gap: ${theme.spacing(0.5)}; + gap: 4px; & svg { width: 12px; @@ -129,7 +129,7 @@ export const DeploymentBannerView: FC = (props) => { align-items: center; justify-content: center; background-color: ${unhealthy ? colors.red[10] : undefined}; - padding: ${theme.spacing(0, 1.5)}; + padding: 0 12px; height: ${bannerHeight}px; color: #fff; @@ -142,9 +142,9 @@ export const DeploymentBannerView: FC = (props) => { const statusSummaryStyle = className` ${theme.typography.body2 as CSSObject} - margin: ${theme.spacing(0, 0, 0.5, 1.5)}; - width: ${theme.spacing(50)}; - padding: ${theme.spacing(2)}; + margin: 0 0 4px 12px; + width: 400px; + padding: 16px; color: ${theme.palette.text.primary}; background-color: ${theme.palette.background.paper}; border: 1px solid ${theme.palette.divider}; @@ -158,13 +158,13 @@ export const DeploymentBannerView: FC = (props) => { height: bannerHeight, bottom: 0, zIndex: 1, - paddingRight: theme.spacing(2), + paddingRight: 16, backgroundColor: theme.palette.background.paper, display: "flex", alignItems: "center", fontFamily: MONOSPACE_FONT_FAMILY, fontSize: 12, - gap: theme.spacing(4), + gap: 32, borderTop: `1px solid ${theme.palette.divider}`, overflowX: "auto", whiteSpace: "nowrap", @@ -204,7 +204,7 @@ export const DeploymentBannerView: FC = (props) => { ) } open={process.env.STORYBOOK === "true" ? true : undefined} - css={{ marginRight: theme.spacing(-2) }} + css={{ marginRight: -16 }} > {unhealthy ? ( @@ -323,7 +323,7 @@ export const DeploymentBannerView: FC = (props) => { marginLeft: "auto", display: "flex", alignItems: "center", - gap: theme.spacing(2), + gap: 16, }} > @@ -335,23 +335,24 @@ export const DeploymentBannerView: FC = (props) => {