From ccabec6dd187b1551df9d516a93cabbf8dc48f16 Mon Sep 17 00:00:00 2001 From: Garrett Delfosse Date: Fri, 26 Aug 2022 11:18:42 -0400 Subject: [PATCH] fi stop tracing 4xx http status codes as errors (#3707) --- coderd/tracing/httpmw.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/coderd/tracing/httpmw.go b/coderd/tracing/httpmw.go index 15ff57f482..b11c62500e 100644 --- a/coderd/tracing/httpmw.go +++ b/coderd/tracing/httpmw.go @@ -56,7 +56,7 @@ func EndHTTPSpan(r *http.Request, status int) { status = http.StatusOK } span.SetAttributes(semconv.HTTPStatusCodeKey.Int(status)) - spanStatus, spanMessage := semconv.SpanStatusFromHTTPStatusCode(status) + spanStatus, spanMessage := semconv.SpanStatusFromHTTPStatusCodeAndSpanKind(status, trace.SpanKindServer) span.SetStatus(spanStatus, spanMessage) // finally end span