synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-13 21:36:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: log long-lived connections acceptance (#17219)

Browse Source 
Closes #16904
This commit is contained in:
Michael Suchacz
2025-04-08 10:30:05 +02:00
committed by GitHub
parent abe3ad68f5
commit ce22de8d15
9 changed files with 351 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
coderd/provisionerjobs_internal_test.go
View File

@ -19,6 +19,8 @@ import (
"github.com/coder/coder/v2/coderd/database/dbmock"
"github.com/coder/coder/v2/coderd/database/dbtime"
"github.com/coder/coder/v2/coderd/database/pubsub"
"github.com/coder/coder/v2/coderd/httpmw"
"github.com/coder/coder/v2/coderd/httpmw/loggermock"
"github.com/coder/coder/v2/codersdk"
"github.com/coder/coder/v2/provisionersdk"
"github.com/coder/coder/v2/testutil"
@ -305,11 +307,16 @@ func Test_logFollower_EndOfLogs(t *testing.T) {
JobStatus: database.ProvisionerJobStatusRunning,
}
mockLogger := loggermock.NewMockRequestLogger(ctrl)
mockLogger.EXPECT().WriteLog(gomock.Any(), http.StatusAccepted).Times(1)
ctx = httpmw.WithRequestLogger(ctx, mockLogger)
// we need an HTTP server to get a websocket
srv := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) {
uut := newLogFollower(ctx, logger, mDB, ps, rw, r, job, 0)
uut.follow()
}))
defer srv.Close()
// job was incomplete when we create the logFollower, and still incomplete when it queries