synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-15 22:20:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(coderd/workspaceapps): Fix incorrect use of testing.T (#7243)

Browse Source
This commit is contained in:
Mathias Fredriksson
2023-04-21 17:32:10 +03:00
committed by GitHub
parent 3680e158d9
commit ea78ca5dff
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
coderd/workspaceapps/apptest/apptest.go
View File

@ -47,7 +47,7 @@ func Run(t *testing.T, factory DeploymentFactory) {
t.Skip("ConPTY appears to be inconsistent on Windows.") t.Skip("ConPTY appears to be inconsistent on Windows.")
} }
expectLine := func(r *bufio.Reader, matcher func(string) bool) { expectLine := func(t *testing.T, r *bufio.Reader, matcher func(string) bool) {
for { for {
line, err := r.ReadString('\n') line, err := r.ReadString('\n')
require.NoError(t, err) require.NoError(t, err)
@ -98,8 +98,8 @@ func Run(t *testing.T, factory DeploymentFactory) {
_, err = conn.Write(data) _, err = conn.Write(data)
require.NoError(t, err) require.NoError(t, err)
expectLine(bufRead, matchEchoCommand) expectLine(t, bufRead, matchEchoCommand)
expectLine(bufRead, matchEchoOutput) expectLine(t, bufRead, matchEchoOutput)
}) })
t.Run("SignedTokenQueryParameter", func(t *testing.T) { t.Run("SignedTokenQueryParameter", func(t *testing.T) {
@ -148,7 +148,7 @@ func Run(t *testing.T, factory DeploymentFactory) {
conn := websocket.NetConn(ctx, wsConn, websocket.MessageBinary) conn := websocket.NetConn(ctx, wsConn, websocket.MessageBinary)
bufRead := bufio.NewReader(conn) bufRead := bufio.NewReader(conn)
expectLine(bufRead, matchEchoOutput) expectLine(t, bufRead, matchEchoOutput)
}) })
}) })