synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-13 21:36:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: improve listener algorithm in apptest (#8502)

Browse Source
This commit is contained in:
Dean Sheather
2023-07-13 10:34:14 -07:00
committed by GitHub
parent c2acc35d45
commit ecee3ceeec
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
coderd/workspaceapps/apptest/setup.go
View File

@ -240,7 +240,7 @@ func appServer(t *testing.T, headers http.Header) uint16 {
ln net.Listener ln net.Listener
tcpAddr *net.TCPAddr tcpAddr *net.TCPAddr
) )
for i := 0; i < 10; i++ { for i := 0; i < 32; i++ {
var err error var err error
// #nosec // #nosec
ln, err = net.Listen("tcp", ":0") ln, err = net.Listen("tcp", ":0")
@ -251,10 +251,12 @@ func appServer(t *testing.T, headers http.Header) uint16 {
require.True(t, ok) require.True(t, ok)
if tcpAddr.Port < codersdk.WorkspaceAgentMinimumListeningPort { if tcpAddr.Port < codersdk.WorkspaceAgentMinimumListeningPort {
_ = ln.Close() _ = ln.Close()
ln = nil
time.Sleep(20 * time.Millisecond) time.Sleep(20 * time.Millisecond)
continue continue
} }
} }
require.NotNil(t, ln, "failed to find a free port greater than the minimum app port")
server := http.Server{ server := http.Server{
ReadHeaderTimeout: time.Minute, ReadHeaderTimeout: time.Minute,