synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-18 14:17:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: accept agent RPC connection without version query parameter (#11790)

Browse Source 
Fixes an issue where Coder v2.7.1 agents connect to /api/v2/workspaceagents/me/rpc without a version query parameter
This commit is contained in:
Spike Curtis
2024-01-24 09:10:16 +04:00
committed by GitHub
parent 13beb04521
commit f5dbc718a7
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
coderd/workspaceagentsrpc.go
View File

@ -40,10 +40,10 @@ func (api *API) workspaceAgentRPC(rw http.ResponseWriter, r *http.Request) {
version := r.URL.Query().Get("version") version := r.URL.Query().Get("version")
if version == "" { if version == "" {
httpapi.Write(ctx, rw, http.StatusBadRequest, codersdk.Response{ // The initial version on this HTTP endpoint was 2.0, so assume this version if unspecified.
Message: "Missing required query parameter: version", // Coder v2.7.1 (not to be confused with the Agent API version) calls this endpoint without
}) // a version parameter and wants Agent API version 2.0.
return version = "2.0"
} }
if err := proto.CurrentVersion.Validate(version); err != nil { if err := proto.CurrentVersion.Validate(version); err != nil {
httpapi.Write(ctx, rw, http.StatusBadRequest, codersdk.Response{ httpapi.Write(ctx, rw, http.StatusBadRequest, codersdk.Response{