synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-18 14:17:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(coderd/debug): putDeploymentHealthSettings: use 204 instead of 304 if not modified (#11048)

Browse Source
This commit is contained in:
Cian Johnston
2023-12-05 19:06:56 +00:00
committed by GitHub
parent 876d448d69
commit f66e802fae
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
coderd/debug.go
View File

@ -205,7 +205,8 @@ func (api *API) putDeploymentHealthSettings(rw http.ResponseWriter, r *http.Requ
}
if bytes.Equal(settingsJSON, []byte(currentSettingsJSON)) {
httpapi.Write(r.Context(), rw, http.StatusNotModified, nil)
// See: https://www.rfc-editor.org/rfc/rfc7231#section-6.3.5
httpapi.Write(r.Context(), rw, http.StatusNoContent, nil)
return
}

2
codersdk/health.go
View File

@ -36,7 +36,7 @@ func (c *Client) PutHealthSettings(ctx context.Context, settings HealthSettings)
}
defer res.Body.Close()
if res.StatusCode == http.StatusNotModified {
if res.StatusCode == http.StatusNoContent {
return xerrors.New("health settings not modified")
}
if res.StatusCode != http.StatusOK {