synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-13 21:36:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Open new windows for terminals (#2568)

Browse Source
This commit is contained in:
Abhineet Jain
2022-06-22 12:29:08 -04:00
committed by GitHub
parent c366725472
commit f72a6d09fc
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
site/src/components/TerminalLink/TerminalLink.tsx
View File

@ -4,10 +4,11 @@ import ComputerIcon from "@material-ui/icons/Computer"
import { FC } from "react" import { FC } from "react"
import * as TypesGen from "../../api/typesGenerated" import * as TypesGen from "../../api/typesGenerated"
import { combineClasses } from "../../util/combineClasses" import { combineClasses } from "../../util/combineClasses"
import { generateRandomString } from "../../util/random"
export const Language = { export const Language = {
linkText: "Open terminal", linkText: "Open terminal",
terminalTitle: "Terminal", terminalTitle: (identifier: string): string => `Terminal - ${identifier}`,
} }
export interface TerminalLinkProps { export interface TerminalLinkProps {
@ -35,7 +36,7 @@ export const TerminalLink: FC<TerminalLinkProps> = ({ agentName, userName = "me"
target="_blank" target="_blank"
onClick={(event) => { onClick={(event) => {
event.preventDefault() event.preventDefault()
window.open(href, Language.terminalTitle, "width=900,height=600") window.open(href, Language.terminalTitle(generateRandomString(12)), "width=900,height=600")
}} }}
> >
<ComputerIcon className={styles.icon} /> <ComputerIcon className={styles.icon} />