From fade8ba759e4c84c2dabffcbad974b53ca5a0967 Mon Sep 17 00:00:00 2001 From: Spike Curtis Date: Wed, 5 Jun 2024 18:27:56 +0400 Subject: [PATCH] fix: fix MeasureLatencyRecvTimeout to accept send=0 (#13477) Fixes the flake seen here: https://github.com/coder/coder/runs/25832852690 Linux is not a real time operating system, and so there is no guarantee that subsequent `time.Now()` `time.Since()` calls will return a non-zero time. This assert is mainly there to ensure we don't return `-1`. --- coderd/database/pubsub/pubsub_linux_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/coderd/database/pubsub/pubsub_linux_test.go b/coderd/database/pubsub/pubsub_linux_test.go index 203287eb71..f208af921b 100644 --- a/coderd/database/pubsub/pubsub_linux_test.go +++ b/coderd/database/pubsub/pubsub_linux_test.go @@ -351,7 +351,7 @@ func TestMeasureLatency(t *testing.T) { send, recv, err := pubsub.NewLatencyMeasurer(logger).Measure(ctx, ps) require.ErrorContains(t, err, context.Canceled.Error()) - require.Greater(t, send.Nanoseconds(), int64(0)) + require.GreaterOrEqual(t, send.Nanoseconds(), int64(0)) require.EqualValues(t, recv, time.Duration(-1)) })