4 Commits

Author	SHA1	Message	Date
Mathias Fredriksson	6916d34458	fix: Fix cleanup in test helpers, prefer defer in tests (#3113) ... * fix: Change uses of t.Cleanup -> defer in test bodies Mixing t.Cleanup and defer can lead to unexpected order of execution. * fix: Ensure t.Cleanup is not aborted by require * chore: Add helper annotations	2022-07-25 19:22:02 +03:00
Mathias Fredriksson	ef7d357e19	fix: Move timeout ctx closer to use in tests, increase timeout (#3109) ... Some contexts were moved closer to use so that test setup doesn't affect timeout. And timeout was increased for some others to avoid flakyness due to slow test runners.	2022-07-22 17:42:09 +03:00
Kira Pilot	0aa8c2efeb	fix: set a failed canceled job status correctly (#3101) ... * set a failed canceled job status correctly resolves #1374 * added unit test for convertProvisionerJob * Update coderd/provisionerjobs_internal_test.go Co-authored-by: Cian Johnston <cian@coder.com> * PR feedback Co-authored-by: Cian Johnston <cian@coder.com>	2022-07-21 16:47:06 -04:00
Spike Curtis	b1e4cfe6c8	fix pubsub/poll race on provisioner job logs (#2783) ... * fix pubsub/poll race on provisioner job logs Signed-off-by: Spike Curtis <spike@coder.com> * only cancel on non-error Signed-off-by: Spike Curtis <spike@coder.com> * Improve logging & comments Signed-off-by: spikecurtis <spike@spikecurtis.com>	2022-07-01 14:07:18 -07:00