Files
coder/coderd/httpmw/recover_test.go
Spike Curtis 5861e516b9 chore: add standard test logger ignoring db canceled (#15556)
Refactors our use of `slogtest` to instantiate a "standard logger" across most of our tests.  This standard logger incorporates https://github.com/coder/slog/pull/217 to also ignore database query canceled errors by default, which are a source of low-severity flakes.

Any test that has set non-default `slogtest.Options` is left alone. In particular, `coderdtest` defaults to ignoring all errors. We might consider revisiting that decision now that we have better tools to target the really common flaky Error logs on shutdown.
2024-11-18 14:09:22 +04:00

75 lines
1.2 KiB
Go

package httpmw_test
import (
"net/http"
"net/http/httptest"
"testing"
"github.com/stretchr/testify/require"
"github.com/coder/coder/v2/coderd/httpmw"
"github.com/coder/coder/v2/coderd/tracing"
"github.com/coder/coder/v2/testutil"
)
func TestRecover(t *testing.T) {
t.Parallel()
handler := func(isPanic, hijack bool) http.Handler {
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
if isPanic {
panic("Oh no!")
}
w.WriteHeader(http.StatusOK)
})
}
cases := []struct {
Name string
Code int
Panic bool
Hijack bool
}{
{
Name: "OK",
Code: http.StatusOK,
Panic: false,
Hijack: false,
},
{
Name: "Panic",
Code: http.StatusInternalServerError,
Panic: true,
Hijack: false,
},
{
Name: "Hijack",
Code: 0,
Panic: true,
Hijack: true,
},
}
for _, c := range cases {
c := c
t.Run(c.Name, func(t *testing.T) {
t.Parallel()
var (
log = testutil.Logger(t)
r = httptest.NewRequest("GET", "/", nil)
w = &tracing.StatusWriter{
ResponseWriter: httptest.NewRecorder(),
Hijacked: c.Hijack,
}
)
httpmw.Recover(log)(handler(c.Panic, c.Hijack)).ServeHTTP(w, r)
require.Equal(t, c.Code, w.Status)
})
}
}