mirror of
https://github.com/coder/coder.git
synced 2025-07-03 16:13:58 +00:00
e21a301682
Relates to https://github.com/coder/coder/issues/15082 Further to https://github.com/coder/coder/pull/15429, this reduces the amount of false-positives returned by the 'is eligible for autostart' part of the query. We achieve this by calculating the 'next start at' time of the workspace, storing it in the database, and using it in our `GetWorkspacesEligibleForTransition` query. The prior implementation of the 'is eligible for autostart' query would return _all_ workspaces that at some point in the future _might_ be eligible for autostart. This now ensures we only return workspaces that _should_ be eligible for autostart. We also now pass `currentTick` instead of `t` to the `GetWorkspacesEligibleForTransition` query as otherwise we'll have one round of workspaces that are skipped by `isEligibleForTransition` due to `currentTick` being a truncated version of `t`.
42 lines
1.2 KiB
Go
42 lines
1.2 KiB
Go
package schedule_test
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/coder/coder/v2/coderd/schedule"
|
|
)
|
|
|
|
func TestNextAllowedAutostart(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
t.Run("WhenScheduleOutOfSync", func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
// 1st January 2024 is a Monday
|
|
at := time.Date(2024, time.January, 1, 10, 0, 0, 0, time.UTC)
|
|
// Monday-Friday 9:00AM UTC
|
|
sched := "CRON_TZ=UTC 00 09 * * 1-5"
|
|
// Only allow an autostart on mondays
|
|
opts := schedule.TemplateScheduleOptions{
|
|
AutostartRequirement: schedule.TemplateAutostartRequirement{
|
|
DaysOfWeek: 0b00000001,
|
|
},
|
|
}
|
|
|
|
// NextAutostart will return a non-allowed autostart time as
|
|
// our AutostartRequirement only allows Mondays but we expect
|
|
// this to return a Tuesday.
|
|
next, allowed := schedule.NextAutostart(at, sched, opts)
|
|
require.False(t, allowed)
|
|
require.Equal(t, time.Date(2024, time.January, 2, 9, 0, 0, 0, time.UTC), next)
|
|
|
|
// NextAllowedAutostart should return the next allowed autostart time.
|
|
next, err := schedule.NextAllowedAutostart(at, sched, opts)
|
|
require.NoError(t, err)
|
|
require.Equal(t, time.Date(2024, time.January, 8, 9, 0, 0, 0, time.UTC), next)
|
|
})
|
|
}
|