mirror of
https://github.com/coder/coder.git
synced 2025-07-03 16:13:58 +00:00
I modified the proxy host cache we already had and were using for websocket csp headers to also include the wildcard app host, then used those for frame-src policies. I did not add frame-ancestors, since if I understand correctly, those would go on the app, and this middleware does not come into play there. Maybe we will want to add it on workspace apps like we do with cors, if we find apps are setting it to `none` or something. Closes https://github.com/coder/internal/issues/684
312 lines
10 KiB
Go
312 lines
10 KiB
Go
package appurl
|
|
|
|
import (
|
|
"fmt"
|
|
"net"
|
|
"net/url"
|
|
"regexp"
|
|
"strconv"
|
|
"strings"
|
|
|
|
"golang.org/x/xerrors"
|
|
)
|
|
|
|
var (
|
|
// nameRegex is the same as our UsernameRegex without the ^ and $.
|
|
nameRegex = "[a-zA-Z0-9]+(?:-[a-zA-Z0-9]+)*"
|
|
appURL = regexp.MustCompile(fmt.Sprintf(
|
|
// {PORT/APP_SLUG}--{AGENT_NAME}--{WORKSPACE_NAME}--{USERNAME}
|
|
`^(?P<AppSlug>%[1]s)--(?P<AgentName>%[1]s)--(?P<WorkspaceName>%[1]s)--(?P<Username>%[1]s)$`,
|
|
nameRegex))
|
|
|
|
validHostnameLabelRegex = regexp.MustCompile(`^[a-z0-9]([-a-z0-9]*[a-z0-9])?$`)
|
|
)
|
|
|
|
// SubdomainAppHost returns the URL of the apphost for subdomain based apps.
|
|
// It will omit the scheme.
|
|
//
|
|
// Arguments:
|
|
// apphost: Expected to contain a wildcard, example: "*.coder.com"
|
|
// accessURL: The access url for the deployment.
|
|
//
|
|
// Returns:
|
|
// 'apphost:port'
|
|
//
|
|
// For backwards compatibility and for "accessurl=localhost:0" purposes, we need
|
|
// to use the port from the accessurl if the apphost doesn't have a port.
|
|
// If the user specifies a port in the apphost, we will use that port instead.
|
|
func SubdomainAppHost(apphost string, accessURL *url.URL) string {
|
|
if apphost == "" {
|
|
return ""
|
|
}
|
|
|
|
if apphost != "" && accessURL.Port() != "" {
|
|
// This should always parse if we prepend a scheme. We should add
|
|
// the access url port if the apphost doesn't have a port specified.
|
|
appHostU, err := url.Parse(fmt.Sprintf("https://%s", apphost))
|
|
if err != nil || (err == nil && appHostU.Port() == "") {
|
|
apphost += fmt.Sprintf(":%s", accessURL.Port())
|
|
}
|
|
}
|
|
|
|
return apphost
|
|
}
|
|
|
|
// ApplicationURL is a parsed application URL hostname.
|
|
type ApplicationURL struct {
|
|
Prefix string
|
|
AppSlugOrPort string
|
|
AgentName string
|
|
WorkspaceName string
|
|
Username string
|
|
}
|
|
|
|
// String returns the application URL hostname without scheme. You will likely
|
|
// want to append a period and the base hostname.
|
|
func (a ApplicationURL) String() string {
|
|
var appURL strings.Builder
|
|
_, _ = appURL.WriteString(a.Prefix)
|
|
_, _ = appURL.WriteString(a.AppSlugOrPort)
|
|
_, _ = appURL.WriteString("--")
|
|
_, _ = appURL.WriteString(a.AgentName)
|
|
_, _ = appURL.WriteString("--")
|
|
_, _ = appURL.WriteString(a.WorkspaceName)
|
|
_, _ = appURL.WriteString("--")
|
|
_, _ = appURL.WriteString(a.Username)
|
|
return appURL.String()
|
|
}
|
|
|
|
// Path is a helper function to get the url path of the app if it is not served
|
|
// on a subdomain. In practice this is not really used because we use the chi
|
|
// `{variable}` syntax to extract these parts. For testing purposes and for
|
|
// completeness of this package, we include it.
|
|
func (a ApplicationURL) Path() string {
|
|
return fmt.Sprintf("/@%s/%s.%s/apps/%s", a.Username, a.WorkspaceName, a.AgentName, a.AppSlugOrPort)
|
|
}
|
|
|
|
// PortInfo returns the port, protocol, and whether the AppSlugOrPort is a port or not.
|
|
func (a ApplicationURL) PortInfo() (uint, string, bool) {
|
|
var (
|
|
port uint64
|
|
protocol string
|
|
isPort bool
|
|
err error
|
|
)
|
|
|
|
if strings.HasSuffix(a.AppSlugOrPort, "s") {
|
|
trimmed := strings.TrimSuffix(a.AppSlugOrPort, "s")
|
|
port, err = strconv.ParseUint(trimmed, 10, 16)
|
|
if err == nil {
|
|
protocol = "https"
|
|
isPort = true
|
|
}
|
|
} else {
|
|
port, err = strconv.ParseUint(a.AppSlugOrPort, 10, 16)
|
|
if err == nil {
|
|
protocol = "http"
|
|
isPort = true
|
|
}
|
|
}
|
|
|
|
return uint(port), protocol, isPort
|
|
}
|
|
|
|
func (a *ApplicationURL) ChangePortProtocol(target string) ApplicationURL {
|
|
newAppURL := *a
|
|
port, protocol, isPort := a.PortInfo()
|
|
if !isPort {
|
|
return newAppURL
|
|
}
|
|
|
|
if target == protocol {
|
|
return newAppURL
|
|
}
|
|
|
|
if target == "https" {
|
|
newAppURL.AppSlugOrPort = fmt.Sprintf("%ds", port)
|
|
}
|
|
|
|
if target == "http" {
|
|
newAppURL.AppSlugOrPort = fmt.Sprintf("%d", port)
|
|
}
|
|
|
|
return newAppURL
|
|
}
|
|
|
|
// ParseSubdomainAppURL parses an ApplicationURL from the given subdomain. If
|
|
// the subdomain is not a valid application URL hostname, returns a non-nil
|
|
// error. If the hostname is not a subdomain of the given base hostname, returns
|
|
// a non-nil error.
|
|
//
|
|
// Subdomains should be in the form:
|
|
//
|
|
// ({PREFIX}---)?{PORT{s?}/APP_SLUG}--{AGENT_NAME}--{WORKSPACE_NAME}--{USERNAME}
|
|
// e.g.
|
|
// https://8080--main--dev--dean.hi.c8s.io
|
|
// https://8080s--main--dev--dean.hi.c8s.io
|
|
// https://app--main--dev--dean.hi.c8s.io
|
|
// https://prefix---8080--main--dev--dean.hi.c8s.io
|
|
// https://prefix---app--main--dev--dean.hi.c8s.io
|
|
//
|
|
// The optional prefix is permitted to allow customers to put additional URL at
|
|
// the beginning of their application URL (i.e. if they want to simulate
|
|
// different subdomains on the same app/port).
|
|
//
|
|
// Prefix requires three hyphens at the end to separate it from the rest of the
|
|
// URL so we can add/remove segments in the future from the parsing logic.
|
|
//
|
|
// TODO(dean): make the agent name optional when using the app slug. This will
|
|
// reduce the character count for app URLs.
|
|
func ParseSubdomainAppURL(subdomain string) (ApplicationURL, error) {
|
|
var (
|
|
prefixSegments = strings.Split(subdomain, "---")
|
|
prefix = ""
|
|
)
|
|
if len(prefixSegments) > 1 {
|
|
prefix = strings.Join(prefixSegments[:len(prefixSegments)-1], "---") + "---"
|
|
subdomain = prefixSegments[len(prefixSegments)-1]
|
|
}
|
|
|
|
matches := appURL.FindAllStringSubmatch(subdomain, -1)
|
|
if len(matches) == 0 {
|
|
return ApplicationURL{}, xerrors.Errorf("invalid application url format: %q", subdomain)
|
|
}
|
|
matchGroup := matches[0]
|
|
|
|
return ApplicationURL{
|
|
Prefix: prefix,
|
|
AppSlugOrPort: matchGroup[appURL.SubexpIndex("AppSlug")],
|
|
AgentName: matchGroup[appURL.SubexpIndex("AgentName")],
|
|
WorkspaceName: matchGroup[appURL.SubexpIndex("WorkspaceName")],
|
|
Username: matchGroup[appURL.SubexpIndex("Username")],
|
|
}, nil
|
|
}
|
|
|
|
// HostnamesMatch returns true if the hostnames are equal, disregarding
|
|
// capitalization, extra leading or trailing periods, and ports.
|
|
func HostnamesMatch(a, b string) bool {
|
|
a = strings.Trim(a, ".")
|
|
b = strings.Trim(b, ".")
|
|
|
|
aHost, _, err := net.SplitHostPort(a)
|
|
if err != nil {
|
|
aHost = a
|
|
}
|
|
bHost, _, err := net.SplitHostPort(b)
|
|
if err != nil {
|
|
bHost = b
|
|
}
|
|
|
|
return strings.EqualFold(aHost, bHost)
|
|
}
|
|
|
|
// CompileHostnamePattern compiles a hostname pattern into a regular expression.
|
|
// A hostname pattern is a string that may contain a single wildcard character
|
|
// at the beginning. The wildcard character matches any number of hostname-safe
|
|
// characters excluding periods. The pattern is case-insensitive.
|
|
//
|
|
// The supplied pattern:
|
|
// - must not start or end with a period
|
|
// - must contain exactly one asterisk at the beginning
|
|
// - must not contain any other wildcard characters
|
|
// - must not contain any other characters that are not hostname-safe (including
|
|
// whitespace)
|
|
// - must contain at least two hostname labels/segments (i.e. "foo" or "*" are
|
|
// not valid patterns, but "foo.bar" and "*.bar" are).
|
|
//
|
|
// The returned regular expression will match an entire hostname with optional
|
|
// trailing periods and whitespace. The first submatch will be the wildcard
|
|
// match.
|
|
func CompileHostnamePattern(pattern string) (*regexp.Regexp, error) {
|
|
pattern = strings.ToLower(pattern)
|
|
if strings.Contains(pattern, "http:") || strings.Contains(pattern, "https:") {
|
|
return nil, xerrors.Errorf("hostname pattern must not contain a scheme: %q", pattern)
|
|
}
|
|
|
|
if strings.HasPrefix(pattern, ".") || strings.HasSuffix(pattern, ".") {
|
|
return nil, xerrors.Errorf("hostname pattern must not start or end with a period: %q", pattern)
|
|
}
|
|
if strings.Count(pattern, ".") < 1 {
|
|
return nil, xerrors.Errorf("hostname pattern must contain at least two labels/segments: %q", pattern)
|
|
}
|
|
if strings.Count(pattern, "*") != 1 {
|
|
return nil, xerrors.Errorf("hostname pattern must contain exactly one asterisk: %q", pattern)
|
|
}
|
|
if !strings.HasPrefix(pattern, "*") {
|
|
return nil, xerrors.Errorf("hostname pattern must only contain an asterisk at the beginning: %q", pattern)
|
|
}
|
|
|
|
// If there is a hostname:port, we only care about the hostname. For hostname
|
|
// pattern reasons, we do not actually care what port the client is requesting.
|
|
// Any port provided here is used for generating urls for the ui, not for
|
|
// validation.
|
|
hostname, _, err := net.SplitHostPort(pattern)
|
|
if err == nil {
|
|
pattern = hostname
|
|
}
|
|
|
|
for i, label := range strings.Split(pattern, ".") {
|
|
if i == 0 {
|
|
// We have to allow the asterisk to be a valid hostname label, so
|
|
// we strip the asterisk (which is only on the first one).
|
|
label = strings.TrimPrefix(label, "*")
|
|
// Put an "a" at the start to stand in for the asterisk in the regex
|
|
// test below. This makes `*.coder.com` become `a.coder.com` and
|
|
// `*--prod.coder.com` become `a--prod.coder.com`.
|
|
label = "a" + label
|
|
}
|
|
if !validHostnameLabelRegex.MatchString(label) {
|
|
return nil, xerrors.Errorf("hostname pattern contains invalid label %q: %q", label, pattern)
|
|
}
|
|
}
|
|
|
|
// Replace periods with escaped periods.
|
|
regexPattern := strings.ReplaceAll(pattern, ".", "\\.")
|
|
|
|
// Capture wildcard match.
|
|
regexPattern = strings.Replace(regexPattern, "*", "([^.]+)", 1)
|
|
|
|
// Allow trailing period.
|
|
regexPattern += "\\.?"
|
|
|
|
// Allow optional port number.
|
|
regexPattern += "(:\\d+)?"
|
|
|
|
// Allow leading and trailing whitespace.
|
|
regexPattern = `^\s*` + regexPattern + `\s*$`
|
|
|
|
return regexp.Compile(regexPattern)
|
|
}
|
|
|
|
// ExecuteHostnamePattern executes a pattern generated by CompileHostnamePattern
|
|
// and returns the wildcard match. If the pattern does not match the hostname,
|
|
// returns false.
|
|
func ExecuteHostnamePattern(pattern *regexp.Regexp, hostname string) (string, bool) {
|
|
matches := pattern.FindStringSubmatch(hostname)
|
|
if len(matches) < 2 {
|
|
return "", false
|
|
}
|
|
|
|
return matches[1], true
|
|
}
|
|
|
|
// ConvertAppHostForCSP converts the wildcard host to a format accepted by CSP.
|
|
// For example *--apps.coder.com must become *.coder.com. If there is no
|
|
// wildcard host, or it cannot be converted, return the base host.
|
|
func ConvertAppHostForCSP(host, wildcard string) string {
|
|
if wildcard == "" {
|
|
return host
|
|
}
|
|
parts := strings.Split(wildcard, ".")
|
|
for i, part := range parts {
|
|
if strings.Contains(part, "*") {
|
|
// The wildcard can only be in the first section.
|
|
if i != 0 {
|
|
return host
|
|
}
|
|
parts[i] = "*"
|
|
}
|
|
}
|
|
return strings.Join(parts, ".")
|
|
}
|