coder/CODEOWNERS at mes/headers-fix-b - coder - Ahri Cloud Code

synced/coder

mirror of https://github.com/coder/coder.git synced 2025-03-14 10:09:57 +00:00

Line: 3: incorrect codeowner user: spikecurtis Line: 3: incorrect codeowner user: johnstcn Line: 3: no users/groups matched Line: 4: incorrect codeowner user: spikecurtis Line: 4: incorrect codeowner user: johnstcn Line: 4: no users/groups matched Line: 5: incorrect codeowner user: spikecurtis Line: 5: incorrect codeowner user: johnstcn Line: 5: no users/groups matched Line: 6: incorrect codeowner user: spikecurtis Line: 6: incorrect codeowner user: johnstcn Line: 6: no users/groups matched

Spike Curtis 40802958e9 fix: use explicit api versions for agent and tailnet (#15508 )

Bumps the Tailnet and Agent API version 2.3, and creates some extra controls and machinery around these versions.

What happened is that we accidentally shipped two new API features without bumping the version. `ScriptCompleted` on the Agent API in Coder v2.16 and `RefreshResumeToken` on the Tailnet API in Coder v2.15.

Since we can't easily retroactively bump the versions, we'll roll these changes into API version 2.3 along with the new WorkspaceUpdates RPC, which hasn't been released yet. That means there is some ambiguity in Coder v2.15-v2.17 about exactly what methods are supported on the Tailnet and Agent APIs. This isn't great, but hasn't caused us major issues because

1. RefreshResumeToken is considered optional, and clients just log and move on if the RPC isn't supported.
2. Agents basically never get started talking to a Coderd that is older than they are, since the agent binary is normally downloaded from Coderd at workspace start.

Still it's good to get things squared away in terms of versions for SDK users and possible edge cases around client and server versions.

To mitigate against this thing happening again, this PR also:

1. adds a CODEOWNERS for the API proto packages, so I'll review changes
2. defines interface types for different API versions, and has the agent explicitly use a specific version. That way, if you add a new method, and try to use it in the agent without thinking explicitly about versions, it won't compile.

With the protocol controllers stuff, we've sort of already abstracted the Tailnet API such that the interface type strategy won't work, but I'll work on getting the Controller to be version aware, such that it can check the API version it's getting against the controllers it has -- in a later PR.

2024-11-15 11:16:28 +04:00

7 lines

273 B

Plaintext

Raw Permalink Blame History

 # These APIs are versioned, so any changes need to be carefully reviewed for whether
 # to bump API major or minor versions.
 agent/proto/ @spikecurtis @johnstcn
 tailnet/proto/ @spikecurtis @johnstcn
 vpn/vpn.proto @spikecurtis @johnstcn
 vpn/version.go @spikecurtis @johnstcn