gcp-cherry-pick-bot[bot] 6da3c9d48c fix: allow orgs with default github provider (cherry-pick #16755) (#16784) ...

Cherry-picked fix: allow orgs with default github provider (#16755)

This PR fixes 2 bugs:

## Problem 1

The server would fail to start when the default github provider was
configured and the flag `--oauth2-github-allowed-orgs` was set. The
error was

```
error: configure github oauth2: allow everyone and allowed orgs cannot be used together
```

This PR fixes it by enabling "allow everone" with the default provider
only if "allowed orgs" isn't set.

## Problem 2

The default github provider uses the device flow to authorize users, and
that's handled differently by our web UI than the standard oauth flow.
In particular, the web UI only handles JSON responses rather than HTTP
redirects. There were 2 code paths that returned redirects, and the PR
changes them to return JSON messages instead if the device flow is
configured.

Co-authored-by: Hugo Dutka <hugo@coder.com>

2025-03-03 17:49:35 -06:00

..

clilog

test: fix use of t.Logf where t.Log would suffice (#16328)

2025-01-29 14:35:04 +00:00

clistat

fix(cli): improve container detection when cgroupns=private (#15156)

2024-10-21 15:28:32 +01:00

clitest

chore(testutil): add testutil.GoleakOptions (#16070)

2025-01-08 15:38:37 +00:00

cliui

fix: display the correct response for coder list (#16547)

2025-02-13 10:13:20 -05:00

cliutil

feat(coderd): add matched provisioner daemons information to more places (#15688)

2024-12-02 20:54:32 +00:00

config

feat: implement organization context in the cli (#12259)

2024-02-26 10:03:49 -06:00

exptest

test(cli/exptest): fix context in TestScaleTestWorkspaceTraffic_UseHostLogin (#16171)

2025-01-17 14:51:24 +02:00

gitauth

feat: extend OverrideVSCodeConfigs for additional VS Code IDEs (#16654)

2025-02-25 21:08:55 +05:00

telemetry

…

testdata

feat: enable GitHub OAuth2 login by default on new deployments (#16662)

2025-02-25 16:31:33 +01:00

agent_internal_test.go

…

agent_test.go

chore: join owner, template, and org in new workspace view (#15116)

2024-10-22 09:20:54 -05:00

agent.go

chore(cli): disable agent devcontainer integration by default (#16531)

2025-02-12 10:47:25 +00:00

autoupdate_test.go

chore(coderd): allow creating workspaces without specifying an organization (#14048)

2024-07-30 10:44:02 -06:00

autoupdate.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

completion.go

chore: skip completion install prompts in non-interactive shells (#14391)

2024-08-22 15:40:53 +10:00

configssh_internal_test.go

fix: fix flaking Test_sshConfigExecEscape (#14233)

2024-08-12 18:56:34 +10:00

configssh_other.go

…

configssh_test.go

feat: use wildcard Host entry in config-ssh (#16096)

2025-01-13 19:07:42 -06:00

configssh_windows.go

…

configssh.go

feat: use wildcard Host entry in config-ssh (#16096)

2025-01-13 19:07:42 -06:00

create_test.go

chore(docs): document how to correctly override list(string) parameters (#15497)

2024-11-13 15:41:36 +00:00

create.go

fix: unify coder create and coder delete help message (#15752)

2024-12-05 12:32:52 +11:00

delete_test.go

chore(cli): fix test flake introduced by #15688 (#15724)

2024-12-02 22:11:42 +00:00

delete.go

fix: unify coder create and coder delete help message (#15752)

2024-12-05 12:32:52 +11:00

dotfiles_test.go

fix: detect nested dotfiles scripts (#14455)

2024-08-28 02:14:23 +10:00

dotfiles.go

fix: make cli respect deployment --docs-url (#14568)

2024-09-18 21:47:53 +10:00

errors_test.go

feat(cli): add golden tests for errors (#11588) (#12698)

2024-04-01 09:19:26 -05:00

errors.go

feat(cli): add golden tests for errors (#11588) (#12698)

2024-04-01 09:19:26 -05:00

exp_scaletest_slim.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

exp_scaletest_test.go

chore(cli): skip scaletest tests when race detector enabled (#16033)

2025-01-03 23:08:51 +02:00

exp_scaletest.go

feat: add workspace-proxy-url flag to scaletest workspace-traffic (#15920)

2024-12-18 11:53:01 -05:00

exp.go

chore: add command to render all existing cli prompts (#13689)

2024-06-27 05:20:15 -10:00

externalauth_test.go

chore: explain GIT_ASKPASS behavior in docs (#12784)

2024-03-28 13:59:03 -05:00

externalauth.go

chore: expose formatExamples enterprise commands (#13304)

2024-05-21 13:26:34 -05:00

favorite_test.go

chore: join owner, template, and org in new workspace view (#15116)

2024-10-22 09:20:54 -05:00

favorite.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

gitaskpass_test.go

…

gitaskpass.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

gitssh_test.go

chore: join owner, template, and org in new workspace view (#15116)

2024-10-22 09:20:54 -05:00

gitssh.go

fix: conform to stricter printf usage in Go 1.24 (#16330)

2025-01-29 18:06:22 +02:00

help.go

feat(cli): add shell completions (#14341)

2024-08-20 14:47:46 +10:00

help.tpl

…

list_test.go

fix: display the correct response for coder list (#16547)

2025-02-13 10:13:20 -05:00

list.go

fix: display the correct response for coder list (#16547)

2025-02-13 10:13:20 -05:00

login_test.go

feat: expose premium trial form via CLI (#15054)

2024-10-29 13:02:20 +00:00

login.go

fix: conform to stricter printf usage in Go 1.24 (#16330)

2025-01-29 18:06:22 +02:00

logout_test.go

chore: remove middleware to request version and entitlement warnings (#12750)

2024-03-25 15:01:42 -04:00

logout.go

fix: conform to stricter printf usage in Go 1.24 (#16330)

2025-01-29 18:06:22 +02:00

netcheck_test.go

feat!: add interface report to coder netcheck (#13562)

2024-06-13 10:19:36 +04:00

netcheck.go

feat!: add interface report to coder netcheck (#13562)

2024-06-13 10:19:36 +04:00

notifications_test.go

feat: add tool to send a test notification (#16611)

2025-02-19 13:08:38 +00:00

notifications.go

feat: add tool to send a test notification (#16611)

2025-02-19 13:08:38 +00:00

open_internal_test.go

feat(cli): add coder open vscode (#11191)

2024-01-02 20:46:18 +02:00

open_test.go

feat(cli): add coder open vscode (#11191)

2024-01-02 20:46:18 +02:00

open.go

fix: make cli respect deployment --docs-url (#14568)

2024-09-18 21:47:53 +10:00

organization_test.go

chore: protect organization endpoints with license (#14001)

2024-07-25 16:07:53 -05:00

organization.go

chore: add cli command to fetch group sync settings as json (#14694)

2024-09-17 14:08:33 -05:00

organizationmanage.go

chore: unhide multi-organization cli commands (#14693)

2024-09-17 10:22:20 -05:00

organizationmembers_test.go

feat(cli): add shell completions (#14341)

2024-08-20 14:47:46 +10:00

organizationmembers.go

feat(cli): add shell completions (#14341)

2024-08-20 14:47:46 +10:00

organizationroles_test.go

chore: include custom roles in list org roles (#13336)

2024-05-23 07:54:59 -10:00

organizationroles.go

chore: unhide multi-organization cli commands (#14693)

2024-09-17 10:22:20 -05:00

organizationsettings.go

chore: add cli command to update organization sync settings (#15459)

2024-11-13 13:44:21 -06:00

parameter_internal_test.go

…

parameter.go

chore(cli): rename build options to ephemeral parameters in cli (#15030)

2024-10-16 23:54:12 +02:00

parameterresolver.go

chore(cli): rename build options to ephemeral parameters in cli (#15030)

2024-10-16 23:54:12 +02:00

ping_internal_test.go

feat!: add summary to coder ping (#14762)

2024-09-25 13:24:23 +10:00

ping_test.go

feat(cli): add local and UTC time options to ping cmd (#16648)

2025-02-24 05:38:17 +00:00

ping.go

feat(cli): add local and UTC time options to ping cmd (#16648)

2025-02-24 05:38:17 +00:00

portforward_internal_test.go

feat: change port-forward to opportunistically listen on IPv6 (#15640)

2024-11-25 16:33:28 +04:00

portforward_test.go

feat: change port-forward to opportunistically listen on IPv6 (#15640)

2024-11-25 16:33:28 +04:00

portforward.go

feat: change port-forward to opportunistically listen on IPv6 (#15640)

2024-11-25 16:33:28 +04:00

prompts.go

feat: allow entering non-default values in multi-select (#15935)

2024-12-27 16:45:46 +05:00

provisionerjobs_test.go

feat(cli): add provisioner job cancel command (#16252)

2025-01-27 16:26:56 +00:00

provisionerjobs.go

feat(cli): add provisioner job cancel command (#16252)

2025-01-27 16:26:56 +00:00

provisioners_test.go

fix(coderd): add stricter authorization for provisioners endpoint (#16587)

2025-02-17 14:34:47 +02:00

provisioners.go

feat(cli): add provisioner list and provisioner jobs list (#16030)

2025-01-20 17:24:22 +00:00

publickey_test.go

…

publickey.go

fix: conform to stricter printf usage in Go 1.24 (#16330)

2025-01-29 18:06:22 +02:00

remoteforward.go

feat(cli/ssh): allow multiple remote forwards and allow missing local file (#11648)

2024-01-19 15:21:10 +02:00

rename_test.go

chore(coderd): allow creating workspaces without specifying an organization (#14048)

2024-07-30 10:44:02 -06:00

rename.go

fix: make cli respect deployment --docs-url (#14568)

2024-09-18 21:47:53 +10:00

resetpassword_slim.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

resetpassword_test.go

chore: add postgres template caching for tests (#15336)

2024-11-04 17:23:31 +01:00

resetpassword.go

chore: prevent db migrations from running on all cli commands (#15980)

2025-01-03 11:15:35 -06:00

restart_test.go

chore(cli): rename build options to ephemeral parameters in cli (#15030)

2024-10-16 23:54:12 +02:00

restart.go

feat(cli): add --provisioner-log-debug option (#14558)

2024-09-04 14:39:35 +01:00

root_internal_test.go

chore(testutil): add testutil.GoleakOptions (#16070)

2025-01-08 15:38:37 +00:00

root_test.go

feat(cli): add provisioner list and provisioner jobs list (#16030)

2025-01-20 17:24:22 +00:00

root.go

chore: show server install.sh on cli version mismatch (#16668)

2025-02-25 02:32:34 +00:00

schedule_internal_test.go

…

schedule_test.go

fix: allow users to extend their running workspace's deadline (#15895)

2024-12-18 10:58:33 +00:00

schedule.go

fix: allow users to extend their running workspace's deadline (#15895)

2024-12-18 10:58:33 +00:00

server_createadminuser_test.go

chore: add postgres template caching for tests (#15336)

2024-11-04 17:23:31 +01:00

server_createadminuser.go

chore: add the --ephemeral server flag (#16126)

2025-01-20 14:31:16 +01:00

server_internal_test.go

fix: escape special characters in postgres password (#16510)

2025-02-11 09:06:42 +01:00

server_slim.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

server_test.go

fix: allow orgs with default github provider (cherry-pick #16755) (#16784)

2025-03-03 17:49:35 -06:00

server.go

fix: allow orgs with default github provider (cherry-pick #16755) (#16784)

2025-03-03 17:49:35 -06:00

show_test.go

chore(coderd): allow creating workspaces without specifying an organization (#14048)

2024-07-30 10:44:02 -06:00

show.go

feat(cli): display devcontainers in show command (#16515)

2025-02-11 09:20:55 +00:00

signal_unix.go

fix: separate signals for passive, active, and forced shutdown (#12358)

2024-03-15 13:16:36 +00:00

signal_windows.go

fix: separate signals for passive, active, and forced shutdown (#12358)

2024-03-15 13:16:36 +00:00

speedtest_test.go

chore: add standard test logger ignoring db canceled (#15556)

2024-11-18 14:09:22 +04:00

speedtest.go

fix: make cli respect deployment --docs-url (#14568)

2024-09-18 21:47:53 +10:00

ssh_internal_test.go

chore: add standard test logger ignoring db canceled (#15556)

2024-11-18 14:09:22 +04:00

ssh_other.go

…

ssh_test.go

fix(agent/agentssh): use deterministic host key for SSH server (#16626)

2025-02-21 14:58:41 +01:00

ssh_windows.go

…

ssh.go

feat: add --ssh-host-prefix flag for "coder ssh" (#16088)

2025-01-13 19:07:21 -06:00

start_test.go

chore: join owner, template, and org in new workspace view (#15116)

2024-10-22 09:20:54 -05:00

start.go

feat(coderd): add matched provisioner daemons information to more places (#15688)

2024-12-02 20:54:32 +00:00

stat_test.go

…

stat.go

feat(cli): add shell completions (#14341)

2024-08-20 14:47:46 +10:00

state_test.go

chore: join owner, template, and org in new workspace view (#15116)

2024-10-22 09:20:54 -05:00

state.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

stop.go

feat(coderd): add matched provisioner daemons information to more places (#15688)

2024-12-02 20:54:32 +00:00

support_test.go

test(cli): fix context init in TestSupportBundle (#16174)

2025-01-17 14:51:38 +02:00

support.go

fix(cli): ensure that the support bundle command does not panic on zero values (#14392)

2024-08-22 11:15:02 +01:00

templatecreate_test.go

chore: protect organization endpoints with license (#14001)

2024-07-25 16:07:53 -05:00

templatecreate.go

chore: fix docs/admin links and upgrade notice (#15043)

2024-11-01 19:43:51 +00:00

templatedelete_test.go

…

templatedelete.go

chore: remove org context switcher in the cli (#13674)

2024-07-01 16:04:45 -05:00

templateedit_test.go

chore: remove max_ttl from templates (#12644)

2024-03-20 10:37:57 -05:00

templateedit.go

chore: fix docs/admin links and upgrade notice (#15043)

2024-11-01 19:43:51 +00:00

templateinit_test.go

…

templateinit.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

templatelist_test.go

chore: protect organization endpoints with license (#14001)

2024-07-25 16:07:53 -05:00

templatelist.go

chore: include all templates in cli template list (#13841)

2024-07-09 11:04:16 -05:00

templatepull_test.go

chore(coderd): extract fileszip to package archive for reuse (#15229)

2024-10-25 15:14:39 +01:00

templatepull.go

chore: remove org context switcher in the cli (#13674)

2024-07-01 16:04:45 -05:00

templatepush_test.go

fix(cli): handle version mismatch re MatchedProvisioners response (#15682)

2024-11-29 19:45:58 +00:00

templatepush.go

feat(coderd): add matched provisioner daemons information to more places (#15688)

2024-12-02 20:54:32 +00:00

templates.go

fix: remove templates plan docs (#13824)

2024-07-09 14:27:34 +00:00

templateversionarchive_test.go

…

templateversionarchive.go

fix: conform to stricter printf usage in Go 1.24 (#16330)

2025-01-29 18:06:22 +02:00

templateversions_test.go

feat: allow promoting an existing template version to active from CLI (#15051)

2024-10-17 14:15:14 +05:00

templateversions.go

feat: allow promoting an existing template version to active from CLI (#15051)

2024-10-17 14:15:14 +05:00

tokens_test.go

feat(cli): support deleting tokens by id (#16341)

2025-02-12 18:18:17 +11:00

tokens.go

feat(cli): support deleting tokens by id (#16341)

2025-02-12 18:18:17 +11:00

update_test.go

fix: wait for prompt on rich param CLI test (#15406)

2024-11-07 16:47:15 +04:00

update.go

chore(cli): rename build options to ephemeral parameters in cli (#15030)

2024-10-16 23:54:12 +02:00

user_delete_test.go

chore!: allow CreateUser to accept multiple organizations (#14383)

2024-08-23 21:23:51 +00:00

usercreate_test.go

feat: add "Full Name" field to user creation (#13659)

2024-06-26 09:00:42 +01:00

usercreate.go

feat(codersdk): export name validators (#14551)

2024-09-04 08:34:39 +00:00

userdelete.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

userlist_test.go

feat: add "Full Name" field to user creation (#13659)

2024-06-26 09:00:42 +01:00

userlist.go

feat(cli): add shell completions (#14341)

2024-08-20 14:47:46 +10:00

users.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

userstatus_test.go

…

userstatus.go

feat(cli): add shell completions (#14341)

2024-08-20 14:47:46 +10:00

util_internal_test.go

feat(cli): extend duration to longer units (#15040)

2024-10-16 17:02:56 +02:00

util.go

feat(cli): extend duration to longer units (#15040)

2024-10-16 17:02:56 +02:00

version_test.go

…

version.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

vpndaemon_other.go

chore: add vpn-daemon run subcommand for windows (#15526)

2024-11-18 21:10:01 +10:00

vpndaemon_windows_test.go

chore: add vpn-daemon run subcommand for windows (#15526)

2024-11-18 21:10:01 +10:00

vpndaemon_windows.go

chore: get TUN/DNS working on Windows for CoderVPN (#16310)

2025-01-29 08:09:36 +00:00

vpndaemon.go

chore: add vpn-daemon run subcommand for windows (#15526)

2024-11-18 21:10:01 +10:00

vscodessh_test.go

chore: add standard test logger ignoring db canceled (#15556)

2024-11-18 14:09:22 +04:00

vscodessh.go

feat: add --network-info-dir and --network-info-interval flags to coder ssh (#16078)

2025-01-13 18:29:31 -06:00

whoami_test.go

feat: added whomai cmd to coder cli (#13814)

2024-07-09 13:23:11 -05:00

whoami.go

feat: added whomai cmd to coder cli (#13814)

2024-07-09 13:23:11 -05:00