Spike Curtis 29099d4727 chore: refactor notifier to use quartz.TickerFunc (#15134) ...

In investigating https://github.com/coder/internal/issues/109 I noticed many of the notification tests are still using `time.Sleep` and `require.Eventually`. This is an initial effort to start converting these to Quartz.

One product change is to switch the `notifier` to use a `TickerFunc` instead of a normal Ticker, since it allows the test to assert that a batch process is complete via the Quartz `Mock` clock.  This does introduce one slight behavioral change in that the notifier waits the fetch interval before processing its first batch.  In practice, this is inconsequential: no one will notice if we send notifications immediately on startup, or just a little later.

But, it does make a difference to some tests, which are fixed up here.

2024-10-21 12:07:19 +04:00

..

agentapi

feat(coderd): return agent script timings (#14923)

2024-10-14 09:31:03 -03:00

agentmetrics

feat: make agent stats' cardinality configurable (#12535)

2024-03-13 12:03:36 +02:00

apidoc

feat(coderd): return agent script timings (#14923)

2024-10-14 09:31:03 -03:00

apikey

fix: add missing route for codersdk.PostLogSource (#13421)

2024-06-03 12:29:50 -05:00

appearance

fix: make cli respect deployment --docs-url (#14568)

2024-09-18 21:47:53 +10:00

audit

feat: add notification preferences database & audit support (#14100)

2024-08-05 16:18:45 +02:00

autobuild

fix(coderd): humanize duration on notifications (#14333)

2024-08-19 15:49:47 -03:00

awsidentity

…

azureidentity

chore: skip Azure TestExpiresSoon (#13385)

2024-05-28 16:45:41 +00:00

coderdtest

feat: implement api for "forgot password?" flow (#14915)

2024-10-04 11:53:25 +01:00

cryptokeys

chore: refactor keycache implementation to reduce duplication (#15100)

2024-10-16 20:01:45 +01:00

database

feat(site): add forgot password link (#15108)

2024-10-18 09:50:22 -03:00

devtunnel

feat: use latest gVisor and go 1.22.3 (#13338)

2024-05-23 08:22:44 -04:00

entitlements

fix: serialize updateEntitlements() (#14974)

2024-10-05 06:58:43 +04:00

externalauth

feat(codersdk): export name validators (#14550)

2024-09-04 18:17:53 +10:00

gitsshkey

…

healthcheck

feat: add keys to organization provision daemons (#14627)

2024-09-16 20:02:08 +00:00

httpapi

feat(codersdk): export name validators (#14551)

2024-09-04 08:34:39 +00:00

httpmw

chore: remove multi-organization and custom role experiment (#14862)

2024-09-27 14:06:16 -05:00

identityprovider

chore: use rw.WriteHeader to write responses without bodies (#13870)

2024-07-11 13:38:33 -06:00

idpsync

feat: implement patch and get api methods for role sync (#14692)

2024-09-17 10:38:42 -05:00

jwtutils

chore: refactor keycache implementation to reduce duplication (#15100)

2024-10-16 20:01:45 +01:00

metricscache

fix: handle new agent stat format correctly (#14576)

2024-09-20 01:52:14 +10:00

notifications

chore: refactor notifier to use quartz.TickerFunc (#15134)

2024-10-21 12:07:19 +04:00

oauthpki

…

portsharing

fix: properly convert max port share level for oss (#13261)

2024-05-13 14:37:51 -04:00

prometheusmetrics

fix: handle new agent stat format correctly (#14576)

2024-09-20 01:52:14 +10:00

promoauth

chore: deprecate gauge metrics with _total suffix (#12744) (#12976)

2024-04-24 11:23:24 +03:00

provisionerdserver

fix(coderd/notifications): simplify TemplateWorkspaceManualBuildFailed (#15067)

2024-10-15 21:02:02 +02:00

provisionerkey

chore: shorten provisioner key (#14017)

2024-07-25 16:08:12 -05:00

rbac

chore: allow user admins to configure idp sync (#14861)

2024-09-27 14:07:15 -05:00

render

feat: implement thin vertical slice of system-generated notifications (#13537)

2024-07-08 15:38:50 +02:00

runtimeconfig

feat: implement organization role sync (#14649)

2024-09-16 19:03:25 -05:00

schedule

chore: move template meta last_used_at update to workspacestats (#13415)

2024-05-31 12:26:19 -04:00

searchquery

chore: add organization search query to workspaces (#14474)

2024-08-28 15:18:45 -05:00

telemetry

fix: handle new agent stat format correctly (#14576)

2024-09-20 01:52:14 +10:00

testdata

feat(coderd): add times_used to coder_apps in insights API (#13292)

2024-05-16 16:53:01 +03:00

tracing

chore: bump gopkg.in/DataDog/dd-trace-go.v1 from 1.57.0 to 1.61.0 (#12610)

2024-03-17 22:08:32 -05:00

unhanger

chore: add dbauthz to unhanger tests (#14394)

2024-08-22 22:23:52 +04:00

updatecheck

…

userpassword

chore: fix 30% startup time hit from userpassword (#12769)

2024-03-26 20:47:14 -05:00

util

chore: remove duplicates using the symmetric difference function (#14469)

2024-08-28 21:06:27 -05:00

workspaceapps

chore!: allow CreateUser to accept multiple organizations (#14383)

2024-08-23 21:23:51 +00:00

workspacestats

fix: handle new agent stat format correctly (#14576)

2024-09-20 01:52:14 +10:00

wsbuilder

feat: evaluate provisioner tags (#13333)

2024-05-23 07:53:51 +00:00

activitybump_test.go

fix: check unstaged files during ci lint (#15120)

2024-10-17 05:37:43 +00:00

apikey_test.go

fix: remove redundant flaking test (#14888)

2024-10-01 09:01:24 +00:00

apikey.go

feat!: add --default-token-lifetime (#14631)

2024-09-18 21:23:42 +10:00

apiroot.go

…

audit_internal_test.go

chore: add sql filter to fetching audit logs (#14070)

2024-08-01 12:07:19 -05:00

audit_test.go

chore: add sql filter to fetching audit logs (#14070)

2024-08-01 12:07:19 -05:00

audit.go

chore: add sql filter to fetching audit logs (#14070)

2024-08-01 12:07:19 -05:00

authorize_test.go

chore: add built in organization roles to match site (#13938)

2024-07-19 15:44:18 -05:00

authorize.go

chore: authz 'any_org' to return if at least 1 org has perms (#14009)

2024-07-29 19:58:48 -05:00

client_test.go

…

coderd_test.go

chore: add Coder service prefix to tailnet (#14943)

2024-10-04 10:04:10 +04:00

coderd.go

feat(coderd): return agent script timings (#14923)

2024-10-14 09:31:03 -03:00

csp.go

…

debug_test.go

chore(codersdk): move all tailscale imports out of codersdk (#12735)

2024-03-26 12:44:31 -05:00

debug.go

chore: disallow sdk imports from the db package, switch enum to string(#14539)

2024-09-03 10:32:33 -05:00

deployment_test.go

fix(coderd): mark provisioner daemon psk as secret (#12322)

2024-02-27 16:33:32 +00:00

deployment.go

chore: remove rbac psuedo resources, add custom verbs (#13276)

2024-05-15 11:09:42 -05:00

deprecated.go

chore!: remove deprecated agent v1 routes (#13486)

2024-06-11 12:22:59 +10:00

experiments_test.go

…

experiments.go

…

externalauth_test.go

fix: limit OAuth redirects to local paths (#14585)

2024-09-10 15:58:50 +01:00

externalauth.go

fix: limit OAuth redirects to local paths (#14585)

2024-09-10 15:58:50 +01:00

files_test.go

chore(coderd): improve tests for tar<->zip conversion (#12477)

2024-03-11 13:29:57 +00:00

files.go

fix: document files API needs ustar format (#14152)

2024-08-06 11:00:49 +04:00

fileszip_test.go

fix(coderd): correctly handle tar dir entries with missing path separator (#12479)

2024-03-11 14:06:41 +00:00

fileszip.go

fix(coderd): correctly handle tar dir entries with missing path separator (#12479)

2024-03-11 14:06:41 +00:00

gitsshkey_test.go

chore(coderd): allow creating workspaces without specifying an organization (#14048)

2024-07-30 10:44:02 -06:00

gitsshkey.go

…

insights_internal_test.go

fix(coderd): move test location to ignore Australia time saving error (#15013)

2024-10-07 21:10:01 +02:00

insights_test.go

test: ignore slog errors in TestUserLatencyInsights (#15105)

2024-10-16 13:20:28 +02:00

insights.go

fix: correct swagger description for Insights API (#13442)

2024-06-03 15:48:31 +02:00

latencycheck.go

…

members_test.go

chore: allow removing users from the default org (#14699)

2024-09-17 10:42:47 -05:00

members.go

chore: include error detail for ui error display (#14837)

2024-09-26 11:48:50 -05:00

notifications_test.go

chore: remove notifications experiment (#14869)

2024-10-01 13:43:47 +00:00

notifications.go

feat: add notification preferences database & audit support (#14100)

2024-08-05 16:18:45 +02:00

oauth2_test.go

feat: make OAuth2 provider not enterprise-only (#12732)

2024-03-25 11:52:22 -08:00

oauth2.go

chore: use rw.WriteHeader to write responses without bodies (#13870)

2024-07-11 13:38:33 -06:00

organizations_test.go

chore: protect organization endpoints with license (#14001)

2024-07-25 16:07:53 -05:00

organizations.go

chore: implement filters for the organizations query (#14468)

2024-08-28 13:24:28 -05:00

pagination_internal_test.go

fix: improve pagination parser (#12422)

2024-03-05 14:05:15 +00:00

pagination.go

chore: implement sane default pagination limit for audit logs (#13676)

2024-06-28 07:38:04 -05:00

provisionerjobs_internal_test.go

…

provisionerjobs_test.go

chore(coderd): allow creating workspaces without specifying an organization (#14048)

2024-07-30 10:44:02 -06:00

provisionerjobs.go

…

roles_test.go

chore: protect organization endpoints with license (#14001)

2024-07-25 16:07:53 -05:00

roles.go

chore: refactor patch custom organization route to live in enterprise (#14099)

2024-08-05 13:42:11 -05:00

tailnet_internal_test.go

fix: set node callback each time we reinit the coordinator in servertailnet (#12140)

2024-02-14 20:45:31 +04:00

tailnet_test.go

chore: add Coder service prefix to tailnet (#14943)

2024-10-04 10:04:10 +04:00

tailnet.go

chore: add Coder service prefix to tailnet (#14943)

2024-10-04 10:04:10 +04:00

templates_test.go

fix(coderd/notifications): simplify TemplateWorkspaceManualBuildFailed (#15067)

2024-10-15 21:02:02 +02:00

templates.go

fix(coderd/notifications): simplify TemplateWorkspaceManualBuildFailed (#15067)

2024-10-15 21:02:02 +02:00

templateversions_test.go

chore: don't require an organization to read starter templates (#14190)

2024-08-06 11:26:26 -06:00

templateversions.go

fix: improve duplicate template version name error (#14572)

2024-09-06 16:13:34 +10:00

updatecheck_test.go

…

updatecheck.go

…

userauth_test.go

feat: implement api for "forgot password?" flow (#14915)

2024-10-04 11:53:25 +01:00

userauth.go

feat(coderd/notifications): improve notification format consistency (#14967)

2024-10-09 17:31:12 -05:00

users_test.go

chore(coderd/notifications): expand golden file testing for notifications (#15032)

2024-10-14 12:34:32 +00:00

users.go

chore(coderd/notifications): expand golden file testing for notifications (#15032)

2024-10-14 12:34:32 +00:00

workspaceagentportshare_test.go

feat: move shared ports out of experiment (#13120)

2024-05-02 14:11:33 -04:00

workspaceagentportshare.go

fix: properly convert max port share level for oss (#13261)

2024-05-13 14:37:51 -04:00

workspaceagents_test.go

fix: fix flake in TestWorkspaceAgentClientCoordinate_ResumeToken (#14642)

2024-09-11 16:32:47 +04:00

workspaceagents.go

feat: add agent timings (#14713)

2024-09-24 10:51:49 +01:00

workspaceagentsrpc_internal_test.go

feat: move agent v2 API connection monitoring to yamux layer (#11910)

2024-02-01 08:18:35 +04:00

workspaceagentsrpc_test.go

chore!: remove deprecated agent v1 routes (#13486)

2024-06-11 12:22:59 +10:00

workspaceagentsrpc.go

fix(provisionerd/runner): do not log entire resources (#14538)

2024-09-04 10:23:34 +01:00

workspaceapps_test.go

chore: protect organization endpoints with license (#14001)

2024-07-25 16:07:53 -05:00

workspaceapps.go

chore: push rbac actions to policy package (#13274)

2024-05-15 09:46:35 -05:00

workspacebuilds_test.go

fix(coderd): improve workspace tests (#15069)

2024-10-15 16:30:38 +02:00

workspacebuilds.go

feat(coderd): return agent script timings (#14923)

2024-10-14 09:31:03 -03:00

workspaceproxies_test.go

…

workspaceproxies.go

…

workspaceresourceauth_test.go

chore(coderd): allow creating workspaces without specifying an organization (#14048)

2024-07-30 10:44:02 -06:00

workspaceresourceauth.go

…

workspaces_test.go

feat(coderd): return agent script timings (#14923)

2024-10-14 09:31:03 -03:00

workspaces.go

feat(coderd): return agent script timings (#14923)

2024-10-14 09:31:03 -03:00