Cian Johnston 36c2cf8a40 fix(coderd/database): exclude canceled jobs in queue position (#15835) ...

When calculating the queue position in
`GetProvisionerJobsByIDsWithQueuePosition` we only counted jobs with
`started_at = NULL`. This is misleading, as it allows canceling or
canceled jobs to take up rows in the computed queue position, giving an
impression that the queue is larger than it really is.

This modifies the query to also exclude jobs with a null `canceled_at`,
`completed_at`, or `error` field for the purposes of calculating the
queue position, and also adds a test to validate this behaviour.

(Note: due to the behaviour of `dbgen.ProvisionerJob` with `dbmem` I had
to use other proxy methods to validate the corresponding dbmem
implementation.)

---------

Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>

2024-12-12 12:37:45 +00:00

..

dbmem_test.go

chore: implement filters for the organizations query (#14468)

2024-08-28 13:24:28 -05:00

dbmem.go

fix(coderd/database): exclude canceled jobs in queue position (#15835)

2024-12-12 12:37:45 +00:00