coder

mirror of https://github.com/coder/coder.git synced 2025-03-14 10:09:57 +00:00

History

Spike Curtis cee6b1ebde fix: wait for prompt on rich param CLI test (#15406 )

Fixes a race in TestUpdateValidateRichParameters where the parameter is sent prior to the prompt.

Causes errors like: https://github.com/coder/coder/actions/runs/11681622439/job/32527173007

```
    ptytest.go:132: 2024-11-05 10:02:18.819: cmd: "bool_parameter"
    ptytest.go:167: 2024-11-05 10:02:18.819: cmd: matched "bool_parameter" = "bool_parameter"
    update_test.go:440: 2024-11-05 10:02:18.819: cmd: stdin: "cat\r\n"
    ptytest.go:132: 2024-11-05 10:02:18.819: cmd: "> Enter a value (default: \"\"): can't validate build parameter \"bool_parameter\": boolean value can be either \"true\" or \"false\""
    ptytest.go:167: 2024-11-05 10:02:18.819: cmd: matched "boolean value can be either" = "\n> Enter a value (default: \"\"): can't validate build parameter \"bool_parameter\": boolean value can be either"
    update_test.go:440: 2024-11-05 10:02:18.819: cmd: stdin: "\r\n"
    ptytest.go:167: 2024-11-05 10:02:18.819: cmd: matched "Enter a value" = " \"true\" or \"false\"\n> Enter a value"
    update_test.go:440: 2024-11-05 10:02:18.819: cmd: stdin: "false\r\n"
    ptytest.go:132: 2024-11-05 10:02:18.821: cmd: "> Enter a value (default: \"\"): can't validate build parameter \"bool_parameter\": boolean value can be either \"true\" or \"false\""
```

2024-11-07 16:47:15 +04:00

ptytest

fix: wait for prompt on rich param CLI test (#15406 )

2024-11-07 16:47:15 +04:00

pty_linux.go

fix: Terminal emulation used by SSH sessions (#3473 )

2022-09-12 19:27:51 +03:00

pty_other.go

feat(agent/agentssh): handle session signals (#10842 )

2023-11-23 19:55:36 +02:00

pty_windows.go

feat(agent/agentssh): handle session signals (#10842 )