mirror of
https://github.com/coder/coder.git
synced 2025-07-06 15:41:45 +00:00
* feat: begin impl of agent script timings * feat: add job_id and display_name to script timings * fix: increment migration number * fix: rename migrations from 251 to 254 * test: get tests compiling * fix: appease the linter * fix: get tests passing again * fix: drop column from correct table * test: add fixture for agent script timings * fix: typo * fix: use job id used in provisioner job timings * fix: increment migration number * test: behaviour of script runner * test: rewrite test * test: does exit 1 script break things? * test: rewrite test again * fix: revert change Not sure how this came to be, I do not recall manually changing these files. * fix: let code breathe * fix: wrap errors * fix: justify nolint * fix: swap require.Equal argument order * fix: add mutex operations * feat: add 'ran_on_start' and 'blocked_login' fields * fix: update testdata fixture * fix: refer to agent_id instead of job_id in timings * fix: JobID -> AgentID in dbauthz_test * fix: add 'id' to scripts, make timing refer to script id * fix: fix broken tests and convert bug * fix: update testdata fixtures * fix: update testdata fixtures again * feat: capture stage and if script timed out * fix: update migration number * test: add test for script api * fix: fake db query * fix: use UTC time * fix: ensure r.scriptComplete is not nil * fix: move err check to right after call * fix: uppercase sql * fix: use dbtime.Now() * fix: debug log on r.scriptCompleted being nil * fix: ensure correct rbac permissions * chore: remove DisplayName * fix: get tests passing * fix: remove space in sql up * docs: document ExecuteOption * fix: drop 'RETURNING' from sql * chore: remove 'display_name' from timing table * fix: testdata fixture * fix: put r.scriptCompleted call in goroutine * fix: track goroutine for test + use separate context for reporting * fix: appease linter, handle trackCommandGoroutine error * fix: resolve race condition * feat: replace timed_out column with status column * test: update testdata fixture * fix: apply suggestions from review * revert: linter changes
64 lines
2.0 KiB
Go
64 lines
2.0 KiB
Go
package agentapi
|
|
|
|
import (
|
|
"context"
|
|
|
|
"github.com/google/uuid"
|
|
"golang.org/x/xerrors"
|
|
|
|
agentproto "github.com/coder/coder/v2/agent/proto"
|
|
"github.com/coder/coder/v2/coderd/database"
|
|
"github.com/coder/coder/v2/coderd/database/dbauthz"
|
|
)
|
|
|
|
type ScriptsAPI struct {
|
|
Database database.Store
|
|
}
|
|
|
|
func (s *ScriptsAPI) ScriptCompleted(ctx context.Context, req *agentproto.WorkspaceAgentScriptCompletedRequest) (*agentproto.WorkspaceAgentScriptCompletedResponse, error) {
|
|
res := &agentproto.WorkspaceAgentScriptCompletedResponse{}
|
|
|
|
scriptID, err := uuid.FromBytes(req.Timing.ScriptId)
|
|
if err != nil {
|
|
return nil, xerrors.Errorf("script id from bytes: %w", err)
|
|
}
|
|
|
|
var stage database.WorkspaceAgentScriptTimingStage
|
|
switch req.Timing.Stage {
|
|
case agentproto.Timing_START:
|
|
stage = database.WorkspaceAgentScriptTimingStageStart
|
|
case agentproto.Timing_STOP:
|
|
stage = database.WorkspaceAgentScriptTimingStageStop
|
|
case agentproto.Timing_CRON:
|
|
stage = database.WorkspaceAgentScriptTimingStageCron
|
|
}
|
|
|
|
var status database.WorkspaceAgentScriptTimingStatus
|
|
switch req.Timing.Status {
|
|
case agentproto.Timing_OK:
|
|
status = database.WorkspaceAgentScriptTimingStatusOk
|
|
case agentproto.Timing_EXIT_FAILURE:
|
|
status = database.WorkspaceAgentScriptTimingStatusExitFailure
|
|
case agentproto.Timing_TIMED_OUT:
|
|
status = database.WorkspaceAgentScriptTimingStatusTimedOut
|
|
case agentproto.Timing_PIPES_LEFT_OPEN:
|
|
status = database.WorkspaceAgentScriptTimingStatusPipesLeftOpen
|
|
}
|
|
|
|
//nolint:gocritic // We need permissions to write to the DB here and we are in the context of the agent.
|
|
ctx = dbauthz.AsProvisionerd(ctx)
|
|
err = s.Database.InsertWorkspaceAgentScriptTimings(ctx, database.InsertWorkspaceAgentScriptTimingsParams{
|
|
ScriptID: scriptID,
|
|
Stage: stage,
|
|
Status: status,
|
|
StartedAt: req.Timing.Start.AsTime(),
|
|
EndedAt: req.Timing.End.AsTime(),
|
|
ExitCode: req.Timing.ExitCode,
|
|
})
|
|
if err != nil {
|
|
return nil, xerrors.Errorf("insert workspace agent script timings into database: %w", err)
|
|
}
|
|
|
|
return res, nil
|
|
}
|