mirror of
https://github.com/coder/coder.git
synced 2025-07-03 16:13:58 +00:00
An issue came up last week... our `embed.go` strategy doesn't handle dynamic NextJS-style routes! This is a blocker, because I'm aiming to set up CD on Monday, and the v2 UI makes heavy use of dynamic routing. As a potential solution, this implements a go pkg `nextrouter` that serves `html` files, but respecting the dynamic routing behavior of NextJS: - Files that have square brackets - ie `[providers]` provide a single-level dynamic route - Files that have `[[...` prefix - ie `[[...any]]` - are catch-all routes. - Files should be preferred over folders (ie, `providers.html` is preferred over `/providers`) - Fixes the trailing-slash bug we hit in the previous `embed` strategy This also integrates with `slog.Logger` for tracing, and handles injecting template parameters - a feature we need in v1 and v2 to be able to inject stuff like CSRF tokens. This implements testing by using an in-memory file-system, so that we can exercise all of these cases. In addition, this adjust V2's `embed.go` strategy to use `nextrouter`, which simplifies that file considerably. I'm tempted to factor out the `secureheaders` logic into a separate package, too. If this works OK, it could be used for V1 too (although that scenario is more complex due to our hybrid-routing strategy). Based on our FE variety meeting, there's always a chance we could move away from NextJS in v1 - if that's the case, this router will still work and be more tested than our previous strategy (it just won't make use of dynamic routing). So I figured this was worth doing to make sure we can make forward progress in V2.
140 lines
4.2 KiB
Go
140 lines
4.2 KiB
Go
package coderd
|
|
|
|
import (
|
|
"net/http"
|
|
|
|
"github.com/go-chi/chi/v5"
|
|
|
|
"cdr.dev/slog"
|
|
"github.com/coder/coder/database"
|
|
"github.com/coder/coder/httpapi"
|
|
"github.com/coder/coder/httpmw"
|
|
"github.com/coder/coder/site"
|
|
)
|
|
|
|
// Options are requires parameters for Coder to start.
|
|
type Options struct {
|
|
Logger slog.Logger
|
|
Database database.Store
|
|
Pubsub database.Pubsub
|
|
}
|
|
|
|
// New constructs the Coder API into an HTTP handler.
|
|
func New(options *Options) http.Handler {
|
|
api := &api{
|
|
Database: options.Database,
|
|
Logger: options.Logger,
|
|
Pubsub: options.Pubsub,
|
|
}
|
|
|
|
r := chi.NewRouter()
|
|
r.Route("/api/v2", func(r chi.Router) {
|
|
r.Get("/", func(w http.ResponseWriter, r *http.Request) {
|
|
httpapi.Write(w, http.StatusOK, httpapi.Response{
|
|
Message: "👋",
|
|
})
|
|
})
|
|
r.Post("/login", api.postLogin)
|
|
r.Post("/logout", api.postLogout)
|
|
// Used for setup.
|
|
r.Post("/user", api.postUser)
|
|
r.Route("/users", func(r chi.Router) {
|
|
r.Use(
|
|
httpmw.ExtractAPIKey(options.Database, nil),
|
|
)
|
|
r.Post("/", api.postUsers)
|
|
r.Group(func(r chi.Router) {
|
|
r.Use(httpmw.ExtractUserParam(options.Database))
|
|
r.Get("/{user}", api.userByName)
|
|
r.Get("/{user}/organizations", api.organizationsByUser)
|
|
})
|
|
})
|
|
r.Route("/projects", func(r chi.Router) {
|
|
r.Use(
|
|
httpmw.ExtractAPIKey(options.Database, nil),
|
|
)
|
|
r.Get("/", api.projects)
|
|
r.Route("/{organization}", func(r chi.Router) {
|
|
r.Use(httpmw.ExtractOrganizationParam(options.Database))
|
|
r.Get("/", api.projectsByOrganization)
|
|
r.Post("/", api.postProjectsByOrganization)
|
|
r.Route("/{project}", func(r chi.Router) {
|
|
r.Use(httpmw.ExtractProjectParam(options.Database))
|
|
r.Get("/", api.projectByOrganization)
|
|
r.Get("/workspaces", api.workspacesByProject)
|
|
r.Route("/parameters", func(r chi.Router) {
|
|
r.Get("/", api.parametersByProject)
|
|
r.Post("/", api.postParametersByProject)
|
|
})
|
|
r.Route("/versions", func(r chi.Router) {
|
|
r.Get("/", api.projectVersionsByOrganization)
|
|
r.Post("/", api.postProjectVersionByOrganization)
|
|
r.Route("/{projectversion}", func(r chi.Router) {
|
|
r.Use(httpmw.ExtractProjectVersionParam(api.Database))
|
|
r.Get("/", api.projectVersionByOrganizationAndName)
|
|
r.Get("/parameters", api.projectVersionParametersByOrganizationAndName)
|
|
})
|
|
})
|
|
})
|
|
})
|
|
})
|
|
|
|
// Listing operations specific to resources should go under
|
|
// their respective routes. eg. /orgs/<name>/workspaces
|
|
r.Route("/workspaces", func(r chi.Router) {
|
|
r.Use(httpmw.ExtractAPIKey(options.Database, nil))
|
|
r.Get("/", api.workspaces)
|
|
r.Route("/{user}", func(r chi.Router) {
|
|
r.Use(httpmw.ExtractUserParam(options.Database))
|
|
r.Post("/", api.postWorkspaceByUser)
|
|
r.Route("/{workspace}", func(r chi.Router) {
|
|
r.Use(httpmw.ExtractWorkspaceParam(options.Database))
|
|
r.Get("/", api.workspaceByUser)
|
|
r.Route("/version", func(r chi.Router) {
|
|
r.Post("/", api.postWorkspaceHistoryByUser)
|
|
r.Get("/", api.workspaceHistoryByUser)
|
|
r.Route("/{workspacehistory}", func(r chi.Router) {
|
|
r.Use(httpmw.ExtractWorkspaceHistoryParam(options.Database))
|
|
r.Get("/", api.workspaceHistoryByName)
|
|
})
|
|
})
|
|
})
|
|
})
|
|
})
|
|
|
|
r.Route("/files", func(r chi.Router) {
|
|
r.Use(httpmw.ExtractAPIKey(options.Database, nil))
|
|
r.Post("/", api.postFiles)
|
|
})
|
|
|
|
r.Route("/provisioners", func(r chi.Router) {
|
|
r.Route("/daemons", func(r chi.Router) {
|
|
r.Get("/", api.provisionerDaemons)
|
|
r.Get("/serve", api.provisionerDaemonsServe)
|
|
})
|
|
r.Route("/jobs/{organization}", func(r chi.Router) {
|
|
r.Use(
|
|
httpmw.ExtractAPIKey(options.Database, nil),
|
|
httpmw.ExtractOrganizationParam(options.Database),
|
|
)
|
|
r.Post("/import", api.postProvisionerImportJobByOrganization)
|
|
r.Route("/{provisionerjob}", func(r chi.Router) {
|
|
r.Use(httpmw.ExtractProvisionerJobParam(options.Database))
|
|
r.Get("/", api.provisionerJobByOrganization)
|
|
r.Get("/logs", api.provisionerJobLogsByID)
|
|
})
|
|
})
|
|
})
|
|
})
|
|
r.NotFound(site.Handler(options.Logger).ServeHTTP)
|
|
return r
|
|
}
|
|
|
|
// API contains all route handlers. Only HTTP handlers should
|
|
// be added to this struct for code clarity.
|
|
type api struct {
|
|
Database database.Store
|
|
Logger slog.Logger
|
|
Pubsub database.Pubsub
|
|
}
|