mirror of
https://github.com/coder/coder.git
synced 2025-07-03 16:13:58 +00:00
* chore: rename `AgentConn` to `WorkspaceAgentConn` The codersdk was becoming bloated with consts for the workspace agent that made no sense to a reader. `Tailnet*` is an example of these consts. * chore: remove `Get` prefix from *Client functions * chore: remove `BypassRatelimits` option in `codersdk.Client` It feels wrong to have this as a direct option because it's so infrequently needed by API callers. It's better to directly modify headers in the two places that we actually use it. * Merge `appearance.go` and `buildinfo.go` into `deployment.go` * Merge `experiments.go` and `features.go` into `deployment.go` * Fix `make gen` referencing old type names * Merge `error.go` into `client.go` `codersdk.Response` lived in `error.go`, which is wrong. * chore: refactor workspace agent functions into agentsdk It was odd conflating the codersdk that clients should use with functions that only the agent should use. This separates them into two SDKs that are closely coupled, but separate. * Merge `insights.go` into `deployment.go` * Merge `organizationmember.go` into `organizations.go` * Merge `quota.go` into `workspaces.go` * Rename `sse.go` to `serversentevents.go` * Rename `codersdk.WorkspaceAppHostResponse` to `codersdk.AppHostResponse` * Format `.vscode/settings.json` * Fix outdated naming in `api.ts` * Fix app host response * Fix unsupported type * Fix imported type
232 lines
6.1 KiB
Go
232 lines
6.1 KiB
Go
package wsconncache_test
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"io"
|
|
"net"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"net/http/httputil"
|
|
"net/netip"
|
|
"net/url"
|
|
"strings"
|
|
"sync"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/google/uuid"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
"go.uber.org/atomic"
|
|
"go.uber.org/goleak"
|
|
|
|
"cdr.dev/slog"
|
|
"cdr.dev/slog/sloggers/slogtest"
|
|
"github.com/coder/coder/agent"
|
|
"github.com/coder/coder/coderd/wsconncache"
|
|
"github.com/coder/coder/codersdk"
|
|
"github.com/coder/coder/codersdk/agentsdk"
|
|
"github.com/coder/coder/tailnet"
|
|
"github.com/coder/coder/tailnet/tailnettest"
|
|
)
|
|
|
|
func TestMain(m *testing.M) {
|
|
goleak.VerifyTestMain(m)
|
|
}
|
|
|
|
func TestCache(t *testing.T) {
|
|
t.Parallel()
|
|
t.Run("Same", func(t *testing.T) {
|
|
t.Parallel()
|
|
cache := wsconncache.New(func(r *http.Request, id uuid.UUID) (*codersdk.WorkspaceAgentConn, error) {
|
|
return setupAgent(t, agentsdk.Metadata{}, 0), nil
|
|
}, 0)
|
|
defer func() {
|
|
_ = cache.Close()
|
|
}()
|
|
conn1, _, err := cache.Acquire(httptest.NewRequest(http.MethodGet, "/", nil), uuid.Nil)
|
|
require.NoError(t, err)
|
|
conn2, _, err := cache.Acquire(httptest.NewRequest(http.MethodGet, "/", nil), uuid.Nil)
|
|
require.NoError(t, err)
|
|
require.True(t, conn1 == conn2)
|
|
})
|
|
t.Run("Expire", func(t *testing.T) {
|
|
t.Parallel()
|
|
called := atomic.NewInt32(0)
|
|
cache := wsconncache.New(func(r *http.Request, id uuid.UUID) (*codersdk.WorkspaceAgentConn, error) {
|
|
called.Add(1)
|
|
return setupAgent(t, agentsdk.Metadata{}, 0), nil
|
|
}, time.Microsecond)
|
|
defer func() {
|
|
_ = cache.Close()
|
|
}()
|
|
conn, release, err := cache.Acquire(httptest.NewRequest(http.MethodGet, "/", nil), uuid.Nil)
|
|
require.NoError(t, err)
|
|
release()
|
|
<-conn.Closed()
|
|
conn, release, err = cache.Acquire(httptest.NewRequest(http.MethodGet, "/", nil), uuid.Nil)
|
|
require.NoError(t, err)
|
|
release()
|
|
<-conn.Closed()
|
|
require.Equal(t, int32(2), called.Load())
|
|
})
|
|
t.Run("NoExpireWhenLocked", func(t *testing.T) {
|
|
t.Parallel()
|
|
cache := wsconncache.New(func(r *http.Request, id uuid.UUID) (*codersdk.WorkspaceAgentConn, error) {
|
|
return setupAgent(t, agentsdk.Metadata{}, 0), nil
|
|
}, time.Microsecond)
|
|
defer func() {
|
|
_ = cache.Close()
|
|
}()
|
|
conn, release, err := cache.Acquire(httptest.NewRequest(http.MethodGet, "/", nil), uuid.Nil)
|
|
require.NoError(t, err)
|
|
time.Sleep(time.Millisecond)
|
|
release()
|
|
<-conn.Closed()
|
|
})
|
|
t.Run("HTTPTransport", func(t *testing.T) {
|
|
t.Parallel()
|
|
random, err := net.Listen("tcp", "127.0.0.1:0")
|
|
require.NoError(t, err)
|
|
defer func() {
|
|
_ = random.Close()
|
|
}()
|
|
tcpAddr, valid := random.Addr().(*net.TCPAddr)
|
|
require.True(t, valid)
|
|
|
|
server := &http.Server{
|
|
ReadHeaderTimeout: time.Minute,
|
|
Handler: http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
w.WriteHeader(http.StatusOK)
|
|
}),
|
|
}
|
|
defer func() {
|
|
_ = server.Close()
|
|
}()
|
|
go server.Serve(random)
|
|
|
|
cache := wsconncache.New(func(r *http.Request, id uuid.UUID) (*codersdk.WorkspaceAgentConn, error) {
|
|
return setupAgent(t, agentsdk.Metadata{}, 0), nil
|
|
}, time.Microsecond)
|
|
defer func() {
|
|
_ = cache.Close()
|
|
}()
|
|
|
|
var wg sync.WaitGroup
|
|
// Perform many requests in parallel to simulate
|
|
// simultaneous HTTP requests.
|
|
for i := 0; i < 50; i++ {
|
|
wg.Add(1)
|
|
go func() {
|
|
defer wg.Done()
|
|
proxy := httputil.NewSingleHostReverseProxy(&url.URL{
|
|
Scheme: "http",
|
|
Host: fmt.Sprintf("127.0.0.1:%d", tcpAddr.Port),
|
|
Path: "/",
|
|
})
|
|
req := httptest.NewRequest(http.MethodGet, "/", nil)
|
|
conn, release, err := cache.Acquire(req, uuid.Nil)
|
|
if !assert.NoError(t, err) {
|
|
return
|
|
}
|
|
defer release()
|
|
transport := conn.HTTPTransport()
|
|
defer transport.CloseIdleConnections()
|
|
proxy.Transport = transport
|
|
res := httptest.NewRecorder()
|
|
proxy.ServeHTTP(res, req)
|
|
resp := res.Result()
|
|
defer resp.Body.Close()
|
|
assert.Equal(t, http.StatusOK, resp.StatusCode)
|
|
}()
|
|
}
|
|
wg.Wait()
|
|
})
|
|
}
|
|
|
|
func setupAgent(t *testing.T, metadata agentsdk.Metadata, ptyTimeout time.Duration) *codersdk.WorkspaceAgentConn {
|
|
metadata.DERPMap = tailnettest.RunDERPAndSTUN(t)
|
|
|
|
coordinator := tailnet.NewCoordinator()
|
|
t.Cleanup(func() {
|
|
_ = coordinator.Close()
|
|
})
|
|
agentID := uuid.New()
|
|
closer := agent.New(agent.Options{
|
|
Client: &client{
|
|
t: t,
|
|
agentID: agentID,
|
|
metadata: metadata,
|
|
coordinator: coordinator,
|
|
},
|
|
Logger: slogtest.Make(t, nil).Named("agent").Leveled(slog.LevelInfo),
|
|
ReconnectingPTYTimeout: ptyTimeout,
|
|
})
|
|
t.Cleanup(func() {
|
|
_ = closer.Close()
|
|
})
|
|
conn, err := tailnet.NewConn(&tailnet.Options{
|
|
Addresses: []netip.Prefix{netip.PrefixFrom(tailnet.IP(), 128)},
|
|
DERPMap: metadata.DERPMap,
|
|
Logger: slogtest.Make(t, nil).Named("tailnet").Leveled(slog.LevelDebug),
|
|
})
|
|
require.NoError(t, err)
|
|
clientConn, serverConn := net.Pipe()
|
|
t.Cleanup(func() {
|
|
_ = clientConn.Close()
|
|
_ = serverConn.Close()
|
|
_ = conn.Close()
|
|
})
|
|
go coordinator.ServeClient(serverConn, uuid.New(), agentID)
|
|
sendNode, _ := tailnet.ServeCoordinator(clientConn, func(node []*tailnet.Node) error {
|
|
return conn.UpdateNodes(node)
|
|
})
|
|
conn.SetNodeCallback(sendNode)
|
|
return &codersdk.WorkspaceAgentConn{
|
|
Conn: conn,
|
|
}
|
|
}
|
|
|
|
type client struct {
|
|
t *testing.T
|
|
agentID uuid.UUID
|
|
metadata agentsdk.Metadata
|
|
coordinator tailnet.Coordinator
|
|
}
|
|
|
|
func (c *client) Metadata(_ context.Context) (agentsdk.Metadata, error) {
|
|
return c.metadata, nil
|
|
}
|
|
|
|
func (c *client) Listen(_ context.Context) (net.Conn, error) {
|
|
clientConn, serverConn := net.Pipe()
|
|
closed := make(chan struct{})
|
|
c.t.Cleanup(func() {
|
|
_ = serverConn.Close()
|
|
_ = clientConn.Close()
|
|
<-closed
|
|
})
|
|
go func() {
|
|
_ = c.coordinator.ServeAgent(serverConn, c.agentID, "")
|
|
close(closed)
|
|
}()
|
|
return clientConn, nil
|
|
}
|
|
|
|
func (*client) ReportStats(_ context.Context, _ slog.Logger, _ func() *agentsdk.Stats) (io.Closer, error) {
|
|
return io.NopCloser(strings.NewReader("")), nil
|
|
}
|
|
|
|
func (*client) PostLifecycle(_ context.Context, _ agentsdk.PostLifecycleRequest) error {
|
|
return nil
|
|
}
|
|
|
|
func (*client) PostAppHealth(_ context.Context, _ agentsdk.PostAppHealthsRequest) error {
|
|
return nil
|
|
}
|
|
|
|
func (*client) PostVersion(_ context.Context, _ string) error {
|
|
return nil
|
|
}
|