mirror of
https://github.com/coder/coder.git
synced 2025-07-12 00:14:10 +00:00
Fixes https://github.com/coder/coder/issues/17009 Adds a CLI command `coder open app <workspace> <app-slug>` that allows opening arbitrary `coder_apps` via the CLI. Users can optionally specify a region for workspace applications.
169 lines
5.5 KiB
Go
169 lines
5.5 KiB
Go
package cli
|
|
|
|
import (
|
|
"net/url"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/coder/coder/v2/codersdk"
|
|
)
|
|
|
|
func Test_resolveAgentAbsPath(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
type args struct {
|
|
workingDirectory string
|
|
relOrAbsPath string
|
|
agentOS string
|
|
local bool
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
args args
|
|
want string
|
|
wantErr bool
|
|
}{
|
|
{"ok no args", args{}, "", false},
|
|
{"ok only working directory", args{workingDirectory: "/workdir"}, "/workdir", false},
|
|
{"ok with working directory and rel path", args{workingDirectory: "/workdir", relOrAbsPath: "my/path"}, "/workdir/my/path", false},
|
|
{"ok with working directory and abs path", args{workingDirectory: "/workdir", relOrAbsPath: "/my/path"}, "/my/path", false},
|
|
{"ok with no working directory and abs path", args{relOrAbsPath: "/my/path"}, "/my/path", false},
|
|
|
|
{"fail tilde", args{relOrAbsPath: "~"}, "", true},
|
|
{"fail tilde with working directory", args{workingDirectory: "/workdir", relOrAbsPath: "~"}, "", true},
|
|
{"fail tilde path", args{relOrAbsPath: "~/workdir"}, "", true},
|
|
{"fail tilde path with working directory", args{workingDirectory: "/workdir", relOrAbsPath: "~/workdir"}, "", true},
|
|
{"fail relative dot with no working directory", args{relOrAbsPath: "."}, "", true},
|
|
{"fail relative with no working directory", args{relOrAbsPath: "workdir"}, "", true},
|
|
|
|
{"ok with working directory and rel path on windows", args{workingDirectory: "C:\\workdir", relOrAbsPath: "my\\path", agentOS: "windows"}, "C:\\workdir\\my\\path", false},
|
|
{"ok with working directory and abs path on windows", args{workingDirectory: "C:\\workdir", relOrAbsPath: "C:\\my\\path", agentOS: "windows"}, "C:\\my\\path", false},
|
|
{"ok with no working directory and abs path on windows", args{relOrAbsPath: "C:\\my\\path", agentOS: "windows"}, "C:\\my\\path", false},
|
|
{"ok abs unix path on windows", args{workingDirectory: "C:\\workdir", relOrAbsPath: "/my/path", agentOS: "windows"}, "\\my\\path", false},
|
|
{"ok rel unix path on windows", args{workingDirectory: "C:\\workdir", relOrAbsPath: "my/path", agentOS: "windows"}, "C:\\workdir\\my\\path", false},
|
|
|
|
{"fail with no working directory and rel path on windows", args{relOrAbsPath: "my\\path", agentOS: "windows"}, "", true},
|
|
}
|
|
for _, tt := range tests {
|
|
tt := tt
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
got, err := resolveAgentAbsPath(tt.args.workingDirectory, tt.args.relOrAbsPath, tt.args.agentOS, tt.args.local)
|
|
if (err != nil) != tt.wantErr {
|
|
t.Errorf("resolveAgentAbsPath() error = %v, wantErr %v", err, tt.wantErr)
|
|
return
|
|
}
|
|
if got != tt.want {
|
|
t.Errorf("resolveAgentAbsPath() = %v, want %v", got, tt.want)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func Test_buildAppLinkURL(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
for _, tt := range []struct {
|
|
name string
|
|
// function arguments
|
|
baseURL string
|
|
workspace codersdk.Workspace
|
|
agent codersdk.WorkspaceAgent
|
|
app codersdk.WorkspaceApp
|
|
appsHost string
|
|
preferredPathBase string
|
|
// expected results
|
|
expectedLink string
|
|
}{
|
|
{
|
|
name: "external url",
|
|
baseURL: "https://coder.tld",
|
|
app: codersdk.WorkspaceApp{
|
|
External: true,
|
|
URL: "https://external-url.tld",
|
|
},
|
|
expectedLink: "https://external-url.tld",
|
|
},
|
|
{
|
|
name: "without subdomain",
|
|
baseURL: "https://coder.tld",
|
|
workspace: codersdk.Workspace{
|
|
Name: "Test-Workspace",
|
|
OwnerName: "username",
|
|
},
|
|
agent: codersdk.WorkspaceAgent{
|
|
Name: "a-workspace-agent",
|
|
},
|
|
app: codersdk.WorkspaceApp{
|
|
Slug: "app-slug",
|
|
Subdomain: false,
|
|
},
|
|
preferredPathBase: "/path-base",
|
|
expectedLink: "https://coder.tld/path-base/@username/Test-Workspace.a-workspace-agent/apps/app-slug/",
|
|
},
|
|
{
|
|
name: "with command",
|
|
baseURL: "https://coder.tld",
|
|
workspace: codersdk.Workspace{
|
|
Name: "Test-Workspace",
|
|
OwnerName: "username",
|
|
},
|
|
agent: codersdk.WorkspaceAgent{
|
|
Name: "a-workspace-agent",
|
|
},
|
|
app: codersdk.WorkspaceApp{
|
|
Command: "ls -la",
|
|
},
|
|
expectedLink: "https://coder.tld/@username/Test-Workspace.a-workspace-agent/terminal?command=ls%20-la",
|
|
},
|
|
{
|
|
name: "with subdomain",
|
|
baseURL: "ftps://coder.tld",
|
|
workspace: codersdk.Workspace{
|
|
Name: "Test-Workspace",
|
|
OwnerName: "username",
|
|
},
|
|
agent: codersdk.WorkspaceAgent{
|
|
Name: "a-workspace-agent",
|
|
},
|
|
app: codersdk.WorkspaceApp{
|
|
Subdomain: true,
|
|
SubdomainName: "hellocoder",
|
|
},
|
|
preferredPathBase: "/path-base",
|
|
appsHost: "*.apps-host.tld",
|
|
expectedLink: "ftps://hellocoder.apps-host.tld/",
|
|
},
|
|
{
|
|
name: "with subdomain, but not apps host",
|
|
baseURL: "https://coder.tld",
|
|
workspace: codersdk.Workspace{
|
|
Name: "Test-Workspace",
|
|
OwnerName: "username",
|
|
},
|
|
agent: codersdk.WorkspaceAgent{
|
|
Name: "a-workspace-agent",
|
|
},
|
|
app: codersdk.WorkspaceApp{
|
|
Slug: "app-slug",
|
|
Subdomain: true,
|
|
SubdomainName: "It really doesn't matter what this is without AppsHost.",
|
|
},
|
|
preferredPathBase: "/path-base",
|
|
expectedLink: "https://coder.tld/path-base/@username/Test-Workspace.a-workspace-agent/apps/app-slug/",
|
|
},
|
|
} {
|
|
tt := tt
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
baseURL, err := url.Parse(tt.baseURL)
|
|
require.NoError(t, err)
|
|
actual := buildAppLinkURL(baseURL, tt.workspace, tt.agent, tt.app, tt.appsHost, tt.preferredPathBase)
|
|
assert.Equal(t, tt.expectedLink, actual)
|
|
})
|
|
}
|
|
}
|