mirror of
https://github.com/coder/coder.git
synced 2025-07-03 16:13:58 +00:00
Closes #14716 Closes #14717 Adds a new user-scoped tailnet API endpoint (`api/v2/tailnet`) with a new RPC stream for receiving updates on workspaces owned by a specific user, as defined in #14716. When a stream is started, the `WorkspaceUpdatesProvider` will begin listening on the user-scoped pubsub events implemented in #14964. When a relevant event type is seen (such as a workspace state transition), the provider will query the DB for all the workspaces (and agents) owned by the user. This gets compared against the result of the previous query to produce a set of workspace updates. Workspace updates can be requested for any user ID, however only workspaces the authorised user is permitted to `ActionRead` will have their updates streamed. Opening a tunnel to an agent requires that the user can perform `ActionSSH` against the workspace containing it.
372 lines
9.3 KiB
Go
372 lines
9.3 KiB
Go
package coderd_test
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"slices"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/google/uuid"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"cdr.dev/slog/sloggers/slogtest"
|
|
"github.com/coder/coder/v2/coderd"
|
|
"github.com/coder/coder/v2/coderd/database"
|
|
"github.com/coder/coder/v2/coderd/database/dbauthz"
|
|
"github.com/coder/coder/v2/coderd/database/pubsub"
|
|
"github.com/coder/coder/v2/coderd/rbac"
|
|
"github.com/coder/coder/v2/coderd/rbac/policy"
|
|
"github.com/coder/coder/v2/coderd/wspubsub"
|
|
"github.com/coder/coder/v2/tailnet"
|
|
"github.com/coder/coder/v2/tailnet/proto"
|
|
"github.com/coder/coder/v2/testutil"
|
|
)
|
|
|
|
func TestWorkspaceUpdates(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
ws1ID := uuid.UUID{0x01}
|
|
ws1IDSlice := tailnet.UUIDToByteSlice(ws1ID)
|
|
agent1ID := uuid.UUID{0x02}
|
|
agent1IDSlice := tailnet.UUIDToByteSlice(agent1ID)
|
|
ws2ID := uuid.UUID{0x03}
|
|
ws2IDSlice := tailnet.UUIDToByteSlice(ws2ID)
|
|
ws3ID := uuid.UUID{0x04}
|
|
ws3IDSlice := tailnet.UUIDToByteSlice(ws3ID)
|
|
agent2ID := uuid.UUID{0x05}
|
|
agent2IDSlice := tailnet.UUIDToByteSlice(agent2ID)
|
|
ws4ID := uuid.UUID{0x06}
|
|
ws4IDSlice := tailnet.UUIDToByteSlice(ws4ID)
|
|
agent3ID := uuid.UUID{0x07}
|
|
agent3IDSlice := tailnet.UUIDToByteSlice(agent3ID)
|
|
|
|
ownerID := uuid.UUID{0x08}
|
|
memberRole, err := rbac.RoleByName(rbac.RoleMember())
|
|
require.NoError(t, err)
|
|
ownerSubject := rbac.Subject{
|
|
FriendlyName: "member",
|
|
ID: ownerID.String(),
|
|
Roles: rbac.Roles{memberRole},
|
|
Scope: rbac.ScopeAll,
|
|
}
|
|
|
|
t.Run("Basic", func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
ctx := testutil.Context(t, testutil.WaitShort)
|
|
|
|
db := &mockWorkspaceStore{
|
|
orderedRows: []database.GetWorkspacesAndAgentsByOwnerIDRow{
|
|
// Gains agent2
|
|
{
|
|
ID: ws1ID,
|
|
Name: "ws1",
|
|
JobStatus: database.ProvisionerJobStatusRunning,
|
|
Transition: database.WorkspaceTransitionStart,
|
|
Agents: []database.AgentIDNamePair{
|
|
{
|
|
ID: agent1ID,
|
|
Name: "agent1",
|
|
},
|
|
},
|
|
},
|
|
// Changes status
|
|
{
|
|
ID: ws2ID,
|
|
Name: "ws2",
|
|
JobStatus: database.ProvisionerJobStatusRunning,
|
|
Transition: database.WorkspaceTransitionStart,
|
|
},
|
|
// Is deleted
|
|
{
|
|
ID: ws3ID,
|
|
Name: "ws3",
|
|
JobStatus: database.ProvisionerJobStatusSucceeded,
|
|
Transition: database.WorkspaceTransitionStop,
|
|
Agents: []database.AgentIDNamePair{
|
|
{
|
|
ID: agent3ID,
|
|
Name: "agent3",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
ps := &mockPubsub{
|
|
cbs: map[string]pubsub.ListenerWithErr{},
|
|
}
|
|
|
|
updateProvider := coderd.NewUpdatesProvider(slogtest.Make(t, nil), ps, db, &mockAuthorizer{})
|
|
t.Cleanup(func() {
|
|
_ = updateProvider.Close()
|
|
})
|
|
|
|
sub, err := updateProvider.Subscribe(dbauthz.As(ctx, ownerSubject), ownerID)
|
|
require.NoError(t, err)
|
|
t.Cleanup(func() {
|
|
_ = sub.Close()
|
|
})
|
|
|
|
update := testutil.RequireRecvCtx(ctx, t, sub.Updates())
|
|
slices.SortFunc(update.UpsertedWorkspaces, func(a, b *proto.Workspace) int {
|
|
return strings.Compare(a.Name, b.Name)
|
|
})
|
|
slices.SortFunc(update.UpsertedAgents, func(a, b *proto.Agent) int {
|
|
return strings.Compare(a.Name, b.Name)
|
|
})
|
|
require.Equal(t, &proto.WorkspaceUpdate{
|
|
UpsertedWorkspaces: []*proto.Workspace{
|
|
{
|
|
Id: ws1IDSlice,
|
|
Name: "ws1",
|
|
Status: proto.Workspace_STARTING,
|
|
},
|
|
{
|
|
Id: ws2IDSlice,
|
|
Name: "ws2",
|
|
Status: proto.Workspace_STARTING,
|
|
},
|
|
{
|
|
Id: ws3IDSlice,
|
|
Name: "ws3",
|
|
Status: proto.Workspace_STOPPED,
|
|
},
|
|
},
|
|
UpsertedAgents: []*proto.Agent{
|
|
{
|
|
Id: agent1IDSlice,
|
|
Name: "agent1",
|
|
WorkspaceId: ws1IDSlice,
|
|
},
|
|
{
|
|
Id: agent3IDSlice,
|
|
Name: "agent3",
|
|
WorkspaceId: ws3IDSlice,
|
|
},
|
|
},
|
|
DeletedWorkspaces: []*proto.Workspace{},
|
|
DeletedAgents: []*proto.Agent{},
|
|
}, update)
|
|
|
|
// Update the database
|
|
db.orderedRows = []database.GetWorkspacesAndAgentsByOwnerIDRow{
|
|
{
|
|
ID: ws1ID,
|
|
Name: "ws1",
|
|
JobStatus: database.ProvisionerJobStatusRunning,
|
|
Transition: database.WorkspaceTransitionStart,
|
|
Agents: []database.AgentIDNamePair{
|
|
{
|
|
ID: agent1ID,
|
|
Name: "agent1",
|
|
},
|
|
{
|
|
ID: agent2ID,
|
|
Name: "agent2",
|
|
},
|
|
},
|
|
},
|
|
{
|
|
ID: ws2ID,
|
|
Name: "ws2",
|
|
JobStatus: database.ProvisionerJobStatusRunning,
|
|
Transition: database.WorkspaceTransitionStop,
|
|
},
|
|
{
|
|
ID: ws4ID,
|
|
Name: "ws4",
|
|
JobStatus: database.ProvisionerJobStatusRunning,
|
|
Transition: database.WorkspaceTransitionStart,
|
|
},
|
|
}
|
|
publishWorkspaceEvent(t, ps, ownerID, &wspubsub.WorkspaceEvent{
|
|
Kind: wspubsub.WorkspaceEventKindStateChange,
|
|
WorkspaceID: ws1ID,
|
|
})
|
|
|
|
update = testutil.RequireRecvCtx(ctx, t, sub.Updates())
|
|
slices.SortFunc(update.UpsertedWorkspaces, func(a, b *proto.Workspace) int {
|
|
return strings.Compare(a.Name, b.Name)
|
|
})
|
|
require.Equal(t, &proto.WorkspaceUpdate{
|
|
UpsertedWorkspaces: []*proto.Workspace{
|
|
{
|
|
// Changed status
|
|
Id: ws2IDSlice,
|
|
Name: "ws2",
|
|
Status: proto.Workspace_STOPPING,
|
|
},
|
|
{
|
|
// New workspace
|
|
Id: ws4IDSlice,
|
|
Name: "ws4",
|
|
Status: proto.Workspace_STARTING,
|
|
},
|
|
},
|
|
UpsertedAgents: []*proto.Agent{
|
|
{
|
|
Id: agent2IDSlice,
|
|
Name: "agent2",
|
|
WorkspaceId: ws1IDSlice,
|
|
},
|
|
},
|
|
DeletedWorkspaces: []*proto.Workspace{
|
|
{
|
|
Id: ws3IDSlice,
|
|
Name: "ws3",
|
|
Status: proto.Workspace_STOPPED,
|
|
},
|
|
},
|
|
DeletedAgents: []*proto.Agent{
|
|
{
|
|
Id: agent3IDSlice,
|
|
Name: "agent3",
|
|
WorkspaceId: ws3IDSlice,
|
|
},
|
|
},
|
|
}, update)
|
|
})
|
|
|
|
t.Run("Resubscribe", func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
ctx := testutil.Context(t, testutil.WaitShort)
|
|
|
|
db := &mockWorkspaceStore{
|
|
orderedRows: []database.GetWorkspacesAndAgentsByOwnerIDRow{
|
|
{
|
|
ID: ws1ID,
|
|
Name: "ws1",
|
|
JobStatus: database.ProvisionerJobStatusRunning,
|
|
Transition: database.WorkspaceTransitionStart,
|
|
Agents: []database.AgentIDNamePair{
|
|
{
|
|
ID: agent1ID,
|
|
Name: "agent1",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
ps := &mockPubsub{
|
|
cbs: map[string]pubsub.ListenerWithErr{},
|
|
}
|
|
|
|
updateProvider := coderd.NewUpdatesProvider(slogtest.Make(t, nil), ps, db, &mockAuthorizer{})
|
|
t.Cleanup(func() {
|
|
_ = updateProvider.Close()
|
|
})
|
|
|
|
sub, err := updateProvider.Subscribe(dbauthz.As(ctx, ownerSubject), ownerID)
|
|
require.NoError(t, err)
|
|
t.Cleanup(func() {
|
|
_ = sub.Close()
|
|
})
|
|
|
|
expected := &proto.WorkspaceUpdate{
|
|
UpsertedWorkspaces: []*proto.Workspace{
|
|
{
|
|
Id: ws1IDSlice,
|
|
Name: "ws1",
|
|
Status: proto.Workspace_STARTING,
|
|
},
|
|
},
|
|
UpsertedAgents: []*proto.Agent{
|
|
{
|
|
Id: agent1IDSlice,
|
|
Name: "agent1",
|
|
WorkspaceId: ws1IDSlice,
|
|
},
|
|
},
|
|
DeletedWorkspaces: []*proto.Workspace{},
|
|
DeletedAgents: []*proto.Agent{},
|
|
}
|
|
|
|
update := testutil.RequireRecvCtx(ctx, t, sub.Updates())
|
|
slices.SortFunc(update.UpsertedWorkspaces, func(a, b *proto.Workspace) int {
|
|
return strings.Compare(a.Name, b.Name)
|
|
})
|
|
require.Equal(t, expected, update)
|
|
|
|
resub, err := updateProvider.Subscribe(dbauthz.As(ctx, ownerSubject), ownerID)
|
|
require.NoError(t, err)
|
|
t.Cleanup(func() {
|
|
_ = resub.Close()
|
|
})
|
|
|
|
update = testutil.RequireRecvCtx(ctx, t, resub.Updates())
|
|
slices.SortFunc(update.UpsertedWorkspaces, func(a, b *proto.Workspace) int {
|
|
return strings.Compare(a.Name, b.Name)
|
|
})
|
|
require.Equal(t, expected, update)
|
|
})
|
|
}
|
|
|
|
func publishWorkspaceEvent(t *testing.T, ps pubsub.Pubsub, ownerID uuid.UUID, event *wspubsub.WorkspaceEvent) {
|
|
msg, err := json.Marshal(event)
|
|
require.NoError(t, err)
|
|
ps.Publish(wspubsub.WorkspaceEventChannel(ownerID), msg)
|
|
}
|
|
|
|
type mockWorkspaceStore struct {
|
|
orderedRows []database.GetWorkspacesAndAgentsByOwnerIDRow
|
|
}
|
|
|
|
// GetAuthorizedWorkspacesAndAgentsByOwnerID implements coderd.UpdatesQuerier.
|
|
func (m *mockWorkspaceStore) GetWorkspacesAndAgentsByOwnerID(context.Context, uuid.UUID) ([]database.GetWorkspacesAndAgentsByOwnerIDRow, error) {
|
|
return m.orderedRows, nil
|
|
}
|
|
|
|
// GetWorkspaceByAgentID implements coderd.UpdatesQuerier.
|
|
func (*mockWorkspaceStore) GetWorkspaceByAgentID(context.Context, uuid.UUID) (database.Workspace, error) {
|
|
return database.Workspace{}, nil
|
|
}
|
|
|
|
var _ coderd.UpdatesQuerier = (*mockWorkspaceStore)(nil)
|
|
|
|
type mockPubsub struct {
|
|
cbs map[string]pubsub.ListenerWithErr
|
|
}
|
|
|
|
// Close implements pubsub.Pubsub.
|
|
func (*mockPubsub) Close() error {
|
|
panic("unimplemented")
|
|
}
|
|
|
|
// Publish implements pubsub.Pubsub.
|
|
func (m *mockPubsub) Publish(event string, message []byte) error {
|
|
cb, ok := m.cbs[event]
|
|
if !ok {
|
|
return nil
|
|
}
|
|
cb(context.Background(), message, nil)
|
|
return nil
|
|
}
|
|
|
|
func (*mockPubsub) Subscribe(string, pubsub.Listener) (cancel func(), err error) {
|
|
panic("unimplemented")
|
|
}
|
|
|
|
func (m *mockPubsub) SubscribeWithErr(event string, listener pubsub.ListenerWithErr) (func(), error) {
|
|
m.cbs[event] = listener
|
|
return func() {}, nil
|
|
}
|
|
|
|
var _ pubsub.Pubsub = (*mockPubsub)(nil)
|
|
|
|
type mockAuthorizer struct{}
|
|
|
|
func (*mockAuthorizer) Authorize(context.Context, rbac.Subject, policy.Action, rbac.Object) error {
|
|
return nil
|
|
}
|
|
|
|
// Prepare implements rbac.Authorizer.
|
|
func (*mockAuthorizer) Prepare(context.Context, rbac.Subject, policy.Action, string) (rbac.PreparedAuthorized, error) {
|
|
return nil, nil
|
|
}
|
|
|
|
var _ rbac.Authorizer = (*mockAuthorizer)(nil)
|