synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-03 16:13:58 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
b7462fb256bd97c59600a263cd3465092fd6c9ac
coder/coderd
History
Michael Suchacz b7462fb256 feat: improve transaction safety in CompleteJob function (#17970) 
This PR refactors the CompleteJob function to use database transactions
more consistently for better atomicity guarantees. The large function
was broken down into three specialized handlers:

- completeTemplateImportJob
- completeWorkspaceBuildJob
- completeTemplateDryRunJob

Each handler now uses the Database.InTx wrapper to ensure all database
operations for a job completion are performed within a single
transaction, preventing partial updates in case of failures.

Added comprehensive tests for transaction behavior for each job type.

Fixes #17694

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-authored-by: Claude <noreply@anthropic.com>
2025-05-21 16:48:51 +02:00
..
agentapi
fix: remove unnecessary user lookup in agent API calls (#17934)
2025-05-20 17:07:50 +02:00
agentmetrics
…
ai
feat: add database tables and API routes for agentic chat feature (#17570)
2025-05-02 17:29:57 +01:00
apidoc
chore(coderd/rbac): add Action{Create,Delete}Agent to ResourceWorkspace (#17932)
2025-05-20 21:20:56 +01:00
apikey
chore: update golang to 1.24.1 (#17035)
2025-03-26 01:56:39 -05:00
appearance
fix: make cli respect deployment --docs-url (#14568)
2024-09-18 21:47:53 +10:00
audit
chore: update golang to 1.24.1 (#17035)
2025-03-26 01:56:39 -05:00
autobuild
chore: disable parameter validatation for dynamic params for all transitions (#17926)
2025-05-20 10:09:53 -05:00
awsidentity
…
azureidentity
…
coderdtest
chore: disable parameter validatation for dynamic params for all transitions (#17926)
2025-05-20 10:09:53 -05:00
cryptokeys
fix(coderd/cryptokeys): relock mutex to avoid double unlock (#16802)
2025-03-04 17:10:12 +00:00
database
chore(coderd/rbac): add Action{Create,Delete}Agent to ResourceWorkspace (#17932)
2025-05-20 21:20:56 +01:00
devtunnel
refactor: replace golang.org/x/exp/slices with slices (#16772)
2025-03-04 00:46:49 +11:00
entitlements
chore: update testutil chan helpers (#17408)
2025-04-16 10:37:09 -06:00
externalauth
chore: update golang to 1.24.1 (#17035)
2025-03-26 01:56:39 -05:00
files
chore: use static params when dynamic param metadata is missing (#17836)
2025-05-16 11:47:59 -05:00
gitsshkey
…
healthcheck
chore: update golang to 1.24.1 (#17035)
2025-03-26 01:56:39 -05:00
httpapi
chore: add x-authz-checks debug header when running in dev mode (#16873)
2025-04-10 11:36:27 -06:00
httpmw
feat: cancel stuck pending jobs (#17803)
2025-05-20 15:22:44 +02:00
identityprovider
…
idpsync
test: do not run memory race test in parallel (#17582)
2025-04-28 12:20:07 -05:00
jobreaper
feat: cancel stuck pending jobs (#17803)
2025-05-20 15:22:44 +02:00
jwtutils
chore: replace github.com/go-jose/go-jose/v3 with v4 (#16031)
2025-01-03 11:21:49 -06:00
metricscache
ci: re-enable revive and gosec linters (#17225)
2025-04-02 16:19:23 +01:00
notifications
feat: track resource replacements when claiming a prebuilt workspace (#17571)
2025-05-14 14:52:22 +02:00
oauthpki
fix: stop extending API key access if OIDC refresh is available (#17878)
2025-05-19 12:05:35 +04:00
portsharing
…
prebuilds
feat: track resource replacements when claiming a prebuilt workspace (#17571)
2025-05-14 14:52:22 +02:00
prometheusmetrics
chore: revert dynamic params as a safe experiment (#17510)
2025-04-22 16:21:15 +00:00
promoauth
chore: add tx metrics and logs for serialization errors (#15215)
2024-10-25 12:14:15 -04:00
provisionerdserver
feat: improve transaction safety in CompleteJob function (#17970)
2025-05-21 16:48:51 +02:00
provisionerkey
…
pubsub
feat(coderd): add inbox notifications endpoints (#16889)
2025-03-18 00:02:47 +01:00
rbac
chore(coderd/rbac): add Action{Create,Delete}Agent to ResourceWorkspace (#17932)
2025-05-20 21:20:56 +01:00
render
…
runtimeconfig
feat: add endpoint for partial updates to org sync mapping (#16316)
2025-01-30 10:52:50 -07:00
schedule
chore: update golang to 1.24.1 (#17035)
2025-03-26 01:56:39 -05:00
searchquery
feat: support filtering users table by login type (#17238)
2025-04-09 13:59:41 +10:00
telemetry
chore: update golang to 1.24.1 (#17035)
2025-03-26 01:56:39 -05:00
testdata
chore: use static params when dynamic param metadata is missing (#17836)
2025-05-16 11:47:59 -05:00
tracing
chore: update golang to 1.24.1 (#17035)
2025-03-26 01:56:39 -05:00
updatecheck
chore: update golang to 1.24.1 (#17035)
2025-03-26 01:56:39 -05:00
userpassword
refactor: replace golang.org/x/exp/slices with slices (#16772)
2025-03-04 00:46:49 +11:00
util
feat: add API key scope to restrict access to user data (#17692)
2025-05-15 15:32:52 +01:00
webpush
feat(site): add webpush notification serviceworker (#17123)
2025-03-27 17:30:25 +00:00
workspaceapps
chore: add custom samesite options to auth cookies (#16885)
2025-04-08 14:15:14 -05:00
workspacestats
chore: update golang to 1.24.1 (#17035)
2025-03-26 01:56:39 -05:00
wsbuilder
chore: disable parameter validatation for dynamic params for all transitions (#17926)
2025-05-20 10:09:53 -05:00
wspubsub
feat: add app status tracking to the backend (#17163)
2025-03-31 10:55:44 -04:00
activitybump_test.go
chore: add standard test logger ignoring db canceled (#15556)
2024-11-18 14:09:22 +04:00
apikey_test.go
fix: remove redundant flaking test (#14888)
2024-10-01 09:01:24 +00:00
apikey.go
chore: add custom samesite options to auth cookies (#16885)
2025-04-08 14:15:14 -05:00
apiroot.go
…
audit_internal_test.go
chore: add sql filter to fetching audit logs (#14070)
2024-08-01 12:07:19 -05:00
audit_test.go
feat: add workspace agent connect and app open audit types (#16493)
2025-02-17 13:02:30 +00:00
audit.go
chore: update golang to 1.24.1 (#17035)
2025-03-26 01:56:39 -05:00
authorize_test.go
…
authorize.go
chore: authz 'any_org' to return if at least 1 org has perms (#14009)
2024-07-29 19:58:48 -05:00
chat_test.go
feat: add database tables and API routes for agentic chat feature (#17570)
2025-05-02 17:29:57 +01:00
chat.go
feat: add database tables and API routes for agentic chat feature (#17570)
2025-05-02 17:29:57 +01:00
client_test.go
…
coderd_internal_test.go
fix: handle urls with multiple slashes (#16527)
2025-02-12 09:23:28 +01:00
coderd_test.go
chore(testutil): add testutil.GoleakOptions (#16070)
2025-01-08 15:38:37 +00:00
coderd.go
feat: show devcontainer dirty status and allow recreate (#17880)
2025-05-19 12:56:10 +03:00
csp.go
…
debug_test.go
chore(cli): increase healthcheck timeout in TestSupportbundle (#17291)
2025-04-09 09:21:17 +01:00
debug.go
chore(cli): increase healthcheck timeout in TestSupportbundle (#17291)
2025-04-09 09:21:17 +01:00
deployment_test.go
…
deployment.go
feat: add database tables and API routes for agentic chat feature (#17570)
2025-05-02 17:29:57 +01:00
deprecated.go
…
experiments_test.go
chore: revert dynamic params as a safe experiment (#17510)
2025-04-22 16:21:15 +00:00
experiments.go
chore: revert dynamic params as a safe experiment (#17510)
2025-04-22 16:21:15 +00:00
externalauth_test.go
feat: add API key scope to restrict access to user data (#17692)
2025-05-15 15:32:52 +01:00
externalauth.go
fix: limit OAuth redirects to local paths (#14585)
2024-09-10 15:58:50 +01:00
files_test.go
fix: support windows specific zip mime type for template uploads (#15442)
2024-11-08 18:24:12 +11:00
files.go
fix: support windows specific zip mime type for template uploads (#15442)
2024-11-08 18:24:12 +11:00
gitsshkey_test.go
feat: add API key scope to restrict access to user data (#17692)
2025-05-15 15:32:52 +01:00
gitsshkey.go
feat: add API key scope to restrict access to user data (#17692)
2025-05-15 15:32:52 +01:00
inboxnotifications_internal_test.go
feat: set icons for each type of notification (#17115)
2025-03-31 09:40:24 -03:00
inboxnotifications_test.go
feat: set icons for each type of notification (#17115)
2025-03-31 09:40:24 -03:00
inboxnotifications.go
feat: extend request logs with auth & DB info (#17304)
2025-04-15 13:27:23 +02:00
insights_internal_test.go
test: skip tests affected by daylight savings issues (#16857)
2025-03-10 13:10:34 +01:00
insights_test.go
chore(Makefile): update golden files as part of make gen (#17039)
2025-03-21 13:04:30 +00:00
insights.go
chore: update golang to 1.24.1 (#17035)
2025-03-26 01:56:39 -05:00
latencycheck.go
…
members_test.go
chore: update error message for duplicate organization members (#17594)
2025-04-28 14:51:33 -06:00
members.go
chore: update error message for duplicate organization members (#17594)
2025-04-28 14:51:33 -06:00
notifications_test.go
feat(coderd): add new dispatch logic for coder inbox (#16764)
2025-03-05 22:43:18 +01:00
notifications.go
feat(coderd): add new dispatch logic for coder inbox (#16764)
2025-03-05 22:43:18 +01:00
oauth2_test.go
…
oauth2.go
…
organizations_test.go
…
organizations.go
chore: implement filters for the organizations query (#14468)
2024-08-28 13:24:28 -05:00
pagination_internal_test.go
…
pagination.go
…
parameters_test.go
chore: remove coder/preview dependency from codersdk (#17939)
2025-05-20 10:45:12 -05:00
parameters.go
chore: remove coder/preview dependency from codersdk (#17939)
2025-05-20 10:45:12 -05:00
presets_test.go
feat: persist prebuild definitions on template import (#16951)
2025-04-07 10:35:28 +02:00
presets.go
fix(coderd): avoid fetching extra parameters for a preset (#16642)
2025-02-20 09:58:04 +02:00
provisionerdaemons_test.go
fix: return provisioners in desc order and add limit to cli (#16720)
2025-02-26 21:06:51 +02:00
provisionerdaemons.go
feat(coderd/httpapi): add QueryParamParser.JSONStringMap (#16578)
2025-02-18 14:14:30 +00:00
provisionerjobs_internal_test.go
feat: extend request logs with auth & DB info (#17304)
2025-04-15 13:27:23 +02:00
provisionerjobs_test.go
feat: add provisioner daemon name to provisioner jobs responses (#17877)
2025-05-19 16:05:39 +01:00
provisionerjobs.go
feat: add provisioner daemon name to provisioner jobs responses (#17877)
2025-05-19 16:05:39 +01:00
roles_test.go
…
roles.go
chore: refactor patch custom organization route to live in enterprise (#14099)
2024-08-05 13:42:11 -05:00
tailnet_test.go
fix: reduce excessive logging when database is unreachable (#17363)
2025-04-15 10:55:30 +02:00
tailnet.go
fix: reduce excessive logging when database is unreachable (#17363)
2025-04-15 10:55:30 +02:00
templates_test.go
chore: add 'classic_parameter_flow' column setting to templates (#17828)
2025-05-15 17:55:17 -05:00
templates.go
chore: add 'classic_parameter_flow' column setting to templates (#17828)
2025-05-15 17:55:17 -05:00
templateversions_test.go
chore: fill out workspace owner data for dynamic parameters (#17366)
2025-04-17 14:51:50 -06:00
templateversions.go
chore: fill out workspace owner data for dynamic parameters (#17366)
2025-04-17 14:51:50 -06:00
updatecheck_test.go
…
updatecheck.go
…
userauth_test.go
chore: add custom samesite options to auth cookies (#16885)
2025-04-08 14:15:14 -05:00
userauth.go
chore: add custom samesite options to auth cookies (#16885)
2025-04-08 14:15:14 -05:00
users_test.go
chore: update testutil chan helpers (#17408)
2025-04-16 10:37:09 -06:00
users.go
test: add unit test to excercise bug when idp sync hits deleted orgs (#17405)
2025-04-16 09:27:35 -05:00
webpush_test.go
feat(coderd): add webpush package (#17091)
2025-03-27 10:03:53 +00:00
webpush.go
feat(coderd): add webpush package (#17091)
2025-03-27 10:03:53 +00:00
workspaceagentportshare_test.go
chore: join owner, template, and org in new workspace view (#15116)
2024-10-22 09:20:54 -05:00
workspaceagentportshare.go
…
workspaceagents_test.go
fix: remove unnecessary user lookup in agent API calls (#17934)
2025-05-20 17:07:50 +02:00
workspaceagents.go
feat: show devcontainer dirty status and allow recreate (#17880)
2025-05-19 12:56:10 +03:00
workspaceagentsrpc_internal_test.go
chore: update testutil chan helpers (#17408)
2025-04-16 10:37:09 -06:00
workspaceagentsrpc_test.go
fix: remove unnecessary user lookup in agent API calls (#17934)
2025-05-20 17:07:50 +02:00
workspaceagentsrpc.go
fix: remove unnecessary user lookup in agent API calls (#17934)
2025-05-20 17:07:50 +02:00
workspaceapps_test.go
chore: add standard test logger ignoring db canceled (#15556)
2024-11-18 14:09:22 +04:00
workspaceapps.go
feat: enable key rotation (#15066)
2024-10-25 17:14:35 +01:00
workspacebuilds_test.go
feat: mark prebuilds as such and set their preset ids (#16965)
2025-04-14 15:34:50 +02:00
workspacebuilds.go
chore: disable parameter validatation for dynamic params for all transitions (#17926)
2025-05-20 10:09:53 -05:00
workspaceproxies_test.go
…
workspaceproxies.go
…
workspaceresourceauth_test.go
fix!: enforce regex for agent names (#16641)
2025-02-20 05:09:26 +00:00
workspaceresourceauth.go
…
workspaces_test.go
fix: nil ptr deref when removing OIDC from deployment and accessing old users (#17501)
2025-04-23 08:45:26 -05:00
workspaces.go
chore: disable parameter validatation for dynamic params for all transitions (#17926)
2025-05-20 10:09:53 -05:00
workspaceupdates_test.go
chore: update testutil chan helpers (#17408)
2025-04-16 10:37:09 -06:00
workspaceupdates.go
chore: update golang to 1.24.1 (#17035)
2025-03-26 01:56:39 -05:00