mirror of
https://github.com/coder/coder.git
synced 2025-07-03 16:13:58 +00:00
1bfa7d42e8
This PR is the first in a series aimed at closing [#15109](https://github.com/coder/coder/issues/15109). ### Changes - **Template Database Creation:** `dbtestutil.Open` now has the ability to create a template database if none is provided via `DB_FROM`. The template database’s name is derived from a hash of the migration files, ensuring that it can be reused across tests and is automatically updated whenever migrations change. - **Optimized Database Handling:** Previously, `dbtestutil.Open` would spin up a new container for each test when `DB_FROM` was unset. Now, it first checks for an active PostgreSQL instance on `localhost:5432`. If none is found, it creates a single container that remains available for subsequent tests, eliminating repeated container startups. These changes address the long individual test times (10+ seconds) reported by some users, likely due to the time Docker took to start and complete migrations.
99 lines
2.5 KiB
Go
99 lines
2.5 KiB
Go
//go:build linux
|
|
|
|
package database_test
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
"testing"
|
|
|
|
"github.com/google/uuid"
|
|
"github.com/lib/pq"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/coder/coder/v2/coderd/database"
|
|
"github.com/coder/coder/v2/coderd/database/dbtestutil"
|
|
"github.com/coder/coder/v2/coderd/database/dbtime"
|
|
"github.com/coder/coder/v2/coderd/database/migrations"
|
|
)
|
|
|
|
func TestSerializedRetry(t *testing.T) {
|
|
t.Parallel()
|
|
if testing.Short() {
|
|
t.SkipNow()
|
|
}
|
|
|
|
sqlDB := testSQLDB(t)
|
|
db := database.New(sqlDB)
|
|
|
|
called := 0
|
|
txOpts := &database.TxOptions{Isolation: sql.LevelSerializable}
|
|
err := db.InTx(func(tx database.Store) error {
|
|
// Test nested error
|
|
return tx.InTx(func(tx database.Store) error {
|
|
// The easiest way to mock a serialization failure is to
|
|
// return a serialization failure error.
|
|
called++
|
|
return &pq.Error{
|
|
Code: "40001",
|
|
Message: "serialization_failure",
|
|
}
|
|
}, txOpts)
|
|
}, txOpts)
|
|
require.Error(t, err, "should fail")
|
|
// The double "execute transaction: execute transaction" is from the nested transactions.
|
|
// Just want to make sure we don't try 9 times.
|
|
require.Equal(t, err.Error(), "transaction failed after 3 attempts: execute transaction: execute transaction: pq: serialization_failure", "error message")
|
|
require.Equal(t, called, 3, "should retry 3 times")
|
|
}
|
|
|
|
func TestNestedInTx(t *testing.T) {
|
|
t.Parallel()
|
|
if testing.Short() {
|
|
t.SkipNow()
|
|
}
|
|
|
|
uid := uuid.New()
|
|
sqlDB := testSQLDB(t)
|
|
err := migrations.Up(sqlDB)
|
|
require.NoError(t, err, "migrations")
|
|
|
|
db := database.New(sqlDB)
|
|
err = db.InTx(func(outer database.Store) error {
|
|
return outer.InTx(func(inner database.Store) error {
|
|
//nolint:gocritic
|
|
require.Equal(t, outer, inner, "should be same transaction")
|
|
|
|
_, err := inner.InsertUser(context.Background(), database.InsertUserParams{
|
|
ID: uid,
|
|
Email: "coder@coder.com",
|
|
Username: "coder",
|
|
HashedPassword: []byte{},
|
|
CreatedAt: dbtime.Now(),
|
|
UpdatedAt: dbtime.Now(),
|
|
RBACRoles: []string{},
|
|
LoginType: database.LoginTypeGithub,
|
|
})
|
|
return err
|
|
}, nil)
|
|
}, nil)
|
|
require.NoError(t, err, "outer tx: %w", err)
|
|
|
|
user, err := db.GetUserByID(context.Background(), uid)
|
|
require.NoError(t, err, "user exists")
|
|
require.Equal(t, uid, user.ID, "user id expected")
|
|
}
|
|
|
|
func testSQLDB(t testing.TB) *sql.DB {
|
|
t.Helper()
|
|
|
|
connection, err := dbtestutil.Open(t)
|
|
require.NoError(t, err)
|
|
|
|
db, err := sql.Open("postgres", connection)
|
|
require.NoError(t, err)
|
|
t.Cleanup(func() { _ = db.Close() })
|
|
|
|
return db
|
|
}
|