Thomas Kosiewski c65013384a refactor: move OAuth2 provider code to dedicated package (#18746) ...

# Refactor OAuth2 Provider Code into Dedicated Package

This PR refactors the OAuth2 provider functionality by moving it from the main `coderd` package into a dedicated `oauth2provider` package. The change improves code organization and maintainability without changing functionality.

Key changes:

- Created a new `oauth2provider` package to house all OAuth2 provider-related code
- Moved existing OAuth2 provider functionality from `coderd/identityprovider` to the new package
- Refactored handler functions to follow a consistent pattern of returning `http.HandlerFunc` instead of being handlers directly
- Split large files into smaller, more focused files organized by functionality:
  - `app_secrets.go` - Manages OAuth2 application secrets
  - `apps.go` - Handles OAuth2 application CRUD operations
  - `authorize.go` - Implements the authorization flow
  - `metadata.go` - Provides OAuth2 metadata endpoints
  - `registration.go` - Handles dynamic client registration
  - `revoke.go` - Implements token revocation
  - `secrets.go` - Manages secret generation and validation
  - `tokens.go` - Handles token issuance and validation

This refactoring improves code organization and makes the OAuth2 provider functionality more maintainable while preserving all existing behavior.

2025-07-03 20:24:45 +02:00

..

agentapi

fix(coderd/agentapi): make sub agent slugs more unique (#18581)

2025-06-25 17:36:23 +01:00

agentmetrics

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

apidoc

feat: add MCP HTTP server experiment and improve experiment middleware (#18712)

2025-07-03 20:09:18 +02:00

apikey

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

appearance

fix: make cli respect deployment --docs-url (#14568)

2024-09-18 21:47:53 +10:00

audit

feat: allow users to pause prebuilt workspace reconciliation (#18700)

2025-07-02 15:05:42 +00:00

autobuild

chore: increase fileCache hit rate in autobuilds lifecycle (#18507)

2025-06-24 07:36:39 -05:00

awsidentity

fix: add new aws regions to instance identity (#10434)

2023-10-30 19:44:29 +00:00

azureidentity

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

coderdtest

feat: support dynamic parameters on create template request (#18636)

2025-07-02 09:44:01 -05:00

cryptokeys

chore: update to coder/quartz v0.2.0 (#18007)

2025-05-27 16:05:03 +04:00

database

fix: remove unique constraint on OAuth2 provider app names (#18669)

2025-07-03 19:13:13 +02:00

devtunnel

chore: disable devtunnel tests on windows (#18521)

2025-06-24 19:01:29 +10:00

dynamicparameters

chore: create interface for pkgs to return codersdk errors (#18719)

2025-07-03 08:33:45 -05:00

entitlements

chore: update testutil chan helpers (#17408)

2025-04-16 10:37:09 -06:00

externalauth

chore: remove unnecessary redeclarations in for loops (part 2) (#18593)

2025-06-26 12:28:00 -06:00

files

chore: don't cache errors in file cache (#18555)

2025-07-01 13:50:37 -06:00

gitsshkey

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

healthcheck

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

httpapi

chore: create interface for pkgs to return codersdk errors (#18719)

2025-07-03 08:33:45 -05:00

httpmw

feat: add MCP HTTP server experiment and improve experiment middleware (#18712)

2025-07-03 20:09:18 +02:00

idpsync

chore: remove unnecessary redeclarations in for loops (part 2) (#18593)

2025-06-26 12:28:00 -06:00

jobreaper

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

jwtutils

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

mcp

feat: implement MCP HTTP server endpoint with authentication (#18670)

2025-07-03 19:27:41 +02:00

metricscache

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

notifications

chore: update gofumpt from v0.4.0 to v0.8.0 (#18652)

2025-07-03 11:28:00 -06:00

oauth2provider

refactor: move OAuth2 provider code to dedicated package (#18746)

2025-07-03 20:24:45 +02:00

oauthpki

fix: stop extending API key access if OIDC refresh is available (#17878)

2025-05-19 12:05:35 +04:00

portsharing

fix: properly convert max port share level for oss (#13261)

2024-05-13 14:37:51 -04:00

prebuilds

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

prometheusmetrics

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

promoauth

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

provisionerdserver

feat: persist AI task state in template imports & workspace builds (#18449)

2025-06-24 10:36:37 +00:00

provisionerkey

chore: shorten provisioner key (#14017)

2024-07-25 16:08:12 -05:00

proxyhealth

feat: add csp headers for embedded apps (#18374)

2025-06-17 09:00:32 -08:00

pubsub

feat(coderd): add inbox notifications endpoints (#16889)

2025-03-18 00:02:47 +01:00

rbac

chore: improve rbac and add benchmark tooling (#18584)

2025-06-27 12:05:34 +01:00

render

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

runtimeconfig

feat: add endpoint for partial updates to org sync mapping (#16316)

2025-01-30 10:52:50 -07:00

schedule

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

searchquery

chore(coderd/database): optimize AuditLogs queries (#18600)

2025-07-01 07:31:14 +02:00

telemetry

feat: graduate prebuilds to general availability (#18607)

2025-06-26 15:54:52 +02:00

testdata

feat: implement dynamic parameter validation (#18482)

2025-06-23 12:35:15 -05:00

tracing

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

updatecheck

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

userpassword

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

util

feat: implement dynamic parameter validation (#18482)

2025-06-23 12:35:15 -05:00

webpush

chore: remove unnecessary redeclarations in for loops (part 2) (#18593)

2025-06-26 12:28:00 -06:00

workspaceapps

fix!: stop workspace before update (#18425)

2025-06-23 09:12:37 +01:00

workspacestats

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

wsbuilder

chore: create interface for pkgs to return codersdk errors (#18719)

2025-07-03 08:33:45 -05:00

wspubsub

feat: add app status tracking to the backend (#17163)

2025-03-31 10:55:44 -04:00

activitybump_test.go

chore: add standard test logger ignoring db canceled (#15556)

2024-11-18 14:09:22 +04:00

aitasks_test.go

feat: add the /aitasks/prompts endpoint (#18464)

2025-06-24 13:06:02 +02:00

aitasks.go

feat: add the /aitasks/prompts endpoint (#18464)

2025-06-24 13:06:02 +02:00

apikey_test.go

feat: add separate max token lifetime for administrators (#18267)

2025-06-06 17:36:30 +02:00

apikey.go

feat: add separate max token lifetime for administrators (#18267)

2025-06-06 17:36:30 +02:00

apiroot.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

audit_internal_test.go

chore: add sql filter to fetching audit logs (#14070)

2024-08-01 12:07:19 -05:00

audit_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

audit.go

chore(coderd/database): optimize AuditLogs queries (#18600)

2025-07-01 07:31:14 +02:00

authorize_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

authorize.go

chore: ensure proper rbac permissions on 'Acquire' file in the cache (#18348)

2025-06-16 13:40:45 +00:00

client_test.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

coderd_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

coderd_test.go

chore(testutil): add testutil.GoleakOptions (#16070)

2025-01-08 15:38:37 +00:00

coderd.go

refactor: move OAuth2 provider code to dedicated package (#18746)

2025-07-03 20:24:45 +02:00

csp.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

debug_test.go

chore(cli): increase healthcheck timeout in TestSupportbundle (#17291)

2025-04-09 09:21:17 +01:00

debug.go

chore(cli): increase healthcheck timeout in TestSupportbundle (#17291)

2025-04-09 09:21:17 +01:00

deployment_test.go

fix(coderd): mark provisioner daemon psk as secret (#12322)

2024-02-27 16:33:32 +00:00

deployment.go

chore: remove chats experiment (#18535)

2025-06-25 13:03:32 +00:00

deprecated.go

chore!: remove deprecated agent v1 routes (#13486)

2024-06-11 12:22:59 +10:00

experiments_test.go

chore: revert dynamic params as a safe experiment (#17510)

2025-04-22 16:21:15 +00:00

experiments.go

fix: do not warn on valid known experiments (#18514)

2025-06-24 09:14:41 +01:00

externalauth_test.go

feat: add API key scope to restrict access to user data (#17692)

2025-05-15 15:32:52 +01:00

externalauth.go

fix: limit OAuth redirects to local paths (#14585)

2024-09-10 15:58:50 +01:00

files_test.go

fix: support windows specific zip mime type for template uploads (#15442)

2024-11-08 18:24:12 +11:00

files.go

fix: support windows specific zip mime type for template uploads (#15442)

2024-11-08 18:24:12 +11:00

gitsshkey_test.go

feat: add API key scope to restrict access to user data (#17692)

2025-05-15 15:32:52 +01:00

gitsshkey.go

feat: add API key scope to restrict access to user data (#17692)

2025-05-15 15:32:52 +01:00

inboxnotifications_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

inboxnotifications_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

inboxnotifications.go

fix(coderd): fix panics by always checking for non-nil request logger (#18228)

2025-06-12 13:50:50 +03:00

insights_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

insights_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

insights.go

chore: update golang to 1.24.1 (#17035)

2025-03-26 01:56:39 -05:00

latencycheck.go

chore: add prometheus timing to latency endpoint (#7742)

2023-06-06 10:26:13 -05:00

mcp_http.go

feat: implement MCP HTTP server endpoint with authentication (#18670)

2025-07-03 19:27:41 +02:00

members_test.go

chore: update error message for duplicate organization members (#17594)

2025-04-28 14:51:33 -06:00

members.go

chore: update error message for duplicate organization members (#17594)

2025-04-28 14:51:33 -06:00

notifications_test.go

feat(coderd): add new dispatch logic for coder inbox (#16764)

2025-03-05 22:43:18 +01:00

notifications.go

feat(coderd): add new dispatch logic for coder inbox (#16764)

2025-03-05 22:43:18 +01:00

oauth2_error_compliance_test.go

feat: implement OAuth2 dynamic client registration (RFC 7591/7592) (#18645)

2025-07-03 18:33:47 +02:00

oauth2_metadata_test.go

feat: implement RFC 6750 Bearer token authentication (#18644)

2025-07-02 19:14:54 +02:00

oauth2_metadata_validation_test.go

feat: implement OAuth2 dynamic client registration (RFC 7591/7592) (#18645)

2025-07-03 18:33:47 +02:00

oauth2_security_test.go

feat: implement OAuth2 dynamic client registration (RFC 7591/7592) (#18645)

2025-07-03 18:33:47 +02:00

oauth2_test.go

refactor: move OAuth2 provider code to dedicated package (#18746)

2025-07-03 20:24:45 +02:00

oauth2.go

refactor: move OAuth2 provider code to dedicated package (#18746)

2025-07-03 20:24:45 +02:00

organizations_test.go

chore: protect organization endpoints with license (#14001)

2024-07-25 16:07:53 -05:00

organizations.go

chore: implement filters for the organizations query (#14468)

2024-08-28 13:24:28 -05:00

pagination_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

pagination.go

chore: implement sane default pagination limit for audit logs (#13676)

2024-06-28 07:38:04 -05:00

parameters_test.go

chore: remove per request dynamic parameters opt in and rely on template (#18505)

2025-06-23 15:04:09 -05:00

parameters.go

chore: refactor dynamic parameters into dedicated package (#18420)

2025-06-20 13:00:39 -05:00

presets_test.go

feat: allow for default presets (#18445)

2025-06-24 12:19:19 +02:00

presets.go

feat: allow for default presets (#18445)

2025-06-24 12:19:19 +02:00

provisionerdaemons_test.go

fix: return provisioners in desc order and add limit to cli (#16720)

2025-02-26 21:06:51 +02:00

provisionerdaemons.go

feat(coderd/httpapi): add QueryParamParser.JSONStringMap (#16578)

2025-02-18 14:14:30 +00:00

provisionerjobs_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

provisionerjobs_test.go

feat: add provisioner daemon name to provisioner jobs responses (#17877)

2025-05-19 16:05:39 +01:00

provisionerjobs.go

fix(coderd): fix panics by always checking for non-nil request logger (#18228)

2025-06-12 13:50:50 +03:00

roles_test.go

chore: protect organization endpoints with license (#14001)

2024-07-25 16:07:53 -05:00

roles.go

chore: ensure proper rbac permissions on 'Acquire' file in the cache (#18348)

2025-06-16 13:40:45 +00:00

tailnet_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

tailnet.go

fix: reduce excessive logging when database is unreachable (#17363)

2025-04-15 10:55:30 +02:00

templates_test.go

feat: support dynamic parameters on create template request (#18636)

2025-07-02 09:44:01 -05:00

templates.go

feat: support dynamic parameters on create template request (#18636)

2025-07-02 09:44:01 -05:00

templateversions_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

templateversions.go

feat: persist AI task state in template imports & workspace builds (#18449)

2025-06-24 10:36:37 +00:00

updatecheck_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

updatecheck.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

userauth_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

userauth.go

chore: add custom samesite options to auth cookies (#16885)

2025-04-08 14:15:14 -05:00

users_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

users.go

chore: ensure proper rbac permissions on 'Acquire' file in the cache (#18348)

2025-06-16 13:40:45 +00:00

webpush_test.go

feat(coderd): add webpush package (#17091)

2025-03-27 10:03:53 +00:00

webpush.go

feat(coderd): add webpush package (#17091)

2025-03-27 10:03:53 +00:00

workspaceagentportshare_test.go

chore: join owner, template, and org in new workspace view (#15116)

2024-10-22 09:20:54 -05:00

workspaceagentportshare.go

docs: fix swagger documentation for DELETE port share endpoint (#18426)

2025-06-18 14:07:53 +00:00

workspaceagents_test.go

fix!: use devcontainer ID when rebuilding a devcontainer (#18604)

2025-06-26 11:41:57 +01:00

workspaceagents.go

fix!: use devcontainer ID when rebuilding a devcontainer (#18604)

2025-06-26 11:41:57 +01:00

workspaceagentsrpc_internal_test.go

chore: update testutil chan helpers (#17408)

2025-04-16 10:37:09 -06:00

workspaceagentsrpc_test.go

fix: remove unnecessary user lookup in agent API calls (#17934)

2025-05-20 17:07:50 +02:00

workspaceagentsrpc.go

feat(coderd/agentapi): implement sub agent api (#17823)

2025-05-29 12:15:47 +01:00

workspaceapps_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

workspaceapps.go

feat: enable key rotation (#15066)

2024-10-25 17:14:35 +01:00

workspacebuilds_test.go

fix: complete job and mark workspace as deleted when no provisioners are available (#18465)

2025-06-23 14:07:42 +01:00

workspacebuilds.go

chore: reorder prebuilt workspace authorization logic (#18506)

2025-06-24 16:33:21 +01:00

workspaceproxies_test.go

fix: allow ports in wildcard url configuration (#11657)

2024-01-18 09:44:05 -06:00

workspaceproxies.go

fix: allow ports in wildcard url configuration (#11657)

2024-01-18 09:44:05 -06:00

workspaceresourceauth_test.go

fix!: enforce regex for agent names (#16641)

2025-02-20 05:09:26 +00:00

workspaceresourceauth.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

workspaces_test.go

feat: persist AI task state in template imports & workspace builds (#18449)

2025-06-24 10:36:37 +00:00

workspaces.go

chore: improve dynamic parameter validation errors (#18501)

2025-06-23 15:08:18 -05:00

workspaceupdates_test.go

chore: update testutil chan helpers (#17408)

2025-04-16 10:37:09 -06:00

workspaceupdates.go

chore: update golang to 1.24.1 (#17035)

2025-03-26 01:56:39 -05:00