Files
coder/expect/expect.go
Bryan c9c03123eb fix: Run expect tests on Windows with conpty pseudo-terminal (#276)
This brings together a bunch of random, partially implemented packages for support of the new(ish) Windows [`conpty`](https://devblogs.microsoft.com/commandline/windows-command-line-introducing-the-windows-pseudo-console-conpty/) API - such that we can leverage the `expect` style of CLI tests, but in a way that works in Linux/OSX `pty`s and Windows `conpty`.

These include:
- Vendoring the `go-expect` library from Netflix w/ some tweaks to work cross-platform
- Vendoring the `pty` cross-platform implementation from [waypoint-plugin-sdk](b55c787a65/internal/pkg/pty)
- Vendoring the `conpty` Windows-specific implementation from [waypoint-plugin-sdk](b55c787a65/internal/pkg/conpty)
- Adjusting the `pty` interface to work with `go-expect` + the cross-plat version

There were several limitations with the current packages:
- `go-expect` requires the same `os.File` (TTY) for input / output, but `conhost` requires separate file handles
- `conpty` does not handle input, only output
- The cross-platform `pty` didn't expose the full set of primitives needed for `console`

Therefore, the following changes were made:
- Handling of `stdin` was added to the `conpty` interface
- We weren't using the full extent of the `go-expect` interface, so some portions were removed (ie, exec'ing a process) to simplify our implementation and make it easier to extend cross-platform
- Instead of `console` exposing just a `Tty`, it exposes an `InTty` and `OutTty`, to help encapsulate the difference on Windows (on Linux, these point to the same pipe)

Future improvements:
- The `isatty` implementation doesn't support accurate detection of `conhost` pty's without an associated process. In lieu of a more robust check, I've added a `--force-tty` flag intended for test case use - that forces the CLI to run in tty mode.
- It seems the windows implementation doesn't support setting a deadline. This is needed for the expect.Timeout API, but isn't used by us yet.

Fixes #241
2022-02-14 17:05:40 -08:00

110 lines
2.8 KiB
Go

// Copyright 2018 Netflix, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package expect
import (
"bufio"
"bytes"
"fmt"
"io"
"unicode/utf8"
)
// Expectf reads from the Console's tty until the provided formatted string
// is read or an error occurs, and returns the buffer read by Console.
func (c *Console) Expectf(format string, args ...interface{}) (string, error) {
return c.Expect(String(fmt.Sprintf(format, args...)))
}
// ExpectString reads from Console's tty until the provided string is read or
// an error occurs, and returns the buffer read by Console.
func (c *Console) ExpectString(s string) (string, error) {
return c.Expect(String(s))
}
// Expect reads from Console's tty until a condition specified from opts is
// encountered or an error occurs, and returns the buffer read by console.
// No extra bytes are read once a condition is met, so if a program isn't
// expecting input yet, it will be blocked. Sends are queued up in tty's
// internal buffer so that the next Expect will read the remaining bytes (i.e.
// rest of prompt) as well as its conditions.
func (c *Console) Expect(opts ...Opt) (string, error) {
var options Opts
for _, opt := range opts {
if err := opt(&options); err != nil {
return "", err
}
}
buf := new(bytes.Buffer)
writer := io.MultiWriter(append(c.opts.Stdouts, buf)...)
runeWriter := bufio.NewWriterSize(writer, utf8.UTFMax)
var matcher Matcher
var err error
defer func() {
for _, observer := range c.opts.ExpectObservers {
if matcher != nil {
observer([]Matcher{matcher}, buf.String(), err)
return
}
observer(options.Matchers, buf.String(), err)
}
}()
for {
var r rune
r, _, err = c.runeReader.ReadRune()
if err != nil {
matcher = options.Match(err)
if matcher != nil {
err = nil
break
}
return buf.String(), err
}
c.Logf("expect read: %q", string(r))
_, err = runeWriter.WriteRune(r)
if err != nil {
return buf.String(), err
}
// Immediately flush rune to the underlying writers.
err = runeWriter.Flush()
if err != nil {
return buf.String(), err
}
matcher = options.Match(buf)
if matcher != nil {
break
}
}
if matcher != nil {
cb, ok := matcher.(CallbackMatcher)
if ok {
err = cb.Callback(buf)
if err != nil {
return buf.String(), err
}
}
}
return buf.String(), err
}