mirror of
https://github.com/coder/coder.git
synced 2025-07-09 11:45:56 +00:00
dd97fe2bce
This change will improve over CLI performance and "snappiness" as well as substantially reduce our test times. Preliminary benchmarks show `coder server --help` times cut from 300ms to 120ms on my dogfood instance. The inefficiency of lipgloss disproportionately impacts our system, as all help text for every command is generated whenever any command is invoked. The `pretty` API could clean up a lot of the code (e.g., by replacing complex string concatenations with Printf), but this commit is too expansive as is so that work will be done in a follow up.
118 lines
3.0 KiB
Go
118 lines
3.0 KiB
Go
package cli_test
|
|
|
|
import (
|
|
"fmt"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/coder/pretty"
|
|
|
|
"github.com/coder/coder/v2/cli/clitest"
|
|
"github.com/coder/coder/v2/cli/cliui"
|
|
"github.com/coder/coder/v2/coderd/coderdtest"
|
|
"github.com/coder/coder/v2/codersdk"
|
|
"github.com/coder/coder/v2/enterprise/coderd/coderdenttest"
|
|
"github.com/coder/coder/v2/enterprise/coderd/license"
|
|
"github.com/coder/coder/v2/pty/ptytest"
|
|
"github.com/coder/coder/v2/testutil"
|
|
)
|
|
|
|
func TestGroupEdit(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
t.Run("OK", func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
client, admin := coderdenttest.New(t, &coderdenttest.Options{LicenseOptions: &coderdenttest.LicenseOptions{
|
|
Features: license.Features{
|
|
codersdk.FeatureTemplateRBAC: 1,
|
|
},
|
|
}})
|
|
|
|
ctx := testutil.Context(t, testutil.WaitLong)
|
|
_, user1 := coderdtest.CreateAnotherUser(t, client, admin.OrganizationID)
|
|
_, user2 := coderdtest.CreateAnotherUser(t, client, admin.OrganizationID)
|
|
_, user3 := coderdtest.CreateAnotherUser(t, client, admin.OrganizationID)
|
|
|
|
group, err := client.CreateGroup(ctx, admin.OrganizationID, codersdk.CreateGroupRequest{
|
|
Name: "alpha",
|
|
})
|
|
require.NoError(t, err)
|
|
|
|
// We use the sdk here as opposed to the CLI since adding this user
|
|
// is considered setup. They will be removed in the proper CLI test.
|
|
group, err = client.PatchGroup(ctx, group.ID, codersdk.PatchGroupRequest{
|
|
AddUsers: []string{user3.ID.String()},
|
|
})
|
|
require.NoError(t, err)
|
|
|
|
expectedName := "beta"
|
|
|
|
inv, conf := newCLI(
|
|
t,
|
|
"groups", "edit", group.Name,
|
|
"--name", expectedName,
|
|
"--avatar-url", "https://example.com",
|
|
"-a", user1.ID.String(),
|
|
"-a", user2.Email,
|
|
"-r", user3.ID.String(),
|
|
)
|
|
|
|
pty := ptytest.New(t)
|
|
|
|
inv.Stdout = pty.Output()
|
|
clitest.SetupConfig(t, client, conf)
|
|
|
|
err = inv.Run()
|
|
require.NoError(t, err)
|
|
|
|
pty.ExpectMatch(fmt.Sprintf("Successfully patched group %s", pretty.Sprint(cliui.DefaultStyles.Keyword, expectedName)))
|
|
})
|
|
|
|
t.Run("InvalidUserInput", func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
client, admin := coderdenttest.New(t, &coderdenttest.Options{LicenseOptions: &coderdenttest.LicenseOptions{
|
|
Features: license.Features{
|
|
codersdk.FeatureTemplateRBAC: 1,
|
|
},
|
|
}})
|
|
|
|
ctx := testutil.Context(t, testutil.WaitLong)
|
|
|
|
group, err := client.CreateGroup(ctx, admin.OrganizationID, codersdk.CreateGroupRequest{
|
|
Name: "alpha",
|
|
})
|
|
require.NoError(t, err)
|
|
|
|
inv, conf := newCLI(
|
|
t,
|
|
"groups", "edit", group.Name,
|
|
"-a", "foo",
|
|
)
|
|
|
|
clitest.SetupConfig(t, client, conf)
|
|
|
|
err = inv.Run()
|
|
require.Error(t, err)
|
|
require.Contains(t, err.Error(), "must be a valid UUID or email address")
|
|
})
|
|
|
|
t.Run("NoArg", func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
client, _ := coderdenttest.New(t, &coderdenttest.Options{LicenseOptions: &coderdenttest.LicenseOptions{
|
|
Features: license.Features{
|
|
codersdk.FeatureTemplateRBAC: 1,
|
|
},
|
|
}})
|
|
|
|
inv, conf := newCLI(t, "groups", "edit")
|
|
clitest.SetupConfig(t, client, conf)
|
|
|
|
err := inv.Run()
|
|
require.Error(t, err)
|
|
})
|
|
}
|