synced/discourse
1
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-03-14 10:33:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

FIX: use virtualElementFromTextRange on emoji autocomplete more (#31783)

Browse Source 
There's no `textarea` with the rich editor, so being `undefined` it
fails with a `TypeError: Cannot read properties of undefined (reading
'id')`.

This has the same behavior with the textarea editor but works much
better (positioning closer to the caret) with the rich editor.
This commit is contained in:
Renato Atilio
2025-03-12 22:24:40 -03:00
committed by GitHub
parent 9b692ede96
commit 962bdf3697
1 changed files with 5 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
app/assets/javascripts/discourse/app/components/d-editor.js
View File

@ -293,7 +293,7 @@ export default class DEditor extends Component {
} }
}, },
transformComplete: (v, event) => { transformComplete: (v) => {
if (v.code) { if (v.code) {
this.emojiStore.trackEmojiForContext(v.code, "topic"); this.emojiStore.trackEmojiForContext(v.code, "topic");
return `${v.code}:`; return `${v.code}:`;
@ -312,18 +312,10 @@ export default class DEditor extends Component {
}, },
}; };
let virtualElement; this.menuInstance = this.menu.show(
if (event instanceof KeyboardEvent) { virtualElementFromTextRange(),
// when user selects more by pressing enter menuOptions
virtualElement = virtualElementFromTextRange(); );
} else {
// when user selects more by clicking on it
// using textarea as a fallback as it's hard to have a good position
// given the autocomplete menu will be gone by the time we are here
virtualElement = this.textManipulation.textarea;
}
this.menuInstance = this.menu.show(virtualElement, menuOptions);
return ""; return "";
} }
}, },