Compare commits

..

1 Commits

6 changed files with 268 additions and 212 deletions

View File

@ -265,8 +265,7 @@ export const useGetFolderCommitHistory = ({
], ],
queryFn: () => queryFn: () =>
fetchFolderCommitHistory(workspaceId, environment, directory, offset, limit, search, sort), fetchFolderCommitHistory(workspaceId, environment, directory, offset, limit, search, sort),
enabled: Boolean(workspaceId && environment), enabled: Boolean(workspaceId && environment)
placeholderData: (prev) => prev
}); });
}; };

View File

@ -1,10 +1,5 @@
import { useEffect, useState } from "react"; import { useEffect, useState } from "react";
import { import { faAngleDown } from "@fortawesome/free-solid-svg-icons";
faAngleDown,
faChevronLeft,
faCodeCommit,
faWarning
} from "@fortawesome/free-solid-svg-icons";
import { FontAwesomeIcon } from "@fortawesome/react-fontawesome"; import { FontAwesomeIcon } from "@fortawesome/react-fontawesome";
import { DropdownMenuItem } from "@radix-ui/react-dropdown-menu"; import { DropdownMenuItem } from "@radix-ui/react-dropdown-menu";
import { useSearch } from "@tanstack/react-router"; import { useSearch } from "@tanstack/react-router";
@ -12,14 +7,12 @@ import { useSearch } from "@tanstack/react-router";
import { createNotification } from "@app/components/notifications"; import { createNotification } from "@app/components/notifications";
import { ProjectPermissionCan } from "@app/components/permissions"; import { ProjectPermissionCan } from "@app/components/permissions";
import { import {
Button,
ContentLoader,
DeleteActionModal, DeleteActionModal,
DropdownMenu, DropdownMenu,
DropdownMenuContent, DropdownMenuContent,
DropdownMenuTrigger, DropdownMenuTrigger,
EmptyState, IconButton,
PageHeader Spinner
} from "@app/components/v2"; } from "@app/components/v2";
import { ROUTE_PATHS } from "@app/const/routes"; import { ROUTE_PATHS } from "@app/const/routes";
import { import {
@ -115,25 +108,25 @@ export const CommitDetailsTab = ({
// If no commit is selected or data is loading, show appropriate message // If no commit is selected or data is loading, show appropriate message
if (!selectedCommitId) { if (!selectedCommitId) {
return ( return (
<EmptyState className="mt-40" title="Select a commit to view details." icon={faCodeCommit}> <div className="flex h-64 items-center justify-center">
<Button className="mt-4" colorSchema="secondary" onClick={() => goBackToHistory()}> <p className="text-gray-400">Select a commit to view details</p>
Back to Commits </div>
</Button>
</EmptyState>
); );
} }
if (isLoading) { if (isLoading) {
return <ContentLoader />; return (
<div className="flex h-64 items-center justify-center">
<Spinner size="lg" />
</div>
);
} }
if (!commitDetails) { if (!commitDetails) {
return ( return (
<EmptyState className="mt-40" title="No details found for this commit." icon={faCodeCommit}> <div className="flex h-64 items-center justify-center">
<Button className="mt-4" colorSchema="secondary" onClick={() => goBackToHistory()}> <p className="text-gray-400">No details found for this commit</p>
Back to Commits </div>
</Button>
</EmptyState>
); );
} }
@ -145,11 +138,9 @@ export const CommitDetailsTab = ({
} catch (error) { } catch (error) {
console.error("Failed to parse commit details:", error); console.error("Failed to parse commit details:", error);
return ( return (
<EmptyState className="mt-40" title="Error parsing commit details." icon={faWarning}> <div className="flex h-64 items-center justify-center">
<Button className="mt-4" colorSchema="secondary" onClick={() => goBackToHistory()}> <p className="text-gray-400">Error parsing commit details</p>
Back to Commits </div>
</Button>
</EmptyState>
); );
} }
@ -232,12 +223,13 @@ export const CommitDetailsTab = ({
// Render an item from the merged list // Render an item from the merged list
const renderMergedItem = (item: MergedItem): JSX.Element => { const renderMergedItem = (item: MergedItem): JSX.Element => {
return ( return (
<SecretVersionDiffView <div key={item.id} className="mb-2">
key={item.id} <SecretVersionDiffView
item={item} item={item}
isCollapsed={collapsedItems[item.id]} isCollapsed={collapsedItems[item.id]}
onToggleCollapse={(id) => toggleItemCollapsed(id)} onToggleCollapse={(id) => toggleItemCollapsed(id)}
/> />
</div>
); );
}; };
@ -248,104 +240,114 @@ export const CommitDetailsTab = ({
"Unknown"; "Unknown";
return ( return (
<> <div className="w-full">
<Button <div>
variant="link" <div className="flex justify-between pb-2">
type="submit" <div className="w-5/6">
leftIcon={<FontAwesomeIcon icon={faChevronLeft} />} <div>
onClick={() => { <div className="flex items-center">
goBackToHistory(); <h1 className="mr-4 truncate text-3xl font-semibold text-white">
}} {parsedCommitDetails.changes?.message || "No message"}
> </h1>
Commit History </div>
</Button> </div>
<PageHeader <div className="font-small mb-4 mt-2 flex items-center text-sm">
title={`${parsedCommitDetails.changes?.message}` || "No message"} <p>
description={ <span> Commited by </span>
<> <b>{actorDisplay}</b>
Commited by {actorDisplay} on{" "} <span> on </span>
{formatDisplayDate(parsedCommitDetails.changes?.createdAt || new Date().toISOString())} <b>
{parsedCommitDetails.changes?.isLatest && ( {formatDisplayDate(
<span className="ml-1 text-mineshaft-400">(Latest)</span> parsedCommitDetails.changes?.createdAt || new Date().toISOString()
)} )}
</> </b>
} {parsedCommitDetails.changes?.isLatest && (
> <span className="ml-1 italic text-gray-400">(Latest)</span>
<ProjectPermissionCan
I={ProjectPermissionCommitsActions.PerformRollback}
a={ProjectPermissionSub.Commits}
>
{(isAllowed) => (
<DropdownMenu>
<DropdownMenuTrigger
asChild
disabled={!isAllowed}
className={`${!isAllowed ? "cursor-not-allowed" : ""}`}
>
<Button
rightIcon={<FontAwesomeIcon className="ml-2" icon={faAngleDown} />}
variant="solid"
className="h-min"
colorSchema="secondary"
>
Restore Options
</Button>
</DropdownMenuTrigger>
<DropdownMenuContent align="end" sideOffset={2}>
{!parsedCommitDetails.changes.isLatest && (
<DropdownMenuItem
className="group cursor-pointer rounded-md px-3 py-3 transition-colors hover:bg-mineshaft-700"
onClick={() => goToRollbackPreview()}
>
<div className="flex items-center space-x-3">
<div className="flex flex-col">
<span className="text-sm font-medium text-white">
Roll back to this commit
</span>
<span className="whitespace-normal break-words text-xs leading-snug text-gray-400">
Return this folder to its exact state at the time of this commit,
discarding all other changes made after it
</span>
</div>
</div>
</DropdownMenuItem>
)} )}
<DropdownMenuItem </p>
className="group cursor-pointer rounded-md px-3 py-3 transition-colors hover:bg-mineshaft-700" </div>
onClick={() => handlePopUpOpen("revertChanges")} </div>
> <div className="flex items-center justify-start">
<div className="flex items-center space-x-3"> <ProjectPermissionCan
<div className="flex flex-col"> I={ProjectPermissionCommitsActions.PerformRollback}
<span className="text-sm font-medium text-white">Revert changes</span> a={ProjectPermissionSub.Commits}
<span className="whitespace-normal break-words text-xs leading-snug text-gray-400"> >
Will restore to the previous version of affected resources {(isAllowed) => (
</span> <DropdownMenu>
</div> <DropdownMenuTrigger
</div> asChild
</DropdownMenuItem> disabled={!isAllowed}
</DropdownMenuContent> className={`${!isAllowed ? "cursor-not-allowed" : ""}`}
</DropdownMenu> >
)} <IconButton
</ProjectPermissionCan> ariaLabel="commit-options"
</PageHeader> variant="outline_bg"
<div className="flex w-full flex-col rounded-lg border border-mineshaft-600 bg-mineshaft-900 pt-4"> className="h-10 rounded border border-mineshaft-600 bg-mineshaft-800 px-4 py-2 text-sm font-medium"
<div className="mx-4 flex items-center justify-between border-b border-mineshaft-400 pb-4"> >
<h3 className="text-lg font-semibold text-mineshaft-100">Commit Changes</h3> <p className="mr-2">Restore Options</p>
<FontAwesomeIcon icon={faAngleDown} />
</IconButton>
</DropdownMenuTrigger>
<DropdownMenuContent
align="end"
sideOffset={2}
className="animate-in fade-in-50 zoom-in-95 min-w-[240px] rounded-md bg-mineshaft-800 p-1 shadow-lg"
style={{ marginTop: "0" }}
>
{!parsedCommitDetails.changes.isLatest && (
<DropdownMenuItem
className="group cursor-pointer rounded-md px-3 py-3 transition-colors hover:bg-mineshaft-700"
onClick={() => goToRollbackPreview()}
>
<div className="flex items-center space-x-3">
<div className="flex flex-col">
<span className="text-sm font-medium text-white">
Roll back to this commit
</span>
<span className="max-w-[180px] whitespace-normal break-words text-xs leading-snug text-gray-400">
Return this folder to its exact state at the time of this commit,
discarding all other changes made after it
</span>
</div>
</div>
</DropdownMenuItem>
)}
<DropdownMenuItem
className="group cursor-pointer rounded-md px-3 py-3 transition-colors hover:bg-mineshaft-700"
onClick={() => handlePopUpOpen("revertChanges")}
>
<div className="flex items-center space-x-3">
<div className="flex flex-col">
<span className="text-sm font-medium text-white">Revert changes</span>
<span className="max-w-[180px] whitespace-normal break-words text-xs leading-snug text-gray-400">
Will restore to the previous version of affected resources
</span>
</div>
</div>
</DropdownMenuItem>
</DropdownMenuContent>
</DropdownMenu>
)}
</ProjectPermissionCan>
</div>
</div> </div>
<div className="flex flex-col overflow-hidden pl-4 pr-1">
<div className="thin-scrollbar overflow-y-scroll py-4"> <div className="py-2">
{sortedChangedItems.length > 0 ? ( <div className="overflow-hidden">
sortedChangedItems.map((item) => renderMergedItem(item)) <div className="space-y-2">
) : ( {sortedChangedItems.length > 0 ? (
<EmptyState sortedChangedItems.map((item) => renderMergedItem(item))
title="No changes found." ) : (
className="h-full pb-0 pt-28" <div className="flex h-32 items-center justify-center rounded-lg border border-mineshaft-600 bg-mineshaft-800">
icon={faCodeCommit} <p className="text-gray-400">No changed items found</p>
/> </div>
)} )}
</div>
</div> </div>
</div> </div>
</div> </div>
<DeleteActionModal <DeleteActionModal
isOpen={popUp.revertChanges.isOpen} isOpen={popUp.revertChanges.isOpen}
deleteKey="revert" deleteKey="revert"
@ -355,6 +357,6 @@ export const CommitDetailsTab = ({
onDeleteApproved={handleRevertChanges} onDeleteApproved={handleRevertChanges}
buttonText="Yes, revert changes" buttonText="Yes, revert changes"
/> />
</> </div>
); );
}; };

View File

@ -225,12 +225,15 @@ const renderJsonWithDiffs = (
const getLineClass = (different: boolean) => { const getLineClass = (different: boolean) => {
if (!different) return "flex"; if (!different) return "flex";
return isOldVersion return isOldVersion ? "flex bg-red-950 text-red-300" : "flex bg-green-950 text-green-300";
? "flex bg-red-500/50 rounded-sm text-red-300"
: "flex bg-green-500/50 rounded-sm text-green-300";
}; };
const prefix = isDifferent ? (isOldVersion ? " -" : " +") : " "; const getHighlightClass = (different: boolean) => {
if (!different) return "";
return isOldVersion ? "bg-red-900 rounded px-1" : "bg-green-900 rounded px-1";
};
const prefix = isDifferent ? (isOldVersion ? "-" : "+") : " ";
const keyDisplay = keyName ? `"${keyName}": ` : ""; const keyDisplay = keyName ? `"${keyName}": ` : "";
const comma = !isLastItem ? "," : ""; const comma = !isLastItem ? "," : "";
@ -252,8 +255,8 @@ const renderJsonWithDiffs = (
<div className="w-4 flex-shrink-0">{prefix}</div> <div className="w-4 flex-shrink-0">{prefix}</div>
<div> <div>
{indent} {indent}
{keyName && <span>{keyDisplay}</span>} {keyName && <span className={getHighlightClass(isDifferent)}>{keyDisplay}</span>}
<span>{valueDisplay}</span> <span className={getHighlightClass(isDifferent)}>{valueDisplay}</span>
{comma} {comma}
</div> </div>
</div> </div>
@ -266,8 +269,8 @@ const renderJsonWithDiffs = (
<div className="w-4 flex-shrink-0">{prefix}</div> <div className="w-4 flex-shrink-0">{prefix}</div>
<div> <div>
{indent} {indent}
{keyName && <span>{keyDisplay}</span>} {keyName && <span className={getHighlightClass(isDifferent)}>{keyDisplay}</span>}
<span>[]</span> <span className={getHighlightClass(isDifferent)}>[]</span>
{comma} {comma}
</div> </div>
</div> </div>
@ -280,8 +283,8 @@ const renderJsonWithDiffs = (
<div className="w-4 flex-shrink-0">{prefix}</div> <div className="w-4 flex-shrink-0">{prefix}</div>
<div> <div>
{indent} {indent}
{keyName && <span>{keyDisplay}</span>} {keyName && <span className={getHighlightClass(isDifferent)}>{keyDisplay}</span>}
<span>{"{}"}</span> <span className={getHighlightClass(isDifferent)}>{"{}"}</span>
{comma} {comma}
</div> </div>
</div> </div>
@ -317,12 +320,16 @@ const renderJsonWithDiffs = (
<div key={reactKey}> <div key={reactKey}>
<div className={getLineClass(isContainerAddedOrRemoved)}> <div className={getLineClass(isContainerAddedOrRemoved)}>
<div className="w-4 flex-shrink-0"> <div className="w-4 flex-shrink-0">
{isContainerAddedOrRemoved ? (isOldVersion ? " -" : " +") : " "} {isContainerAddedOrRemoved ? (isOldVersion ? "-" : "+") : " "}
</div> </div>
<div> <div>
{indent} {indent}
{keyName && <span>{keyDisplay}</span>} {keyName && (
<span>[</span> <span className={isContainerAddedOrRemoved ? getHighlightClass(true) : ""}>
{keyDisplay}
</span>
)}
<span className={isContainerAddedOrRemoved ? getHighlightClass(true) : ""}>[</span>
</div> </div>
</div> </div>
@ -350,11 +357,11 @@ const renderJsonWithDiffs = (
<div className={getLineClass(isContainerAddedOrRemoved)}> <div className={getLineClass(isContainerAddedOrRemoved)}>
<div className="w-4 flex-shrink-0"> <div className="w-4 flex-shrink-0">
{isContainerAddedOrRemoved ? (isOldVersion ? " -" : " +") : " "} {isContainerAddedOrRemoved ? (isOldVersion ? "-" : "+") : " "}
</div> </div>
<div> <div>
{indent} {indent}
<span>]</span> <span className={isContainerAddedOrRemoved ? getHighlightClass(true) : ""}>]</span>
{comma} {comma}
</div> </div>
</div> </div>
@ -369,12 +376,16 @@ const renderJsonWithDiffs = (
<div key={reactKey}> <div key={reactKey}>
<div className={getLineClass(isContainerAddedOrRemoved)}> <div className={getLineClass(isContainerAddedOrRemoved)}>
<div className="w-4 flex-shrink-0"> <div className="w-4 flex-shrink-0">
{isContainerAddedOrRemoved ? (isOldVersion ? " -" : " +") : " "} {isContainerAddedOrRemoved ? (isOldVersion ? "-" : "+") : " "}
</div> </div>
<div> <div>
{indent} {indent}
{keyName && <span>{keyDisplay}</span>} {keyName && (
<span>{"{"}</span> <span className={isContainerAddedOrRemoved ? getHighlightClass(true) : ""}>
{keyDisplay}
</span>
)}
<span className={isContainerAddedOrRemoved ? getHighlightClass(true) : ""}>{"{"}</span>
</div> </div>
</div> </div>
@ -403,11 +414,11 @@ const renderJsonWithDiffs = (
<div className={getLineClass(isContainerAddedOrRemoved)}> <div className={getLineClass(isContainerAddedOrRemoved)}>
<div className="w-4 flex-shrink-0"> <div className="w-4 flex-shrink-0">
{isContainerAddedOrRemoved ? (isOldVersion ? " -" : " +") : " "} {isContainerAddedOrRemoved ? (isOldVersion ? "-" : "+") : " "}
</div> </div>
<div> <div>
{indent} {indent}
<span>{"}"}</span> <span className={isContainerAddedOrRemoved ? getHighlightClass(true) : ""}>{"}"}</span>
{comma} {comma}
</div> </div>
</div> </div>
@ -614,21 +625,22 @@ export const SecretVersionDiffView = ({
}; };
return ( return (
<div className="overflow-hidden border border-b-0 border-mineshaft-600 bg-mineshaft-800 first:rounded-t last:rounded-b last:border-b"> <div className="overflow-hidden rounded-lg border border-mineshaft-600 bg-mineshaft-800">
{showHeader && renderHeader()} {showHeader && renderHeader()}
{!collapsed && ( {!collapsed && (
<div className="border-t border-mineshaft-700 bg-mineshaft-900 p-3 text-mineshaft-100"> <div className="border-t border-mineshaft-700 bg-mineshaft-900 px-6 py-4">
<div className="flex gap-3"> <div className="grid grid-cols-2 gap-4">
<div <div
ref={oldContainerRef} ref={oldContainerRef}
className="thin-scrollbar max-h-96 flex-1 overflow-auto whitespace-pre" className="thin-scrollbar max-h-96 overflow-auto whitespace-pre rounded border border-mineshaft-600 bg-mineshaft-900 p-4"
> >
{oldVersionContent} {oldVersionContent}
</div> </div>
<div className="max-h-96 w-[0.05rem] self-stretch bg-mineshaft-600" />
<div <div
ref={newContainerRef} ref={newContainerRef}
className="thin-scrollbar max-h-96 flex-1 overflow-auto whitespace-pre" className="thin-scrollbar max-h-96 overflow-auto whitespace-pre rounded border border-mineshaft-600 bg-mineshaft-900 p-4"
> >
{newVersionContent} {newVersionContent}
</div> </div>

View File

@ -52,7 +52,7 @@ export const CommitsPage = () => {
title="Commits" title="Commits"
description="Track, inspect, and restore your secrets and folders with confidence. View the complete history of changes made to your environment, examine specific modifications at each commit point, and preview the exact impact before rolling back to previous states." description="Track, inspect, and restore your secrets and folders with confidence. View the complete history of changes made to your environment, examine specific modifications at each commit point, and preview the exact impact before rolling back to previous states."
/> />
<NoticeBannerV2 title="Secret Snapshots Update" className="mb-2"> <NoticeBannerV2 title="" className="mb-2">
<p className="my-1 text-sm text-mineshaft-300"> <p className="my-1 text-sm text-mineshaft-300">
Secret Snapshots have been officially renamed to Commits. Going forward, all secret Secret Snapshots have been officially renamed to Commits. Going forward, all secret
changes will be tracked as Commits. If you made changes before this update, you can changes will be tracked as Commits. If you made changes before this update, you can

View File

@ -2,14 +2,13 @@ import { useCallback, useEffect, useMemo, useRef, useState } from "react";
import { import {
faArrowDownWideShort, faArrowDownWideShort,
faArrowUpWideShort, faArrowUpWideShort,
faCodeCommit,
faCopy, faCopy,
faSearch faSearch
} from "@fortawesome/free-solid-svg-icons"; } from "@fortawesome/free-solid-svg-icons";
import { FontAwesomeIcon } from "@fortawesome/react-fontawesome"; import { FontAwesomeIcon } from "@fortawesome/react-fontawesome";
import { format, formatDistanceToNow } from "date-fns"; import { format, formatDistanceToNow } from "date-fns";
import { Button, ContentLoader, EmptyState, IconButton, Input } from "@app/components/v2"; import { Button, Input, Spinner } from "@app/components/v2";
import { CopyButton } from "@app/components/v2/CopyButton"; import { CopyButton } from "@app/components/v2/CopyButton";
import { useGetFolderCommitHistory } from "@app/hooks/api/folderCommits"; import { useGetFolderCommitHistory } from "@app/hooks/api/folderCommits";
@ -41,40 +40,58 @@ const CommitItem = ({
onSelectCommit: (commitId: string, tab: string) => void; onSelectCommit: (commitId: string, tab: string) => void;
}) => { }) => {
return ( return (
<button <div className="border-b border-zinc-800 last:border-b-0">
type="button" <div className="px-4 py-4 transition-colors duration-200 hover:bg-zinc-800">
onClick={(e) => { <div className="flex flex-col sm:flex-row sm:justify-between">
e.stopPropagation(); <div className="w-5/6 flex-1">
onSelectCommit(commit.id, "tab-commit-details"); <div className="flex items-center">
}} <Button
className="w-full border border-b-0 border-mineshaft-600 bg-mineshaft-800 first:rounded-t-md last:rounded-b-md last:border-b" variant="link"
> className="truncate text-left text-white hover:underline"
<div className="flex gap-2 px-4 py-3 transition-colors duration-200 hover:bg-zinc-800"> isFullWidth
<div className="flex flex-1 flex-col items-start"> onClick={(e) => {
<span className="w-min whitespace-nowrap text-sm text-mineshaft-100"> e.stopPropagation();
{commit.message} onSelectCommit(commit.id, "tab-commit-details");
</span> }}
<p className="text-left text-xs text-mineshaft-300"> >
{commit.actorMetadata?.email || commit.actorMetadata?.name || commit.actorType}{" "} {commit.message}
committed <time dateTime={commit.createdAt}>{formatTimeAgo(commit.createdAt)}</time> </Button>
</p> </div>
</div> <p className="text-white-400 mt-2 flex flex-wrap items-center gap-4 text-sm">
<span className="flex items-center text-mineshaft-300">
<div className="flex items-center space-x-2"> {commit.actorMetadata?.email || commit.actorMetadata?.name || commit.actorType}
<code className="mt-0.5 font-mono text-xs text-mineshaft-400"> <p className="ml-1 mr-1">committed</p>
{commit.id?.substring(0, 11)} <time dateTime={commit.createdAt}>{formatTimeAgo(commit.createdAt)}</time>
</code> </span>
<CopyButton </p>
value={commit.id} </div>
name={commit.id} <div className="mt-2 flex w-1/6 items-center justify-end sm:mt-0">
size="xs" <div className="flex items-center space-x-1">
variant="plain" <Button
color="text-mineshaft-400" variant="link"
icon={faCopy} className="text-white hover:underline"
/> onClick={(e) => {
e.stopPropagation();
onSelectCommit(commit.id, "tab-commit-details");
}}
>
<code className="text-white-400 px-3 py-1 font-mono text-sm">
{commit.id?.substring(0, 11)}
</code>
</Button>
<CopyButton
value={commit.id}
name={commit.id}
size="sm"
variant="plain"
color="text-mineshaft-400"
icon={faCopy}
/>
</div>
</div>
</div> </div>
</div> </div>
</button> </div>
); );
}; };
@ -91,16 +108,24 @@ const DateGroup = ({
onSelectCommit: (commitId: string, tab: string) => void; onSelectCommit: (commitId: string, tab: string) => void;
}) => { }) => {
return ( return (
<div className="mt-4 first:mt-0"> <div className="mb-8 last:mb-0 last:pb-2">
<div className="mb-4 ml-[0.15rem] flex items-center"> <div className="mb-4 flex items-center">
<FontAwesomeIcon icon={faCodeCommit} className="text-mineshaft-400" /> <div className="relative mr-3 flex h-6 w-6 items-center justify-center">
<h2 className="ml-4 text-sm text-mineshaft-400">Commits on {date}</h2> <div className="z-10 h-3 w-3 rounded-full border-2 border-mineshaft-600 bg-bunker-800" />
<div className="absolute left-0 right-0 top-1/2 h-0.5 -translate-y-1/2 bg-mineshaft-600" />
</div>
<h2 className="text-sm text-white">Commits on {date}</h2>
</div> </div>
<div className="relative"> <div className="relative">
<div className="absolute bottom-0 left-3 top-0 w-[0.1rem] bg-mineshaft-500" /> <div className="absolute bottom-0 left-3 top-0 w-0.5 bg-mineshaft-600" />
<div className="ml-10"> <div className="ml-10">
{commits.map((commit) => ( {commits.map((commit) => (
<CommitItem key={commit.id} commit={commit} onSelectCommit={onSelectCommit} /> <div key={commit.id} className="relative mb-3 pb-1">
<div className="overflow-hidden rounded-md border border-solid border-mineshaft-600">
<CommitItem commit={commit} onSelectCommit={onSelectCommit} />
</div>
</div>
))} ))}
</div> </div>
</div> </div>
@ -125,7 +150,7 @@ export const CommitHistoryTab = ({
const [offset, setOffset] = useState(0); const [offset, setOffset] = useState(0);
const [allCommits, setAllCommits] = useState<Commit[]>([]); const [allCommits, setAllCommits] = useState<Commit[]>([]);
const debounceTimeoutRef = useRef<NodeJS.Timeout>(); const debounceTimeoutRef = useRef<NodeJS.Timeout>();
const limit = 10; const limit = 5;
// Debounce search term // Debounce search term
useEffect(() => { useEffect(() => {
@ -209,37 +234,42 @@ export const CommitHistoryTab = ({
}, [hasMore, isFetching, limit]); }, [hasMore, isFetching, limit]);
return ( return (
<div className="mt-4 w-full rounded-lg border border-mineshaft-600 bg-mineshaft-900 p-4"> <div className="w-full">
<p className="mb-4 text-xl font-semibold text-mineshaft-100">Commit History</p>
<div className="mb-4 flex flex-col sm:flex-row sm:justify-end"> <div className="mb-4 flex flex-col sm:flex-row sm:justify-end">
<div className="flex w-full flex-wrap items-center gap-2"> <div className="flex w-full flex-wrap items-center gap-2">
<div className="relative flex-grow"> <div className="relative flex-grow">
<Input <Input
leftIcon={<FontAwesomeIcon icon={faSearch} aria-hidden="true" />}
placeholder="Search commits..." placeholder="Search commits..."
className="h-10 w-full rounded-md border-transparent bg-zinc-800 pl-9 pr-3 text-sm text-white placeholder-gray-400 focus:border-gray-600 focus:ring-primary-500/20"
onChange={(e) => handleSearch(e.target.value)} onChange={(e) => handleSearch(e.target.value)}
value={searchTerm} value={searchTerm}
aria-label="Search commits" aria-label="Search commits"
/> />
<div className="absolute left-3 top-1/2 -translate-y-1/2 transform text-gray-400">
<FontAwesomeIcon icon={faSearch} aria-hidden="true" />
</div>
</div> </div>
<IconButton <Button
variant="outline_bg" variant="outline_bg"
size="sm" size="md"
className="flex h-[2.4rem] items-center justify-center gap-2 rounded-md" className="flex h-10 items-center justify-center gap-2 rounded-md bg-zinc-800 px-4 py-2 text-sm text-white transition-colors duration-200 hover:bg-zinc-700 focus:outline-none focus:ring-2 focus:ring-primary-500"
onClick={handleSort} onClick={handleSort}
ariaLabel={`Sort by date ${sortDirection === "desc" ? "ascending" : "descending"}`} aria-label={`Sort by date ${sortDirection === "desc" ? "ascending" : "descending"}`}
> >
<FontAwesomeIcon <FontAwesomeIcon
icon={sortDirection === "desc" ? faArrowDownWideShort : faArrowUpWideShort} icon={sortDirection === "desc" ? faArrowDownWideShort : faArrowUpWideShort}
aria-hidden="true" aria-hidden="true"
/> />
</IconButton> </Button>
</div> </div>
</div> </div>
{isLoading && offset === 0 ? ( {isLoading && offset === 0 ? (
<ContentLoader className="h-80" /> <div className="flex h-64 items-center justify-center">
<Spinner size="lg" aria-label="Loading commits" />
</div>
) : ( ) : (
<div> <div className="space-y-8">
{Object.keys(groupedCommits).length > 0 ? ( {Object.keys(groupedCommits).length > 0 ? (
<> <>
{Object.entries(groupedCommits).map(([date, dateCommits]) => ( {Object.entries(groupedCommits).map(([date, dateCommits]) => (
@ -252,21 +282,34 @@ export const CommitHistoryTab = ({
))} ))}
</> </>
) : ( ) : (
<EmptyState title="No commits found." icon={faCodeCommit} /> <div className="text-white-400 flex min-h-40 flex-col items-center justify-center rounded-lg bg-zinc-900 py-8 text-center">
<FontAwesomeIcon
icon={faSearch}
className="text-white-500 mb-3 text-3xl"
aria-hidden="true"
/>
<p>No matching commits found. Try a different search term.</p>
</div>
)} )}
{hasMore && ( {hasMore && (
<div className="flex justify-center pb-2"> <div className="flex justify-center pb-2">
<Button <Button
variant="outline_bg" variant="outline_bg"
size="sm" size="md"
className="ml-10 mt-4 w-full" className="rounded-md bg-zinc-900 px-6 py-2 text-sm font-medium text-white transition-colors duration-200 hover:bg-zinc-800 focus:outline-none focus:ring-2 focus:ring-primary-500"
onClick={loadMoreCommits} onClick={loadMoreCommits}
disabled={isFetching} disabled={isFetching}
isLoading={isFetching}
aria-label="Load more commits" aria-label="Load more commits"
> >
Load More Commits {isFetching ? (
<>
<Spinner size="sm" className="mr-2" />
Loading...
</>
) : (
"Load more commits"
)}
</Button> </Button>
</div> </div>
)} )}

View File

@ -174,7 +174,7 @@ export const SecretOverviewTableRow = ({
)} )}
{isSecretEmpty && ( {isSecretEmpty && (
<Tooltip content="Empty value"> <Tooltip content="Empty value">
<FontAwesomeIcon size="sm" icon={faCircle} /> <FontAwesomeIcon size="sm" icon={faCircle} className="text-yellow" />
</Tooltip> </Tooltip>
)} )}
</div> </div>