tempo/modules/frontend/combiner/trace_by_id_test.go

109 lines
3.0 KiB
Go
Raw Normal View History

Tempo: Refactor Trace By ID and Metrics Summary (#3522) * extend buildUpstreamRequest Signed-off-by: Joe Elliott <number101010@gmail.com> * metrics summary Signed-off-by: Joe Elliott <number101010@gmail.com> * trace by id first pass Signed-off-by: Joe Elliott <number101010@gmail.com> * fixed inf loop Signed-off-by: Joe Elliott <number101010@gmail.com> * works Signed-off-by: Joe Elliott <number101010@gmail.com> * removed trace id hedging in the frontend Signed-off-by: Joe Elliott <number101010@gmail.com> * todos, tests and cleanup Signed-off-by: Joe Elliott <number101010@gmail.com> * add 429 test Signed-off-by: Joe Elliott <number101010@gmail.com> * changelog Signed-off-by: Joe Elliott <number101010@gmail.com> * lint Signed-off-by: Joe Elliott <number101010@gmail.com> * restore api prefix Signed-off-by: Joe Elliott <number101010@gmail.com> * pass the right param Signed-off-by: Joe Elliott <number101010@gmail.com> * fix race in test Signed-off-by: Joe Elliott <number101010@gmail.com> * move deduper into combiner Signed-off-by: Joe Elliott <number101010@gmail.com> * Move content type marshalling into combiner Signed-off-by: Joe Elliott <number101010@gmail.com> * lint: check err in test Signed-off-by: Joe Elliott <number101010@gmail.com> * Update integration/e2e/limits_test.go Co-authored-by: Koenraad Verheyden <koenraad.verheyden@posteo.net> * Apply suggestions from code review Co-authored-by: Koenraad Verheyden <koenraad.verheyden@posteo.net> * rename func for clarity Signed-off-by: Joe Elliott <number101010@gmail.com> * review Signed-off-by: Joe Elliott <number101010@gmail.com> --------- Signed-off-by: Joe Elliott <number101010@gmail.com> Co-authored-by: Koenraad Verheyden <koenraad.verheyden@posteo.net>
2024-04-11 15:07:36 -04:00
package combiner
import (
"bytes"
"io"
"net/http"
"strings"
"testing"
"github.com/gogo/protobuf/proto"
"github.com/grafana/tempo/pkg/api"
"github.com/grafana/tempo/pkg/tempopb"
"github.com/grafana/tempo/pkg/util/test"
"github.com/stretchr/testify/require"
)
func TestTraceByIDShouldQuit(t *testing.T) {
// new combiner should not quit
c := NewTraceByID(0, api.HeaderAcceptJSON)
should := c.ShouldQuit()
require.False(t, should)
// 500 response should quit
c = NewTraceByID(0, api.HeaderAcceptJSON)
err := c.AddResponse(toHTTPResponse(t, &tempopb.SearchResponse{}, 500))
require.NoError(t, err)
should = c.ShouldQuit()
require.True(t, should)
// 429 response should quit
c = NewTraceByID(0, api.HeaderAcceptJSON)
err = c.AddResponse(toHTTPProtoResponse(t, &tempopb.SearchResponse{}, 429))
require.NoError(t, err)
should = c.ShouldQuit()
require.True(t, should)
// 404 response should not quit
c = NewTraceByID(0, api.HeaderAcceptJSON)
err = c.AddResponse(toHTTPProtoResponse(t, &tempopb.SearchResponse{}, 404))
require.NoError(t, err)
should = c.ShouldQuit()
require.False(t, should)
// unparseable body should not quit, but should return an error
c = NewTraceByID(0, api.HeaderAcceptJSON)
err = c.AddResponse(&testPipelineResponse{r: &http.Response{Body: io.NopCloser(strings.NewReader("foo")), StatusCode: 200}})
Tempo: Refactor Trace By ID and Metrics Summary (#3522) * extend buildUpstreamRequest Signed-off-by: Joe Elliott <number101010@gmail.com> * metrics summary Signed-off-by: Joe Elliott <number101010@gmail.com> * trace by id first pass Signed-off-by: Joe Elliott <number101010@gmail.com> * fixed inf loop Signed-off-by: Joe Elliott <number101010@gmail.com> * works Signed-off-by: Joe Elliott <number101010@gmail.com> * removed trace id hedging in the frontend Signed-off-by: Joe Elliott <number101010@gmail.com> * todos, tests and cleanup Signed-off-by: Joe Elliott <number101010@gmail.com> * add 429 test Signed-off-by: Joe Elliott <number101010@gmail.com> * changelog Signed-off-by: Joe Elliott <number101010@gmail.com> * lint Signed-off-by: Joe Elliott <number101010@gmail.com> * restore api prefix Signed-off-by: Joe Elliott <number101010@gmail.com> * pass the right param Signed-off-by: Joe Elliott <number101010@gmail.com> * fix race in test Signed-off-by: Joe Elliott <number101010@gmail.com> * move deduper into combiner Signed-off-by: Joe Elliott <number101010@gmail.com> * Move content type marshalling into combiner Signed-off-by: Joe Elliott <number101010@gmail.com> * lint: check err in test Signed-off-by: Joe Elliott <number101010@gmail.com> * Update integration/e2e/limits_test.go Co-authored-by: Koenraad Verheyden <koenraad.verheyden@posteo.net> * Apply suggestions from code review Co-authored-by: Koenraad Verheyden <koenraad.verheyden@posteo.net> * rename func for clarity Signed-off-by: Joe Elliott <number101010@gmail.com> * review Signed-off-by: Joe Elliott <number101010@gmail.com> --------- Signed-off-by: Joe Elliott <number101010@gmail.com> Co-authored-by: Koenraad Verheyden <koenraad.verheyden@posteo.net>
2024-04-11 15:07:36 -04:00
require.Error(t, err)
should = c.ShouldQuit()
require.False(t, should)
// trace too large, should quit and should not return an error
Tempo: Refactor Trace By ID and Metrics Summary (#3522) * extend buildUpstreamRequest Signed-off-by: Joe Elliott <number101010@gmail.com> * metrics summary Signed-off-by: Joe Elliott <number101010@gmail.com> * trace by id first pass Signed-off-by: Joe Elliott <number101010@gmail.com> * fixed inf loop Signed-off-by: Joe Elliott <number101010@gmail.com> * works Signed-off-by: Joe Elliott <number101010@gmail.com> * removed trace id hedging in the frontend Signed-off-by: Joe Elliott <number101010@gmail.com> * todos, tests and cleanup Signed-off-by: Joe Elliott <number101010@gmail.com> * add 429 test Signed-off-by: Joe Elliott <number101010@gmail.com> * changelog Signed-off-by: Joe Elliott <number101010@gmail.com> * lint Signed-off-by: Joe Elliott <number101010@gmail.com> * restore api prefix Signed-off-by: Joe Elliott <number101010@gmail.com> * pass the right param Signed-off-by: Joe Elliott <number101010@gmail.com> * fix race in test Signed-off-by: Joe Elliott <number101010@gmail.com> * move deduper into combiner Signed-off-by: Joe Elliott <number101010@gmail.com> * Move content type marshalling into combiner Signed-off-by: Joe Elliott <number101010@gmail.com> * lint: check err in test Signed-off-by: Joe Elliott <number101010@gmail.com> * Update integration/e2e/limits_test.go Co-authored-by: Koenraad Verheyden <koenraad.verheyden@posteo.net> * Apply suggestions from code review Co-authored-by: Koenraad Verheyden <koenraad.verheyden@posteo.net> * rename func for clarity Signed-off-by: Joe Elliott <number101010@gmail.com> * review Signed-off-by: Joe Elliott <number101010@gmail.com> --------- Signed-off-by: Joe Elliott <number101010@gmail.com> Co-authored-by: Koenraad Verheyden <koenraad.verheyden@posteo.net>
2024-04-11 15:07:36 -04:00
c = NewTraceByID(1, api.HeaderAcceptJSON)
err = c.AddResponse(toHTTPProtoResponse(t, &tempopb.TraceByIDResponse{
Trace: test.MakeTrace(1, nil),
Metrics: &tempopb.TraceByIDMetrics{},
}, 200))
require.NoError(t, err)
Tempo: Refactor Trace By ID and Metrics Summary (#3522) * extend buildUpstreamRequest Signed-off-by: Joe Elliott <number101010@gmail.com> * metrics summary Signed-off-by: Joe Elliott <number101010@gmail.com> * trace by id first pass Signed-off-by: Joe Elliott <number101010@gmail.com> * fixed inf loop Signed-off-by: Joe Elliott <number101010@gmail.com> * works Signed-off-by: Joe Elliott <number101010@gmail.com> * removed trace id hedging in the frontend Signed-off-by: Joe Elliott <number101010@gmail.com> * todos, tests and cleanup Signed-off-by: Joe Elliott <number101010@gmail.com> * add 429 test Signed-off-by: Joe Elliott <number101010@gmail.com> * changelog Signed-off-by: Joe Elliott <number101010@gmail.com> * lint Signed-off-by: Joe Elliott <number101010@gmail.com> * restore api prefix Signed-off-by: Joe Elliott <number101010@gmail.com> * pass the right param Signed-off-by: Joe Elliott <number101010@gmail.com> * fix race in test Signed-off-by: Joe Elliott <number101010@gmail.com> * move deduper into combiner Signed-off-by: Joe Elliott <number101010@gmail.com> * Move content type marshalling into combiner Signed-off-by: Joe Elliott <number101010@gmail.com> * lint: check err in test Signed-off-by: Joe Elliott <number101010@gmail.com> * Update integration/e2e/limits_test.go Co-authored-by: Koenraad Verheyden <koenraad.verheyden@posteo.net> * Apply suggestions from code review Co-authored-by: Koenraad Verheyden <koenraad.verheyden@posteo.net> * rename func for clarity Signed-off-by: Joe Elliott <number101010@gmail.com> * review Signed-off-by: Joe Elliott <number101010@gmail.com> --------- Signed-off-by: Joe Elliott <number101010@gmail.com> Co-authored-by: Koenraad Verheyden <koenraad.verheyden@posteo.net>
2024-04-11 15:07:36 -04:00
should = c.ShouldQuit()
require.True(t, should)
Tempo: Refactor Trace By ID and Metrics Summary (#3522) * extend buildUpstreamRequest Signed-off-by: Joe Elliott <number101010@gmail.com> * metrics summary Signed-off-by: Joe Elliott <number101010@gmail.com> * trace by id first pass Signed-off-by: Joe Elliott <number101010@gmail.com> * fixed inf loop Signed-off-by: Joe Elliott <number101010@gmail.com> * works Signed-off-by: Joe Elliott <number101010@gmail.com> * removed trace id hedging in the frontend Signed-off-by: Joe Elliott <number101010@gmail.com> * todos, tests and cleanup Signed-off-by: Joe Elliott <number101010@gmail.com> * add 429 test Signed-off-by: Joe Elliott <number101010@gmail.com> * changelog Signed-off-by: Joe Elliott <number101010@gmail.com> * lint Signed-off-by: Joe Elliott <number101010@gmail.com> * restore api prefix Signed-off-by: Joe Elliott <number101010@gmail.com> * pass the right param Signed-off-by: Joe Elliott <number101010@gmail.com> * fix race in test Signed-off-by: Joe Elliott <number101010@gmail.com> * move deduper into combiner Signed-off-by: Joe Elliott <number101010@gmail.com> * Move content type marshalling into combiner Signed-off-by: Joe Elliott <number101010@gmail.com> * lint: check err in test Signed-off-by: Joe Elliott <number101010@gmail.com> * Update integration/e2e/limits_test.go Co-authored-by: Koenraad Verheyden <koenraad.verheyden@posteo.net> * Apply suggestions from code review Co-authored-by: Koenraad Verheyden <koenraad.verheyden@posteo.net> * rename func for clarity Signed-off-by: Joe Elliott <number101010@gmail.com> * review Signed-off-by: Joe Elliott <number101010@gmail.com> --------- Signed-off-by: Joe Elliott <number101010@gmail.com> Co-authored-by: Koenraad Verheyden <koenraad.verheyden@posteo.net>
2024-04-11 15:07:36 -04:00
}
func TestTraceByIDHonorsContentType(t *testing.T) {
expected := test.MakeTrace(2, nil)
// json
c := NewTraceByID(0, api.HeaderAcceptJSON)
err := c.AddResponse(toHTTPProtoResponse(t, &tempopb.TraceByIDResponse{Trace: expected}, 200))
require.NoError(t, err)
resp, err := c.HTTPFinal()
require.NoError(t, err)
actual := &tempopb.Trace{}
bodyBytes, _ := io.ReadAll(resp.Body)
err = tempopb.UnmarshalFromJSONV1(bodyBytes, actual)
Tempo: Refactor Trace By ID and Metrics Summary (#3522) * extend buildUpstreamRequest Signed-off-by: Joe Elliott <number101010@gmail.com> * metrics summary Signed-off-by: Joe Elliott <number101010@gmail.com> * trace by id first pass Signed-off-by: Joe Elliott <number101010@gmail.com> * fixed inf loop Signed-off-by: Joe Elliott <number101010@gmail.com> * works Signed-off-by: Joe Elliott <number101010@gmail.com> * removed trace id hedging in the frontend Signed-off-by: Joe Elliott <number101010@gmail.com> * todos, tests and cleanup Signed-off-by: Joe Elliott <number101010@gmail.com> * add 429 test Signed-off-by: Joe Elliott <number101010@gmail.com> * changelog Signed-off-by: Joe Elliott <number101010@gmail.com> * lint Signed-off-by: Joe Elliott <number101010@gmail.com> * restore api prefix Signed-off-by: Joe Elliott <number101010@gmail.com> * pass the right param Signed-off-by: Joe Elliott <number101010@gmail.com> * fix race in test Signed-off-by: Joe Elliott <number101010@gmail.com> * move deduper into combiner Signed-off-by: Joe Elliott <number101010@gmail.com> * Move content type marshalling into combiner Signed-off-by: Joe Elliott <number101010@gmail.com> * lint: check err in test Signed-off-by: Joe Elliott <number101010@gmail.com> * Update integration/e2e/limits_test.go Co-authored-by: Koenraad Verheyden <koenraad.verheyden@posteo.net> * Apply suggestions from code review Co-authored-by: Koenraad Verheyden <koenraad.verheyden@posteo.net> * rename func for clarity Signed-off-by: Joe Elliott <number101010@gmail.com> * review Signed-off-by: Joe Elliott <number101010@gmail.com> --------- Signed-off-by: Joe Elliott <number101010@gmail.com> Co-authored-by: Koenraad Verheyden <koenraad.verheyden@posteo.net>
2024-04-11 15:07:36 -04:00
require.NoError(t, err)
require.Equal(t, expected, actual)
// proto
c = NewTraceByID(0, api.HeaderAcceptProtobuf)
err = c.AddResponse(toHTTPProtoResponse(t, &tempopb.TraceByIDResponse{Trace: expected}, 200))
require.NoError(t, err)
resp, err = c.HTTPFinal()
require.NoError(t, err)
actual = &tempopb.Trace{}
buff, err := io.ReadAll(resp.Body)
require.NoError(t, err)
err = proto.Unmarshal(buff, actual)
require.NoError(t, err)
require.Equal(t, expected, actual)
}
Query Frontend Refactor: Metrics Query Range (#3584) * things technically compile! Signed-off-by: Joe Elliott <number101010@gmail.com> * Succeed with no data Signed-off-by: Joe Elliott <number101010@gmail.com> * remove prom compat Signed-off-by: Joe Elliott <number101010@gmail.com> * Add tests for the metrics pipeline and fix Signed-off-by: Joe Elliott <number101010@gmail.com> * cleanup Signed-off-by: Joe Elliott <number101010@gmail.com> * restore sorting Signed-off-by: Joe Elliott <number101010@gmail.com> * removed unreferenced files Signed-off-by: Joe Elliott <number101010@gmail.com> * migrate to response interface Signed-off-by: Joe Elliott <number101010@gmail.com> * Sampling rate! Signed-off-by: Joe Elliott <number101010@gmail.com> * remove no-op Signed-off-by: Joe Elliott <number101010@gmail.com> * wip: add cli Signed-off-by: Joe Elliott <number101010@gmail.com> * QueryRange -> MetricsQueryRange Signed-off-by: Joe Elliott <number101010@gmail.com> * changelog and other cleanup Signed-off-by: Joe Elliott <number101010@gmail.com> * lint Signed-off-by: Joe Elliott <number101010@gmail.com> * lint + guardcode Signed-off-by: Joe Elliott <number101010@gmail.com> * change the way we're ignoring tests Signed-off-by: Joe Elliott <number101010@gmail.com> * clean up url parsing Signed-off-by: Joe Elliott <number101010@gmail.com> * fixed url parsing and add test Signed-off-by: Joe Elliott <number101010@gmail.com> * adjust sanity check Signed-off-by: Joe Elliott <number101010@gmail.com> --------- Signed-off-by: Joe Elliott <number101010@gmail.com>
2024-04-19 09:07:30 -04:00
func toHTTPProtoResponse(t *testing.T, pb proto.Message, statusCode int) PipelineResponse {
Tempo: Refactor Trace By ID and Metrics Summary (#3522) * extend buildUpstreamRequest Signed-off-by: Joe Elliott <number101010@gmail.com> * metrics summary Signed-off-by: Joe Elliott <number101010@gmail.com> * trace by id first pass Signed-off-by: Joe Elliott <number101010@gmail.com> * fixed inf loop Signed-off-by: Joe Elliott <number101010@gmail.com> * works Signed-off-by: Joe Elliott <number101010@gmail.com> * removed trace id hedging in the frontend Signed-off-by: Joe Elliott <number101010@gmail.com> * todos, tests and cleanup Signed-off-by: Joe Elliott <number101010@gmail.com> * add 429 test Signed-off-by: Joe Elliott <number101010@gmail.com> * changelog Signed-off-by: Joe Elliott <number101010@gmail.com> * lint Signed-off-by: Joe Elliott <number101010@gmail.com> * restore api prefix Signed-off-by: Joe Elliott <number101010@gmail.com> * pass the right param Signed-off-by: Joe Elliott <number101010@gmail.com> * fix race in test Signed-off-by: Joe Elliott <number101010@gmail.com> * move deduper into combiner Signed-off-by: Joe Elliott <number101010@gmail.com> * Move content type marshalling into combiner Signed-off-by: Joe Elliott <number101010@gmail.com> * lint: check err in test Signed-off-by: Joe Elliott <number101010@gmail.com> * Update integration/e2e/limits_test.go Co-authored-by: Koenraad Verheyden <koenraad.verheyden@posteo.net> * Apply suggestions from code review Co-authored-by: Koenraad Verheyden <koenraad.verheyden@posteo.net> * rename func for clarity Signed-off-by: Joe Elliott <number101010@gmail.com> * review Signed-off-by: Joe Elliott <number101010@gmail.com> --------- Signed-off-by: Joe Elliott <number101010@gmail.com> Co-authored-by: Koenraad Verheyden <koenraad.verheyden@posteo.net>
2024-04-11 15:07:36 -04:00
var body []byte
if pb != nil {
var err error
body, err = proto.Marshal(pb)
require.NoError(t, err)
}
return &testPipelineResponse{r: &http.Response{
Tempo: Refactor Trace By ID and Metrics Summary (#3522) * extend buildUpstreamRequest Signed-off-by: Joe Elliott <number101010@gmail.com> * metrics summary Signed-off-by: Joe Elliott <number101010@gmail.com> * trace by id first pass Signed-off-by: Joe Elliott <number101010@gmail.com> * fixed inf loop Signed-off-by: Joe Elliott <number101010@gmail.com> * works Signed-off-by: Joe Elliott <number101010@gmail.com> * removed trace id hedging in the frontend Signed-off-by: Joe Elliott <number101010@gmail.com> * todos, tests and cleanup Signed-off-by: Joe Elliott <number101010@gmail.com> * add 429 test Signed-off-by: Joe Elliott <number101010@gmail.com> * changelog Signed-off-by: Joe Elliott <number101010@gmail.com> * lint Signed-off-by: Joe Elliott <number101010@gmail.com> * restore api prefix Signed-off-by: Joe Elliott <number101010@gmail.com> * pass the right param Signed-off-by: Joe Elliott <number101010@gmail.com> * fix race in test Signed-off-by: Joe Elliott <number101010@gmail.com> * move deduper into combiner Signed-off-by: Joe Elliott <number101010@gmail.com> * Move content type marshalling into combiner Signed-off-by: Joe Elliott <number101010@gmail.com> * lint: check err in test Signed-off-by: Joe Elliott <number101010@gmail.com> * Update integration/e2e/limits_test.go Co-authored-by: Koenraad Verheyden <koenraad.verheyden@posteo.net> * Apply suggestions from code review Co-authored-by: Koenraad Verheyden <koenraad.verheyden@posteo.net> * rename func for clarity Signed-off-by: Joe Elliott <number101010@gmail.com> * review Signed-off-by: Joe Elliott <number101010@gmail.com> --------- Signed-off-by: Joe Elliott <number101010@gmail.com> Co-authored-by: Koenraad Verheyden <koenraad.verheyden@posteo.net>
2024-04-11 15:07:36 -04:00
Body: io.NopCloser(bytes.NewReader(body)),
StatusCode: statusCode,
Query Frontend Refactor: Metrics Query Range (#3584) * things technically compile! Signed-off-by: Joe Elliott <number101010@gmail.com> * Succeed with no data Signed-off-by: Joe Elliott <number101010@gmail.com> * remove prom compat Signed-off-by: Joe Elliott <number101010@gmail.com> * Add tests for the metrics pipeline and fix Signed-off-by: Joe Elliott <number101010@gmail.com> * cleanup Signed-off-by: Joe Elliott <number101010@gmail.com> * restore sorting Signed-off-by: Joe Elliott <number101010@gmail.com> * removed unreferenced files Signed-off-by: Joe Elliott <number101010@gmail.com> * migrate to response interface Signed-off-by: Joe Elliott <number101010@gmail.com> * Sampling rate! Signed-off-by: Joe Elliott <number101010@gmail.com> * remove no-op Signed-off-by: Joe Elliott <number101010@gmail.com> * wip: add cli Signed-off-by: Joe Elliott <number101010@gmail.com> * QueryRange -> MetricsQueryRange Signed-off-by: Joe Elliott <number101010@gmail.com> * changelog and other cleanup Signed-off-by: Joe Elliott <number101010@gmail.com> * lint Signed-off-by: Joe Elliott <number101010@gmail.com> * lint + guardcode Signed-off-by: Joe Elliott <number101010@gmail.com> * change the way we're ignoring tests Signed-off-by: Joe Elliott <number101010@gmail.com> * clean up url parsing Signed-off-by: Joe Elliott <number101010@gmail.com> * fixed url parsing and add test Signed-off-by: Joe Elliott <number101010@gmail.com> * adjust sanity check Signed-off-by: Joe Elliott <number101010@gmail.com> --------- Signed-off-by: Joe Elliott <number101010@gmail.com>
2024-04-19 09:07:30 -04:00
}}
Tempo: Refactor Trace By ID and Metrics Summary (#3522) * extend buildUpstreamRequest Signed-off-by: Joe Elliott <number101010@gmail.com> * metrics summary Signed-off-by: Joe Elliott <number101010@gmail.com> * trace by id first pass Signed-off-by: Joe Elliott <number101010@gmail.com> * fixed inf loop Signed-off-by: Joe Elliott <number101010@gmail.com> * works Signed-off-by: Joe Elliott <number101010@gmail.com> * removed trace id hedging in the frontend Signed-off-by: Joe Elliott <number101010@gmail.com> * todos, tests and cleanup Signed-off-by: Joe Elliott <number101010@gmail.com> * add 429 test Signed-off-by: Joe Elliott <number101010@gmail.com> * changelog Signed-off-by: Joe Elliott <number101010@gmail.com> * lint Signed-off-by: Joe Elliott <number101010@gmail.com> * restore api prefix Signed-off-by: Joe Elliott <number101010@gmail.com> * pass the right param Signed-off-by: Joe Elliott <number101010@gmail.com> * fix race in test Signed-off-by: Joe Elliott <number101010@gmail.com> * move deduper into combiner Signed-off-by: Joe Elliott <number101010@gmail.com> * Move content type marshalling into combiner Signed-off-by: Joe Elliott <number101010@gmail.com> * lint: check err in test Signed-off-by: Joe Elliott <number101010@gmail.com> * Update integration/e2e/limits_test.go Co-authored-by: Koenraad Verheyden <koenraad.verheyden@posteo.net> * Apply suggestions from code review Co-authored-by: Koenraad Verheyden <koenraad.verheyden@posteo.net> * rename func for clarity Signed-off-by: Joe Elliott <number101010@gmail.com> * review Signed-off-by: Joe Elliott <number101010@gmail.com> --------- Signed-off-by: Joe Elliott <number101010@gmail.com> Co-authored-by: Koenraad Verheyden <koenraad.verheyden@posteo.net>
2024-04-11 15:07:36 -04:00
}