From a8e43302876f49359ccdf3a93b7321db0c028280 Mon Sep 17 00:00:00 2001 From: Edgar K <68842306+edgarkz@users.noreply.github.com> Date: Tue, 11 Mar 2025 14:33:32 +0200 Subject: [PATCH] add dedicated column logging (#4832) * add dedicated column logging * add changelog * typo --- CHANGELOG.md | 1 + tempodb/encoding/vparquet2/compactor.go | 1 + tempodb/encoding/vparquet3/compactor.go | 1 + tempodb/encoding/vparquet4/compactor.go | 1 + 4 files changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4f879b1a1..18d2cdd03 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -44,6 +44,7 @@ configurable via the throughput_bytes_slo field, and it will populate op="traces * [ENHANCEMENT] rhythm: fair partition consumption in blockbuilders[#4655](https://github.com/grafana/tempo/pull/4655) (@javiermolinar) * [ENHANCEMENT] TraceQL: add support for querying by parent span id [#4692](https://github.com/grafana/tempo/pull/4692) (@ie-pham) * [ENHANCEMENT] metrics-generator: allow skipping localblocks and consuming from a different source of data [#4686](https://github.com/grafana/tempo/pull/4686) (@flxbk) +* [ENHANCEMENT] compactor: restore dedicated columns logging for completed blocks * [BUGFIX] Choose a default step for a gRPC streaming query range request if none is provided. [#4546](https://github.com/grafana/tempo/pull/4576) (@joe-elliott) Correctly copy exemplars for metrics like `| rate()` when gRPC streaming. * [BUGFIX] Fix performance bottleneck and file cleanup in block builder [#4550](https://github.com/grafana/tempo/pull/4550) (@mdisibio) diff --git a/tempodb/encoding/vparquet2/compactor.go b/tempodb/encoding/vparquet2/compactor.go index ccf1e2f87..e43f07121 100644 --- a/tempodb/encoding/vparquet2/compactor.go +++ b/tempodb/encoding/vparquet2/compactor.go @@ -265,6 +265,7 @@ func (c *Compactor) finishBlock(ctx context.Context, block *streamingBlock, l lo "bloomShardCount", block.meta.BloomShardCount, "footerSize", block.meta.FooterSize, "replicationFactor", block.meta.ReplicationFactor, + "dedicatedColumns", fmt.Sprintf("%+v", block.meta.DedicatedColumns), ) compactionLevel := int(block.meta.CompactionLevel) - 1 diff --git a/tempodb/encoding/vparquet3/compactor.go b/tempodb/encoding/vparquet3/compactor.go index 7d66cadcf..6143d344d 100644 --- a/tempodb/encoding/vparquet3/compactor.go +++ b/tempodb/encoding/vparquet3/compactor.go @@ -273,6 +273,7 @@ func (c *Compactor) finishBlock(ctx context.Context, block *streamingBlock, l lo "bloomShardCount", block.meta.BloomShardCount, "footerSize", block.meta.FooterSize, "replicationFactor", block.meta.ReplicationFactor, + "dedicatedColumns", fmt.Sprintf("%+v", block.meta.DedicatedColumns), ) compactionLevel := int(block.meta.CompactionLevel) - 1 diff --git a/tempodb/encoding/vparquet4/compactor.go b/tempodb/encoding/vparquet4/compactor.go index b47817c9b..22429b40c 100644 --- a/tempodb/encoding/vparquet4/compactor.go +++ b/tempodb/encoding/vparquet4/compactor.go @@ -277,6 +277,7 @@ func (c *Compactor) finishBlock(ctx context.Context, block *streamingBlock, l lo "bloomShardCount", block.meta.BloomShardCount, "footerSize", block.meta.FooterSize, "replicationFactor", block.meta.ReplicationFactor, + "dedicatedColumns", fmt.Sprintf("%+v", block.meta.DedicatedColumns), ) span.AddEvent("wrote compacted block")