Update changelog

* Add "cryptoCode" for invoice payment method API endpoint response

* Add "cryptoCode" for pull payment payout API endpoint response

* Add "#nullable enable" to GreenFieldInvoiceController

* Add "#nullable enable" to GreenfieldPullPaymentController

.circleci/config.yml

@@ -2,15 +2,15 @@ version: 2
 jobs:
   fast_tests:
     machine:
-      image: ubuntu-2004:202111-02
+        enabled: true
     steps:
       - checkout
       - run:
           command: |
-            cd .circleci && ./run-tests.sh "Fast=Fast|ThirdParty=ThirdParty" && ./can-build.sh
+            cd .circleci && ./run-tests.sh "Fast=Fast" && ./can-build.sh
   selenium_tests:
     machine:
-      image: ubuntu-2004:202111-02
+        enabled: true
     steps:
       - checkout
       - run:
@@ -18,26 +18,32 @@ jobs:
             cd .circleci && ./run-tests.sh "Selenium=Selenium"
   integration_tests:
     machine:
-      image: ubuntu-2004:202111-02
+        enabled: true
     steps:
       - checkout
       - run:
           command: |
             cd .circleci && ./run-tests.sh "Integration=Integration"
-  trigger_docs_build:
+  external_tests:
     machine:
-      image: ubuntu-2004:202111-02
+        enabled: true
     steps:
+      - checkout
       - run:
           command: |
-            curl -X POST -H "Authorization: token $GH_PAT" -H "Accept: application/vnd.github.everest-preview+json" -H "Content-Type: application/json" https://api.github.com/repos/btcpayserver/btcpayserver-doc/dispatches --data '{"event_type": "build_docs"}'
+            if [ "$CIRCLE_PROJECT_USERNAME" == "btcpayserver" ] && [ "$CIRCLE_PROJECT_REPONAME" == "btcpayserver" ]; then
+                cd .circleci && ./run-tests.sh "ExternalIntegration=ExternalIntegration"
+            else
+              echo "Skipping running ExternalIntegration tests outside of context of main user and repository that have access to secrets"
+            fi
+
 
   # publish jobs require $DOCKERHUB_REPO, $DOCKERHUB_USER, $DOCKERHUB_PASS defined
   amd64:
     machine:
-      image: ubuntu-2004:202111-02
+        enabled: true
     steps:
-      - checkout
+      - checkout  
       - run:
           command: |
             LATEST_TAG=${CIRCLE_TAG:1} #trim v from tag
@@ -50,9 +56,9 @@ jobs:
 
   arm32v7:
     machine:
-      image: ubuntu-2004:202111-02
+        enabled: true
     steps:
-      - checkout
+      - checkout  
       - run:
           command: |
             sudo docker run --rm --privileged multiarch/qemu-user-static:register --reset
@@ -66,9 +72,9 @@ jobs:
 
   arm64v8:
     machine:
-      image: ubuntu-2004:202111-02
+        enabled: true
     steps:
-      - checkout
+      - checkout  
       - run:
           command: |
             sudo docker run --rm --privileged multiarch/qemu-user-static:register --reset
@@ -82,10 +88,15 @@ jobs:
 
   multiarch:
     machine:
-      image: ubuntu-2004:202201-02
+      enabled: true
+      image: circleci/classic:201808-01
     steps:
       - run:
           command: |
+            # Turn on Experimental features
+            sudo mkdir $HOME/.docker
+            sudo sh -c 'echo "{ \"experimental\": \"enabled\" }" >> $HOME/.docker/config.json'
+            #
             sudo docker login --username=$DOCKERHUB_USER --password=$DOCKERHUB_PASS
             #
             LATEST_TAG=${CIRCLE_TAG:1} #trim v from tag
@@ -94,7 +105,8 @@ jobs:
             sudo docker manifest annotate $DOCKERHUB_REPO:$LATEST_TAG $DOCKERHUB_REPO:$LATEST_TAG-arm32v7 --os linux --arch arm --variant v7
             sudo docker manifest annotate $DOCKERHUB_REPO:$LATEST_TAG $DOCKERHUB_REPO:$LATEST_TAG-arm64v8 --os linux --arch arm64 --variant v8
             sudo docker manifest push $DOCKERHUB_REPO:$LATEST_TAG -p
-
+            
+            
             sudo docker manifest create --amend $DOCKERHUB_REPO:$LATEST_TAG-altcoins $DOCKERHUB_REPO:$LATEST_TAG-altcoins-amd64 $DOCKERHUB_REPO:$LATEST_TAG-altcoins-arm32v7 $DOCKERHUB_REPO:$LATEST_TAG-altcoins-arm64v8
             sudo docker manifest annotate $DOCKERHUB_REPO:$LATEST_TAG-altcoins $DOCKERHUB_REPO:$LATEST_TAG-altcoins-amd64 --os linux --arch amd64
             sudo docker manifest annotate $DOCKERHUB_REPO:$LATEST_TAG-altcoins $DOCKERHUB_REPO:$LATEST_TAG-altcoins-arm32v7 --os linux --arch arm --variant v7
@@ -108,15 +120,12 @@ workflows:
       - fast_tests
       - selenium_tests
       - integration_tests
-  publish:
-    jobs:
-      - trigger_docs_build:
+      - external_tests:
           filters:
             branches:
-              ignore: /.*/
-            # only act on version tags
-            tags:
-              only: /(v[1-9]+(\.[0-9]+)*(-[a-z0-9-]+)?)|(v[a-z0-9-]+)/
+                only: master
+  publish:
+    jobs:
       - amd64:
           filters:
             # ignore any commit on any branch by default
@@ -126,6 +135,7 @@ workflows:
             # OR feature tags like vlndseedbackup
             # OR features on specific versions like v1.0.0.88-lndseedbackup-1
             tags:
+
               only: /(v[1-9]+(\.[0-9]+)*(-[a-z0-9-]+)?)|(v[a-z0-9-]+)/
       - arm32v7:
           filters:

.editorconfig

@@ -121,11 +121,8 @@ csharp_space_between_method_declaration_name_and_open_parenthesis = false
 csharp_space_between_method_declaration_parameter_list_parentheses = false
 csharp_space_between_parentheses = false
 csharp_space_between_square_brackets = false
-csharp_style_prefer_null_check_over_type_check = true:warning
-csharp_prefer_simple_using_statement = true:warning
 
 # C++ Files
-
 [*.{cpp,h,in}]
 curly_bracket_next_line = true
 indent_brace_style = Allman

.gitignore

@@ -299,4 +299,3 @@ BTCPayServer/wwwroot/bundles/*
 BTCPayServer/testpwd
 .DS_Store
 Packed Plugins
-Plugins/packed

.vscode/launch.json

@@ -10,14 +10,14 @@
             "request": "launch",
             "preLaunchTask": "build",
             // If you have changed target frameworks, make sure to update the program path.
-            "program": "${workspaceFolder}/BTCPayServer/bin/Debug/net6.0/BTCPayServer.dll",
+            "program": "${workspaceFolder}/BTCPayServer/bin/Debug/netcoreapp3.1/BTCPayServer.dll",
             "args": [],
             "cwd": "${workspaceFolder}/BTCPayServer",
             "stopAtEntry": false,
             // Enable launching a web browser when ASP.NET Core starts. For more information: https://aka.ms/VSCode-CS-LaunchJson-WebBrowser
             "serverReadyAction": {
                 "action": "openExternally",
-                "pattern": "\\bNow listening on:\\s+(https?://\\S+)"
+                "pattern": "\\bListening on\\s+(https?://\\S+)"
             },
             "env": {
                 "ASPNETCORE_ENVIRONMENT": "Development"

BTCPayServer.Abstractions/BTCPayServer.Abstractions.csproj

@@ -31,10 +31,10 @@
     <None Include="icon.png" Pack="true" PackagePath="\" />
   </ItemGroup>
   <ItemGroup>
-    <PackageReference Include="Microsoft.EntityFrameworkCore" Version="6.0.1" />
-    <PackageReference Include="Microsoft.EntityFrameworkCore.Sqlite" Version="6.0.1" />
-    <PackageReference Include="Npgsql.EntityFrameworkCore.PostgreSQL" Version="6.0.1" />
-    <PackageReference Include="Pomelo.EntityFrameworkCore.MySql" Version="6.0.0" />
+    <PackageReference Include="Microsoft.EntityFrameworkCore" Version="3.1.19" />
+    <PackageReference Include="Microsoft.EntityFrameworkCore.Sqlite" Version="3.1.19" />
+    <PackageReference Include="Npgsql.EntityFrameworkCore.PostgreSQL" Version="3.1.18" />
+    <PackageReference Include="Pomelo.EntityFrameworkCore.MySql" Version="3.2.7" />
   </ItemGroup>
   <ItemGroup>
     <ProjectReference Include="..\BTCPayServer.Client\BTCPayServer.Client.csproj" />

BTCPayServer.Abstractions/Configuration/DataDirectories.cs

@@ -2,10 +2,11 @@ namespace BTCPayServer.Configuration
 {
     public class DataDirectories
     {
-        public string DataDir { get; set; }
-        public string PluginDir { get; set; }
+        public string DataDir  { get; set; }
+        public string PluginDir  { get; set; }
         public string TempStorageDir { get; set; }
         public string StorageDir { get; set; }
-        public string TempDir { get; set; }
     }
+    
+    
 }

BTCPayServer.Abstractions/Constants/WellKnownTempData.cs

@@ -1,7 +0,0 @@
-namespace BTCPayServer.Abstractions.Constants;
-
-public class WellKnownTempData
-{
-    public const string SuccessMessage = nameof(SuccessMessage);
-    public const string ErrorMessage = nameof(ErrorMessage);
-}

BTCPayServer.Abstractions/Contracts/BaseDbContextFactory.cs

@@ -9,7 +9,7 @@ using Npgsql.EntityFrameworkCore.PostgreSQL.Migrations.Operations;
 
 namespace BTCPayServer.Abstractions.Contracts
 {
-    public abstract class BaseDbContextFactory<T> where T : DbContext
+    public abstract class BaseDbContextFactory<T> where T: DbContext
     {
         private readonly IOptions<DatabaseOptions> _options;
         private readonly string _schemaPrefix;
@@ -24,9 +24,7 @@ namespace BTCPayServer.Abstractions.Contracts
 
         class CustomNpgsqlMigrationsSqlGenerator : NpgsqlMigrationsSqlGenerator
         {
-#pragma warning disable EF1001 // Internal EF Core API usage.
-            public CustomNpgsqlMigrationsSqlGenerator(MigrationsSqlGeneratorDependencies dependencies, Npgsql.EntityFrameworkCore.PostgreSQL.Infrastructure.Internal.INpgsqlOptions opts) : base(dependencies, opts)
-#pragma warning restore EF1001 // Internal EF Core API usage.
+            public CustomNpgsqlMigrationsSqlGenerator(MigrationsSqlGeneratorDependencies dependencies, IMigrationsAnnotationProvider annotations, Npgsql.EntityFrameworkCore.PostgreSQL.Infrastructure.Internal.INpgsqlOptions opts) : base(dependencies, annotations, opts)
             {
             }
 
@@ -92,10 +90,10 @@ namespace BTCPayServer.Abstractions.Contracts
                         .ReplaceService<IMigrationsSqlGenerator, CustomNpgsqlMigrationsSqlGenerator>();
                     break;
                 case DatabaseType.MySQL:
-                    builder.UseMySql(_options.Value.ConnectionString, ServerVersion.AutoDetect(_options.Value.ConnectionString), o =>
+                    builder.UseMySql(_options.Value.ConnectionString, o =>
                     {
                         o.EnableRetryOnFailure(10);
-
+                            
                         if (!string.IsNullOrEmpty(_schemaPrefix))
                         {
                             o.MigrationsHistoryTable(_schemaPrefix);
@@ -106,6 +104,6 @@ namespace BTCPayServer.Abstractions.Contracts
                     throw new ArgumentOutOfRangeException();
             }
         }
-
+        
     }
 }

BTCPayServer.Abstractions/Contracts/IBTCPayServerClientFactory.cs

@@ -1,12 +1,10 @@
 using System.Threading.Tasks;
 using BTCPayServer.Client;
-using Microsoft.AspNetCore.Http;
 
 namespace BTCPayServer.Abstractions.Contracts
 {
     public interface IBTCPayServerClientFactory
     {
         Task<BTCPayServerClient> Create(string userId, params string[] storeIds);
-        Task<BTCPayServerClient> Create(string userId, string[] storeIds, HttpContext httpRequest);
     }
 }

BTCPayServer.Abstractions/Contracts/IBTCPayServerPlugin.cs

@@ -28,5 +28,5 @@ namespace BTCPayServer.Abstractions.Contracts
             }
         }
     }
-
+    
 }

BTCPayServer.Abstractions/Contracts/IFileService.cs

@@ -1,17 +0,0 @@
-#nullable enable
-using System;
-using System.Threading.Tasks;
-using Microsoft.AspNetCore.Http;
-
-namespace BTCPayServer.Abstractions.Contracts;
-
-public interface IFileService
-{
-    Task<bool> IsAvailable();
-    Task<IStoredFile> AddFile(IFormFile file, string userId);
-    Task<IStoredFile> AddFile(Uri file, string userId);
-    Task<string?> GetFileUrl(Uri baseUri, string fileId);
-    Task<string?> GetTemporaryFileUrl(Uri baseUri, string fileId, DateTimeOffset expiry,
-        bool isDownload);
-    Task RemoveFile(string fileId, string userId);
-}

BTCPayServer.Abstractions/Contracts/INotificationHandler.cs

@@ -7,7 +7,7 @@ namespace BTCPayServer.Abstractions.Contracts
         public abstract string Identifier { get; }
         public abstract string NotificationType { get; }
     }
-
+    
     public interface INotificationHandler
     {
         string NotificationType { get; }
@@ -15,7 +15,7 @@ namespace BTCPayServer.Abstractions.Contracts
         public (string identifier, string name)[] Meta { get; }
         void FillViewModel(object notification, NotificationViewModel vm);
     }
-
+    
     public class NotificationViewModel
     {
         public string Id { get; set; }

BTCPayServer.Abstractions/Contracts/IPluginHookFilter.cs

@@ -5,7 +5,7 @@ namespace BTCPayServer.Abstractions.Contracts
     public interface IPluginHookFilter
     {
         public string Hook { get; }
-
+        
         Task<object> Execute(object args);
     }
 }

BTCPayServer.Abstractions/Contracts/IStoredFile.cs

@@ -1,12 +0,0 @@
-using System;
-
-namespace BTCPayServer.Abstractions.Contracts;
-
-public interface IStoredFile
-{
-    string Id { get; set; }
-    string FileName { get; set; }
-    string StorageFileName { get; set; }
-    DateTime Timestamp { get; set; }
-    string ApplicationUserId { get; set; }
-}

BTCPayServer.Abstractions/Contracts/ISwaggerProvider.cs

@@ -1,9 +0,0 @@
-using System.Threading.Tasks;
-using Newtonsoft.Json.Linq;
-
-namespace BTCPayServer.Abstractions.Contracts;
-
-public interface ISwaggerProvider
-{
-    Task<JObject> Fetch();
-}

BTCPayServer.Abstractions/Contracts/IUIExtension.cs

@@ -3,7 +3,7 @@ namespace BTCPayServer.Abstractions.Contracts
     public interface IUIExtension
     {
         string Partial { get; }
-
+        
         string Location { get; }
     }
 }

BTCPayServer.Abstractions/Extensions/Extensions.cs

@@ -0,0 +1,20 @@
+using System.Text.Json;
+using BTCPayServer.Abstractions.Models;
+using Microsoft.AspNetCore.Mvc.ViewFeatures;
+
+namespace BTCPayServer.Abstractions.Extensions
+{
+    public static class SetStatusMessageModelExtensions
+    {
+        public static void SetStatusMessageModel(this ITempDataDictionary tempData, StatusMessageModel statusMessage)
+        {
+            if (statusMessage == null)
+            {
+                tempData.Remove("StatusMessageModel");
+                return;
+            }
+
+            tempData["StatusMessageModel"] = JsonSerializer.Serialize(statusMessage, new JsonSerializerOptions());
+        }
+    }
+}

BTCPayServer.Abstractions/Extensions/GreenfieldExtensions.cs

@@ -1,43 +0,0 @@
-using System.Collections.Generic;
-using BTCPayServer.Client.Models;
-using Microsoft.AspNetCore.Mvc;
-using Microsoft.AspNetCore.Mvc.ModelBinding;
-
-namespace BTCPayServer.Abstractions.Extensions;
-
-public static class GreenfieldExtensions
-{
-    public static IActionResult CreateValidationError(this ControllerBase controller, ModelStateDictionary modelState)
-    {
-        return controller.UnprocessableEntity(modelState.ToGreenfieldValidationError());
-    }
-
-    public static List<GreenfieldValidationError> ToGreenfieldValidationError(this ModelStateDictionary modelState)
-    {
-        List<GreenfieldValidationError> errors = new List<GreenfieldValidationError>();
-        foreach (var error in modelState)
-        {
-            foreach (var errorMessage in error.Value.Errors)
-            {
-                errors.Add(new GreenfieldValidationError(error.Key, errorMessage.ErrorMessage));
-            }
-        }
-
-        return errors;
-    }
-
-    public static IActionResult CreateAPIError(this ControllerBase controller, string errorCode, string errorMessage)
-    {
-        return controller.BadRequest(new GreenfieldAPIError(errorCode, errorMessage));
-    }
-        
-    public static IActionResult CreateAPIError(this ControllerBase controller, int httpCode, string errorCode, string errorMessage)
-    {
-        return controller.StatusCode(httpCode, new GreenfieldAPIError(errorCode, errorMessage));
-    }
-        
-    public static IActionResult CreateAPIPermissionError(this ControllerBase controller, string missingPermission, string message = null)
-    {
-        return controller.StatusCode(403, new GreenfieldPermissionAPIError(missingPermission, message));
-    }
-}

BTCPayServer.Abstractions/Extensions/HttpRequestExtensions.cs

@@ -1,120 +0,0 @@
-using System;
-using Microsoft.AspNetCore.Http;
-
-namespace BTCPayServer.Abstractions.Extensions;
-
-public static class HttpRequestExtensions
-{
-    public static bool IsOnion(this HttpRequest request)
-    {
-        if (request?.Host.Host == null)
-            return false;
-        return request.Host.Host.EndsWith(".onion", StringComparison.OrdinalIgnoreCase);
-    }
-    
-    public static string GetAbsoluteRoot(this HttpRequest request)
-    {
-        return string.Concat(
-            request.Scheme,
-            "://",
-            request.Host.ToUriComponent(),
-            request.PathBase.ToUriComponent());
-    }
-
-    public static Uri GetAbsoluteRootUri(this HttpRequest request)
-    {
-        return new Uri(request.GetAbsoluteRoot());
-    }
-
-    public static string GetCurrentUrl(this HttpRequest request)
-    {
-        return string.Concat(
-            request.Scheme,
-            "://",
-            request.Host.ToUriComponent(),
-            request.PathBase.ToUriComponent(),
-            request.Path.ToUriComponent());
-    }
-
-    public static string GetCurrentPath(this HttpRequest request)
-    {
-        return string.Concat(
-            request.PathBase.ToUriComponent(),
-            request.Path.ToUriComponent());
-    }
-
-    public static string GetCurrentPathWithQueryString(this HttpRequest request)
-    {
-        return request.PathBase + request.Path + request.QueryString;
-    }
-
-    /// <summary>
-    /// If 'toto' and RootPath is 'rootpath' returns '/rootpath/toto'
-    /// If 'toto' and RootPath is empty returns '/toto'
-    /// </summary>
-    /// <param name="request"></param>
-    /// <param name="path"></param>
-    /// <returns></returns>
-    public static string GetRelativePath(this HttpRequest request, string path)
-    {
-        if (path.Length > 0 && path[0] != '/')
-            path = $"/{path}";
-        return string.Concat(
-            request.PathBase.ToUriComponent(),
-            path);
-    }
-
-    /// <summary>
-    /// If 'https://example.com/toto' returns 'https://example.com/toto'
-    /// If 'toto' and RootPath is 'rootpath' returns '/rootpath/toto'
-    /// If 'toto' and RootPath is empty returns '/toto'
-    /// </summary>
-    /// <param name="request"></param>
-    /// <param name="path"></param>
-    /// <returns></returns>
-    public static string GetRelativePathOrAbsolute(this HttpRequest request, string path)
-    {
-        if (!Uri.TryCreate(path, UriKind.RelativeOrAbsolute, out var uri) ||
-            uri.IsAbsoluteUri)
-            return path;
-
-        if (path.Length > 0 && path[0] != '/')
-            path = $"/{path}";
-        return string.Concat(
-            request.PathBase.ToUriComponent(),
-            path);
-    }
-
-    public static string GetAbsoluteUri(this HttpRequest request, string redirectUrl)
-    {
-        bool isRelative =
-            (redirectUrl.Length > 0 && redirectUrl[0] == '/')
-            || !new Uri(redirectUrl, UriKind.RelativeOrAbsolute).IsAbsoluteUri;
-        return isRelative ? request.GetAbsoluteRoot() + redirectUrl : redirectUrl;
-    }
-
-    /// <summary>
-    /// Will return an absolute URL. 
-    /// If `relativeOrAsbolute` is absolute, returns it.
-    /// If `relativeOrAsbolute` is relative, send absolute url based on the HOST of this request (without PathBase)
-    /// </summary>
-    /// <param name="request"></param>
-    /// <param name="relativeOrAbsolte"></param>
-    /// <returns></returns>
-    public static Uri GetAbsoluteUriNoPathBase(this HttpRequest request, Uri relativeOrAbsolute = null)
-    {
-        if (relativeOrAbsolute == null)
-        {
-            return new Uri(string.Concat(
-                request.Scheme,
-                "://",
-                request.Host.ToUriComponent()), UriKind.Absolute);
-        }
-        if (relativeOrAbsolute.IsAbsoluteUri)
-            return relativeOrAbsolute;
-        return new Uri(string.Concat(
-            request.Scheme,
-            "://",
-            request.Host.ToUriComponent()) + relativeOrAbsolute.ToString().WithStartingSlash(), UriKind.Absolute);
-    }
-}

BTCPayServer.Abstractions/Extensions/ITempDataDictionaryExtensions.cs

@@ -1,59 +0,0 @@
-using System.Text.Json;
-using BTCPayServer.Abstractions.Constants;
-using BTCPayServer.Abstractions.Models;
-using Microsoft.AspNetCore.Mvc.ViewFeatures;
-using Newtonsoft.Json.Linq;
-
-namespace BTCPayServer.Abstractions.Extensions;
-
-public static class SetStatusMessageModelExtensions
-{
-    public static void SetStatusMessageModel(this ITempDataDictionary tempData, StatusMessageModel statusMessage)
-    {
-        if (statusMessage == null)
-        {
-            tempData.Remove("StatusMessageModel");
-            return;
-        }
-
-        tempData["StatusMessageModel"] = JsonSerializer.Serialize(statusMessage, new JsonSerializerOptions());
-    }
-
-    public static StatusMessageModel GetStatusMessageModel(this ITempDataDictionary tempData)
-    {
-        tempData.TryGetValue(WellKnownTempData.SuccessMessage, out var successMessage);
-        tempData.TryGetValue(WellKnownTempData.ErrorMessage, out var errorMessage);
-        tempData.TryGetValue("StatusMessageModel", out var model);
-        if (successMessage != null || errorMessage != null)
-        {
-            var parsedModel = new StatusMessageModel();
-            parsedModel.Message = (string)successMessage ?? (string)errorMessage;
-            if (successMessage != null)
-            {
-                parsedModel.Severity = StatusMessageModel.StatusSeverity.Success;
-            }
-            else
-            {
-                parsedModel.Severity = StatusMessageModel.StatusSeverity.Error;
-            }
-            return parsedModel;
-        }
-        else if (model != null && model is string str)
-        {
-            return JObject.Parse(str).ToObject<StatusMessageModel>();
-        }
-        return null;
-    }
-
-    public static bool HasStatusMessage(this ITempDataDictionary tempData)
-    {
-        return (tempData.Peek(WellKnownTempData.SuccessMessage) ??
-                tempData.Peek(WellKnownTempData.ErrorMessage) ??
-                tempData.Peek("StatusMessageModel")) != null;
-    }
-
-    public static bool HasErrorMessage(this ITempDataDictionary tempData)
-    {
-        return GetStatusMessageModel(tempData)?.Severity == StatusMessageModel.StatusSeverity.Error;
-    }
-}

BTCPayServer.Abstractions/Extensions/StringExtensions.cs

@@ -1,45 +0,0 @@
-using System;
-using System.IO;
-using System.Linq;
-
-namespace BTCPayServer.Abstractions.Extensions;
-
-public static class StringExtensions
-{
-
-    public static bool IsValidFileName(this string fileName)
-    {
-        return !fileName.ToCharArray().Any(c => Path.GetInvalidFileNameChars().Contains(c)
-                                                || c == Path.AltDirectorySeparatorChar
-                                                || c == Path.DirectorySeparatorChar
-                                                || c == Path.PathSeparator
-                                                || c == '\\');
-    }
-
-    public static string Truncate(this string value, int maxLength)
-    {
-        if (string.IsNullOrEmpty(value))
-            return value;
-        return value.Length <= maxLength ? value : value.Substring(0, maxLength);
-    }
-
-    public static string WithTrailingSlash(this string str)
-    {
-        if (str.EndsWith("/", StringComparison.InvariantCulture))
-            return str;
-        return str + "/";
-    }
-    public static string WithStartingSlash(this string str)
-    {
-        if (str.StartsWith("/", StringComparison.InvariantCulture))
-            return str;
-        return $"/{str}";
-    }
-    public static string WithoutEndingSlash(this string str)
-    {
-        if (str.EndsWith("/", StringComparison.InvariantCulture))
-            return str.Substring(0, str.Length - 1);
-        return str;
-    }
-    
-}

BTCPayServer.Abstractions/Extensions/ViewsRazor.cs

@@ -9,70 +9,44 @@ namespace BTCPayServer.Abstractions.Extensions
     {
         private const string ACTIVE_CATEGORY_KEY = "ActiveCategory";
         private const string ACTIVE_PAGE_KEY = "ActivePage";
-        private const string ACTIVE_ID_KEY = "ActiveId";
 
-        public static void SetActivePage<T>(this ViewDataDictionary viewData, T activePage, string title = null, string activeId = null)
+        public static void SetActivePageAndTitle<T>(this ViewDataDictionary viewData, T activePage, string title = null, string mainTitle = null)
             where T : IConvertible
         {
-            SetActivePage(viewData, activePage.ToString(), activePage.GetType().ToString(), title, activeId);
-        }
-
-        public static void SetActivePage(this ViewDataDictionary viewData, string activePage, string category, string title = null, string activeId = null)
-        {
-            // Page Title
-            viewData["Title"] = title ?? activePage;
+            // Browser Title
+            viewData["Title"] = title ?? activePage.ToString();
+            // Breadcrumb
+            viewData["MainTitle"] = mainTitle;
+            viewData["PageTitle"] = title;
             // Navigation
             viewData[ACTIVE_PAGE_KEY] = activePage;
-            viewData[ACTIVE_ID_KEY] = activeId;
-            SetActiveCategory(viewData, category);
+            SetActiveCategory(viewData, activePage.GetType());
         }
 
         public static void SetActiveCategory<T>(this ViewDataDictionary viewData, T activeCategory)
-        {
-            SetActiveCategory(viewData, activeCategory.ToString());
-        }
-
-        public static void SetActiveCategory(this ViewDataDictionary viewData, string activeCategory)
         {
             viewData[ACTIVE_CATEGORY_KEY] = activeCategory;
         }
 
-        public static string IsActiveCategory<T>(this ViewDataDictionary viewData, T category, object id = null)
-        {
-            return IsActiveCategory(viewData, category.ToString(), id);
-        }
-        
-        public static string IsActiveCategory(this ViewDataDictionary viewData, string category, object id = null)
+        public static string IsActiveCategory<T>(this ViewDataDictionary viewData, T category)
         {
             if (!viewData.ContainsKey(ACTIVE_CATEGORY_KEY))
             {
                 return null;
             }
-            var activeId = viewData[ACTIVE_ID_KEY];
-            var activeCategory = viewData[ACTIVE_CATEGORY_KEY]?.ToString();
-            var categoryMatch = category.Equals(activeCategory, StringComparison.InvariantCultureIgnoreCase);
-            var idMatch = id == null || activeId == null || id.Equals(activeId);
-            return categoryMatch && idMatch ? "active" : null;
+            var activeCategory = (T)viewData[ACTIVE_CATEGORY_KEY];
+            return category.Equals(activeCategory) ? "active" : null;
         }
 
-        public static string IsActivePage<T>(this ViewDataDictionary viewData, T page, object id = null)
+        public static string IsActivePage<T>(this ViewDataDictionary viewData, T page)
             where T : IConvertible
-        {
-            return IsActivePage(viewData, page.ToString(), page.GetType().ToString(), id);
-        }
-        
-        public static string IsActivePage(this ViewDataDictionary viewData, string page, string category, object id = null)
         {
             if (!viewData.ContainsKey(ACTIVE_PAGE_KEY))
             {
                 return null;
             }
-            var activeId = viewData[ACTIVE_ID_KEY];
-            var activePage = viewData[ACTIVE_PAGE_KEY]?.ToString();
-            var activeCategory = viewData[ACTIVE_CATEGORY_KEY]?.ToString();
-            var categoryAndPageMatch = (category == null || activeCategory.Equals(category, StringComparison.InvariantCultureIgnoreCase)) && page.Equals(activePage, StringComparison.InvariantCultureIgnoreCase);
-            var idMatch = id == null || activeId == null || id.Equals(activeId);
-            return categoryAndPageMatch && idMatch ? "active" : null;
+            var activePage = (T)viewData[ACTIVE_PAGE_KEY];
+            return page.Equals(activePage) ? "active" : null;
         }
 
         public static HtmlString ToBrowserDate(this DateTimeOffset date)
@@ -86,13 +60,10 @@ namespace BTCPayServer.Abstractions.Extensions
             var displayDate = date.ToString("o", CultureInfo.InvariantCulture);
             return new HtmlString($"<span class='localizeDate'>{displayDate}</span>");
         }
-
+        
         public static string ToTimeAgo(this DateTimeOffset date)
         {
-            var diff = DateTimeOffset.UtcNow - date;
-            var formatted = diff.Seconds > 0
-                ? $"{diff.TimeString()} ago"
-                : $"in {diff.Negate().TimeString()}";
+            var formatted = (DateTimeOffset.UtcNow - date).TimeString() + " ago";
             return formatted;
         }
 

BTCPayServer.Abstractions/Security/ContentSecurityPolicies.cs

@@ -96,7 +96,8 @@ namespace BTCPayServer.Security
         /// <param name="script"></param>
         public void AllowInline(string script)
         {
-            ArgumentNullException.ThrowIfNull(script);
+            if (script is null)
+                throw new ArgumentNullException(nameof(script));
             var sha = GetSha256(script);
             Add("script-src", $"'sha256-{sha}'");
         }

BTCPayServer.Abstractions/Services/PluginAction.cs

@@ -3,7 +3,7 @@ using BTCPayServer.Abstractions.Contracts;
 
 namespace BTCPayServer.Abstractions.Services
 {
-    public abstract class PluginAction<T> : IPluginHookAction
+    public abstract class PluginAction<T>:IPluginHookAction
     {
         public abstract string Hook { get; }
         public Task Execute(object args)

BTCPayServer.Abstractions/Services/PluginHookFilter.cs

@@ -3,7 +3,7 @@ using BTCPayServer.Abstractions.Contracts;
 
 namespace BTCPayServer.Abstractions.Services
 {
-    public abstract class PluginHookFilter<T> : IPluginHookFilter
+    public abstract class PluginHookFilter<T>:IPluginHookFilter
     {
         public abstract string Hook { get; }
 

BTCPayServer.Abstractions/Services/UIExtension.cs

@@ -2,7 +2,7 @@ using BTCPayServer.Abstractions.Contracts;
 
 namespace BTCPayServer.Abstractions.Services
 {
-    public class UIExtension : IUIExtension
+    public class UIExtension: IUIExtension
     {
         public UIExtension(string partial, string location)
         {

BTCPayServer.Client/BTCPayServer.Client.csproj

@@ -2,7 +2,6 @@
 
     <PropertyGroup>
         <TargetFramework>netstandard2.1</TargetFramework>
-        <LangVersion>10.0</LangVersion>
         <Company>BTCPay Server</Company>
         <Copyright>Copyright © BTCPay Server 2020</Copyright>
         <Description>A client library for BTCPay Server Greenfield API</Description>
@@ -14,7 +13,7 @@
         <RepositoryType>git</RepositoryType>
     </PropertyGroup>
   <PropertyGroup>
-    <Version Condition=" '$(Version)' == '' ">1.6.0</Version>
+    <Version Condition=" '$(Version)' == '' ">1.5.0</Version>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)' == 'Release' ">
     <PublishRepositoryUrl>true</PublishRepositoryUrl>
@@ -28,8 +27,8 @@
     <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" PrivateAssets="All" />
   </ItemGroup>
     <ItemGroup>
-      <PackageReference Include="NBitcoin" Version="7.0.1" />
-      <PackageReference Include="BTCPayServer.Lightning.Common" Version="1.3.2" />
+      <PackageReference Include="NBitcoin" Version="6.0.17" />
+      <PackageReference Include="BTCPayServer.Lightning.Common" Version="1.2.7" />
       <PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
     </ItemGroup>
   <ItemGroup>

BTCPayServer.Client/BTCPayServerClient.Invoices.cs

@@ -35,18 +35,16 @@ namespace BTCPayServer.Client
             if (textSearch != null)
                 queryPayload.Add(nameof(textSearch), textSearch);
             if (status != null)
-                queryPayload.Add(nameof(status), status.Select(s => s.ToString().ToLower()).ToArray());
+                queryPayload.Add(nameof(status), status.Select(s=> s.ToString().ToLower()).ToArray());
 
-            if (skip != null)
-            {
+            if(skip != null) {
                 queryPayload.Add(nameof(skip), skip);
             }
 
-            if (take != null)
-            {
+             if(take != null) {
                 queryPayload.Add(nameof(take), take);
             }
-
+            
             var response =
                 await _httpClient.SendAsync(
                     CreateHttpRequest($"api/v1/stores/{storeId}/invoices",
@@ -116,7 +114,7 @@ namespace BTCPayServer.Client
         public virtual async Task<InvoiceData> UnarchiveInvoice(string storeId, string invoiceId, CancellationToken token = default)
         {
             var response = await _httpClient.SendAsync(
-                CreateHttpRequest($"api/v1/stores/{storeId}/invoices/{invoiceId}/unarchive",
+                CreateHttpRequest($"api/v1/stores/{storeId}/invoices/{invoiceId}/unarchive", 
                     method: HttpMethod.Post), token);
             return await HandleResponse<InvoiceData>(response);
         }
@@ -124,7 +122,7 @@ namespace BTCPayServer.Client
         public virtual async Task ActivateInvoicePaymentMethod(string storeId, string invoiceId, string paymentMethod, CancellationToken token = default)
         {
             var response = await _httpClient.SendAsync(
-                CreateHttpRequest($"api/v1/stores/{storeId}/invoices/{invoiceId}/payment-methods/{paymentMethod}/activate",
+                CreateHttpRequest($"api/v1/stores/{storeId}/invoices/{invoiceId}/payment-methods/{paymentMethod}/activate", 
                     method: HttpMethod.Post), token);
             await HandleResponse(response);
         }

BTCPayServer.Client/BTCPayServerClient.Lightning.Internal.cs

@@ -54,7 +54,8 @@ namespace BTCPayServer.Client
             return await HandleResponse<string>(response);
         }
 
-        public virtual async Task<LightningPaymentData> PayLightningInvoice(string cryptoCode, PayLightningInvoiceRequest request,
+
+        public virtual async Task PayLightningInvoice(string cryptoCode, PayLightningInvoiceRequest request,
             CancellationToken token = default)
         {
             if (request == null)
@@ -62,18 +63,7 @@ namespace BTCPayServer.Client
             var response = await _httpClient.SendAsync(
                 CreateHttpRequest($"api/v1/server/lightning/{cryptoCode}/invoices/pay", bodyPayload: request,
                     method: HttpMethod.Post), token);
-            return await HandleResponse<LightningPaymentData>(response);
-        }
-
-        public virtual async Task<LightningPaymentData> GetLightningPayment(string cryptoCode,
-            string paymentHash, CancellationToken token = default)
-        {
-            if (paymentHash == null)
-                throw new ArgumentNullException(nameof(paymentHash));
-            var response = await _httpClient.SendAsync(
-                CreateHttpRequest($"api/v1/server/lightning/{cryptoCode}/payments/{paymentHash}",
-                    method: HttpMethod.Get), token);
-            return await HandleResponse<LightningPaymentData>(response);
+            await HandleResponse(response);
         }
 
         public virtual async Task<LightningInvoiceData> GetLightningInvoice(string cryptoCode,

BTCPayServer.Client/BTCPayServerClient.Lightning.Store.cs

@@ -67,17 +67,6 @@ namespace BTCPayServer.Client
             await HandleResponse(response);
         }
 
-        public virtual async Task<LightningPaymentData> GetLightningPayment(string storeId, string cryptoCode,
-            string paymentHash, CancellationToken token = default)
-        {
-            if (paymentHash == null)
-                throw new ArgumentNullException(nameof(paymentHash));
-            var response = await _httpClient.SendAsync(
-                CreateHttpRequest($"api/v1/stores/{storeId}/lightning/{cryptoCode}/payments/{paymentHash}",
-                    method: HttpMethod.Get), token);
-            return await HandleResponse<LightningPaymentData>(response);
-        }
-
         public virtual async Task<LightningInvoiceData> GetLightningInvoice(string storeId, string cryptoCode,
             string invoiceId, CancellationToken token = default)
         {

BTCPayServer.Client/BTCPayServerClient.Notifications.cs

@@ -9,22 +9,13 @@ namespace BTCPayServer.Client
 {
     public partial class BTCPayServerClient
     {
-        public virtual async Task<IEnumerable<NotificationData>> GetNotifications(bool? seen = null, int? skip = null,
-            int? take = null, CancellationToken token = default)
+        public virtual async Task<IEnumerable<NotificationData>> GetNotifications(bool? seen = null,
+            CancellationToken token = default)
         {
-            Dictionary<string, object> queryPayload = new Dictionary<string, object>();
-
-            if (seen != null)
-                queryPayload.Add(nameof(seen), seen);
-            if (skip != null)
-                queryPayload.Add(nameof(skip), skip);
-            if (take != null)
-                queryPayload.Add(nameof(take), take);
-
-            var response = await _httpClient.SendAsync(
-                CreateHttpRequest($"api/v1/users/me/notifications",
-                    queryPayload), token);
-
+            var response =
+                await _httpClient.SendAsync(
+                    CreateHttpRequest($"api/v1/users/me/notifications",
+                        seen != null ? new Dictionary<string, object>() {{nameof(seen), seen}} : null), token);
             return await HandleResponse<IEnumerable<NotificationData>>(response);
         }
 
@@ -41,7 +32,7 @@ namespace BTCPayServer.Client
         {
             var response = await _httpClient.SendAsync(
                 CreateHttpRequest($"api/v1/users/me/notifications/{notificationId}",
-                    method: HttpMethod.Put, bodyPayload: new UpdateNotification() { Seen = seen }), token);
+                    method: HttpMethod.Put, bodyPayload: new UpdateNotification() {Seen = seen}), token);
             return await HandleResponse<NotificationData>(response);
         }
 

BTCPayServer.Client/BTCPayServerClient.OnChainPaymentMethods.cs

@@ -20,7 +20,7 @@ namespace BTCPayServer.Client
 
             var response =
                 await _httpClient.SendAsync(
-                    CreateHttpRequest($"api/v1/stores/{storeId}/payment-methods/onchain",
+                    CreateHttpRequest($"api/v1/stores/{storeId}/payment-methods/Onchain",
                         query), token);
             return await HandleResponse<IEnumerable<OnChainPaymentMethodData>>(response);
         }
@@ -30,7 +30,7 @@ namespace BTCPayServer.Client
         {
             var response =
                 await _httpClient.SendAsync(
-                    CreateHttpRequest($"api/v1/stores/{storeId}/payment-methods/onchain/{cryptoCode}"), token);
+                    CreateHttpRequest($"api/v1/stores/{storeId}/payment-methods/Onchain/{cryptoCode}"), token);
             return await HandleResponse<OnChainPaymentMethodData>(response);
         }
 
@@ -39,7 +39,7 @@ namespace BTCPayServer.Client
         {
             var response =
                 await _httpClient.SendAsync(
-                    CreateHttpRequest($"api/v1/stores/{storeId}/payment-methods/onchain/{cryptoCode}",
+                    CreateHttpRequest($"api/v1/stores/{storeId}/payment-methods/Onchain/{cryptoCode}",
                         method: HttpMethod.Delete), token);
             await HandleResponse(response);
         }
@@ -49,7 +49,7 @@ namespace BTCPayServer.Client
             CancellationToken token = default)
         {
             var response = await _httpClient.SendAsync(
-                CreateHttpRequest($"api/v1/stores/{storeId}/payment-methods/onchain/{cryptoCode}",
+                CreateHttpRequest($"api/v1/stores/{storeId}/payment-methods/Onchain/{cryptoCode}",
                     bodyPayload: paymentMethod, method: HttpMethod.Put), token);
             return await HandleResponse<OnChainPaymentMethodData>(response);
         }
@@ -61,9 +61,9 @@ namespace BTCPayServer.Client
                 CancellationToken token = default)
         {
             var response = await _httpClient.SendAsync(
-                CreateHttpRequest($"api/v1/stores/{storeId}/payment-methods/onchain/{cryptoCode}/preview",
+                CreateHttpRequest($"api/v1/stores/{storeId}/payment-methods/Onchain/{cryptoCode}/preview",
                     bodyPayload: paymentMethod,
-                    queryPayload: new Dictionary<string, object>() { { "offset", offset }, { "amount", amount } },
+                    queryPayload: new Dictionary<string, object>() {{"offset", offset}, {"amount", amount}},
                     method: HttpMethod.Post), token);
             return await HandleResponse<OnChainPaymentMethodPreviewResultData>(response);
         }
@@ -73,18 +73,18 @@ namespace BTCPayServer.Client
             CancellationToken token = default)
         {
             var response = await _httpClient.SendAsync(
-                CreateHttpRequest($"api/v1/stores/{storeId}/payment-methods/onchain/{cryptoCode}/preview",
-                    queryPayload: new Dictionary<string, object>() { { "offset", offset }, { "amount", amount } },
+                CreateHttpRequest($"api/v1/stores/{storeId}/payment-methods/Onchain/{cryptoCode}/preview",
+                    queryPayload: new Dictionary<string, object>() {{"offset", offset}, {"amount", amount}},
                     method: HttpMethod.Get), token);
             return await HandleResponse<OnChainPaymentMethodPreviewResultData>(response);
         }
-
+        
         public virtual async Task<OnChainPaymentMethodDataWithSensitiveData> GenerateOnChainWallet(string storeId,
             string cryptoCode, GenerateOnChainWalletRequest request,
             CancellationToken token = default)
         {
             var response = await _httpClient.SendAsync(
-                CreateHttpRequest($"api/v1/stores/{storeId}/payment-methods/onchain/{cryptoCode}/generate",
+                CreateHttpRequest($"api/v1/stores/{storeId}/payment-methods/Onchain/{cryptoCode}/generate",
                     bodyPayload: request,
                     method: HttpMethod.Post), token);
             return await HandleResponse<OnChainPaymentMethodDataWithSensitiveData>(response);

BTCPayServer.Client/BTCPayServerClient.OnChainWallet.cs

@@ -16,7 +16,7 @@ namespace BTCPayServer.Client
         {
             var response =
                 await _httpClient.SendAsync(
-                    CreateHttpRequest($"api/v1/stores/{storeId}/payment-methods/onchain/{cryptoCode}/wallet"), token);
+                    CreateHttpRequest($"api/v1/stores/{storeId}/payment-methods/Onchain/{cryptoCode}/wallet"), token);
             return await HandleResponse<OnChainWalletOverviewData>(response);
         }
         public virtual async Task<OnChainWalletFeeRateData> GetOnChainFeeRate(string storeId, string cryptoCode, int? blockTarget = null,
@@ -25,35 +25,35 @@ namespace BTCPayServer.Client
             Dictionary<string, object> queryParams = new Dictionary<string, object>();
             if (blockTarget != null)
             {
-                queryParams.Add("blockTarget", blockTarget);
+                queryParams.Add("blockTarget",blockTarget);
             }
             var response =
                 await _httpClient.SendAsync(
-                    CreateHttpRequest($"api/v1/stores/{storeId}/payment-methods/onchain/{cryptoCode}/wallet/feeRate", queryParams), token);
+                    CreateHttpRequest($"api/v1/stores/{storeId}/payment-methods/Onchain/{cryptoCode}/wallet/feeRate", queryParams), token);
             return await HandleResponse<OnChainWalletFeeRateData>(response);
         }
-
+        
         public virtual async Task<OnChainWalletAddressData> GetOnChainWalletReceiveAddress(string storeId, string cryptoCode, bool forceGenerate = false,
             CancellationToken token = default)
         {
             var response =
                 await _httpClient.SendAsync(
-                    CreateHttpRequest($"api/v1/stores/{storeId}/payment-methods/onchain/{cryptoCode}/wallet/address", new Dictionary<string, object>()
+                    CreateHttpRequest($"api/v1/stores/{storeId}/payment-methods/Onchain/{cryptoCode}/wallet/address", new Dictionary<string, object>()
                     {
                         {"forceGenerate", forceGenerate}
                     }), token);
             return await HandleResponse<OnChainWalletAddressData>(response);
         }
-
+        
         public virtual async Task UnReserveOnChainWalletReceiveAddress(string storeId, string cryptoCode,
             CancellationToken token = default)
         {
             var response =
                 await _httpClient.SendAsync(
-                    CreateHttpRequest($"api/v1/stores/{storeId}/payment-methods/onchain/{cryptoCode}/wallet/address", method: HttpMethod.Delete), token);
+                    CreateHttpRequest($"api/v1/stores/{storeId}/payment-methods/Onchain/{cryptoCode}/wallet/address",method:HttpMethod.Delete), token);
             await HandleResponse(response);
         }
-
+       
         public virtual async Task<IEnumerable<OnChainWalletTransactionData>> ShowOnChainWalletTransactions(
             string storeId, string cryptoCode, TransactionStatus[] statusFilter = null,
             CancellationToken token = default)
@@ -65,41 +65,30 @@ namespace BTCPayServer.Client
             }
             var response =
                 await _httpClient.SendAsync(
-                    CreateHttpRequest($"api/v1/stores/{storeId}/payment-methods/onchain/{cryptoCode}/wallet/transactions", query), token);
+                    CreateHttpRequest($"api/v1/stores/{storeId}/payment-methods/Onchain/{cryptoCode}/wallet/transactions", query), token);
             return await HandleResponse<IEnumerable<OnChainWalletTransactionData>>(response);
         }
-
+        
         public virtual async Task<OnChainWalletTransactionData> GetOnChainWalletTransaction(
             string storeId, string cryptoCode, string transactionId,
             CancellationToken token = default)
         {
             var response =
                 await _httpClient.SendAsync(
-                    CreateHttpRequest($"api/v1/stores/{storeId}/payment-methods/onchain/{cryptoCode}/wallet/transactions/{transactionId}"), token);
+                    CreateHttpRequest($"api/v1/stores/{storeId}/payment-methods/Onchain/{cryptoCode}/wallet/transactions/{transactionId}"), token);
             return await HandleResponse<OnChainWalletTransactionData>(response);
         }
-
-        public virtual async Task<OnChainWalletTransactionData> PatchOnChainWalletTransaction(
-            string storeId, string cryptoCode, string transactionId,
-            PatchOnChainTransactionRequest request,
-            CancellationToken token = default)
-        {
-            var response =
-                await _httpClient.SendAsync(
-                    CreateHttpRequest($"api/v1/stores/{storeId}/payment-methods/onchain/{cryptoCode}/wallet/transactions/{transactionId}", queryPayload: null, bodyPayload: request, HttpMethod.Patch), token);
-            return await HandleResponse<OnChainWalletTransactionData>(response);
-        }
-
+        
         public virtual async Task<IEnumerable<OnChainWalletUTXOData>> GetOnChainWalletUTXOs(string storeId,
             string cryptoCode,
             CancellationToken token = default)
         {
             var response =
                 await _httpClient.SendAsync(
-                    CreateHttpRequest($"api/v1/stores/{storeId}/payment-methods/onchain/{cryptoCode}/wallet/utxos"), token);
+                    CreateHttpRequest($"api/v1/stores/{storeId}/payment-methods/Onchain/{cryptoCode}/wallet/utxos"), token);
             return await HandleResponse<IEnumerable<OnChainWalletUTXOData>>(response);
         }
-
+        
         public virtual async Task<OnChainWalletTransactionData> CreateOnChainTransaction(string storeId,
             string cryptoCode, CreateOnChainTransactionRequest request,
             CancellationToken token = default)
@@ -111,10 +100,10 @@ namespace BTCPayServer.Client
             }
             var response =
                 await _httpClient.SendAsync(
-                    CreateHttpRequest($"api/v1/stores/{storeId}/payment-methods/onchain/{cryptoCode}/wallet/transactions", null, request, HttpMethod.Post), token);
+                    CreateHttpRequest($"api/v1/stores/{storeId}/payment-methods/Onchain/{cryptoCode}/wallet/transactions", null, request, HttpMethod.Post), token);
             return await HandleResponse<OnChainWalletTransactionData>(response);
         }
-
+        
         public virtual async Task<Transaction> CreateOnChainTransactionButDoNotBroadcast(string storeId,
             string cryptoCode, CreateOnChainTransactionRequest request, Network network,
             CancellationToken token = default)
@@ -126,7 +115,7 @@ namespace BTCPayServer.Client
             }
             var response =
                 await _httpClient.SendAsync(
-                    CreateHttpRequest($"api/v1/stores/{storeId}/payment-methods/onchain/{cryptoCode}/wallet/transactions", null, request, HttpMethod.Post), token);
+                    CreateHttpRequest($"api/v1/stores/{storeId}/payment-methods/Onchain/{cryptoCode}/wallet/transactions", null, request, HttpMethod.Post), token);
             return Transaction.Parse(await HandleResponse<string>(response), network);
         }
     }

BTCPayServer.Client/BTCPayServerClient.PaymentRequests.cs

@@ -16,7 +16,7 @@ namespace BTCPayServer.Client
             var response =
                 await _httpClient.SendAsync(
                     CreateHttpRequest($"api/v1/stores/{storeId}/payment-requests",
-                        new Dictionary<string, object>() { { nameof(includeArchived), includeArchived } }), token);
+                        new Dictionary<string, object>() {{nameof(includeArchived), includeArchived}}), token);
             return await HandleResponse<IEnumerable<PaymentRequestData>>(response);
         }
 

BTCPayServer.Client/BTCPayServerClient.StoreEmail.cs

@@ -1,37 +0,0 @@
-using System.Net.Http;
-using System.Threading;
-using System.Threading.Tasks;
-using BTCPayServer.Client.Models;
-
-namespace BTCPayServer.Client
-{
-    public partial class BTCPayServerClient
-    {
-        public virtual async Task<EmailSettingsData> GetStoreEmailSettings(string storeId,
-            CancellationToken token = default)
-        {
-            using var response = await _httpClient.SendAsync(
-                CreateHttpRequest($"api/v1/stores/{storeId}/email", method: HttpMethod.Get),
-                token);
-            return await HandleResponse<EmailSettingsData>(response);
-        }
-
-        public virtual async Task<EmailSettingsData> UpdateStoreEmailSettings(string storeId, EmailSettingsData request,
-            CancellationToken token = default)
-        {
-            using var response = await _httpClient.SendAsync(
-                CreateHttpRequest($"api/v1/stores/{storeId}/email", bodyPayload: request, method: HttpMethod.Put),
-                token);
-            return await HandleResponse<EmailSettingsData>(response);
-        }
-
-        public virtual async Task SendEmail(string storeId, SendEmailRequest request,
-            CancellationToken token = default)
-        {
-            using var response = await _httpClient.SendAsync(
-                CreateHttpRequest($"api/v1/stores/{storeId}/email/send", bodyPayload: request, method: HttpMethod.Post),
-                token);
-            await HandleResponse(response);
-        }
-    }
-}

BTCPayServer.Client/BTCPayServerClient.StoreUsers.cs

@@ -1,37 +0,0 @@
-using System;
-using System.Collections.Generic;
-using System.Net.Http;
-using System.Threading;
-using System.Threading.Tasks;
-using BTCPayServer.Client.Models;
-
-namespace BTCPayServer.Client
-{
-    public partial class BTCPayServerClient
-    {
-        public virtual async Task<IEnumerable<StoreUserData>> GetStoreUsers(string storeId,
-            CancellationToken token = default)
-        {
-            using var response = await _httpClient.SendAsync(CreateHttpRequest($"api/v1/stores/{storeId}/users"), token);
-            return await HandleResponse<IEnumerable<StoreUserData>>(response);
-        }
-
-        public virtual async Task RemoveStoreUser(string storeId, string userId, CancellationToken token = default)
-        {
-            using var response = await _httpClient.SendAsync(
-                CreateHttpRequest($"api/v1/stores/{storeId}/users/{userId}", method: HttpMethod.Delete), token);
-            await HandleResponse(response);
-        }
-
-        public virtual async Task AddStoreUser(string storeId, StoreUserData request,
-            CancellationToken token = default)
-        {
-            if (request == null)
-                throw new ArgumentNullException(nameof(request));
-            using var response = await _httpClient.SendAsync(
-                CreateHttpRequest($"api/v1/stores/{storeId}/users", bodyPayload: request, method: HttpMethod.Post),
-                token);
-            await HandleResponse(response);
-        }
-    }
-}

BTCPayServer.Client/BTCPayServerClient.Users.cs

@@ -27,27 +27,6 @@ namespace BTCPayServer.Client
             await HandleResponse(response);
         }
 
-        public virtual async Task<ApplicationUserData> GetUserByIdOrEmail(string idOrEmail, CancellationToken token = default)
-        {
-            var response = await _httpClient.SendAsync(CreateHttpRequest($"api/v1/users/{idOrEmail}", null, HttpMethod.Get), token);
-            return await HandleResponse<ApplicationUserData>(response);
-        }
-
-        public virtual async Task ToggleUser(string idOrEmail, bool enabled, CancellationToken token = default)
-        {
-            var response = await _httpClient.SendAsync(CreateHttpRequest($"api/v1/users/{idOrEmail}/toggle", null,new
-            {
-                enabled
-            } , HttpMethod.Post), token);
-            await HandleResponse(response);
-        }
-
-        public virtual async Task<ApplicationUserData[]> GetUsers( CancellationToken token = default)
-        {
-            var response = await _httpClient.SendAsync(CreateHttpRequest($"api/v1/users/", null, HttpMethod.Get), token);
-            return await HandleResponse<ApplicationUserData[]>(response);
-        }
-
         public virtual async Task DeleteCurrentUser(CancellationToken token = default)
         {
             await DeleteUser("me", token);

BTCPayServer.Client/BTCPayServerClient.cs

@@ -18,6 +18,7 @@ namespace BTCPayServer.Client
         private readonly string _username;
         private readonly string _password;
         private readonly HttpClient _httpClient;
+
         public Uri Host => _btcpayHost;
 
         public string APIKey => _apiKey;
@@ -47,25 +48,18 @@ namespace BTCPayServer.Client
 
         protected async Task HandleResponse(HttpResponseMessage message)
         {
-            if (!message.IsSuccessStatusCode && message.Content?.Headers?.ContentType?.MediaType?.StartsWith("application/json", StringComparison.OrdinalIgnoreCase) is true)
+            if (message.StatusCode == System.Net.HttpStatusCode.UnprocessableEntity)
             {
-                if (message.StatusCode == System.Net.HttpStatusCode.UnprocessableEntity)
-                {
-                    var err = JsonConvert.DeserializeObject<Models.GreenfieldValidationError[]>(await message.Content.ReadAsStringAsync());
-                    throw new GreenfieldValidationException(err);
-                }
-                if (message.StatusCode == System.Net.HttpStatusCode.Forbidden)
-                {
-                    var err = JsonConvert.DeserializeObject<Models.GreenfieldPermissionAPIError>(await message.Content.ReadAsStringAsync());
-                    throw new GreenfieldAPIException((int)message.StatusCode, err);
-                }
-                else
-                {
-                    var err = JsonConvert.DeserializeObject<Models.GreenfieldAPIError>(await message.Content.ReadAsStringAsync());
-                    if (err.Code != null)
-                        throw new GreenfieldAPIException((int)message.StatusCode, err);
-                }
+                var err = JsonConvert.DeserializeObject<Models.GreenfieldValidationError[]>(await message.Content.ReadAsStringAsync());
+                ;
+                throw new GreenFieldValidationException(err);
             }
+            else if (message.StatusCode == System.Net.HttpStatusCode.BadRequest)
+            {
+                var err = JsonConvert.DeserializeObject<Models.GreenfieldAPIError>(await message.Content.ReadAsStringAsync());
+                throw new GreenFieldAPIException(err);
+            }
+
             message.EnsureSuccessStatusCode();
         }
 
@@ -83,13 +77,6 @@ namespace BTCPayServer.Client
             using var resp = await _httpClient.SendAsync(CreateHttpRequest(path, queryPayload, method), cancellationToken);
             return await HandleResponse<T>(resp);
         }
-        public async Task<T> SendHttpRequest<T>(string path,
-        object bodyPayload = null,
-        HttpMethod method = null, CancellationToken cancellationToken = default)
-        {
-            using var resp = await _httpClient.SendAsync(CreateHttpRequest(path: path, bodyPayload: bodyPayload, method: method), cancellationToken);
-            return await HandleResponse<T>(resp);
-        }
         protected virtual HttpRequestMessage CreateHttpRequest(string path,
             Dictionary<string, object> queryPayload = null,
             HttpMethod method = null)

BTCPayServer.Client/GreenFieldAPIException.cs

@@ -2,16 +2,14 @@ using System;
 
 namespace BTCPayServer.Client
 {
-    public class GreenfieldAPIException : Exception
+    public class GreenFieldAPIException : Exception
     {
-        public GreenfieldAPIException(int httpCode, Models.GreenfieldAPIError error) : base(error.Message)
+        public GreenFieldAPIException(Models.GreenfieldAPIError error) : base(error.Message)
         {
             if (error == null)
                 throw new ArgumentNullException(nameof(error));
-            HttpCode = httpCode;
             APIError = error;
         }
         public Models.GreenfieldAPIError APIError { get; }
-        public int HttpCode { get; set; }
     }
 }

BTCPayServer.Client/GreenFieldValidationException.cs

@@ -4,9 +4,9 @@ using BTCPayServer.Client.Models;
 
 namespace BTCPayServer.Client
 {
-    public class GreenfieldValidationException : Exception
+    public class GreenFieldValidationException : Exception
     {
-        public GreenfieldValidationException(Models.GreenfieldValidationError[] errors) : base(BuildMessage(errors))
+        public GreenFieldValidationException(Models.GreenfieldValidationError[] errors) : base(BuildMessage(errors))
         {
             ValidationErrors = errors;
         }

BTCPayServer.Client/JsonConverters/MnemonicJsonConverter.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using NBitcoin;
 using NBitcoin.JsonConverters;
 using Newtonsoft.Json;

BTCPayServer.Client/JsonConverters/NodeUriJsonConverter.cs

@@ -19,7 +19,7 @@ namespace BTCPayServer.Client.JsonConverters
 
         public override void WriteJson(JsonWriter writer, [AllowNull] NodeInfo value, JsonSerializer serializer)
         {
-            if (value is not null)
+            if (value is NodeInfo)
                 writer.WriteValue(value.ToString());
         }
     }

BTCPayServer.Client/JsonConverters/NumericStringJsonConverter.cs

@@ -29,7 +29,7 @@ namespace BTCPayServer.JsonConverters
                     throw new JsonSerializationException("Unexpected object type: " + objectType);
                 case JTokenType.Integer:
                 case JTokenType.String:
-                    if (objectType == typeof(decimal) || objectType == typeof(decimal?))
+                    if (objectType == typeof(decimal) || objectType == typeof(decimal?) )
                         return decimal.Parse(token.ToString(), CultureInfo.InvariantCulture);
                     if (objectType == typeof(double) || objectType == typeof(double?))
                         return double.Parse(token.ToString(), CultureInfo.InvariantCulture);

BTCPayServer.Client/JsonConverters/TimeSpanJsonConverter.cs

@@ -29,17 +29,6 @@ namespace BTCPayServer.Client.JsonConverters
                 return TimeSpan.FromMinutes(value);
             }
         }
-        public class Days : TimeSpanJsonConverter
-        {
-            protected override long ToLong(TimeSpan value)
-            {
-                return (long)value.TotalDays;
-            }
-            protected override TimeSpan ToTimespan(long value)
-            {
-                return TimeSpan.FromDays(value);
-            }
-        }
         public override bool CanConvert(Type objectType)
         {
             return objectType == typeof(TimeSpan) || objectType == typeof(TimeSpan?);

BTCPayServer.Client/JsonConverters/WordcountJsonConverter.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using System.Reflection;

BTCPayServer.Client/JsonConverters/WordlistJsonConverter.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using System.Reflection;
@@ -21,7 +21,7 @@ public class WordlistJsonConverter : JsonConverter
             {"PortugueseBrazil", Wordlist.PortugueseBrazil},
             {"Czech", Wordlist.Czech}
         };
-
+            
         _WordlistsReverse = _Wordlists.ToDictionary(kv => kv.Value, kv => kv.Key);
     }
 

BTCPayServer.Client/Models/AddCustomerEmailRequest.cs

@@ -4,4 +4,4 @@ namespace BTCPayServer.Client.Models
     {
         public string Email { get; set; }
     }
-}
+}

BTCPayServer.Client/Models/ApplicationUserData.cs

@@ -35,7 +35,5 @@ namespace BTCPayServer.Client.Models
         /// </summary>
         [JsonConverter(typeof(NBitcoin.JsonConverters.DateTimeToUnixTimeConverter))]
         public DateTimeOffset? Created { get; set; }
-
-        public bool Disabled { get; set; }
     }
 }

BTCPayServer.Client/Models/CreateLightningInvoiceRequest.cs

@@ -1,6 +1,6 @@
 using System;
 using BTCPayServer.Lightning;
-using NBitcoin;
+using BTCPayServer.Lightning.JsonConverters;
 using Newtonsoft.Json;
 
 namespace BTCPayServer.Client.Models
@@ -11,19 +11,15 @@ namespace BTCPayServer.Client.Models
         {
 
         }
-        
         public CreateLightningInvoiceRequest(LightMoney amount, string description, TimeSpan expiry)
         {
             Amount = amount;
             Description = description;
             Expiry = expiry;
         }
-        
-        [JsonConverter(typeof(JsonConverters.LightMoneyJsonConverter))]
+        [JsonConverter(typeof(BTCPayServer.Client.JsonConverters.LightMoneyJsonConverter))]
         public LightMoney Amount { get; set; }
         public string Description { get; set; }
-        [JsonConverter(typeof(NBitcoin.JsonConverters.UInt256JsonConverter))]
-        public uint256 DescriptionHash { get; set; }
         [JsonConverter(typeof(JsonConverters.TimeSpanJsonConverter.Seconds))]
         public TimeSpan Expiry { get; set; }
         public bool PrivateRouteHints { get; set; }

BTCPayServer.Client/Models/CreateOnChainTransactionRequest.cs

@@ -18,7 +18,7 @@ namespace BTCPayServer.Client.Models
         }
         [JsonConverter(typeof(FeeRateJsonConverter))]
         public FeeRate FeeRate { get; set; }
-        public bool ProceedWithPayjoin { get; set; } = true;
+        public bool ProceedWithPayjoin { get; set; }= true;
         public bool ProceedWithBroadcast { get; set; } = true;
         public bool NoChange { get; set; } = false;
         [JsonProperty(ItemConverterType = typeof(OutpointJsonConverter))]

BTCPayServer.Client/Models/CreatePullPaymentRequest.cs

@@ -8,15 +8,11 @@ namespace BTCPayServer.Client.Models
     public class CreatePullPaymentRequest
     {
         public string Name { get; set; }
-        public string Description { get; set; }
         [JsonProperty(ItemConverterType = typeof(NumericStringJsonConverter))]
         public decimal Amount { get; set; }
         public string Currency { get; set; }
         [JsonConverter(typeof(TimeSpanJsonConverter.Seconds))]
         public TimeSpan? Period { get; set; }
-        [JsonConverter(typeof(TimeSpanJsonConverter.Days))]
-        [JsonProperty("BOLT11Expiration")]
-        public TimeSpan? BOLT11Expiration { get; set; }
         [JsonConverter(typeof(NBitcoin.JsonConverters.DateTimeToUnixTimeConverter))]
         public DateTimeOffset? ExpiresAt { get; set; }
         [JsonConverter(typeof(NBitcoin.JsonConverters.DateTimeToUnixTimeConverter))]

BTCPayServer.Client/Models/EmailSettingsData.cs

@@ -1,33 +0,0 @@
-namespace BTCPayServer.Client.Models;
-
-public class EmailSettingsData
-{
-    public string Server
-    {
-        get; set;
-    }
-
-    public int? Port
-    {
-        get; set;
-    }
-
-    public string Login
-    {
-        get; set;
-    }
-
-    public string Password
-    {
-        get; set;
-    }
-
-    public string FromDisplay
-    {
-        get; set;
-    }
-    public string From
-    {
-        get; set;
-    }
-}

BTCPayServer.Client/Models/GenerateOnChainWalletRequest.cs

@@ -1,4 +1,4 @@
-using BTCPayServer.Client.JsonConverters;
+using BTCPayServer.Client.JsonConverters;
 using NBitcoin;
 using Newtonsoft.Json;
 using Newtonsoft.Json.Converters;
@@ -8,7 +8,7 @@ namespace BTCPayServer.Client
     public class GenerateOnChainWalletRequest
     {
         public int AccountNumber { get; set; } = 0;
-        [JsonConverter(typeof(MnemonicJsonConverter))]
+        [JsonConverter(typeof(MnemonicJsonConverter))]	
         public Mnemonic ExistingMnemonic { get; set; }
         [JsonConverter(typeof(WordlistJsonConverter))]
         public NBitcoin.Wordlist WordList { get; set; }

BTCPayServer.Client/Models/GenericPaymentMethodData.cs

@@ -1,4 +1,4 @@
-namespace BTCPayServer.Client.Models
+namespace BTCPayServer.Client.Models
 {
     public class GenericPaymentMethodData
     {

BTCPayServer.Client/Models/GreenfieldPermissionAPIError.cs

@@ -1,17 +0,0 @@
-using System;
-
-namespace BTCPayServer.Client.Models
-{
-    public class GreenfieldPermissionAPIError : GreenfieldAPIError
-    {
-        public GreenfieldPermissionAPIError(string missingPermission, string message = null) : base()
-        {
-            MissingPermission = missingPermission;
-            Code = "missing-permission";
-            Message = message ?? $"Insufficient API Permissions. Please use an API key with permission \"{MissingPermission}\". You can create an API key in your account's settings / Api Keys.";
-        }
-
-        public string MissingPermission { get; }
-
-    }
-}

BTCPayServer.Client/Models/InvoiceExceptionStatus.cs

@@ -9,4 +9,4 @@ namespace BTCPayServer.Client.Models
         Invalid,
         PaidOver
     }
-}
+}

BTCPayServer.Client/Models/InvoicePaymentMethodDataModel.cs

@@ -3,7 +3,6 @@ using System.Collections.Generic;
 using BTCPayServer.JsonConverters;
 using Newtonsoft.Json;
 using Newtonsoft.Json.Converters;
-using Newtonsoft.Json.Linq;
 
 namespace BTCPayServer.Client.Models
 {
@@ -35,7 +34,6 @@ namespace BTCPayServer.Client.Models
         public string PaymentMethod { get; set; }
 
         public string CryptoCode { get; set; }
-        public JObject AdditionalData { get; set; }
 
         public class Payment
         {
@@ -54,7 +52,7 @@ namespace BTCPayServer.Client.Models
             public PaymentStatus Status { get; set; }
 
             public string Destination { get; set; }
-
+            
             public enum PaymentStatus
             {
                 Invalid,

BTCPayServer.Client/Models/LNURLPayPaymentMethodBaseData.cs

@@ -1,4 +1,4 @@
-namespace BTCPayServer.Client.Models
+namespace BTCPayServer.Client.Models
 {
     public class LNURLPayPaymentMethodBaseData
     {
@@ -8,7 +8,7 @@ namespace BTCPayServer.Client.Models
 
         public LNURLPayPaymentMethodBaseData()
         {
-
+            
         }
     }
 }

BTCPayServer.Client/Models/LNURLPayPaymentMethodData.cs

@@ -1,6 +1,6 @@
-namespace BTCPayServer.Client.Models
+namespace BTCPayServer.Client.Models
 {
-    public class LNURLPayPaymentMethodData : LNURLPayPaymentMethodBaseData
+    public class LNURLPayPaymentMethodData: LNURLPayPaymentMethodBaseData
     {
         /// <summary>
         /// Whether the payment method is enabled
@@ -16,7 +16,7 @@ namespace BTCPayServer.Client.Models
         {
         }
 
-        public LNURLPayPaymentMethodData(string cryptoCode, bool enabled, bool useBech32Scheme, bool enableForStandardInvoices)
+        public LNURLPayPaymentMethodData(string cryptoCode, bool enabled,  bool useBech32Scheme, bool enableForStandardInvoices)
         {
             Enabled = enabled;
             CryptoCode = cryptoCode;

BTCPayServer.Client/Models/LabelData.cs

@@ -11,4 +11,4 @@ namespace BTCPayServer.Client.Models
 
         [JsonExtensionData] public Dictionary<string, JToken> AdditionalData { get; set; }
     }
-}
+}

BTCPayServer.Client/Models/LightningNetworkPaymentMethodBaseData.cs

@@ -1,4 +1,4 @@
-namespace BTCPayServer.Client.Models
+namespace BTCPayServer.Client.Models
 {
     public class LightningNetworkPaymentMethodBaseData
     {
@@ -7,7 +7,7 @@ namespace BTCPayServer.Client.Models
         public bool DisableBOLT11PaymentOption { get; set; }
         public LightningNetworkPaymentMethodBaseData()
         {
-
+            
         }
     }
 }

BTCPayServer.Client/Models/LightningNetworkPaymentMethodData.cs

@@ -1,6 +1,6 @@
 namespace BTCPayServer.Client.Models
 {
-    public class LightningNetworkPaymentMethodData : LightningNetworkPaymentMethodBaseData
+    public class LightningNetworkPaymentMethodData: LightningNetworkPaymentMethodBaseData
     {
         /// <summary>
         /// Whether the payment method is enabled

BTCPayServer.Client/Models/LightningPaymentData.cs

@@ -1,32 +0,0 @@
-using System;
-using BTCPayServer.Client.JsonConverters;
-using BTCPayServer.Lightning;
-using Newtonsoft.Json;
-using Newtonsoft.Json.Converters;
-
-namespace BTCPayServer.Client.Models
-{
-    public class LightningPaymentData
-    {
-        public string Id { get; set; }
-
-        public string PaymentHash { get; set; }
-
-        [JsonConverter(typeof(StringEnumConverter))]
-        public LightningPaymentStatus Status { get; set; }
-
-        [JsonProperty("BOLT11")]
-        public string BOLT11 { get; set; }
-        
-        public string Preimage { get; set; }
-
-        [JsonConverter(typeof(NBitcoin.JsonConverters.DateTimeToUnixTimeConverter))]
-        public DateTimeOffset? CreatedAt { get; set; }
-        
-        [JsonConverter(typeof(LightMoneyJsonConverter))]
-        public LightMoney TotalAmount { get; set; }
-
-        [JsonConverter(typeof(LightMoneyJsonConverter))]
-        public LightMoney FeeAmount { get; set; }
-    }
-}

BTCPayServer.Client/Models/OnChainPaymentMethodBaseData.cs

@@ -1,4 +1,4 @@
-using NBitcoin;
+using NBitcoin;
 using Newtonsoft.Json;
 
 namespace BTCPayServer.Client.Models
@@ -19,6 +19,6 @@ namespace BTCPayServer.Client.Models
         {
         }
 
-
+        
     }
 }

BTCPayServer.Client/Models/OnChainPaymentMethodData.cs

@@ -11,7 +11,7 @@ namespace BTCPayServer.Client.Models
 
         public OnChainPaymentMethodDataPreview()
         {
-
+            
         }
 
         public OnChainPaymentMethodDataPreview(string cryptoCode, string derivationScheme, string label, RootedKeyPath accountKeyPath)
@@ -34,7 +34,7 @@ namespace BTCPayServer.Client.Models
 
         public OnChainPaymentMethodData()
         {
-
+            
         }
 
         public OnChainPaymentMethodData(string cryptoCode, string derivationScheme, bool enabled, string label, RootedKeyPath accountKeyPath, string paymentMethod) :

BTCPayServer.Client/Models/OnChainPaymentMethodDataWithSensitiveData.cs

@@ -1,4 +1,4 @@
-using BTCPayServer.Client.JsonConverters;
+using BTCPayServer.Client.JsonConverters;
 using NBitcoin;
 using Newtonsoft.Json;
 

BTCPayServer.Client/Models/OnChainWalletTransactionData.cs

@@ -21,9 +21,9 @@ namespace BTCPayServer.Client.Models
         [JsonConverter(typeof(UInt256JsonConverter))]
         public uint256 BlockHash { get; set; }
 
-        public long? BlockHeight { get; set; }
+        public int? BlockHeight { get; set; }
 
-        public long Confirmations { get; set; }
+        public int Confirmations { get; set; }
 
         [JsonConverter(typeof(DateTimeToUnixTimeConverter))]
         public DateTimeOffset Timestamp { get; set; }

BTCPayServer.Client/Models/OnChainWalletUTXOData.cs

@@ -21,6 +21,6 @@ namespace BTCPayServer.Client.Models
         [JsonConverter(typeof(KeyPathJsonConverter))]
         public KeyPath KeyPath { get; set; }
         public string Address { get; set; }
-        public long Confirmations { get; set; }
+        public int Confirmations { get; set; }
     }
 }

BTCPayServer.Client/Models/PatchOnChainTransactionRequest.cs

@@ -1,12 +0,0 @@
-#nullable enable
-using System.Collections.Generic;
-
-namespace BTCPayServer.Client.Models
-{
-    public class PatchOnChainTransactionRequest
-    {
-
-        public string? Comment { get; set; } = null;
-        public List<string>? Labels { get; set; } = null;
-    }
-}

BTCPayServer.Client/Models/PayLightningInvoiceRequest.cs

@@ -1,20 +1,8 @@
-#nullable enable
-using BTCPayServer.Client.JsonConverters;
-using BTCPayServer.JsonConverters;
-using NBitcoin;
-using Newtonsoft.Json;
-
 namespace BTCPayServer.Client.Models
 {
     public class PayLightningInvoiceRequest
     {
-        [JsonProperty("BOLT11")]
+        [Newtonsoft.Json.JsonProperty("BOLT11")]
         public string BOLT11 { get; set; }
-        
-        [JsonProperty(ItemConverterType = typeof(NumericStringJsonConverter))]
-        public float? MaxFeePercent { get; set; }
-        
-        [JsonConverter(typeof(MoneyJsonConverter))]
-        public Money? MaxFeeFlat { get; set; }
     }
 }

BTCPayServer.Client/Models/PaymentRequestBaseData.cs

@@ -8,12 +8,10 @@ namespace BTCPayServer.Client.Models
 {
     public class PaymentRequestBaseData
     {
-        public string StoreId { get; set; }
         [JsonProperty(ItemConverterType = typeof(NumericStringJsonConverter))]
         public decimal Amount { get; set; }
         public string Currency { get; set; }
-        [JsonConverter(typeof(NBitcoin.JsonConverters.DateTimeToUnixTimeConverter))]
-        public DateTimeOffset? ExpiryDate { get; set; }
+        public DateTime? ExpiryDate { get; set; }
         public string Title { get; set; }
         public string Description { get; set; }
         public string Email { get; set; }

BTCPayServer.Client/Models/PaymentRequestData.cs

@@ -8,8 +8,7 @@ namespace BTCPayServer.Client.Models
     {
         [JsonConverter(typeof(StringEnumConverter))]
         public PaymentRequestData.PaymentRequestStatus Status { get; set; }
-        [JsonConverter(typeof(NBitcoin.JsonConverters.DateTimeToUnixTimeConverter))]
-        public DateTimeOffset CreatedTime { get; set; }
+        public DateTimeOffset Created { get; set; }
         public string Id { get; set; }
         public bool Archived { get; set; }
 

BTCPayServer.Client/Models/PullPaymentBaseData.cs

@@ -5,13 +5,6 @@ using Newtonsoft.Json;
 
 namespace BTCPayServer.Client.Models
 {
-    public enum PullPaymentState
-    {
-        Active,
-        Expired,
-        Archived,
-        Future
-    }
     public class PullPaymentData
     {
         [JsonConverter(typeof(NBitcoin.JsonConverters.DateTimeToUnixTimeConverter))]
@@ -20,15 +13,11 @@ namespace BTCPayServer.Client.Models
         public DateTimeOffset? ExpiresAt { get; set; }
         public string Id { get; set; }
         public string Name { get; set; }
-        public string Description { get; set; }
         public string Currency { get; set; }
         [JsonConverter(typeof(NumericStringJsonConverter))]
         public decimal Amount { get; set; }
         [JsonConverter(typeof(TimeSpanJsonConverter.Seconds))]
         public TimeSpan? Period { get; set; }
-        [JsonConverter(typeof(TimeSpanJsonConverter.Days))]
-        [JsonProperty("BOLT11Expiration")]
-        public TimeSpan BOLT11Expiration { get; set; }
         public bool Archived { get; set; }
         public string ViewLink { get; set; }
     }

BTCPayServer.Client/Models/SendEmailRequest.cs

@@ -1,10 +0,0 @@
-
-namespace BTCPayServer.Client.Models
-{
-    public class SendEmailRequest
-    {
-        public string Email;
-        public string Subject;
-        public string Body;
-    }
-}

BTCPayServer.Client/Models/ServerInfoData.cs

@@ -29,14 +29,14 @@ namespace BTCPayServer.Client.Models
         /// </summary>
         public IEnumerable<SyncStatus> SyncStatus { get; set; }
     }
-
+    
     public class SyncStatus
     {
         public string CryptoCode { get; set; }
         public virtual bool Available { get; set; }
     }
 
-    public class ServerInfoSyncStatusData : SyncStatus
+    public class ServerInfoSyncStatusData: SyncStatus
     {
         public int ChainHeight { get; set; }
         public int? SyncHeight { get; set; }

BTCPayServer.Client/Models/StoreBaseData.cs

@@ -41,9 +41,9 @@ namespace BTCPayServer.Client.Models
         public bool ShowRecommendedFee { get; set; } = true;
         [JsonProperty(NullValueHandling = NullValueHandling.Ignore)]
         public int RecommendedFeeBlockTarget { get; set; } = 1;
-
+        
         public string DefaultPaymentMethod { get; set; }
-
+        
         [JsonProperty(NullValueHandling = NullValueHandling.Ignore)]
         public string DefaultLang { get; set; } = "en";
 

BTCPayServer.Client/Models/StoreData.cs

@@ -7,14 +7,4 @@ namespace BTCPayServer.Client.Models
         /// </summary>
         public string Id { get; set; }
     }
-    
-    public class StoreUserData
-    {
-        /// <summary>
-        /// the id of the user
-        /// </summary>
-        public string UserId { get; set; }
-
-        public string Role { get; set; }
-    }
 }

BTCPayServer.Client/Models/TransactionStatus.cs

@@ -6,4 +6,4 @@ namespace BTCPayServer.Client.Models
         Confirmed,
         Replaced
     }
-}
+}

BTCPayServer.Client/Models/UpdateLightningNetworkPaymentMethodRequest.cs

@@ -1,6 +1,6 @@
 namespace BTCPayServer.Client.Models
 {
-    public class UpdateLightningNetworkPaymentMethodRequest : LightningNetworkPaymentMethodBaseData
+    public class UpdateLightningNetworkPaymentMethodRequest: LightningNetworkPaymentMethodBaseData
     {
         /// <summary>
         /// Whether the payment method is enabled

BTCPayServer.Client/Models/UpdateOnChainPaymentMethodRequest.cs

@@ -11,7 +11,7 @@ namespace BTCPayServer.Client.Models
 
         public UpdateOnChainPaymentMethodRequest()
         {
-
+            
         }
 
         public UpdateOnChainPaymentMethodRequest(bool enabled, string derivationScheme, string label, RootedKeyPath accountKeyPath)

BTCPayServer.Client/Permissions.cs

@@ -24,7 +24,6 @@ namespace BTCPayServer.Client
         public const string CanViewProfile = "btcpay.user.canviewprofile";
         public const string CanManageNotificationsForUser = "btcpay.user.canmanagenotificationsforuser";
         public const string CanViewNotificationsForUser = "btcpay.user.canviewnotificationsforuser";
-        public const string CanViewUsers = "btcpay.server.canviewusers";
         public const string CanCreateUser = "btcpay.server.cancreateuser";
         public const string CanDeleteUser = "btcpay.user.candeleteuser";
         public const string CanManagePullPayments = "btcpay.store.canmanagepullpayments";
@@ -44,7 +43,6 @@ namespace BTCPayServer.Client
                 yield return CanModifyPaymentRequests;
                 yield return CanModifyProfile;
                 yield return CanViewProfile;
-                yield return CanViewUsers;
                 yield return CanCreateUser;
                 yield return CanDeleteUser;
                 yield return CanManageNotificationsForUser;
@@ -177,9 +175,7 @@ namespace BTCPayServer.Client
                 case Policies.CanViewProfile when this.Policy == Policies.CanModifyProfile:
                 case Policies.CanModifyPaymentRequests when this.Policy == Policies.CanModifyStoreSettings:
                 case Policies.CanViewPaymentRequests when this.Policy == Policies.CanModifyStoreSettings:
-                case Policies.CanManagePullPayments when this.Policy == Policies.CanModifyStoreSettings:
                 case Policies.CanViewPaymentRequests when this.Policy == Policies.CanViewStoreSettings:
-                case Policies.CanViewPaymentRequests when this.Policy == Policies.CanModifyPaymentRequests:
                 case Policies.CanCreateLightningInvoiceInternalNode when this.Policy == Policies.CanUseInternalLightningNode:
                 case Policies.CanCreateLightningInvoiceInStore when this.Policy == Policies.CanUseLightningNodeInStore:
                 case Policies.CanViewNotificationsForUser when this.Policy == Policies.CanManageNotificationsForUser:

BTCPayServer.Common/Altcoins/BTCPayNetworkProvider.Althash.cs

@@ -11,7 +11,7 @@ namespace BTCPayServer
             Add(new BTCPayNetwork()
             {
                 CryptoCode = nbxplorerNetwork.CryptoCode,
-                DisplayName = "Htmlcoin",
+                DisplayName = "Althash",
                 BlockExplorerLink = NetworkType == ChainName.Mainnet ? "https://explorer.htmlcoin.com/api/tx/{0}" : "https://explorer.htmlcoin.com/api/tx/{0}",
                 NBXplorerNetwork = nbxplorerNetwork,
                 DefaultRateRules = new[]
@@ -21,7 +21,7 @@ namespace BTCPayServer
                 },
                 CryptoImagePath = "imlegacy/althash.png",
                 DefaultSettings = BTCPayDefaultSettings.GetDefaultSettings(NetworkType),
-                CoinType = NetworkType == ChainName.Mainnet ? new KeyPath("172'") : new KeyPath("1'")
+                CoinType = NetworkType == ChainName.Mainnet ? new KeyPath("88'") : new KeyPath("1'")
             });
         }
     }

BTCPayServer.Common/Altcoins/Ethereum/BTCPayNetworkProvider.Ethereum.cs

@@ -0,0 +1,78 @@
+#if ALTCOINS
+using NBitcoin;
+
+namespace BTCPayServer
+{
+    public partial class BTCPayNetworkProvider
+    {
+        public void InitEthereum()
+        {
+            Add(new EthereumBTCPayNetwork()
+            {
+                CryptoCode = "ETH",
+                DisplayName = "Ethereum",
+                DefaultRateRules = new[] {"ETH_X = ETH_BTC * BTC_X", "ETH_BTC = kraken(ETH_BTC)"},
+                BlockExplorerLink =
+                    NetworkType == ChainName.Mainnet
+                        ? "https://etherscan.io/address/{0}"
+                        : "https://ropsten.etherscan.io/address/{0}",
+                CryptoImagePath = "/imlegacy/eth.png",
+                ShowSyncSummary = true,
+                CoinType = NetworkType == ChainName.Mainnet? 60 : 1,
+                ChainId = NetworkType == ChainName.Mainnet ? 1 : 3,
+                Divisibility = 18,
+            });
+        }
+        
+        public void InitERC20()
+        {
+            if (NetworkType != ChainName.Mainnet)
+            {
+                Add(new ERC20BTCPayNetwork()
+                {
+                    CryptoCode = "FAU",
+                    DisplayName = "Faucet Token",
+                    DefaultRateRules = new[]
+                    {
+                        "FAU_X = FAU_BTC * BTC_X",
+                        "FAU_BTC = 0.01",
+                    },
+                    BlockExplorerLink = "https://ropsten.etherscan.io/address/{0}#tokentxns",
+                    ShowSyncSummary = false,
+                    CoinType =  1,
+                    ChainId =  3,
+                    //use https://erc20faucet.com for testnet
+                    SmartContractAddress = "0xFab46E002BbF0b4509813474841E0716E6730136",
+                    Divisibility = 18,
+                    CryptoImagePath = "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII=",
+                });
+            }
+            else
+            {
+                Add(new ERC20BTCPayNetwork()
+                {
+                    CryptoCode = "USDT20",
+                    DisplayName = "Tether USD (ERC20)",
+                    DefaultRateRules = new[]
+                    {
+                        "USDT20_UST = 1",
+                        "USDT20_X = USDT20_BTC * BTC_X",
+                        "USDT20_BTC = bitfinex(UST_BTC)",
+                    },
+                    BlockExplorerLink =
+                        NetworkType == ChainName.Mainnet
+                            ? "https://etherscan.io/address/{0}#tokentxns"
+                            : "https://ropsten.etherscan.io/address/{0}#tokentxns",
+                    CryptoImagePath = "/imlegacy/liquid-tether.svg",
+                    ShowSyncSummary = false,
+                    CoinType = NetworkType == ChainName.Mainnet? 60 : 1,
+                    ChainId = NetworkType == ChainName.Mainnet ? 1 : 3,
+                    SmartContractAddress = "0xdAC17F958D2ee523a2206206994597C13D831ec7",
+                    Divisibility = 6
+                });
+            }
+            
+        }
+    }
+}
+#endif

BTCPayServer.Common/Altcoins/Ethereum/EthereumBTCPayNetwork.cs

@@ -0,0 +1,20 @@
+#if ALTCOINS
+namespace BTCPayServer
+{
+    public class EthereumBTCPayNetwork : BTCPayNetworkBase
+    {
+        public int ChainId { get; set; }
+        public int CoinType { get; set; }
+
+        public string GetDefaultKeyPath()
+        {
+            return $"m/44'/{CoinType}'/0'/0/x";
+        }
+    }
+
+    public class ERC20BTCPayNetwork : EthereumBTCPayNetwork
+    {
+        public string SmartContractAddress { get; set; }
+    }
+}
+#endif

BTCPayServer.Common/Altcoins/Ethereum/EthereumExtensions.cs

@@ -0,0 +1,20 @@
+#if ALTCOINS
+using System.Collections.Generic;
+using System.Linq;
+
+namespace BTCPayServer
+{
+    public static class EthereumExtensions
+    {
+        
+        public static IEnumerable<string> GetAllEthereumSubChains(this BTCPayNetworkProvider networkProvider, BTCPayNetworkProvider unfiltered)
+        {
+            var ethBased = networkProvider.GetAll().OfType<EthereumBTCPayNetwork>();
+            var chainId = ethBased.Select(network => network.ChainId).Distinct();
+            return unfiltered.GetAll().OfType<EthereumBTCPayNetwork>()
+                .Where(network => chainId.Contains(network.ChainId))
+                .Select(network => network.CryptoCode.ToUpperInvariant());
+        }
+    }
+}
+#endif

BTCPayServer.Common/Altcoins/Zcash/BTCPayNetworkProvider.Zcash.cs

@@ -1,29 +0,0 @@
-using NBitcoin;
-
-namespace BTCPayServer
-{
-    public partial class BTCPayNetworkProvider
-    {
-        // Change this if you want another zcash coin
-        public void InitZcash()
-        {
-            Add(new ZcashLikeSpecificBtcPayNetwork()
-            {
-                CryptoCode = "ZEC",
-                DisplayName = "Zcash",
-                Divisibility = 8,
-                BlockExplorerLink =
-                    NetworkType == ChainName.Mainnet
-                        ? "https://www.exploreZcash.com/transaction/{0}"
-                        : "https://testnet.xmrchain.net/tx/{0}",
-                DefaultRateRules = new[]
-                {
-                    "ZEC_X = ZEC_BTC * BTC_X",
-                    "ZEC_BTC = kraken(ZEC_BTC)"
-                },
-                CryptoImagePath = "/imlegacy/zcash.png",
-                UriScheme = "zcash"
-            });
-        }
-    }
-}

BTCPayServer.Common/Altcoins/Zcash/RPC/JsonRpcClient.cs

@@ -1,102 +0,0 @@
-using System;
-using System.Net.Http;
-using System.Net.Http.Headers;
-using System.Text;
-using System.Threading;
-using System.Threading.Tasks;
-using Newtonsoft.Json;
-using Newtonsoft.Json.Serialization;
-
-namespace BTCPayServer.Services.Altcoins.Zcash.RPC
-{
-    public class JsonRpcClient
-    {
-        private readonly Uri _address;
-        private readonly string _username;
-        private readonly string _password;
-        private readonly HttpClient _httpClient;
-
-        public JsonRpcClient(Uri address, string username, string password, HttpClient client = null)
-        {
-            _address = address;
-            _username = username;
-            _password = password;
-            _httpClient = client ?? new HttpClient();
-        }
-
-
-        public async Task<TResponse> SendCommandAsync<TRequest, TResponse>(string method, TRequest data,
-            CancellationToken cts = default(CancellationToken))
-        {
-            var jsonSerializer = new JsonSerializerSettings
-            {
-                ContractResolver = new CamelCasePropertyNamesContractResolver()
-            };
-            var httpRequest = new HttpRequestMessage()
-            {
-                Method = HttpMethod.Post,
-                RequestUri = new Uri(_address, method),
-                Content = new StringContent(
-                    JsonConvert.SerializeObject(data, jsonSerializer),
-                    Encoding.UTF8, "application/json")
-            };
-            // httpRequest.Headers.Accept.Clear();
-            // httpRequest.Headers.Accept.Add(new MediaTypeWithQualityHeaderValue("application/json"));
-            // httpRequest.Headers.Authorization = new AuthenticationHeaderValue("Basic",
-            //     Convert.ToBase64String(Encoding.Default.GetBytes($"{_username}:{_password}")));
-
-            var rawResult = await _httpClient.SendAsync(httpRequest, cts);
-
-            var rawJson = await rawResult.Content.ReadAsStringAsync();
-            rawResult.EnsureSuccessStatusCode();
-            var response = JsonConvert.DeserializeObject<TResponse>(rawJson, jsonSerializer);
-            return response;
-        }
-
-        public class NoRequestModel
-        {
-            public static NoRequestModel Instance = new NoRequestModel();
-        }
-
-        internal class JsonRpcApiException : Exception
-        {
-            public JsonRpcResultError Error { get; set; }
-
-            public override string Message => Error?.Message;
-        }
-
-        public class JsonRpcResultError
-        {
-            [JsonProperty("code")] public int Code { get; set; }
-            [JsonProperty("message")] public string Message { get; set; }
-            [JsonProperty("data")] dynamic Data { get; set; }
-        }
-        internal class JsonRpcResult<T>
-        {
-
-
-            [JsonProperty("result")] public T Result { get; set; }
-            [JsonProperty("error")] public JsonRpcResultError Error { get; set; }
-            [JsonProperty("id")] public string Id { get; set; }
-        }
-
-        internal class JsonRpcCommand<T>
-        {
-            [JsonProperty("jsonRpc")] public string JsonRpc { get; set; } = "2.0";
-            [JsonProperty("id")] public string Id { get; set; } = Guid.NewGuid().ToString();
-            [JsonProperty("method")] public string Method { get; set; }
-
-            [JsonProperty("params")] public T Parameters { get; set; }
-
-            public JsonRpcCommand()
-            {
-            }
-
-            public JsonRpcCommand(string method, T parameters)
-            {
-                Method = method;
-                Parameters = parameters;
-            }
-        }
-    }
-}

BTCPayServer.Common/Altcoins/Zcash/RPC/Models/CreateAccountRequest.cs

@@ -1,9 +0,0 @@
-using Newtonsoft.Json;
-
-namespace BTCPayServer.Services.Altcoins.Zcash.RPC.Models
-{
-    public partial class CreateAccountRequest
-    {
-        [JsonProperty("label")] public string Label { get; set; }
-    }
-}

BTCPayServer.Common/Altcoins/Zcash/RPC/Models/CreateAccountResponse.cs

@@ -1,10 +0,0 @@
-using Newtonsoft.Json;
-
-namespace BTCPayServer.Services.Altcoins.Zcash.RPC.Models
-{
-    public partial class CreateAccountResponse
-    {
-        [JsonProperty("account_index")] public long AccountIndex { get; set; }
-        [JsonProperty("address")] public string Address { get; set; }
-    }
-}

BTCPayServer.Common/Altcoins/Zcash/RPC/Models/CreateAddressRequest.cs

@@ -1,10 +0,0 @@
-using Newtonsoft.Json;
-
-namespace BTCPayServer.Services.Altcoins.Zcash.RPC.Models
-{
-    public partial class CreateAddressRequest
-    {
-        [JsonProperty("account_index")] public long AccountIndex { get; set; }
-        [JsonProperty("label")] public string Label { get; set; }
-    }
-}

BTCPayServer.Common/Altcoins/Zcash/RPC/Models/CreateAddressResponse.cs

@@ -1,10 +0,0 @@
-using Newtonsoft.Json;
-
-namespace BTCPayServer.Services.Altcoins.Zcash.RPC.Models
-{
-    public partial class CreateAddressResponse
-    {
-        [JsonProperty("address")] public string Address { get; set; }
-        [JsonProperty("address_index")] public long AddressIndex { get; set; }
-    }
-}

BTCPayServer.Common/Altcoins/Zcash/RPC/Models/GetAccountsRequest.cs

@@ -1,9 +0,0 @@
-using Newtonsoft.Json;
-
-namespace BTCPayServer.Services.Altcoins.Zcash.RPC.Models
-{
-    public partial class GetAccountsRequest
-    {
-        [JsonProperty("tag")] public string Tag { get; set; }
-    }
-}

BTCPayServer.Common/Altcoins/Zcash/RPC/Models/GetAccountsResponse.cs

@@ -1,14 +0,0 @@
-using System.Collections.Generic;
-using Newtonsoft.Json;
-
-namespace BTCPayServer.Services.Altcoins.Zcash.RPC.Models
-{
-    public partial class GetAccountsResponse
-    {
-        [JsonProperty("subaddress_accounts")] public List<SubaddressAccount> SubaddressAccounts { get; set; }
-        [JsonProperty("total_balance")] public decimal TotalBalance { get; set; }
-
-        [JsonProperty("total_unlocked_balance")]
-        public decimal TotalUnlockedBalance { get; set; }
-    }
-}

BTCPayServer.Common/Altcoins/Zcash/RPC/Models/GetFeeEstimateRequest.cs

@@ -1,9 +0,0 @@
-using Newtonsoft.Json;
-
-namespace BTCPayServer.Services.Altcoins.Zcash.RPC.Models
-{
-    public class GetFeeEstimateRequest
-    {
-        [JsonProperty("grace_blocks")] public int? GraceBlocks { get; set; }
-    }
-}

BTCPayServer.Common/Altcoins/Zcash/RPC/Models/GetFeeEstimateResponse.cs

@@ -1,11 +0,0 @@
-using Newtonsoft.Json;
-
-namespace BTCPayServer.Services.Altcoins.Zcash.RPC.Models
-{
-    public class GetFeeEstimateResponse
-    {
-        [JsonProperty("fee")] public long Fee { get; set; }
-        [JsonProperty("status")] public string Status { get; set; }
-        [JsonProperty("untrusted")] public bool Untrusted { get; set; }
-    }
-}

BTCPayServer.Common/Altcoins/Zcash/RPC/Models/GetHeightResponse.cs

@@ -1,9 +0,0 @@
-using Newtonsoft.Json;
-
-namespace BTCPayServer.Services.Altcoins.Zcash.RPC.Models
-{
-    public partial class GetHeightResponse
-    {
-        [JsonProperty("height")] public long Height { get; set; }
-    }
-}

BTCPayServer.Common/Altcoins/Zcash/RPC/Models/GetTransferByTransactionIdRequest.cs

@@ -1,11 +0,0 @@
-using Newtonsoft.Json;
-
-namespace BTCPayServer.Services.Altcoins.Zcash.RPC.Models
-{
-    public class GetTransferByTransactionIdRequest
-    {
-        [JsonProperty("txid")] public string TransactionId { get; set; }
-
-        [JsonProperty("account_index")] public long AccountIndex { get; set; }
-    }
-}

BTCPayServer.Common/Altcoins/Zcash/RPC/Models/GetTransferByTransactionIdResponse.cs

@@ -1,31 +0,0 @@
-using System.Collections.Generic;
-using Newtonsoft.Json;
-
-namespace BTCPayServer.Services.Altcoins.Zcash.RPC.Models
-{
-    public partial class GetTransferByTransactionIdResponse
-    {
-        [JsonProperty("transfer")] public TransferItem Transfer { get; set; }
-        [JsonProperty("transfers")] public IEnumerable<TransferItem> Transfers { get; set; }
-
-        public partial class TransferItem
-        {
-            [JsonProperty("address")] public string Address { get; set; }
-            [JsonProperty("amount")] public long Amount { get; set; }
-            [JsonProperty("confirmations")] public long Confirmations { get; set; }
-            [JsonProperty("double_spend_seen")] public bool DoubleSpendSeen { get; set; }
-            [JsonProperty("height")] public long Height { get; set; }
-            [JsonProperty("note")] public string Note { get; set; }
-            [JsonProperty("payment_id")] public string PaymentId { get; set; }
-            [JsonProperty("subaddr_index")] public SubaddrIndex SubaddrIndex { get; set; }
-
-            [JsonProperty("suggested_confirmations_threshold")]
-            public long SuggestedConfirmationsThreshold { get; set; }
-
-            [JsonProperty("timestamp")] public long Timestamp { get; set; }
-            [JsonProperty("txid")] public string Txid { get; set; }
-            [JsonProperty("type")] public string Type { get; set; }
-            [JsonProperty("unlock_time")] public long UnlockTime { get; set; }
-        }
-    }
-}

BTCPayServer.Common/Altcoins/Zcash/RPC/Models/GetTransfersRequest.cs

@@ -1,19 +0,0 @@
-using System.Collections.Generic;
-using Newtonsoft.Json;
-
-namespace BTCPayServer.Services.Altcoins.Zcash.RPC.Models
-{
-    public partial class GetTransfersRequest
-    {
-        [JsonProperty("in")] public bool In { get; set; }
-        [JsonProperty("out")] public bool Out { get; set; }
-        [JsonProperty("pending")] public bool Pending { get; set; }
-        [JsonProperty("failed")] public bool Failed { get; set; }
-        [JsonProperty("pool")] public bool Pool { get; set; }
-        [JsonProperty("filter_by_height ")] public bool FilterByHeight { get; set; }
-        [JsonProperty("min_height")] public long MinHeight { get; set; }
-        [JsonProperty("max_height")] public long MaxHeight { get; set; }
-        [JsonProperty("account_index")] public long AccountIndex { get; set; }
-        [JsonProperty("subaddr_indices")] public List<long> SubaddrIndices { get; set; }
-    }
-}

BTCPayServer.Common/Altcoins/Zcash/RPC/Models/GetTransfersResponse.cs

@@ -1,35 +0,0 @@
-using System.Collections.Generic;
-using Newtonsoft.Json;
-
-namespace BTCPayServer.Services.Altcoins.Zcash.RPC.Models
-{
-    public partial class GetTransfersResponse
-    {
-        [JsonProperty("in")] public List<GetTransfersResponseItem> In { get; set; }
-        [JsonProperty("out")] public List<GetTransfersResponseItem> Out { get; set; }
-        [JsonProperty("pending")] public List<GetTransfersResponseItem> Pending { get; set; }
-        [JsonProperty("failed")] public List<GetTransfersResponseItem> Failed { get; set; }
-        [JsonProperty("pool")] public List<GetTransfersResponseItem> Pool { get; set; }
-
-        public partial class GetTransfersResponseItem
-
-        {
-            [JsonProperty("address")] public string Address { get; set; }
-            [JsonProperty("amount")] public long Amount { get; set; }
-            [JsonProperty("confirmations")] public long Confirmations { get; set; }
-            [JsonProperty("double_spend_seen")] public bool DoubleSpendSeen { get; set; }
-            [JsonProperty("height")] public long Height { get; set; }
-            [JsonProperty("note")] public string Note { get; set; }
-            [JsonProperty("payment_id")] public string PaymentId { get; set; }
-            [JsonProperty("subaddr_index")] public SubaddrIndex SubaddrIndex { get; set; }
-
-            [JsonProperty("suggested_confirmations_threshold")]
-            public long SuggestedConfirmationsThreshold { get; set; }
-
-            [JsonProperty("timestamp")] public long Timestamp { get; set; }
-            [JsonProperty("txid")] public string Txid { get; set; }
-            [JsonProperty("type")] public string Type { get; set; }
-            [JsonProperty("unlock_time")] public long UnlockTime { get; set; }
-        }
-    }
-}