[Fix] Querying rate with authenticated request should be successfull

BTCPayServer.Tests/UnitTest1.cs

@@ -641,6 +641,13 @@ namespace BTCPayServer.Tests
                 Assert.NotNull(GetCurrencyPairRateResult);
                 Assert.NotNull(GetCurrencyPairRateResult.Data);
                 Assert.Equal("LTC", GetCurrencyPairRateResult.Data.Code);
+
+                // Should be OK because the request is signed, so we can know the store
+                var rates = acc.BitPay.GetRates();
+                HttpClient client = new HttpClient();
+                // Unauthentified requests should also be ok
+                var response = client.GetAsync($"http://127.0.0.1:{tester.PayTester.Port}/api/rates?storeId={acc.StoreId}").GetAwaiter().GetResult();
+                response.EnsureSuccessStatusCode();
             }
         }
 

BTCPayServer/BTCPayServer.csproj

@@ -2,7 +2,7 @@
   <PropertyGroup>
     <OutputType>Exe</OutputType>
     <TargetFramework>netcoreapp2.1</TargetFramework>
-		<Version>1.0.2.110</Version>
+		<Version>1.0.2.112</Version>
     <NoWarn>NU1701,CA1816,CA1308,CA1810,CA2208</NoWarn>
   </PropertyGroup>
   <PropertyGroup>

BTCPayServer/Controllers/RateController.cs

@@ -10,23 +10,32 @@ using BTCPayServer.Services.Rates;
 using BTCPayServer.Services.Stores;
 using BTCPayServer.Rating;
 using Newtonsoft.Json;
+using Microsoft.AspNetCore.Authorization;
+using BTCPayServer.Authentication;
 
 namespace BTCPayServer.Controllers
 {
+    [Authorize(AuthenticationSchemes = Security.Policies.BitpayAuthentication)]
+    [AllowAnonymous]
     public class RateController : Controller
     {
         RateFetcher _RateProviderFactory;
         BTCPayNetworkProvider _NetworkProvider;
         CurrencyNameTable _CurrencyNameTable;
         StoreRepository _StoreRepo;
+
+        public TokenRepository TokenRepository { get; }
+
         public RateController(
             RateFetcher rateProviderFactory,
             BTCPayNetworkProvider networkProvider,
+            TokenRepository tokenRepository,
             StoreRepository storeRepo,
             CurrencyNameTable currencyNameTable)
         {
             _RateProviderFactory = rateProviderFactory ?? throw new ArgumentNullException(nameof(rateProviderFactory));
             _NetworkProvider = networkProvider;
+            TokenRepository = tokenRepository;
             _StoreRepo = storeRepo;
             _CurrencyNameTable = currencyNameTable ?? throw new ArgumentNullException(nameof(currencyNameTable));
         }
@@ -36,7 +45,7 @@ namespace BTCPayServer.Controllers
         [BitpayAPIConstraint]
         public async Task<IActionResult> GetBaseCurrencyRates(string baseCurrency, string storeId)
         {
-            storeId = storeId ?? this.HttpContext.GetStoreData()?.Id;
+            storeId = await GetStoreId(storeId);
             var store = this.HttpContext.GetStoreData();
             if (store == null || store.Id != storeId)
                 store = await _StoreRepo.FindStore(storeId);
@@ -66,7 +75,7 @@ namespace BTCPayServer.Controllers
         [BitpayAPIConstraint]
         public async Task<IActionResult> GetCurrencyPairRate(string baseCurrency, string currency, string storeId)
         {
-            storeId = storeId ?? this.HttpContext.GetStoreData()?.Id;
+            storeId = await GetStoreId(storeId);
             var result = await GetRates2($"{baseCurrency}_{currency}", storeId);
             var rates = (result as JsonResult)?.Value as Rate[];
             if (rates == null)
@@ -79,7 +88,7 @@ namespace BTCPayServer.Controllers
         [BitpayAPIConstraint]
         public async Task<IActionResult> GetRates(string currencyPairs, string storeId)
         {
-            storeId = storeId ?? this.HttpContext.GetStoreData()?.Id;
+            storeId = await GetStoreId(storeId);
             var result = await GetRates2(currencyPairs, storeId);
             var rates = (result as JsonResult)?.Value as Rate[];
             if (rates == null)
@@ -87,11 +96,29 @@ namespace BTCPayServer.Controllers
             return Json(new DataWrapper<Rate[]>(rates));
         }
 
+        private async Task<string> GetStoreId(string storeId)
+        {
+            if (storeId != null && this.HttpContext.GetStoreData()?.Id == storeId)
+                return storeId;
+            if(storeId == null)
+            {
+                var tokens = await this.TokenRepository.GetTokens(this.User.GetSIN());
+                storeId = tokens.Select(s => s.StoreId).Where(s => s != null).FirstOrDefault();
+            }
+            if (storeId == null)
+                return null;
+            var store = await _StoreRepo.FindStore(storeId);
+            if (store == null)
+                return null;
+            this.HttpContext.SetStoreData(store);
+            return storeId;
+        }
 
         [Route("api/rates")]
         [HttpGet]
         public async Task<IActionResult> GetRates2(string currencyPairs, string storeId)
         {
+            storeId = await GetStoreId(storeId);
             if (storeId == null)
             {
                 var result = Json(new BitpayErrorsModel() { Error = "You need to specify storeId (in your store settings)" });

BTCPayServer/Services/LanguageService.cs

@@ -33,6 +33,7 @@ namespace BTCPayServer.Services
                 new Language("cs-CZ", "Česky"),
                 new Language("is-IS", "Íslenska"),
                 new Language("hr-HR", "Croatian"),
+                new Language("it-IT", "Italiano"),
                 new Language("ru-RU", "русский"),
                 new Language("zh-SP", "中文（简体）"),
             };

BTCPayServer/Views/Invoice/Checkout-Body.cshtml

@@ -190,8 +190,14 @@
     <div class="bp-view payment scan" id="scan">
         <div class="wrapBtnGroup" v-bind:class="{ invisible: lndModel === null }">
             <div class="btnGroupLnd">
-                <button onclick="lndToggleBolt11()" v-bind:class="{ active: lndModel != null && lndModel.toggle === 0 }">{{$t("BOLT 11 Invoice")}}</button>
-                <button onclick="lndToggleNode()" v-bind:class="{ active: lndModel != null && lndModel.toggle === 1 }">{{$t("Node Info")}}</button>
+                <button onclick="lndToggleBolt11()" v-bind:class="{ active: lndModel != null && lndModel.toggle === 0 }"
+                        v-bind:title="$t('BOLT 11 Invoice')">
+                    {{$t("BOLT 11 Invoice")}}
+                </button>
+                <button onclick="lndToggleNode()" v-bind:class="{ active: lndModel != null && lndModel.toggle === 1 }"
+                        v-bind:title="$t('Node Info')">
+                    {{$t("Node Info")}}
+                </button>
             </div>
         </div>
         <div class="payment__scan">

BTCPayServer/Views/Invoice/Checkout.cshtml

@@ -120,6 +120,7 @@
                 'np': { translation: locales_np },
                 'cs-CZ': { translation: locales_cs },
                 'is-IS': { translation: locales_is },
+                'it-IT': { translation: locales_it },
                 'hr-HR': { translation: locales_hr },
                 'ru-RU': { translation: locales_ru },
                 'zh-SP': { translation: locales_zh_sp }

BTCPayServer/wwwroot/checkout/css/normalizer.css

@@ -9411,6 +9411,9 @@ strong {
         margin: 0px;
         font-size: 12px;
         width: 50%;
+        text-overflow: ellipsis;
+        overflow: hidden;
+        white-space: nowrap;
     }
 
         .btnGroupLnd button:hover {

BTCPayServer/wwwroot/checkout/js/langs/it.js

@@ -0,0 +1,54 @@
+const locales_it = {
+    nested: {
+        lang: 'Lingua'
+    },
+    "Awaiting Payment...": "In attesa del Pagamento...",
+    "Pay with": "Paga con",
+    "Contact and Refund Email": "Email di Contatto e Rimborso",
+    "Contact_Body": "Inserisci un indirizzo email qui sotto. Ti contatteremo a questo indirizzo in caso di problemi con il pagamento.",
+    "Your email": "La tua email",
+    "Continue": "Continua",
+    "Please enter a valid email address": "Inserisci un indirizzo email valido",
+    "Order Amount": "Importo dell'Ordine",
+    "Network Cost": "Costi di Rete",
+    "Already Paid": "Già pagato",
+    "Due": "Dovuto",
+    // Tabs
+    "Scan": "Scansiona",
+    "Copy": "Copia",
+    "Conversion": "Conversione",
+    // Scan tab
+    "Open in wallet": "Apri nel portafoglio",
+    // Copy tab
+    "CompletePay_Body": "Per completare il pagamento, inviare {{btcDue}} {{cryptoCode}} all'indirizzo riportato di seguito.",
+    "Amount": "Importo",
+    "Address": "Indirizzo",
+    "Copied": "Copiato",
+    // Conversion tab
+    "ConversionTab_BodyTop": "Puoi pagare {{btcDue}} {{cryptoCode}} usando altcoin diverse da quelle che il commerciante supporta direttamente.",
+    "ConversionTab_BodyDesc": "Questo servizio è fornito da terze parti. Si prega di tenere presente che non abbiamo alcun controllo su come i fornitori inoltreranno i fondi. La fattura verrà contrassegnata solo dopo aver ricevuto i fondi su {{cryptoCode}} Blockchain.",
+    "Shapeshift_Button_Text": "Paga con Altcoin",
+    "ConversionTab_Lightning": "Nessun fornitore di conversione disponibile per i pagamenti Lightning Network.",
+    // Invoice expired
+    "Invoice expiring soon...": "Fattura in scadenza a breve...",
+    "Invoice expired": "Fattura scaduta",
+    "What happened?": "Cosa è successo?",
+    "InvoiceExpired_Body_1": "Questa fattura è scaduta. Una fattura è valida solo per {{maxTime minuti}} minuti.   \
+Puoi tornare a {{store name}} se desideri inviare nuovamente il pagamento.",
+    "InvoiceExpired_Body_2": "Se hai provato a inviare un pagamento, non è ancora stato accettato dalla rete. Non abbiamo ancora ricevuto i tuoi fondi.",
+    "InvoiceExpired_Body_3": "Se la transazione non viene accettata dalla rete, i fondi saranno nuovamente spendibili nel tuo portafoglio. A seconda del portafoglio, potrebbero essere necessarie 48-72 ore.",
+    "Invoice ID": "Numero della Fattura",
+    "Order ID": "Numero dell'Ordine",
+    "Return to StoreName": "Ritorna a {{storeName}}",
+    // Invoice paid
+    "This invoice has been paid": "La fattura è stata pagata",
+    // Invoice archived
+    "This invoice has been archived": "TQuesta fattura è stata pagata",
+    "Archived_Body": "Contatta il negozio per informazioni sull'ordine o per assistenza",
+    // Lightning
+    "BOLT 11 Invoice": "Fattura BOLT 11",
+    "Node Info": "Informazioni sul Nodo",
+    //
+    "txCount": "{{count}} transazione",
+    "txCount_plural": "{{count}} transazioni"
+};

README.md

@@ -10,7 +10,7 @@
 
 BTCPay Server is a free and open-source cryptocurrency payment processor which allows you to receive payments in Bitcoin and altcoins directly, with no fees, transaction cost or a middleman.
 
-BTCPay is a non-custodial invoicing system which eliminates the involvement of a third-party. Payments with BTCPay go directly to your wallet, which increases the privacy and security. Your private keys are never uploaded to the server. There is no address re-use, since each invoice generates a new address deriving from your xpubkey.
+BTCPay is a non-custodial invoicing system which eliminates the involvement of a third-party. Payments with BTCPay go directly to your wallet, which increases the privacy and security. Your private keys are never uploaded to the server. There is no address re-use since each invoice generates a new address deriving from your xpubkey.
 
 The software is built in C# and conforms to the invoice [API of BitPay](https://bitpay.com/api). It allows for your website to be easily migrated from BitPay and configured as a self-hosted payment processor.
 
@@ -26,8 +26,8 @@ Thanks to the apps built on top of it, you can use BTCPay to receive donations o
 * Lightning Network support (LND and c-lightning)
 * Altcoin support
 * Complete control over private keys
-* Fully compatability with BitPay API (easy migration)
-* Enchanced privacy
+* Full compatibility with BitPay API (easy migration)
+* Enhanced privacy
 * SegWit support
 * Process payments for others
 * Payment buttons
@@ -60,7 +60,7 @@ You can also read the [BTCPay Merchants Guide](https://www.reddit.com/r/Bitcoin/
 
 ## How to build
 
-While the documentation advise using docker-compose, you may want to build yourself outside of development purpose.
+While the documentation advises to use docker-compose, you may want to build BTCPay yourself.
 
 First install .NET Core SDK v2.1.4 (with patch version >= 402) as specified by [Microsoft website](https://www.microsoft.com/net/download/dotnet-core/2.1).
 
@@ -76,7 +76,7 @@ On linux:
 
 ## How to run
 
-Use the `run` scripts to run BTCPayServer, this example show how to print the available command line arguments of BTCPayServer.
+Use the `run` scripts to run BTCPayServer, this example shows how to print the available command line arguments of BTCPayServer.
 
 On Powershell:
 ```
@@ -90,4 +90,4 @@ On linux:
 
 ## Other dependencies
 
-For more information see the documentation [How to deploy a BTCPay server instance](https://github.com/btcpayserver/btcpayserver-doc/#deployment).
+For more information, see the documentation: [How to deploy a BTCPay server instance](https://github.com/btcpayserver/btcpayserver-doc/#deployment).