bump

BTCPayServer.Tests/RateRulesTest.cs

@@ -104,7 +104,7 @@ namespace BTCPayServer.Tests
             rule2.Reevaluate();
             Assert.False(rule2.HasError);
             Assert.Equal("5000 * 2000.4 * 1.1", rule2.ToString(true));
-            Assert.Equal(rule2.Value, 5000m * 2000.4m * 1.1m);
+            Assert.Equal(rule2.BidAsk.Bid, 5000m * 2000.4m * 1.1m);
             ////////
 
             // Make sure parenthesis are correctly calculated
@@ -120,7 +120,7 @@ namespace BTCPayServer.Tests
             rule2.ExchangeRates.SetRate("coinbase", CurrencyPair.Parse("BTC_CAD"), new BidAsk(1000m));
             Assert.True(rule2.Reevaluate());
             Assert.Equal("(2000 * (-3 + 1000 + 50 - 5)) * 1.1", rule2.ToString(true));
-            Assert.Equal((2000m * (-3m + 1000m + 50m - 5m)) * 1.1m, rule2.Value.Value);
+            Assert.Equal((2000m * (-3m + 1000m + 50m - 5m)) * 1.1m, rule2.BidAsk.Bid);
 
             // Test inverse
             rule2 = rules.GetRuleFor(CurrencyPair.Parse("USD_DOGE"));
@@ -128,7 +128,7 @@ namespace BTCPayServer.Tests
             rule2.ExchangeRates.SetRate("coinbase", CurrencyPair.Parse("BTC_CAD"), new BidAsk(1000m));
             Assert.True(rule2.Reevaluate());
             Assert.Equal("(1 / (2000 * (-3 + 1000 + 50 - 5))) * 1.1", rule2.ToString(true));
-            Assert.Equal((1.0m / (2000m * (-3m + 1000m + 50m - 5m))) * 1.1m, rule2.Value.Value);
+            Assert.Equal((1.0m / (2000m * (-3m + 1000m + 50m - 5m))) * 1.1m, rule2.BidAsk.Bid);
             ////////
 
             // Make sure kraken is not converted to CurrencyPair
@@ -147,12 +147,12 @@ namespace BTCPayServer.Tests
             rule2.ExchangeRates.SetRate("kraken", CurrencyPair.Parse("BTC_USD"), new BidAsk(6000m, 6100m));
             Assert.True(rule2.Reevaluate());
             Assert.Equal("(6000, 6100)", rule2.ToString(true));
-            Assert.Equal(6000m, rule2.Value.Value);
+            Assert.Equal(6000m, rule2.BidAsk.Bid);
             rule2 = rules.GetRuleFor(CurrencyPair.Parse("USD_BTC"));
             rule2.ExchangeRates.SetRate("kraken", CurrencyPair.Parse("BTC_USD"), new BidAsk(6000m, 6100m));
             Assert.True(rule2.Reevaluate());
             Assert.Equal("1 / (6000, 6100)", rule2.ToString(true));
-            Assert.Equal(1m / 6100m, rule2.Value.Value);
+            Assert.Equal(1m / 6100m, rule2.BidAsk.Bid);
 
             // Make sure the inverse has more priority than X_X or CDNT_X
             builder = new StringBuilder();

BTCPayServer.Tests/UnitTest1.cs

@@ -521,14 +521,14 @@ namespace BTCPayServer.Tests
 
             // We get this format from "openssl x509 -noout -fingerprint -sha256 -inform pem -in <certificate>"
             var certthumbprint2 = "C5:1B:B1:D4:02:30:6D:0D:A0:0E:85:58:1B:32:AA:56:16:6B:CB:AB:7E:B8:88:FF:92:5D:71:67:EB:43:6D:06";
-            
+
             var lndUri = $"type=lnd-rest;server=https://lnd:lnd@127.0.0.1:53280/;macaroon={macaroon};certthumbprint={certthumbprint}";
             var lndUri2 = $"type=lnd-rest;server=https://lnd:lnd@127.0.0.1:53280/;macaroon={macaroon};certthumbprint={certthumbprint2}";
 
             var certificateHash = new X509Certificate2(Encoders.Hex.DecodeData("2d2d2d2d2d424547494e2043455254494649434154452d2d2d2d2d0a4d494942396a4343415a7967417749424167495156397a62474252724e54716b4e4b55676d72524d377a414b42676771686b6a4f50515144416a41784d5238770a485159445651514b45785a73626d5167595856306232646c626d56795958526c5a43426a5a584a304d51347744415944565151444577564754304e56557a41650a467730784f4441304d6a55794d7a517a4d6a4261467730784f5441324d6a41794d7a517a4d6a42614d444578487a416442674e5642416f54466d78755a4342680a645852765a3256755a584a686447566b49474e6c636e5178446a414d42674e5642414d5442555a50513156544d466b77457759484b6f5a497a6a3043415159490a4b6f5a497a6a304441516344516741454b7557424568564f75707965434157476130766e713262712f59396b41755a78616865646d454553482b753936436d450a397577486b4b2b4a7667547a66385141783550513741357254637155374b57595170303175364f426c5443426b6a414f42674e56485138424166384542414d430a4171517744775944565230544151482f42415577417745422f7a427642674e56485245456144426d6767564754304e565534494a6247396a5957786f62334e300a6877522f4141414268784141414141414141414141414141414141414141414268775373474f69786877514b41457342687753702f717473687754417141724c0a687753702f6d4a72687753702f754f77687753702f714e59687753702f6874436877514b70514157687753702f6c42514d416f4743437147534d343942414d430a413067414d45554349464866716d595a5043647a4a5178386b47586859473834394c31766541364c784d6f7a4f5774356d726835416945413662756e51556c710a6558553070474168776c3041654d726a4d4974394c7652736179756162565a593278343d0a2d2d2d2d2d454e442043455254494649434154452d2d2d2d2d0a"))
                             .GetCertHash(System.Security.Cryptography.HashAlgorithmName.SHA256);
 
-            
+
             Assert.True(LightningConnectionString.TryParse(lndUri, false, out conn));
             Assert.True(LightningConnectionString.TryParse(lndUri2, false, out var conn2));
             Assert.Equal(conn2.ToString(), conn.ToString());
@@ -574,7 +574,7 @@ namespace BTCPayServer.Tests
                 user.GrantAccess();
                 user.RegisterLightningNode("BTC", type);
                 user.RegisterDerivationScheme("BTC");
-                
+
                 tester.PrepareLightning(type);
 
                 Task.WaitAll(CanSendLightningPaymentCore(tester, user));
@@ -1592,7 +1592,7 @@ namespace BTCPayServer.Tests
             foreach (var value in result)
             {
                 var rateResult = value.Value.GetAwaiter().GetResult();
-                Assert.NotNull(rateResult.Value);
+                Assert.NotNull(rateResult.BidAsk);
             }
         }
 
@@ -1629,7 +1629,7 @@ namespace BTCPayServer.Tests
             // Should cache at exchange level so this should hit the cache
             var fetchedRate2 = factory.FetchRate(CurrencyPair.Parse("LTC_USD"), rateRules).GetAwaiter().GetResult();
             Assert.True(fetchedRate.Cached);
-            Assert.NotEqual(fetchedRate.Value.Value, fetchedRate2.Value.Value);
+            Assert.NotEqual(fetchedRate.BidAsk.Bid, fetchedRate2.BidAsk.Bid);
 
             // Should cache at exchange level this should not hit the cache as it is different exchange
             RateRules.TryParse("X_X = bittrex(X_X);", out rateRules);

BTCPayServer/BTCPayServer.csproj

@@ -2,7 +2,7 @@
   <PropertyGroup>
     <OutputType>Exe</OutputType>
     <TargetFramework>netcoreapp2.1</TargetFramework>
-		<Version>1.0.2.79</Version>
+		<Version>1.0.2.80</Version>
     <NoWarn>NU1701,CA1816,CA1308,CA1810,CA2208</NoWarn>
   </PropertyGroup>
   <ItemGroup>

BTCPayServer/Controllers/InvoiceController.cs

@@ -209,7 +209,7 @@ namespace BTCPayServer.Controllers
             {
                 var storeBlob = store.GetStoreBlob();
                 var rate = await fetchingByCurrencyPair[new CurrencyPair(network.CryptoCode, entity.ProductInformation.Currency)];
-                if (rate.Value == null)
+                if (rate.BidAsk == null)
                 {
                     return null;
                 }
@@ -217,7 +217,7 @@ namespace BTCPayServer.Controllers
                 paymentMethod.ParentEntity = entity;
                 paymentMethod.Network = network;
                 paymentMethod.SetId(supportedPaymentMethod.PaymentId);
-                paymentMethod.Rate = rate.Value.Value;
+                paymentMethod.Rate = rate.BidAsk.Bid;
                 var paymentDetails = await handler.CreatePaymentMethodDetails(supportedPaymentMethod, paymentMethod, store, network);
                 if (storeBlob.NetworkFeeDisabled)
                     paymentDetails.SetNoTxFee();
@@ -244,9 +244,9 @@ namespace BTCPayServer.Controllers
                 if (compare != null)
                 {
                     var limitValueRate = await fetchingByCurrencyPair[new CurrencyPair(network.CryptoCode, limitValue.Currency)];
-                    if (limitValueRate.Value.HasValue)
+                    if (limitValueRate.BidAsk != null)
                     {
-                        var limitValueCrypto = Money.Coins(limitValue.Value / limitValueRate.Value.Value);
+                        var limitValueCrypto = Money.Coins(limitValue.Value / limitValueRate.BidAsk.Bid);
                         if (compare(paymentMethod.Calculate().Due, limitValueCrypto))
                         {
                             logs.Write($"{supportedPaymentMethod.PaymentId.CryptoCode}: {errorMessage}");

BTCPayServer/Controllers/RateController.cs

@@ -81,7 +81,7 @@ namespace BTCPayServer.Controllers
             var fetching = _RateProviderFactory.FetchRates(pairs, rules);
             await Task.WhenAll(fetching.Select(f => f.Value).ToArray());
             return Json(pairs
-                            .Select(r => (Pair: r, Value: fetching[r].GetAwaiter().GetResult().Value))
+                            .Select(r => (Pair: r, Value: fetching[r].GetAwaiter().GetResult().BidAsk?.Bid))
                             .Where(r => r.Value.HasValue)
                             .Select(r =>
                             new Rate()

BTCPayServer/Controllers/StoresController.cs

@@ -262,7 +262,7 @@ namespace BTCPayServer.Controllers
                     {
                         CurrencyPair = fetch.Key.ToString(),
                         Error = testResult.Errors.Count != 0,
-                        Rule = testResult.Errors.Count == 0 ? testResult.Rule + " = " + testResult.Value.Value.ToString(CultureInfo.InvariantCulture)
+                        Rule = testResult.Errors.Count == 0 ? testResult.Rule + " = " + testResult.BidAsk.Bid.ToString(CultureInfo.InvariantCulture)
                                                             : testResult.EvaluatedRule
                     });
                 }

BTCPayServer/Controllers/WalletsController.cs

@@ -162,9 +162,9 @@ namespace BTCPayServer.Controllers
                 {
                     cts.CancelAfter(TimeSpan.FromSeconds(5));
                     var result = await _RateProvider.FetchRate(currencyPair, rateRules).WithCancellation(cts.Token);
-                    if (result.Value != null)
+                    if (result.BidAsk != null)
                     {
-                        model.Rate = result.Value;
+                        model.Rate = result.BidAsk.Center;
                         model.Divisibility = _currencyTable.GetNumberFormatInfo(currencyPair.Right, true).CurrencyDecimalDigits;
                         model.Fiat = currencyPair.Right;
                     }

BTCPayServer/Rating/ExchangeRates.cs

@@ -138,6 +138,9 @@ namespace BTCPayServer.Rating
                 return _Ask;
             }
         }
+
+        public decimal Center => (Ask + Bid) / 2.0m;
+
         public BidAsk Inverse()
         {
             return new BidAsk(1.0m / Ask, 1.0m / Bid);

BTCPayServer/Rating/RateRules.cs

@@ -504,7 +504,7 @@ namespace BTCPayServer.Rating
 
         public bool Reevaluate()
         {
-            _Value = null;
+            _BidAsk = null;
             _EvaluatedNode = null;
             _Evaluated = null;
             Errors.Clear();
@@ -524,7 +524,7 @@ namespace BTCPayServer.Rating
                 Errors.AddRange(calculate.Errors);
                 return false;
             }
-            _Value = calculate.Values.Pop().Bid;
+            _BidAsk = calculate.Values.Pop();
             _EvaluatedNode = result;
             return true;
         }
@@ -563,12 +563,12 @@ namespace BTCPayServer.Rating
             return expression.NormalizeWhitespace("", "\n").ToString();
         }
 
-        decimal? _Value;
-        public decimal? Value
+        BidAsk _BidAsk;
+        public BidAsk BidAsk
         {
             get
             {
-                return _Value;
+                return _BidAsk;
             }
         }
     }

BTCPayServer/Services/Rates/BTCPayRateProviderFactory.cs

@@ -22,7 +22,7 @@ namespace BTCPayServer.Services.Rates
         public string Rule { get; set; }
         public string EvaluatedRule { get; set; }
         public HashSet<RateRulesErrors> Errors { get; set; }
-        public decimal? Value { get; set; }
+        public BidAsk BidAsk { get; set; }
         public bool Cached { get; internal set; }
     }
 
@@ -172,11 +172,11 @@ namespace BTCPayServer.Services.Rates
                 result.ExchangeExceptions.AddRange(query.Exceptions);
                 foreach (var rule in query.ExchangeRates)
                 {
-                    rateRule.ExchangeRates.Add(rule);
+                    rateRule.ExchangeRates.SetRate(rule.Exchange, rule.CurrencyPair, rule.BidAsk);
                 }
             }
             rateRule.Reevaluate();
-            result.Value = rateRule.Value;
+            result.BidAsk = rateRule.BidAsk;
             result.Errors = rateRule.Errors;
             result.EvaluatedRule = rateRule.ToString(true);
             result.Rule = rateRule.ToString(false);