Fix old crowdfunding invoices

BTCPayServer/BTCPayServer.csproj

@@ -2,7 +2,7 @@
   <PropertyGroup>
     <OutputType>Exe</OutputType>
     <TargetFramework>netcoreapp2.1</TargetFramework>
-		<Version>1.0.3.60</Version>
+		<Version>1.0.3.63</Version>
     <NoWarn>NU1701,CA1816,CA1308,CA1810,CA2208</NoWarn>
   </PropertyGroup>
   <PropertyGroup>

BTCPayServer/Configuration/External/ExternalRTL.cs

@@ -15,5 +15,12 @@ namespace BTCPayServer.Configuration.External
                 throw new ArgumentNullException(nameof(connectionString));
             ConnectionString = connectionString;
         }
+
+        public async Task<string> ExtractAccessKey()
+        {
+            if (ConnectionString?.CookeFile == null)
+                throw new FormatException("Invalid connection string");
+            return await System.IO.File.ReadAllTextAsync(ConnectionString.CookeFile);
+        }
     }
 }

BTCPayServer/Configuration/External/ExternalSpark.cs

@@ -8,6 +8,7 @@ namespace BTCPayServer.Configuration.External
     public interface IAccessKeyService
     {
         SparkConnectionString ConnectionString { get; }
+        Task<string> ExtractAccessKey();
     }
     public class ExternalSpark : ExternalService, IAccessKeyService
     {
@@ -19,5 +20,19 @@ namespace BTCPayServer.Configuration.External
                 throw new ArgumentNullException(nameof(connectionString));
             ConnectionString = connectionString;
         }
+
+        public async Task<string> ExtractAccessKey()
+        {
+            if (ConnectionString?.CookeFile == null)
+                throw new FormatException("Invalid connection string");
+            var cookie = (ConnectionString.CookeFile == "fake"
+                        ? "fake:fake:fake" // Hacks for testing
+                        : await System.IO.File.ReadAllTextAsync(ConnectionString.CookeFile)).Split(':');
+            if (cookie.Length >= 3)
+            {
+                return cookie[2];
+            }
+            throw new FormatException("Invalid cookiefile format");
+        }
     }
 }

BTCPayServer/Controllers/AppsPublicController.cs

@@ -174,6 +174,7 @@ namespace BTCPayServer.Controllers
             {
                 var invoice = await _InvoiceController.CreateInvoiceCore(new CreateInvoiceRequest()
                 {
+                    OrderId = AppService.GetCrowdfundOrderId(appId),
                     Currency = settings.TargetCurrency,
                     ItemCode = request.ChoiceKey ?? string.Empty,
                     ItemDesc = title,

BTCPayServer/Controllers/InvoiceController.cs

@@ -70,6 +70,7 @@ namespace BTCPayServer.Controllers
             logs.Write("Creation of invoice starting");
             var entity = new InvoiceEntity
             {
+                Version = InvoiceEntity.Lastest_Version,
                 InvoiceTime = DateTimeOffset.UtcNow
             };
 

BTCPayServer/Controllers/ServerController.cs

@@ -484,7 +484,7 @@ namespace BTCPayServer.Controllers
                     result.LNDServices.Add(new ServicesViewModel.LNDServiceViewModel()
                     {
                         Crypto = cryptoCode,
-                        Type = "Ride the lightning server",
+                        Type = "Ride the Lightning server (RTL)",
                         Action = nameof(RTLService),
                         Index = i++,
                     });
@@ -575,8 +575,8 @@ namespace BTCPayServer.Controllers
                 StatusMessage = $"Error: {cryptoCode} is not fully synched";
                 return RedirectToAction(nameof(Services));
             }
-            var spark = _Options.ExternalServicesByCryptoCode.GetServices<T>(cryptoCode).Select(c => c.ConnectionString).FirstOrDefault();
-            if (spark == null)
+            var external = _Options.ExternalServicesByCryptoCode.GetServices<T>(cryptoCode).Where(c => c?.ConnectionString?.Server != null).FirstOrDefault();
+            if (external == null)
             {
                 return NotFound();
             }
@@ -586,13 +586,7 @@ namespace BTCPayServer.Controllers
             vm.WalletName = walletName;
             try
             {
-                var cookie = (spark.CookeFile == "fake"
-                            ? "fake:fake:fake" // If we are testing, it should not crash
-                            : await System.IO.File.ReadAllTextAsync(spark.CookeFile)).Split(':');
-                if (cookie.Length >= 3)
-                {
-                    vm.ServiceLink = $"{spark.Server.AbsoluteUri}?access-key={cookie[2]}";
-                }
+                vm.ServiceLink = $"{external.ConnectionString.Server.AbsoluteUri}?access-key={await external.ExtractAccessKey()}";
             }
             catch (Exception ex)
             {

BTCPayServer/Services/Invoices/InvoiceEntity.cs

@@ -114,7 +114,8 @@ namespace BTCPayServer.Services.Invoices
     public class InvoiceEntity
     {
         public const int InternalTagSupport_Version = 1;
-        public int Version { get; set; } = 1;
+        public const int Lastest_Version = 1;
+        public int Version { get; set; }
         public string Id
         {
             get; set;