synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-30 22:19:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: address TestPendingUpdatesMetric flake

Browse Source
This commit is contained in:
Danny Kopping
2024-07-23 16:39:57 +02:00
committed by GitHub
parent 966c888e9d
commit 695afb80e6
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
coderd/notifications/metrics_test.go
View File

@@ -254,9 +254,10 @@ func TestPendingUpdatesMetric(t *testing.T) {
success := testutil.RequireRecvCtx(testutil.Context(t, testutil.WaitShort), t, interceptor.updateSuccess)
failure := testutil.RequireRecvCtx(testutil.Context(t, testutil.WaitShort), t, interceptor.updateFailure)
// Ensure that the value set in the metric is equivalent to the number of actual pending updates.
pending := promtest.ToFloat64(metrics.PendingUpdates)
require.EqualValues(t, pending, success+failure)
// Wait for the metric to be updated with the expected count of metrics.
require.Eventually(t, func() bool {
return promtest.ToFloat64(metrics.PendingUpdates) == float64(success+failure)
}, testutil.WaitShort, testutil.IntervalFast)
// Unpause the interceptor so the updates can proceed.
interceptor.unpause()