synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-13 21:36:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Collect all todo testcases in a single file

Browse Source
This commit is contained in:
Sas Swart
2025-02-14 08:42:05 +00:00
parent 0f53056648
commit b1aff3f94e
2 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
coderd/presets_test.go
View File

@ -15,6 +15,14 @@ import (
) )
func TestTemplateVersionPresets(t *testing.T) { func TestTemplateVersionPresets(t *testing.T) {
// TODO (sasswart): test case: what if immutable parameters are used in the preset?
// TODO (sasswart): test case: what if presets are defined for a template version with no params?
// TODO (sasswart): test case: what if a non active version is selected?
// TODO (sasswart): test case: what if a preset is selected that has no parameters?
// TODO (sasswart): what if we have preset params and autofill params on the same param?
// TODO (sasswart): test case: if we move from preset to no preset, do we reset the params?
// If so, how should it behave? Reset to initial value? reset to last set value?
// TODO (sasswart): test case: rich parameters
// TODO (sasswart): Test case: what if a user tries to read presets or preset parameters from a different org? // TODO (sasswart): Test case: what if a user tries to read presets or preset parameters from a different org?
t.Parallel() t.Parallel()

9
site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx
View File

@ -164,15 +164,6 @@ export const CreateWorkspacePageView: FC<CreateWorkspacePageViewProps> = ({
); );
useEffect(() => { useEffect(() => {
// TODO (sasswart): test case: what if immutable parameters are used in the preset?
// TODO (sasswart): test case: what if presets are defined for a template version with no params?
// TODO (sasswart): test case: what if a non active version is selected?
// TODO (sasswart): test case: what if a preset is selected that has no parameters?
// TODO (sasswart): what if we have preset params and autofill params on the same param?
// TODO (sasswart): test case: if we move from preset to no preset, do we reset the params?
// If so, how should it behave? Reset to initial value? reset to last set value?
// TODO (sasswart): test case: rich parameters
const selectedPresetOption = presetOptions[selectedPresetIndex]; const selectedPresetOption = presetOptions[selectedPresetIndex];
let selectedPreset: TypesGen.Preset | undefined; let selectedPreset: TypesGen.Preset | undefined;
for (const preset of presets) { for (const preset of presets) {