synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-09 11:45:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Always use UTC time when inserting stats (#4009)

Browse Source 
Fixes a flake reported by @mafredri
This commit is contained in:
Kyle Carberry
2022-09-12 11:01:42 -05:00
committed by GitHub
parent d0b02e581d
commit b4c29f34c3
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
coderd/templates_test.go
View File

@ -665,6 +665,6 @@ func TestTemplateDAUs(t *testing.T) {
workspaces, err = client.Workspaces(ctx, codersdk.WorkspaceFilter{}) workspaces, err = client.Workspaces(ctx, codersdk.WorkspaceFilter{})
require.NoError(t, err) require.NoError(t, err)
assert.WithinDuration(t, assert.WithinDuration(t,
time.Now(), workspaces[0].LastUsedAt, time.Minute, database.Now(), workspaces[0].LastUsedAt, time.Minute,
) )
} }

4
coderd/workspaceagents.go
View File

@ -848,7 +848,7 @@ func (api *API) workspaceAgentReportStats(rw http.ResponseWriter, r *http.Reques
_, err = api.Database.InsertAgentStat(ctx, database.InsertAgentStatParams{ _, err = api.Database.InsertAgentStat(ctx, database.InsertAgentStatParams{
ID: uuid.New(), ID: uuid.New(),
CreatedAt: time.Now(), CreatedAt: database.Now(),
AgentID: workspaceAgent.ID, AgentID: workspaceAgent.ID,
WorkspaceID: build.WorkspaceID, WorkspaceID: build.WorkspaceID,
UserID: workspace.OwnerID, UserID: workspace.OwnerID,
@ -865,7 +865,7 @@ func (api *API) workspaceAgentReportStats(rw http.ResponseWriter, r *http.Reques
err = api.Database.UpdateWorkspaceLastUsedAt(ctx, database.UpdateWorkspaceLastUsedAtParams{ err = api.Database.UpdateWorkspaceLastUsedAt(ctx, database.UpdateWorkspaceLastUsedAtParams{
ID: build.WorkspaceID, ID: build.WorkspaceID,
LastUsedAt: time.Now(), LastUsedAt: database.Now(),
}) })
if err != nil { if err != nil {
httpapi.Write(rw, http.StatusBadRequest, codersdk.Response{ httpapi.Write(rw, http.StatusBadRequest, codersdk.Response{