synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-03 16:13:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

fi stop tracing 4xx http status codes as errors (#3707)

Browse Source
This commit is contained in:
Garrett Delfosse
2022-08-26 11:18:42 -04:00
committed by GitHub
parent 23f61fce2a
commit ccabec6dd1
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
coderd/tracing/httpmw.go
View File

@ -56,7 +56,7 @@ func EndHTTPSpan(r *http.Request, status int) {
status = http.StatusOK
}
span.SetAttributes(semconv.HTTPStatusCodeKey.Int(status))
spanStatus, spanMessage := semconv.SpanStatusFromHTTPStatusCode(status)
spanStatus, spanMessage := semconv.SpanStatusFromHTTPStatusCodeAndSpanKind(status, trace.SpanKindServer)
span.SetStatus(spanStatus, spanMessage)
// finally end span