synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-15 22:20:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: fix MeasureLatencyRecvTimeout to accept send=0 (#13477)

Browse Source 
Fixes the flake seen here: https://github.com/coder/coder/runs/25832852690

Linux is not a real time operating system, and so there is no guarantee that subsequent `time.Now()` `time.Since()` calls will return a non-zero time.  This assert is mainly there to ensure we don't return `-1`.
This commit is contained in:
Spike Curtis
2024-06-05 18:27:56 +04:00
committed by GitHub
parent 775fc3f5e9
commit fade8ba759
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
coderd/database/pubsub/pubsub_linux_test.go
View File

@ -351,7 +351,7 @@ func TestMeasureLatency(t *testing.T) {
send, recv, err := pubsub.NewLatencyMeasurer(logger).Measure(ctx, ps) send, recv, err := pubsub.NewLatencyMeasurer(logger).Measure(ctx, ps)
require.ErrorContains(t, err, context.Canceled.Error()) require.ErrorContains(t, err, context.Canceled.Error())
require.Greater(t, send.Nanoseconds(), int64(0)) require.GreaterOrEqual(t, send.Nanoseconds(), int64(0))
require.EqualValues(t, recv, time.Duration(-1)) require.EqualValues(t, recv, time.Duration(-1))
}) })