closes#17375
from @ericpaulsen
> a prospect recently inquired about how our OAuth integration with
GitLab works, and I realized we do not have any information on
`GIT_ASKPASS` is used to retreive the OAuth token for users when they
run `git` operations.
Co-authored-by: EdwardAngert <17991901+EdwardAngert@users.noreply.github.com>
We replace timestamps in our golden files to keep the values constant.
However, if a non-UTC timezone is used then the timestamp will still be
replaced but the whitespace will be messed up (since it was aligned to
the original value).
Therefore we must force a timezone when generating golden files.
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
Fixes docs troubleshooting language around low MTU. In fact, we see
conenctions hanging rather than just showing low performance, since
packets are dropped rather than fragmented.
---------
Co-authored-by: Edward Angert <EdwardAngert@users.noreply.github.com>
Co-authored-by: EdwardAngert <17991901+EdwardAngert@users.noreply.github.com>
The behavior of the partitions listing function from gopsutil is that it
will return all partitions that didn't fail to be read, but will return
something similar to a multierror.
Errors are now ignored unless there are no drives returned.
1. increase form width and adjust form field width #17471
2. Move slider value display as its currently broken for long parameter
titles and descriptions
3. increase the height of the slider
4. automatically increase the height of the textarea as the user types
#17472
Bumps
[github.com/charmbracelet/glamour](https://github.com/charmbracelet/glamour)
from 0.9.1 to 0.10.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/charmbracelet/glamour/releases">github.com/charmbracelet/glamour's
releases</a>.</em></p>
<blockquote>
<h2>v0.10.0</h2>
<h1>Actually readable tables</h1>
<p>Big tables that included links were always hard to read. Links can be
very long, and tables often have limited space to render them. This
means that links often took the space of many lines and weren't properly
clickable because they were being truncated in practice.</p>
<p>Starting on this release, Glamour will render links and images at the
footer of the table, with a reference number so you can easily find the
link you're looking for. If you want the old behavior, it is still
supported via the new <code>WithInlineTableLinks</code> option.</p>
<h2>The New Way</h2>
<p><img
src="https://github.com/user-attachments/assets/9ea84076-c318-4835-b5be-a583745a4953"
alt="table_with_footer_links_and_images" /></p>
<h2>The Old Way</h2>
<p>Wanna render tables with inline links? You still can:</p>
<pre lang="go"><code>r, err :=
glamour.NewTermRenderer(glamour.WithInlineTableLinks(true))
if err != nil { /*...*/ }
<p>out, err := r.RenderBytes(in)<br />
if err != nil { /<em>...</em>/ }</p>
<p>fmt.Fprintf(os.Stdout, "%s\n", out)<br />
</code></pre></p>
<p><img
src="https://github.com/user-attachments/assets/de3d3d33-9592-44ea-99d2-f3d8e9e94f9c"
alt="table_with_inline_links_and_images" /></p>
<h1>Prettier GitHub links</h1>
<p>We also introduced a change so that GitHub links inside tables that
reference issues, discussions or PRs will be shown in its shortened
form, similar to how GitHub itself present the links on issue
descriptions: <code>owner/repo#123</code>.</p>
<p><img
src="https://github.com/user-attachments/assets/8adb2498-a361-4749-8e98-02f17d4f9062"
alt="table_with_footer_auto_links_short" /></p>
<h1>Extra</h1>
<p>Also, we introduced <code>WithTableWrap</code>, so you can disable
table text wrapping if really want:</p>
<pre lang="go"><code>r, err :=
glamour.NewTermRenderer(glamour.WithTableWrap(false))
if err != nil { ... }
<p>out, err := r.RenderBytes(in)<br />
if err != nil { ... }</p>
<p>fmt.Fprintf(os.Stdout, "%s\n", out)<br />
</code></pre></p>
<h2>Changelog</h2>
<h3>New Features</h3>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="05ee9b5f4d"><code>05ee9b5</code></a>
v0.10.0</li>
<li><a
href="c9af0458d4"><code>c9af045</code></a>
feat(tables): format github links inside tables in a more readable
manner</li>
<li><a
href="f2eb484a99"><code>f2eb484</code></a>
feat: add autolink package with patterns for more readable github
urls</li>
<li><a
href="9d873734c1"><code>9d87373</code></a>
feat(table): pad position on table link list</li>
<li><a
href="a11e9a0c3a"><code>a11e9a0</code></a>
feat(table): show position of link also inside the table</li>
<li><a
href="42f47a22f3"><code>42f47a2</code></a>
feat(table): prefix all links with the position in the footer</li>
<li><a
href="61cfc45c6b"><code>61cfc45</code></a>
feat(table): add ability to render links at the bottom</li>
<li><a
href="5437e4a1a7"><code>5437e4a</code></a>
fix: ensure that prop is always cleared</li>
<li><a
href="60534f9196"><code>60534f9</code></a>
chore(deps): bump golang.org/x/term from 0.30.0 to 0.31.0 (<a
href="https://redirect.github.com/charmbracelet/glamour/issues/418">#418</a>)</li>
<li><a
href="606f55a8d8"><code>606f55a</code></a>
chore(deps): bump golang.org/x/text from 0.23.0 to 0.24.0 (<a
href="https://redirect.github.com/charmbracelet/glamour/issues/419">#419</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/charmbracelet/glamour/compare/v0.9.1...v0.10.0">compare
view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/moby/moby](https://github.com/moby/moby) from
28.0.0+incompatible to 28.1.1+incompatible.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/moby/moby/releases">github.com/moby/moby's
releases</a>.</em></p>
<blockquote>
<h2>v28.1.1</h2>
<h2>28.1.1</h2>
<p>For a full list of pull requests and changes in this release, refer
to the relevant GitHub milestones:</p>
<ul>
<li><a
href="https://github.com/docker/cli/issues?q=is%3Aclosed+milestone%3A28.1.1">docker/cli,
28.1.1 milestone</a></li>
<li><a
href="https://github.com/moby/moby/issues?q=is%3Aclosed+milestone%3A28.1.1">moby/moby,
28.1.1 milestone</a></li>
</ul>
<h3>Bug fixes and enhancements</h3>
<ul>
<li>Fix <code>dockerd-rootless-setuptool.sh</code> incorrectly reporting
missing <code>iptables</code>. <a
href="https://redirect.github.com/moby/moby/pull/49833">moby/moby#49833</a></li>
<li>containerd image store: Fix a potential daemon crash when using
<code>docker load</code> with archives containing zero-size tar headers.
<a
href="https://redirect.github.com/moby/moby/pull/49837">moby/moby#49837</a></li>
</ul>
<h3>Packaging updates</h3>
<ul>
<li>Update Buildx to <a
href="https://github.com/docker/buildx/releases/tag/v0.23.0">v0.23.0</a>.
<a
href="https://redirect.github.com/docker/docker-ce-packaging/pull/1185">docker/docker-ce-packaging#1185</a></li>
<li>Update Compose to <a
href="https://github.com/docker/compose/releases/tag/v2.35.1">v2.35.1</a>.
<a
href="https://redirect.github.com/docker/docker-ce-packaging/pull/1188">docker/docker-ce-packaging#1188</a></li>
</ul>
<h3>Networking</h3>
<ul>
<li>Add a warning to a container's <code>/etc/resolv.conf</code> when no
upstream DNS servers were found. <a
href="https://redirect.github.com/moby/moby/pull/49827">moby/moby#49827</a></li>
</ul>
<h2>v28.1.0</h2>
<h2>28.1.0</h2>
<p>For a full list of pull requests and changes in this release, refer
to the relevant GitHub milestones:</p>
<ul>
<li><a
href="https://github.com/docker/cli/issues?q=is%3Aclosed+milestone%3A28.1.0">docker/cli,
28.1.0 milestone</a></li>
<li><a
href="https://github.com/moby/moby/issues?q=is%3Aclosed+milestone%3A28.1.0">moby/moby,
28.1.0 milestone</a></li>
<li>Changes to the Engine API, see <a
href="https://github.com/moby/moby/blob/v28.1.0/docs/api/version-history.md">API
version history</a>.</li>
</ul>
<h3>New</h3>
<ul>
<li>Add <code>docker bake</code> sub-command as alias for <code>docker
buildx bake</code>. <a
href="https://redirect.github.com/docker/cli/pull/5947">docker/cli#5947</a></li>
<li>Experimental: add a new <code>--use-api-socket</code> flag on
<code>docker run</code> and <code>docker create</code> to enable access
to Docker socket from inside a container and to share credentials from
the host with the container. <a
href="https://redirect.github.com/docker/cli/pull/5858">docker/cli#5858</a></li>
<li><code>docker image inspect</code> now supports a
<code>--platform</code> flag to inspect a specific platform of a
multi-platform image. <a
href="https://redirect.github.com/docker/cli/pull/5934">docker/cli#5934</a></li>
</ul>
<h3>Bug fixes and enhancements</h3>
<ul>
<li>Add CLI shell-completion for context names. <a
href="https://redirect.github.com/docker/cli/pull/6016">docker/cli#6016</a></li>
<li>Fix <code>docker images --tree</code> not including non-container
images content size in the total image content size. <a
href="https://redirect.github.com/docker/cli/pull/6000">docker/cli#6000</a></li>
<li>Fix <code>docker load</code> not preserving replaced images. <a
href="https://redirect.github.com/moby/moby/pull/49650">moby/moby#49650</a></li>
<li>Fix <code>docker login</code> hints when logging in to a custom
registry. <a
href="https://redirect.github.com/docker/cli/pull/6015">docker/cli#6015</a></li>
<li>Fix <code>docker stats</code> not working properly on machines with
high CPU core count. <a
href="https://redirect.github.com/moby/moby/pull/49734">moby/moby#49734</a></li>
<li>Fix a regression causing <code>docker pull/push</code> to fail when
interacting with a private repository. <a
href="https://redirect.github.com/docker/cli/pull/5964">docker/cli#5964</a></li>
<li>Fix an issue preventing rootless Docker setup on a host with no
<code>ip_tables</code> kernel module. <a
href="https://redirect.github.com/moby/moby/pull/49727">moby/moby#49727</a></li>
<li>Fix an issue that could lead to unwanted iptables rules being
restored and never deleted following a firewalld reload. <a
href="https://redirect.github.com/moby/moby/pull/49728">moby/moby#49728</a></li>
<li>Improve CLI completion of <code>docker service scale</code>. <a
href="https://redirect.github.com/docker/cli/pull/5968">docker/cli#5968</a></li>
<li><code>docker images --tree</code> now hides both untagged and
dangling images by default. <a
href="https://redirect.github.com/docker/cli/pull/5924">docker/cli#5924</a></li>
<li><code>docker system info</code> will provide an exit code if a
connection cannot be established to the Docker daemon. <a
href="https://redirect.github.com/docker/cli/pull/5918">docker/cli#5918</a></li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="01f442b84d"><code>01f442b</code></a>
Merge pull request <a
href="https://redirect.github.com/moby/moby/issues/49588">#49588</a>
from thaJeztah/bump_go_build_tags</li>
<li><a
href="e03c0f03e7"><code>e03c0f0</code></a>
Merge pull request <a
href="https://redirect.github.com/moby/moby/issues/49834">#49834</a>
from thaJeztah/cleanup_ignore</li>
<li><a
href="8dde918e77"><code>8dde918</code></a>
Merge pull request <a
href="https://redirect.github.com/moby/moby/issues/49837">#49837</a>
from thaJeztah/bump_containerd_2.0.5</li>
<li><a
href="e70ce7a35b"><code>e70ce7a</code></a>
Merge pull request <a
href="https://redirect.github.com/moby/moby/issues/49833">#49833</a>
from vvoland/rootless-iptables-check</li>
<li><a
href="fc8361c078"><code>fc8361c</code></a>
vendor: github.com/containerd/containerd v2.0.5</li>
<li><a
href="62f51e4367"><code>62f51e4</code></a>
vendor: golang.org/x/oauth2 v0.29.0</li>
<li><a
href="bbbb0036df"><code>bbbb003</code></a>
cleanup ignore files</li>
<li><a
href="ead379a464"><code>ead379a</code></a>
contrib/rootless-setuptool: Fix iptables detection</li>
<li><a
href="7c52c4d92e"><code>7c52c4d</code></a>
update go:build tags to go1.23 to align with vendor.mod</li>
<li><a
href="6573a13e4a"><code>6573a13</code></a>
Merge pull request <a
href="https://redirect.github.com/moby/moby/issues/49827">#49827</a>
from robmry/warn_no_ext_nameservers</li>
<li>Additional commits viewable in <a
href="https://github.com/moby/moby/compare/v28.0.0...v28.1.1">compare
view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Adds support to our coordinator implementations to send Error updates before disconnecting clients.
I was recently debugging a connection issue where the client was getting repeatedly disconnected from the Coordinator, but since we never send any error information it was really hard without server logs.
This PR aims to correct that, by sending a CoordinateResponse with `Error` set in cases where we disconnect a client without them asking us to.
It also logs the error whenever we get one in the client controller.
- Hooks up the textarea component
- Adds placeholders for dropdown, input and multi-select combobox
---------
Co-authored-by: brettkolodny <brettkolodny@gmail.com>
A few storybook tests have been false positives quite frequently. To
reduce this noise, I'm implementing a few hacks to avoid that. We can
always rollback these changes if we notice they were leading to a lack
in the tests.
Closes https://github.com/coder/internal/issues/510
<details>
<summary> Refactoring Summary </summary>
### 1) `CalculateActions` Function
#### Issues Before Refactoring:
- Large function (~150 lines), making it difficult to read and maintain.
- The control flow is hard to follow due to complex conditional logic.
- The `ReconciliationActions` struct was partially initialized early,
then mutated in multiple places, making the flow error-prone.
Original source:
fe60b569ad/coderd/prebuilds/state.go (L13-L167)
#### Improvements After Refactoring:
- Simplified and broken down into smaller, focused helper methods.
- The flow of the function is now more linear and easier to understand.
- Struct initialization is cleaner, avoiding partial and incremental
mutations.
Refactored function:
eeb0407d78/coderd/prebuilds/state.go (L67-L84)
---
### 2) `ReconciliationActions` Struct
#### Issues Before Refactoring:
- The struct mixed both actionable decisions and diagnostic state, which
blurred its purpose.
- It was unclear which fields were necessary for reconciliation logic,
and which were purely for logging/observability.
#### Improvements After Refactoring:
- Split into two clear, purpose-specific structs:
- **`ReconciliationActions`** — defines the intended reconciliation
action.
- **`ReconciliationState`** — captures runtime state and metadata,
primarily for logging and diagnostics.
Original struct:
fe60b569ad/coderd/prebuilds/reconcile.go (L29-L41)
</details>
---------
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
Co-authored-by: Sas Swart <sas.swart.cdk@gmail.com>
Co-authored-by: Danny Kopping <dannykopping@gmail.com>
Co-authored-by: Dean Sheather <dean@deansheather.com>
Co-authored-by: Spike Curtis <spike@coder.com>
Co-authored-by: Danny Kopping <danny@coder.com>
